Re: [PATCH v2 1/1] usb: musb: call pm_runtime_{get,put}_sync before reading vbus registers

[Bin Liu]

On Mon, Mar 05, 2018 at 08:35:10PM +0200, Ivaylo Dimitrov wrote:
> Hi,
> 
> On  5.03.2018 19:38, Bin Liu wrote:
> >On Wed, Feb 28, 2018 at 01:59:43PM -0800, Tony Lindgren wrote:
> >>* Merlijn Wajer  [180227 22:29]:
> >>>Without pm_runtime_{get,put}_sync calls in place, reading
> >>>vbus status via /sys causes the following error:
> >>>
> >>>Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa0ab060
> >>>pgd = b333e822
> >>>[fa0ab060] *pgd=48011452(bad)
> >>>
> >>>[] (musb_default_readb) from [] 
> >>>(musb_vbus_show+0x58/0xe4)
> >>>[] (musb_vbus_show) from [] (dev_attr_show+0x20/0x44)
> >>>[] (dev_attr_show) from [] 
> >>>(sysfs_kf_seq_show+0x80/0xdc)
> >>>[] (sysfs_kf_seq_show) from [] (seq_read+0x250/0x448)
> >>>[] (seq_read) from [] (__vfs_read+0x1c/0x118)
> >>>[] (__vfs_read) from [] (vfs_read+0x90/0x144)
> >>>[] (vfs_read) from [] (SyS_read+0x3c/0x74)
> >>>[] (SyS_read) from [] (ret_fast_syscall+0x0/0x54)
> >>>
> >>>Solution was suggested by Tony Lindgren .
> >>>
> >>>Signed-off-by: Merlijn Wajer 
> >>
> >>Thanks for fixing this. Assuming it passes Bin's tests:
> >>
> >>Acked-by: Tony Lindgren 
> >
> >Applied and sent out. Thanks.
> >
> 
> What about stable kernels? Shouldn't this be fixed there as well?

Yes, it should, but I need to figure out which stables to send to and I
am busy in something at the moment. So I will send it @stable some time
later.

Regards,
-Bin.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/1] usb: musb: call pm_runtime_{get,put}_sync before reading vbus registers

[Ivaylo Dimitrov]

Hi,

On  5.03.2018 19:38, Bin Liu wrote:

On Wed, Feb 28, 2018 at 01:59:43PM -0800, Tony Lindgren wrote:

* Merlijn Wajer  [180227 22:29]:

Without pm_runtime_{get,put}_sync calls in place, reading
vbus status via /sys causes the following error:

Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa0ab060
pgd = b333e822
[fa0ab060] *pgd=48011452(bad)

[] (musb_default_readb) from [] (musb_vbus_show+0x58/0xe4)
[] (musb_vbus_show) from [] (dev_attr_show+0x20/0x44)
[] (dev_attr_show) from [] (sysfs_kf_seq_show+0x80/0xdc)
[] (sysfs_kf_seq_show) from [] (seq_read+0x250/0x448)
[] (seq_read) from [] (__vfs_read+0x1c/0x118)
[] (__vfs_read) from [] (vfs_read+0x90/0x144)
[] (vfs_read) from [] (SyS_read+0x3c/0x74)
[] (SyS_read) from [] (ret_fast_syscall+0x0/0x54)

Solution was suggested by Tony Lindgren .

Signed-off-by: Merlijn Wajer 


Thanks for fixing this. Assuming it passes Bin's tests:

Acked-by: Tony Lindgren 


Applied and sent out. Thanks.



What about stable kernels? Shouldn't this be fixed there as well?

Ivo
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/1] usb: musb: call pm_runtime_{get,put}_sync before reading vbus registers

[Bin Liu]

On Wed, Feb 28, 2018 at 01:59:43PM -0800, Tony Lindgren wrote:
> * Merlijn Wajer  [180227 22:29]:
> > Without pm_runtime_{get,put}_sync calls in place, reading
> > vbus status via /sys causes the following error:
> > 
> > Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa0ab060
> > pgd = b333e822
> > [fa0ab060] *pgd=48011452(bad)
> > 
> > [] (musb_default_readb) from [] 
> > (musb_vbus_show+0x58/0xe4)
> > [] (musb_vbus_show) from [] (dev_attr_show+0x20/0x44)
> > [] (dev_attr_show) from [] (sysfs_kf_seq_show+0x80/0xdc)
> > [] (sysfs_kf_seq_show) from [] (seq_read+0x250/0x448)
> > [] (seq_read) from [] (__vfs_read+0x1c/0x118)
> > [] (__vfs_read) from [] (vfs_read+0x90/0x144)
> > [] (vfs_read) from [] (SyS_read+0x3c/0x74)
> > [] (SyS_read) from [] (ret_fast_syscall+0x0/0x54)
> > 
> > Solution was suggested by Tony Lindgren .
> > 
> > Signed-off-by: Merlijn Wajer 
> 
> Thanks for fixing this. Assuming it passes Bin's tests:
> 
> Acked-by: Tony Lindgren 

Applied and sent out. Thanks.

-Bin.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/1] usb: musb: call pm_runtime_{get,put}_sync before reading vbus registers

[Tony Lindgren]

* Merlijn Wajer  [180227 22:29]:
> Without pm_runtime_{get,put}_sync calls in place, reading
> vbus status via /sys causes the following error:
> 
> Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa0ab060
> pgd = b333e822
> [fa0ab060] *pgd=48011452(bad)
> 
> [] (musb_default_readb) from [] (musb_vbus_show+0x58/0xe4)
> [] (musb_vbus_show) from [] (dev_attr_show+0x20/0x44)
> [] (dev_attr_show) from [] (sysfs_kf_seq_show+0x80/0xdc)
> [] (sysfs_kf_seq_show) from [] (seq_read+0x250/0x448)
> [] (seq_read) from [] (__vfs_read+0x1c/0x118)
> [] (__vfs_read) from [] (vfs_read+0x90/0x144)
> [] (vfs_read) from [] (SyS_read+0x3c/0x74)
> [] (SyS_read) from [] (ret_fast_syscall+0x0/0x54)
> 
> Solution was suggested by Tony Lindgren .
> 
> Signed-off-by: Merlijn Wajer 

Thanks for fixing this. Assuming it passes Bin's tests:

Acked-by: Tony Lindgren 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html