Re: [PATCH v3 3/5] usb: chipidea: imx: set CI_HDRC_IMX28_WRITE_FIX for imx28

2013-10-28 Thread Marek Vasut 
Hi Shawn,

 On Sun, Oct 27, 2013 at 05:25:36PM +0100, Marek Vasut wrote:
   +static const struct of_device_id ci_hdrc_imx_dt_ids[] = {
   + { .compatible = fsl,imx28-usb, .data = imx28_usb_data},
   + { .compatible = fsl,imx27-usb, .data = imx27_usb_data},
  
  Just a nit-pick, but the order here is wrong ;-)
 
 Oh, no.  Before of_match_device() gets improved to find the best match,
 we have to sort the table from the most specific entry to the most
 generic one.

Oh, thanks for explaining!

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 3/5] usb: chipidea: imx: set CI_HDRC_IMX28_WRITE_FIX for imx28

2013-10-27 Thread Marek Vasut 
Dear Peter Chen,

 Due to imx28 needs ARM swp instruction for writing, we set
 CI_HDRC_IMX28_WRITE_FIX for imx28.
 
 Signed-off-by: Peter Chen peter.c...@freescale.com
 ---
  drivers/usb/chipidea/ci_hdrc_imx.c |   32 ++--
  1 files changed, 26 insertions(+), 6 deletions(-)
 
 diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c
 b/drivers/usb/chipidea/ci_hdrc_imx.c index 023d3cb..68f7f5e 100644
 --- a/drivers/usb/chipidea/ci_hdrc_imx.c
 +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
 @@ -23,6 +23,26 @@
  #include ci.h
  #include ci_hdrc_imx.h
 
 +#define CI_HDRC_IMX_IMX28_WRITE_FIX BIT(0)
 +
 +struct ci_hdrc_imx_platform_flag {
 + unsigned int flags;
 +};
 +
 +static const struct ci_hdrc_imx_platform_flag imx27_usb_data = {
 +};
 +
 +static const struct ci_hdrc_imx_platform_flag imx28_usb_data = {
 + .flags = CI_HDRC_IMX_IMX28_WRITE_FIX,
 +};
 +
 +static const struct of_device_id ci_hdrc_imx_dt_ids[] = {
 + { .compatible = fsl,imx28-usb, .data = imx28_usb_data},
 + { .compatible = fsl,imx27-usb, .data = imx27_usb_data},

Just a nit-pick, but the order here is wrong ;-)
[...]
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 3/5] usb: chipidea: imx: set CI_HDRC_IMX28_WRITE_FIX for imx28

2013-10-27 Thread Shawn Guo 
On Sun, Oct 27, 2013 at 05:25:36PM +0100, Marek Vasut wrote:
  +static const struct of_device_id ci_hdrc_imx_dt_ids[] = {
  +   { .compatible = fsl,imx28-usb, .data = imx28_usb_data},
  +   { .compatible = fsl,imx27-usb, .data = imx27_usb_data},
 
 Just a nit-pick, but the order here is wrong ;-)

Oh, no.  Before of_match_device() gets improved to find the best match,
we have to sort the table from the most specific entry to the most
generic one.

Shawn

--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html