RE: [PATCH v4 0/7] typec: tcpm: Add sink side support for PPS
On 12 March 2018 08:33, Adam Thomson wrote: > On 09 March 2018 17:34, Greg Kroah-Hartman wrote: > > > On Tue, Jan 02, 2018 at 03:50:48PM +, Adam Thomson wrote: > > > This patch set adds sink side support for the PPS feature introduced in > > > the > > > USB PD 3.0 specification. > > > > > > The source PPS supply is represented using the Power Supply framework to > provide > > > access and control APIs for dealing with it's operating voltage and > > > current, > > > and switching between a standard PDO and PPS APDO operation. During > > > standard > > PDO > > > operation the voltage and current is read-only, but for APDO PPS these are > > > writable as well to allow for control. > > > > > > It should be noted that the keepalive for PPS is not handled within TCPM. > > > The > > > expectation is that the external user will be required to ensure > > > re-requests > > > occur regularly to ensure PPS remains and the source does not hard reset. > > > > I've applied the first 3 patches now. Can you rebase and resend based > > on the feedback so far? > > That's great. Thanks. Need to also rebase based on the patch > 'Revert "typec: tcpm: Only request matching pdos"' as this impacts the APDO > selection logic. This is on my TODO list and will try and deal with it ASAP, > hopefully this week. One quick question. The patch 'Revert "typec: tcpm: Only request matching pdos"' from Hans isn't on your next branch. Is that something that will get pulled in soon? Need this as well as my updates you already pulled into your next branch before I can resubmit. For now I cherry-picked that patch locally for testing, but that's no good for submission. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v4 0/7] typec: tcpm: Add sink side support for PPS
On 09 March 2018 17:34, Greg Kroah-Hartman wrote: > On Tue, Jan 02, 2018 at 03:50:48PM +, Adam Thomson wrote: > > This patch set adds sink side support for the PPS feature introduced in the > > USB PD 3.0 specification. > > > > The source PPS supply is represented using the Power Supply framework to > > provide > > access and control APIs for dealing with it's operating voltage and current, > > and switching between a standard PDO and PPS APDO operation. During standard > PDO > > operation the voltage and current is read-only, but for APDO PPS these are > > writable as well to allow for control. > > > > It should be noted that the keepalive for PPS is not handled within TCPM. > > The > > expectation is that the external user will be required to ensure re-requests > > occur regularly to ensure PPS remains and the source does not hard reset. > > I've applied the first 3 patches now. Can you rebase and resend based > on the feedback so far? That's great. Thanks. Need to also rebase based on the patch 'Revert "typec: tcpm: Only request matching pdos"' as this impacts the APDO selection logic. This is on my TODO list and will try and deal with it ASAP, hopefully this week. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 0/7] typec: tcpm: Add sink side support for PPS
On Tue, Jan 02, 2018 at 03:50:48PM +, Adam Thomson wrote: > This patch set adds sink side support for the PPS feature introduced in the > USB PD 3.0 specification. > > The source PPS supply is represented using the Power Supply framework to > provide > access and control APIs for dealing with it's operating voltage and current, > and switching between a standard PDO and PPS APDO operation. During standard > PDO > operation the voltage and current is read-only, but for APDO PPS these are > writable as well to allow for control. > > It should be noted that the keepalive for PPS is not handled within TCPM. The > expectation is that the external user will be required to ensure re-requests > occur regularly to ensure PPS remains and the source does not hard reset. I've applied the first 3 patches now. Can you rebase and resend based on the feedback so far? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v4 0/7] typec: tcpm: Add sink side support for PPS
On 30 January 2018 13:25, Heikki Krogerus wrote: > On Tue, Jan 02, 2018 at 03:50:48PM +, Adam Thomson wrote: > > This patch set adds sink side support for the PPS feature introduced in the > > USB PD 3.0 specification. > > > > The source PPS supply is represented using the Power Supply framework to > > provide > > access and control APIs for dealing with it's operating voltage and current, > > and switching between a standard PDO and PPS APDO operation. During standard > PDO > > operation the voltage and current is read-only, but for APDO PPS these are > > writable as well to allow for control. > > > > It should be noted that the keepalive for PPS is not handled within TCPM. > > The > > expectation is that the external user will be required to ensure re-requests > > occur regularly to ensure PPS remains and the source does not hard reset. > > Sorry for the late reply. I don't have any major problems with these > other than with 6/7. The documentation should be for the psy class, > not tcpm. I'm also not comfortable with the "select POWER_SUPPLY", but > if Guenter does not think it's a problem, I'm fine with it. I guess we > can always, for example, introduce stubs for the power_supply* > functions, and drop the dependency later. > > But as usual with tcpm.c, Guenter needs to give his ACK. > > Oh yes, and Sebastian needs to ACK the power_supply changes or course. No problem. Thanks for your time reviewing this. Not the smallest patch set so appreciate the effort spent. Was travelling last week, but should now have a bit of free time to take a proper look at your comments and get back to you with some meaningful responses. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 0/7] typec: tcpm: Add sink side support for PPS
On 01/30/2018 05:25 AM, Heikki Krogerus wrote: On Tue, Jan 02, 2018 at 03:50:48PM +, Adam Thomson wrote: This patch set adds sink side support for the PPS feature introduced in the USB PD 3.0 specification. The source PPS supply is represented using the Power Supply framework to provide access and control APIs for dealing with it's operating voltage and current, and switching between a standard PDO and PPS APDO operation. During standard PDO operation the voltage and current is read-only, but for APDO PPS these are writable as well to allow for control. It should be noted that the keepalive for PPS is not handled within TCPM. The expectation is that the external user will be required to ensure re-requests occur regularly to ensure PPS remains and the source does not hard reset. Sorry for the late reply. I don't have any major problems with these other than with 6/7. The documentation should be for the psy class, not tcpm. I'm also not comfortable with the "select POWER_SUPPLY", but if Guenter does not think it's a problem, I'm fine with it. I guess we "select POWER_SUPPLY" seems to be quite widely used, so I don't have problems with it as long as it is ok for PS maintainers. can always, for example, introduce stubs for the power_supply* functions, and drop the dependency later. That doesn't sound like a good idea unless generic stubs are already available. But as usual with tcpm.c, Guenter needs to give his ACK. I'll try to get to it this week. Guenter Oh yes, and Sebastian needs to ACK the power_supply changes or course. Thanks, -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 0/7] typec: tcpm: Add sink side support for PPS
On Tue, Jan 02, 2018 at 03:50:48PM +, Adam Thomson wrote: > This patch set adds sink side support for the PPS feature introduced in the > USB PD 3.0 specification. > > The source PPS supply is represented using the Power Supply framework to > provide > access and control APIs for dealing with it's operating voltage and current, > and switching between a standard PDO and PPS APDO operation. During standard > PDO > operation the voltage and current is read-only, but for APDO PPS these are > writable as well to allow for control. > > It should be noted that the keepalive for PPS is not handled within TCPM. The > expectation is that the external user will be required to ensure re-requests > occur regularly to ensure PPS remains and the source does not hard reset. Sorry for the late reply. I don't have any major problems with these other than with 6/7. The documentation should be for the psy class, not tcpm. I'm also not comfortable with the "select POWER_SUPPLY", but if Guenter does not think it's a problem, I'm fine with it. I guess we can always, for example, introduce stubs for the power_supply* functions, and drop the dependency later. But as usual with tcpm.c, Guenter needs to give his ACK. Oh yes, and Sebastian needs to ACK the power_supply changes or course. Thanks, -- heikki -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 0/7] typec: tcpm: Add sink side support for PPS
On Mon, Jan 22, 2018 at 03:31:29PM +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 02, 2018 at 03:50:48PM +, Adam Thomson wrote: > > This patch set adds sink side support for the PPS feature introduced in the > > USB PD 3.0 specification. > > Heikki and Guenter, any thoughts on this patch series? > On my plate, but I am still buried in the fallout from Spectre and Meltdown. It might take a while for me to dig out from it. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 0/7] typec: tcpm: Add sink side support for PPS
On Tue, Jan 02, 2018 at 03:50:48PM +, Adam Thomson wrote: > This patch set adds sink side support for the PPS feature introduced in the > USB PD 3.0 specification. Heikki and Guenter, any thoughts on this patch series? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
