Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index
Arnd, On Wednesday 15 April 2015 03:17 AM, Arnd Bergmann wrote: On Tuesday 14 April 2015 11:05:35 Arun Ramamurthy wrote: [1] - https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/kbuild/kconfig-language.txt#n111 Kishon,removing select GENERIC_PHY also breaks the builds for certain architectures (i386 and x84_64). Is the consensus to leave the select but make GENERIC_PHY a invisible option? Thanks I think the best solution is - make GENERIC_PHY a silent option - change PHY_RCAR_GEN2 to use 'select' instead of 'depends on', so it will still work when all other phy drivers are disabled - change the non-phy drivers that select GENERIC_PHY to either use 'depends on' or no explicit dependency in case they are still functional without the API. Note that drivers/pinctrl/pinctrl-tegra-xusb.c is a phy provider as well, not a consumer, despite being outside of drivers/phy. makes sense to me. Thanks Kishon -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index
On Wed, 15 Apr 2015, rajeev kumar wrote:
@@ -88,15 +88,13 @@ static int ehci_platform_power_on(struct
platform_device *dev)
}
for (phy_num = 0; phy_num priv-num_phys; phy_num++) {
- if (priv-phys[phy_num]) {
- ret = phy_init(priv-phys[phy_num]);
- if (ret)
- goto err_exit_phy;
- ret = phy_power_on(priv-phys[phy_num]);
- if (ret) {
- phy_exit(priv-phys[phy_num]);
- goto err_exit_phy;
- }
+ ret = phy_init(priv-phys[phy_num]);
+ if (ret)
+ goto err_exit_phy;
Jumping to err_exit_phy will perform phy_power_off also which is not
required as you are are powering on after phy_init. Wrong level
jumping
Look again, and this time pay more attention to the value of phy_num.
Alan Stern
~Rajeev
+ ret = phy_power_on(priv-phys[phy_num]);
+ if (ret) {
+ phy_exit(priv-phys[phy_num]);
+ goto err_exit_phy;
}
}
@@ -104,10 +102,8 @@ static int ehci_platform_power_on(struct
platform_device *dev)
err_exit_phy:
while (--phy_num = 0) {
- if (priv-phys[phy_num]) {
- phy_power_off(priv-phys[phy_num]);
- phy_exit(priv-phys[phy_num]);
- }
+ phy_power_off(priv-phys[phy_num]);
+ phy_exit(priv-phys[phy_num]);
}
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index
On Wed, Apr 15, 2015 at 8:06 PM, Alan Stern st...@rowland.harvard.edu wrote:
On Wed, 15 Apr 2015, rajeev kumar wrote:
@@ -88,15 +88,13 @@ static int ehci_platform_power_on(struct
platform_device *dev)
}
for (phy_num = 0; phy_num priv-num_phys; phy_num++) {
- if (priv-phys[phy_num]) {
- ret = phy_init(priv-phys[phy_num]);
- if (ret)
- goto err_exit_phy;
- ret = phy_power_on(priv-phys[phy_num]);
- if (ret) {
- phy_exit(priv-phys[phy_num]);
- goto err_exit_phy;
- }
+ ret = phy_init(priv-phys[phy_num]);
+ if (ret)
+ goto err_exit_phy;
Jumping to err_exit_phy will perform phy_power_off also which is not
required as you are are powering on after phy_init. Wrong level
jumping
Look again, and this time pay more attention to the value of phy_num.
Alan Stern
MIssed it , Thanks for the pointer.
~Rajeev
~Rajeev
+ ret = phy_power_on(priv-phys[phy_num]);
+ if (ret) {
+ phy_exit(priv-phys[phy_num]);
+ goto err_exit_phy;
}
}
@@ -104,10 +102,8 @@ static int ehci_platform_power_on(struct
platform_device *dev)
err_exit_phy:
while (--phy_num = 0) {
- if (priv-phys[phy_num]) {
- phy_power_off(priv-phys[phy_num]);
- phy_exit(priv-phys[phy_num]);
- }
+ phy_power_off(priv-phys[phy_num]);
+ phy_exit(priv-phys[phy_num]);
}
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index
On Tue, Apr 14, 2015 at 3:40 AM, Arun Ramamurthy
arun.ramamur...@broadcom.com wrote:
Getting phys by index instead of phy names so that we do
not have to create a naming scheme when multiple phys
are present
Signed-off-by: Arun Ramamurthy arun.ramamur...@broadcom.com
Reviewed-by: Ray Jui r...@broadcom.com
Reviewed-by: Scott Branden sbran...@broadcom.com
---
drivers/usb/host/Kconfig | 1 +
drivers/usb/host/ehci-platform.c | 70
++--
2 files changed, 26 insertions(+), 45 deletions(-)
diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 5ad60e4..563f22d 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -284,6 +284,7 @@ config USB_EHCI_ATH79
config USB_EHCI_HCD_PLATFORM
tristate Generic EHCI driver for a platform device
+ select GENERIC_PHY
default n
---help---
Adds an EHCI host driver for a generic platform device, which
diff --git a/drivers/usb/host/ehci-platform.c
b/drivers/usb/host/ehci-platform.c
index d8a75a5..a7563b9 100644
--- a/drivers/usb/host/ehci-platform.c
+++ b/drivers/usb/host/ehci-platform.c
@@ -88,15 +88,13 @@ static int ehci_platform_power_on(struct platform_device
*dev)
}
for (phy_num = 0; phy_num priv-num_phys; phy_num++) {
- if (priv-phys[phy_num]) {
- ret = phy_init(priv-phys[phy_num]);
- if (ret)
- goto err_exit_phy;
- ret = phy_power_on(priv-phys[phy_num]);
- if (ret) {
- phy_exit(priv-phys[phy_num]);
- goto err_exit_phy;
- }
+ ret = phy_init(priv-phys[phy_num]);
+ if (ret)
+ goto err_exit_phy;
Jumping to err_exit_phy will perform phy_power_off also which is not
required as you are are powering on after phy_init. Wrong level
jumping
~Rajeev
+ ret = phy_power_on(priv-phys[phy_num]);
+ if (ret) {
+ phy_exit(priv-phys[phy_num]);
+ goto err_exit_phy;
}
}
@@ -104,10 +102,8 @@ static int ehci_platform_power_on(struct platform_device
*dev)
err_exit_phy:
while (--phy_num = 0) {
- if (priv-phys[phy_num]) {
- phy_power_off(priv-phys[phy_num]);
- phy_exit(priv-phys[phy_num]);
- }
+ phy_power_off(priv-phys[phy_num]);
+ phy_exit(priv-phys[phy_num]);
}
err_disable_clks:
while (--clk = 0)
@@ -123,10 +119,8 @@ static void ehci_platform_power_off(struct
platform_device *dev)
int clk, phy_num;
for (phy_num = 0; phy_num priv-num_phys; phy_num++) {
- if (priv-phys[phy_num]) {
- phy_power_off(priv-phys[phy_num]);
- phy_exit(priv-phys[phy_num]);
- }
+ phy_power_off(priv-phys[phy_num]);
+ phy_exit(priv-phys[phy_num]);
}
for (clk = EHCI_MAX_CLKS - 1; clk = 0; clk--)
@@ -154,7 +148,6 @@ static int ehci_platform_probe(struct platform_device
*dev)
struct usb_ehci_pdata *pdata = dev_get_platdata(dev-dev);
struct ehci_platform_priv *priv;
struct ehci_hcd *ehci;
- const char *phy_name;
int err, irq, phy_num, clk = 0;
if (usb_disabled())
@@ -204,36 +197,23 @@ static int ehci_platform_probe(struct platform_device
*dev)
priv-num_phys = of_count_phandle_with_args(dev-dev.of_node,
phys, #phy-cells);
- priv-num_phys = priv-num_phys 0 ? priv-num_phys : 1;
- priv-phys = devm_kcalloc(dev-dev, priv-num_phys,
- sizeof(struct phy *), GFP_KERNEL);
- if (!priv-phys)
- return -ENOMEM;
+ if (priv-num_phys 0) {
+ priv-phys = devm_kcalloc(dev-dev, priv-num_phys,
+ sizeof(struct phy *), GFP_KERNEL);
+ if (!priv-phys)
+ return -ENOMEM;
+ } else
+ priv-num_phys = 0;
for (phy_num = 0; phy_num priv-num_phys; phy_num++) {
- err = of_property_read_string_index(
- dev-dev.of_node,
- phy-names, phy_num,
- phy_name);
-
- if (err 0) {
- if (priv-num_phys 1) {
- dev_err(dev-dev, phy-names
not provided);
-
Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index
On Tuesday 14 April 2015 13:19:34 Greg Kroah-Hartman wrote: On Mon, Apr 13, 2015 at 03:10:46PM -0700, Arun Ramamurthy wrote: Getting phys by index instead of phy names so that we do not have to create a naming scheme when multiple phys are present Signed-off-by: Arun Ramamurthy arun.ramamur...@broadcom.com Reviewed-by: Ray Jui r...@broadcom.com Reviewed-by: Scott Branden sbran...@broadcom.com --- drivers/usb/host/Kconfig | 1 + drivers/usb/host/ehci-platform.c | 70 ++-- 2 files changed, 26 insertions(+), 45 deletions(-) diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index 5ad60e4..563f22d 100644 --- a/drivers/usb/host/Kconfig +++ b/drivers/usb/host/Kconfig @@ -284,6 +284,7 @@ config USB_EHCI_ATH79 config USB_EHCI_HCD_PLATFORM tristate Generic EHCI driver for a platform device + select GENERIC_PHY Configs should never select if at all possible. This is true, but all other drivers do the same for GENERIC_PHY at the moment. If this one gets changed, we should probably apply the same solution to all current users and fix them consistently. We can do one of these two: a) make sure that the framework has 'static inline' stubs that let you build all drivers using it when the framework itself is disabled. b) change the drivers using it to 'depends on', and make GENERIC_PHY itself a hidden option without a Kconfig prompt. Either solution is probably simple enough that it can be done as part of this series. Arnd -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index
On Mon, Apr 13, 2015 at 03:10:46PM -0700, Arun Ramamurthy wrote: Getting phys by index instead of phy names so that we do not have to create a naming scheme when multiple phys are present Signed-off-by: Arun Ramamurthy arun.ramamur...@broadcom.com Reviewed-by: Ray Jui r...@broadcom.com Reviewed-by: Scott Branden sbran...@broadcom.com --- drivers/usb/host/Kconfig | 1 + drivers/usb/host/ehci-platform.c | 70 ++-- 2 files changed, 26 insertions(+), 45 deletions(-) diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index 5ad60e4..563f22d 100644 --- a/drivers/usb/host/Kconfig +++ b/drivers/usb/host/Kconfig @@ -284,6 +284,7 @@ config USB_EHCI_ATH79 config USB_EHCI_HCD_PLATFORM tristate Generic EHCI driver for a platform device + select GENERIC_PHY Configs should never select if at all possible. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index
On Tue, Apr 14, 2015 at 03:17:30PM +0200, Arnd Bergmann wrote: On Tuesday 14 April 2015 14:37:37 Greg Kroah-Hartman wrote: On Tue, Apr 14, 2015 at 01:33:08PM +0200, Arnd Bergmann wrote: This is true, but all other drivers do the same for GENERIC_PHY at the moment. If this one gets changed, we should probably apply the same solution to all current users and fix them consistently. We can do one of these two: a) make sure that the framework has 'static inline' stubs that let you build all drivers using it when the framework itself is disabled. Yes, please do that. b) change the drivers using it to 'depends on', and make GENERIC_PHY itself a hidden option without a Kconfig prompt. Then how could GENERIC_PHY ever get set? Right now, every driver that provides a phy uses 'select GENERIC_PHY', and they would have to keep doing that. This is not unlike what we do for other silent symbols like MFD_CORE, REGMAP_I2C, or PINCTRL, and it's not as problematic as 'select' on a user-visible option, or (worst) mixing 'select' and 'depends on'. Ok, that would make more sense, but it would be good for the PHY maintainer to agree to it as well :) thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index
On 15-04-14 07:21 AM, Kishon Vijay Abraham I wrote: Hi, On Tuesday 14 April 2015 06:57 PM, Greg Kroah-Hartman wrote: On Tue, Apr 14, 2015 at 03:17:30PM +0200, Arnd Bergmann wrote: On Tuesday 14 April 2015 14:37:37 Greg Kroah-Hartman wrote: On Tue, Apr 14, 2015 at 01:33:08PM +0200, Arnd Bergmann wrote: This is true, but all other drivers do the same for GENERIC_PHY at the moment. If this one gets changed, we should probably apply the same solution to all current users and fix them consistently. We can do one of these two: a) make sure that the framework has 'static inline' stubs that let you build all drivers using it when the framework itself is disabled. Yes, please do that. b) change the drivers using it to 'depends on', and make GENERIC_PHY itself a hidden option without a Kconfig prompt. Then how could GENERIC_PHY ever get set? Right now, every driver that provides a phy uses 'select GENERIC_PHY', and they would have to keep doing that. This is not unlike what we do for other silent symbols like MFD_CORE, REGMAP_I2C, or PINCTRL, and it's not as problematic as 'select' on a user-visible option, or (worst) mixing 'select' and 'depends on'. Ok, that would make more sense, but it would be good for the PHY maintainer to agree to it as well :) looking at [1], we should use select only for non-visible symbols and for symbols with no dependencies. As such GENERIC_PHY is not dependent on other symbols but for now it is visible. phy-core has all the stubs already implemented in include/linux/phy/phy.h. So removing select GENERIC_PHY shouldn't be a problem. But then it might break a few platforms where GENERIC_PHY is indirectly enabled by selecting the config of the driver (using default defconfigs in arch/arm/configs). The simplest thing would be to make GENERIC_PHY an invisible option? [1] - https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/kbuild/kconfig-language.txt#n111 Kishon,removing select GENERIC_PHY also breaks the builds for certain architectures (i386 and x84_64). Is the consensus to leave the select but make GENERIC_PHY a invisible option? Thanks Thanks Kishon -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index
My apologies Alan, I missed that comment I was indeed trying to avoid the 80 column rule. It looks like i will have to resend this patch, so i will reformat the code then. Thanks On 15-04-14 07:41 AM, Alan Stern wrote: On Mon, 13 Apr 2015, Arun Ramamurthy wrote: Getting phys by index instead of phy names so that we do not have to create a naming scheme when multiple phys are present Signed-off-by: Arun Ramamurthy arun.ramamur...@broadcom.com Reviewed-by: Ray Jui r...@broadcom.com Reviewed-by: Scott Branden sbran...@broadcom.com You have not responded to the comments I posted earlier: http://marc.info/?l=linux-usbm=142798455925594w=2 Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index
On Mon, 13 Apr 2015, Arun Ramamurthy wrote: Getting phys by index instead of phy names so that we do not have to create a naming scheme when multiple phys are present Signed-off-by: Arun Ramamurthy arun.ramamur...@broadcom.com Reviewed-by: Ray Jui r...@broadcom.com Reviewed-by: Scott Branden sbran...@broadcom.com You have not responded to the comments I posted earlier: http://marc.info/?l=linux-usbm=142798455925594w=2 Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index
Hi Arnd, On Tuesday 14 April 2015 06:47 PM, Arnd Bergmann wrote: On Tuesday 14 April 2015 14:37:37 Greg Kroah-Hartman wrote: On Tue, Apr 14, 2015 at 01:33:08PM +0200, Arnd Bergmann wrote: This is true, but all other drivers do the same for GENERIC_PHY at the moment. If this one gets changed, we should probably apply the same solution to all current users and fix them consistently. We can do one of these two: a) make sure that the framework has 'static inline' stubs that let you build all drivers using it when the framework itself is disabled. Yes, please do that. b) change the drivers using it to 'depends on', and make GENERIC_PHY itself a hidden option without a Kconfig prompt. Then how could GENERIC_PHY ever get set? Right now, every driver that provides a phy uses 'select GENERIC_PHY', and they would have to keep doing that. This is not unlike what we do for other silent symbols like MFD_CORE, REGMAP_I2C, or PINCTRL, and it's not as problematic as 'select' on a user-visible option, or (worst) mixing 'select' and 'depends on'. Sorry, didn't get how GENERIC_PHY could be set with option 'b'. Thanks Kishon -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index
Hi, On Tuesday 14 April 2015 06:57 PM, Greg Kroah-Hartman wrote: On Tue, Apr 14, 2015 at 03:17:30PM +0200, Arnd Bergmann wrote: On Tuesday 14 April 2015 14:37:37 Greg Kroah-Hartman wrote: On Tue, Apr 14, 2015 at 01:33:08PM +0200, Arnd Bergmann wrote: This is true, but all other drivers do the same for GENERIC_PHY at the moment. If this one gets changed, we should probably apply the same solution to all current users and fix them consistently. We can do one of these two: a) make sure that the framework has 'static inline' stubs that let you build all drivers using it when the framework itself is disabled. Yes, please do that. b) change the drivers using it to 'depends on', and make GENERIC_PHY itself a hidden option without a Kconfig prompt. Then how could GENERIC_PHY ever get set? Right now, every driver that provides a phy uses 'select GENERIC_PHY', and they would have to keep doing that. This is not unlike what we do for other silent symbols like MFD_CORE, REGMAP_I2C, or PINCTRL, and it's not as problematic as 'select' on a user-visible option, or (worst) mixing 'select' and 'depends on'. Ok, that would make more sense, but it would be good for the PHY maintainer to agree to it as well :) looking at [1], we should use select only for non-visible symbols and for symbols with no dependencies. As such GENERIC_PHY is not dependent on other symbols but for now it is visible. phy-core has all the stubs already implemented in include/linux/phy/phy.h. So removing select GENERIC_PHY shouldn't be a problem. But then it might break a few platforms where GENERIC_PHY is indirectly enabled by selecting the config of the driver (using default defconfigs in arch/arm/configs). The simplest thing would be to make GENERIC_PHY an invisible option? [1] - https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/kbuild/kconfig-language.txt#n111 Thanks Kishon -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index
On Tuesday 14 April 2015 11:05:35 Arun Ramamurthy wrote: [1] - https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/kbuild/kconfig-language.txt#n111 Kishon,removing select GENERIC_PHY also breaks the builds for certain architectures (i386 and x84_64). Is the consensus to leave the select but make GENERIC_PHY a invisible option? Thanks I think the best solution is - make GENERIC_PHY a silent option - change PHY_RCAR_GEN2 to use 'select' instead of 'depends on', so it will still work when all other phy drivers are disabled - change the non-phy drivers that select GENERIC_PHY to either use 'depends on' or no explicit dependency in case they are still functional without the API. Note that drivers/pinctrl/pinctrl-tegra-xusb.c is a phy provider as well, not a consumer, despite being outside of drivers/phy. Arnd -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index
On Tuesday 14 April 2015 14:37:37 Greg Kroah-Hartman wrote: On Tue, Apr 14, 2015 at 01:33:08PM +0200, Arnd Bergmann wrote: This is true, but all other drivers do the same for GENERIC_PHY at the moment. If this one gets changed, we should probably apply the same solution to all current users and fix them consistently. We can do one of these two: a) make sure that the framework has 'static inline' stubs that let you build all drivers using it when the framework itself is disabled. Yes, please do that. b) change the drivers using it to 'depends on', and make GENERIC_PHY itself a hidden option without a Kconfig prompt. Then how could GENERIC_PHY ever get set? Right now, every driver that provides a phy uses 'select GENERIC_PHY', and they would have to keep doing that. This is not unlike what we do for other silent symbols like MFD_CORE, REGMAP_I2C, or PINCTRL, and it's not as problematic as 'select' on a user-visible option, or (worst) mixing 'select' and 'depends on'. Arnd -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index
On Tue, Apr 14, 2015 at 01:33:08PM +0200, Arnd Bergmann wrote: On Tuesday 14 April 2015 13:19:34 Greg Kroah-Hartman wrote: On Mon, Apr 13, 2015 at 03:10:46PM -0700, Arun Ramamurthy wrote: Getting phys by index instead of phy names so that we do not have to create a naming scheme when multiple phys are present Signed-off-by: Arun Ramamurthy arun.ramamur...@broadcom.com Reviewed-by: Ray Jui r...@broadcom.com Reviewed-by: Scott Branden sbran...@broadcom.com --- drivers/usb/host/Kconfig | 1 + drivers/usb/host/ehci-platform.c | 70 ++-- 2 files changed, 26 insertions(+), 45 deletions(-) diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index 5ad60e4..563f22d 100644 --- a/drivers/usb/host/Kconfig +++ b/drivers/usb/host/Kconfig @@ -284,6 +284,7 @@ config USB_EHCI_ATH79 config USB_EHCI_HCD_PLATFORM tristate Generic EHCI driver for a platform device + select GENERIC_PHY Configs should never select if at all possible. This is true, but all other drivers do the same for GENERIC_PHY at the moment. If this one gets changed, we should probably apply the same solution to all current users and fix them consistently. We can do one of these two: a) make sure that the framework has 'static inline' stubs that let you build all drivers using it when the framework itself is disabled. Yes, please do that. b) change the drivers using it to 'depends on', and make GENERIC_PHY itself a hidden option without a Kconfig prompt. Then how could GENERIC_PHY ever get set? Either solution is probably simple enough that it can be done as part of this series. That's fine with me, but please no more selects. thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
