Re: [PATCH] staging: wilc1000: change WILC_Char to s8

2015-06-14 Thread Greg KH 
On Mon, Jun 15, 2015 at 09:47:04AM +0900, Dean.lee wrote:
 
 
 On 2015년 06월 13일 00:28, Greg KH wrote:
 On Fri, Jun 12, 2015 at 02:39:08PM +0900, Dean Lee wrote:
 change own data type(WILC_Char) to common data type(s8)
 Why not just 'char'?
 
 And you are using these in strings, so why not u8?
 
 thanks,
 
 greg k-h
 i research some documents for change to common data type.
 that's saying 's8' is 'signed char'.
 
 'WILC_Char' is redefine 'char'. so i changed 'WILC_Char' to 's8'

Then stick to 'char', don't change the type.

thanks,

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] staging: wilc1000: change WILC_Char to s8

2015-06-12 Thread Greg KH 
On Fri, Jun 12, 2015 at 02:39:08PM +0900, Dean Lee wrote:
 change own data type(WILC_Char) to common data type(s8)

Why not just 'char'?

And you are using these in strings, so why not u8?

thanks,

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] staging: wilc1000: change WILC_Char to s8

2015-06-11 Thread Dean Lee 
change own data type(WILC_Char) to common data type(s8)

Signed-off-by: Dean Lee dean@atmel.com
---
 drivers/staging/wilc1000/coreconfigurator.c   | 24 +++
 drivers/staging/wilc1000/coreconfigurator.h   |  4 +-
 drivers/staging/wilc1000/host_interface.c | 88 +++
 drivers/staging/wilc1000/wilc_memory.c|  8 +--
 drivers/staging/wilc1000/wilc_memory.h|  8 +--
 drivers/staging/wilc1000/wilc_oswrapper.h |  3 -
 drivers/staging/wilc1000/wilc_strutils.c  |  6 +-
 drivers/staging/wilc1000/wilc_strutils.h  |  6 +-
 drivers/staging/wilc1000/wilc_wfi_cfgoperations.c |  6 +-
 9 files changed, 75 insertions(+), 78 deletions(-)

diff --git a/drivers/staging/wilc1000/coreconfigurator.c 
b/drivers/staging/wilc1000/coreconfigurator.c
index 9abc73d..a048b44 100644
--- a/drivers/staging/wilc1000/coreconfigurator.c
+++ b/drivers/staging/wilc1000/coreconfigurator.c
@@ -142,7 +142,7 @@ typedef enum {
 
 
 typedef struct {
-   WILC_Char *pcRespBuffer;
+   s8 *pcRespBuffer;
s32 s32MaxRespBuffLen;
s32 s32BytesRead;
bool bRespRequired;
@@ -340,7 +340,7 @@ INLINE u8 get_hex_char(u8 inp)
 
 /* This function extracts the MAC address held in a string in standard format 
*/
 /* into another buffer as integers.   
*/
-INLINE u16 extract_mac_addr(WILC_Char *str, u8 *buff)
+INLINE u16 extract_mac_addr(s8 *str, u8 *buff)
 {
*buff = 0;
while (*str != '\0') {
@@ -1096,7 +1096,7 @@ s32 DeallocateSurveyResults(wid_site_survey_reslts_s 
*pstrSurveyResults)
 /*   */
 /*/
 
-void ProcessCharWid(WILC_Char *pcPacket, s32 *ps32PktLen,
+void ProcessCharWid(s8 *pcPacket, s32 *ps32PktLen,
tstrWID *pstrWID, s8 *ps8WidVal)
 {
u8 *pu8val = (u8 *)ps8WidVal;
@@ -1150,7 +1150,7 @@ void ProcessCharWid(WILC_Char *pcPacket, s32 *ps32PktLen,
 /*   */
 /*/
 
-void ProcessShortWid(WILC_Char *pcPacket, s32 *ps32PktLen,
+void ProcessShortWid(s8 *pcPacket, s32 *ps32PktLen,
 tstrWID *pstrWID, s8 *ps8WidVal)
 {
u16 *pu16val = (u16 *)ps8WidVal;
@@ -1205,7 +1205,7 @@ void ProcessShortWid(WILC_Char *pcPacket, s32 *ps32PktLen,
 /*   */
 /*/
 
-void ProcessIntWid(WILC_Char *pcPacket, s32 *ps32PktLen,
+void ProcessIntWid(s8 *pcPacket, s32 *ps32PktLen,
   tstrWID *pstrWID, s8 *ps8WidVal)
 {
u32 *pu32val = (u32 *)ps8WidVal;
@@ -1263,7 +1263,7 @@ void ProcessIntWid(WILC_Char *pcPacket, s32 *ps32PktLen,
 /*   */
 /*/
 
-void ProcessIPwid(WILC_Char *pcPacket, s32 *ps32PktLen,
+void ProcessIPwid(s8 *pcPacket, s32 *ps32PktLen,
  tstrWID *pstrWID, u8 *pu8ip)
 {
u32 u32val = 0;
@@ -1321,7 +1321,7 @@ void ProcessIPwid(WILC_Char *pcPacket, s32 *ps32PktLen,
 /*   */
 /*/
 
-void ProcessStrWid(WILC_Char *pcPacket, s32 *ps32PktLen,
+void ProcessStrWid(s8 *pcPacket, s32 *ps32PktLen,
   tstrWID *pstrWID, u8 *pu8val, s32 s32ValueSize)
 {
u16 u16MsgLen = 0;
@@ -1378,7 +1378,7 @@ void ProcessStrWid(WILC_Char *pcPacket, s32 *ps32PktLen,
 /*   */
 /*/
 
-void ProcessAdrWid(WILC_Char *pcPacket, s32 *ps32PktLen,
+void ProcessAdrWid(s8 *pcPacket, s32 *ps32PktLen,
   tstrWID *pstrWID, u8 *pu8val)
 {
u16 u16MsgLen = 0;
@@ -1442,7 +1442,7 @@ void ProcessAdrWid(WILC_Char *pcPacket, s32 *ps32PktLen,
 /*   */
 /*/
 
-void ProcessBinWid(WILC_Char *pcPacket, s32 *ps32PktLen,
+void ProcessBinWid(s8 *pcPacket, s32 *ps32PktLen,
   tstrWID *pstrWID, u8 *pu8val, s32 s32ValueSize)
 {
/* WILC_ERROR(processing Binary WIDs is not supported\n); */
@@ -1803,7 +1803,7 @@ s32 ParseWriteResponse(u8 *pu8RespBuffer)
  *  @version   1.0
  */
 
-s32 CreatePacketHeader(WILC_Char *pcpacket, s32 *ps32PacketLength)
+s32 CreatePacketHeader(s8 *pcpacket, s32 *ps32PacketLength)
 {
s32 s32Error = WILC_SUCCESS;
u16 u16MsgLen =