Re: [PATCH 0/4] ath10k: fix/cleanup fw stats
Michal Kazior michal.kaz...@tieto.com writes: This cleans up and fixes fw stats aggregation. Michal Kazior (4): ath10k: split wmi stats parsing ath10k: rename fw_stats related stuff ath10k: request fw_stats once on open ath10k: fix fw stats processing Thanks, applied. And thank you for fixing this for good, it has been buggy for way too long. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/4] ath10k: fix/cleanup fw stats
Michal Kazior michal.kaz...@tieto.com writes: Hi, This cleans up and fixes fw stats aggregation. Michal Kazior (4): ath10k: split wmi stats parsing ath10k: rename fw_stats related stuff ath10k: request fw_stats once on open ath10k: fix fw stats processing I didn't review these yet but I saw new warnings: drivers/net/wireless/ath/ath10k/debug.c: In function 'ath10k_fw_stats_fill': drivers/net/wireless/ath/ath10k/debug.c:540:5: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'size_t' [-Wformat] drivers/net/wireless/ath/ath10k/wmi.c:1513: WARNING: else is not generally useful after a break or return -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/4] ath10k: fix/cleanup fw stats
On 26 September 2014 13:06, Kalle Valo kv...@qca.qualcomm.com wrote: Michal Kazior michal.kaz...@tieto.com writes: Hi, This cleans up and fixes fw stats aggregation. Michal Kazior (4): ath10k: split wmi stats parsing ath10k: rename fw_stats related stuff ath10k: request fw_stats once on open ath10k: fix fw stats processing I didn't review these yet but I saw new warnings: drivers/net/wireless/ath/ath10k/debug.c: In function 'ath10k_fw_stats_fill': drivers/net/wireless/ath/ath10k/debug.c:540:5: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'size_t' [-Wformat] Oh, I didn't see this one. I guess it should be %zu. drivers/net/wireless/ath/ath10k/wmi.c:1513: WARNING: else is not generally useful after a break or return I'm aware of this one but the code looks nicer with the `else` to me though. Michał -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/4] ath10k: fix/cleanup fw stats
On Fri, 2014-09-26 at 13:14 +0200, Michal Kazior wrote: On 26 September 2014 13:06, Kalle Valo kv...@qca.qualcomm.com wrote: drivers/net/wireless/ath/ath10k/wmi.c:1513: WARNING: else is not generally useful after a break or return I'm aware of this one but the code looks nicer with the `else` to me though. Yay Michal. Always use your taste over any mindless style tool. Ignore any checkpatch complaint you want. btw: checkpatch shouldn't warn about this as of: commit adefeef310ee8bd3923d41b67bc53c398bc53621 Author: Joe Perches j...@perches.com Date: Fri Sep 26 10:19:29 2014 +1000 checkpatch: add exception to return then else test Add an exception to the return before else warning when the line following it is also a return like: if (foo) return bar; else return baz; This form of a test then return is at least as readable as if (foo) return bar; return baz; so don't emit a warning on the first form. Signed-off-by: Joe Perches j...@perches.com Reported-by: Al Viro v...@zeniv.linux.org.uk Cc: Elshad Mustafayev elshad...@gmail.com Signed-off-by: Andrew Morton a...@linux-foundation.org -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/4] ath10k: fix/cleanup fw stats
Hi, This cleans up and fixes fw stats aggregation. Michal Kazior (4): ath10k: split wmi stats parsing ath10k: rename fw_stats related stuff ath10k: request fw_stats once on open ath10k: fix fw stats processing drivers/net/wireless/ath/ath10k/core.h | 26 +- drivers/net/wireless/ath/ath10k/debug.c | 476 ++-- drivers/net/wireless/ath/ath10k/debug.h | 7 +- drivers/net/wireless/ath/ath10k/wmi.c | 190 - drivers/net/wireless/ath/ath10k/wmi.h | 24 +- 5 files changed, 483 insertions(+), 240 deletions(-) -- 1.8.5.3 -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
