Re: [PATCH 1/2] rtl8xxxu: Fix rtl8723bu driver reload issue

[Kalle Valo]

Jes Sorensen  writes:

> Greg KH  writes:
>> On Fri, Sep 30, 2016 at 07:35:17PM -0400, jes.soren...@redhat.com wrote:
>>> From: Jes Sorensen 
>>> 
>>> The generic disable_rf() function clears bits 22 and 23 in
>>> REG_RX_WAIT_CCA, however we did not re-enable them again in
>>> rtl8723b_enable_rf()
>>> 
>>> This resolves the problem for me with 8723bu devices not working again
>>> after reloading the driver.
>>> 
>>> Signed-off-by: Jes Sorensen 
>>> ---
>>>  drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c | 4 
>>>  1 file changed, 4 insertions(+)
>>
>> 
>>
>> This is not the correct way to submit patches for inclusion in the
>> stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
>> for how to do this properly.
>>
>> 
>
> DOH Kalle told me to CC stable I took it for granted that you meant CC
> in the email sense. Guess I get to blame my self for looking like a
> fool in public.

Yes, I meant adding it to the commit log. This part of the stable
process is a bit confusing, I should have been more clear how this
works.

> I'll send you an email directly with the SHA once it hits Linus' tree
> instead.

No need, I'll add this to the commit log and the stable team will get
the commit automatically once the commit is in Linus' tree:

Cc: sta...@vger.kernel.org # 4.7+

-- 
Kalle Valo

Re: [PATCH 1/2] rtl8xxxu: Fix rtl8723bu driver reload issue

[Jes Sorensen]

Greg KH  writes:
> On Fri, Sep 30, 2016 at 07:35:17PM -0400, jes.soren...@redhat.com wrote:
>> From: Jes Sorensen 
>> 
>> The generic disable_rf() function clears bits 22 and 23 in
>> REG_RX_WAIT_CCA, however we did not re-enable them again in
>> rtl8723b_enable_rf()
>> 
>> This resolves the problem for me with 8723bu devices not working again
>> after reloading the driver.
>> 
>> Signed-off-by: Jes Sorensen 
>> ---
>>  drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c | 4 
>>  1 file changed, 4 insertions(+)
>
> 
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
> for how to do this properly.
>
> 

DOH Kalle told me to CC stable I took it for granted that you meant CC
in the email sense. Guess I get to blame my self for looking like a
fool in public.

I'll send you an email directly with the SHA once it hits Linus' tree
instead.

Jes

Re: [PATCH 1/2] rtl8xxxu: Fix rtl8723bu driver reload issue

[Greg KH]

On Fri, Sep 30, 2016 at 07:35:17PM -0400, jes.soren...@redhat.com wrote:
> From: Jes Sorensen 
> 
> The generic disable_rf() function clears bits 22 and 23 in
> REG_RX_WAIT_CCA, however we did not re-enable them again in
> rtl8723b_enable_rf()
> 
> This resolves the problem for me with 8723bu devices not working again
> after reloading the driver.
> 
> Signed-off-by: Jes Sorensen 
> ---
>  drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c | 4 
>  1 file changed, 4 insertions(+)



This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

[PATCH 1/2] rtl8xxxu: Fix rtl8723bu driver reload issue

[Jes . Sorensen]

From: Jes Sorensen 

The generic disable_rf() function clears bits 22 and 23 in
REG_RX_WAIT_CCA, however we did not re-enable them again in
rtl8723b_enable_rf()

This resolves the problem for me with 8723bu devices not working again
after reloading the driver.

Signed-off-by: Jes Sorensen 
---
 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c 
b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c
index 6c086b5..02b8ddd 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c
@@ -1498,6 +1498,10 @@ static void rtl8723b_enable_rf(struct rtl8xxxu_priv 
*priv)
u32 val32;
u8 val8;
 
+   val32 = rtl8xxxu_read32(priv, REG_RX_WAIT_CCA);
+   val32 |= (BIT(22) | BIT(23));
+   rtl8xxxu_write32(priv, REG_RX_WAIT_CCA, val32);
+
/*
 * No indication anywhere as to what 0x0790 does. The 2 antenna
 * vendor code preserves bits 6-7 here.
-- 
2.7.4