Re: [PATCH 15/34] brcmfamc: remove unnecessary call to brcmf_sdiod_set_backplane_window()

[Arend van Spriel]

On 8/7/2017 1:11 PM, Arend van Spriel wrote:

On 7/26/2017 10:25 PM, Ian Molton wrote:

All functions that might require the window address changing call
brcmf_sdiod_set_backplane_window() prior to access. Thus resetting
the window is not required.


Actually noticed a minor nit. The subject says "brcmfamc".

Regards,
Arend


Acked-by: Arend van Spriel 

Signed-off-by: Ian Molton 
---
  drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 5 -
  1 file changed, 5 deletions(-)

Re: [PATCH 15/34] brcmfamc: remove unnecessary call to brcmf_sdiod_set_backplane_window()

[Arend van Spriel]

On 7/26/2017 10:25 PM, Ian Molton wrote:

All functions that might require the window address changing call
brcmf_sdiod_set_backplane_window() prior to access. Thus resetting
the window is not required.


Acked-by: Arend van Spriel 

Signed-off-by: Ian Molton 
---
  drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 5 -
  1 file changed, 5 deletions(-)

[PATCH 15/34] brcmfamc: remove unnecessary call to brcmf_sdiod_set_backplane_window()

[Ian Molton]

All functions that might require the window address changing call
brcmf_sdiod_set_backplane_window() prior to access. Thus resetting
the window is not required.

Signed-off-by: Ian Molton 
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 5 -
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c 
b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
index 24775869aee4..6884d1f0b935 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
@@ -723,11 +723,6 @@ brcmf_sdiod_ramrw(struct brcmf_sdio_dev *sdiodev, bool 
write, u32 address,
 
dev_kfree_skb(pkt);
 
-   /* Return the window to backplane enumeration space for core access */
-   if (brcmf_sdiod_set_backplane_window(sdiodev, sdiodev->sbwad))
-   brcmf_err("FAILED to set window back to 0x%x\n",
- sdiodev->sbwad);
-
sdio_release_host(sdiodev->func[1]);
 
return err;
-- 
2.11.0

[PATCH 15/34] brcmfamc: remove unnecessary call to brcmf_sdiod_set_backplane_window()

[Ian Molton]

All functions that might require the window address changing call
brcmf_sdiod_set_backplane_window() prior to access. Thus resetting
the window is not required.

Signed-off-by: Ian Molton 
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 5 -
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c 
b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
index eb388b69418a..ab015bad02f2 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
@@ -723,11 +723,6 @@ brcmf_sdiod_ramrw(struct brcmf_sdio_dev *sdiodev, bool 
write, u32 address,
 
dev_kfree_skb(pkt);
 
-   /* Return the window to backplane enumeration space for core access */
-   if (brcmf_sdiod_set_backplane_window(sdiodev, sdiodev->sbwad))
-   brcmf_err("FAILED to set window back to 0x%x\n",
- sdiodev->sbwad);
-
sdio_release_host(sdiodev->func[1]);
 
return err;
-- 
2.11.0