Re: [PATCH 1/6] ath9k: disable overriding AR9340 SLP32 registers

2014-11-12 Thread Felix Fietkau 
On 2014-11-11 08:07, Sujith Manoharan wrote:
 From: Miaoqing Pan miaoq...@qca.qualcomm.com
 
 For AR9340, the correct values for SLP32 registers are present
 in the initvals, so overriding them is not needed.
 
 Signed-off-by: Miaoqing Pan miaoq...@qca.qualcomm.com
 Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com
What's the point in doing this? The writes don't hurt, and this change
is making the code uglier.

- Felix
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/6] ath9k: disable overriding AR9340 SLP32 registers

2014-11-12 Thread Sujith Manoharan 
Felix Fietkau wrote:
 What's the point in doing this? The writes don't hurt, and this change
 is making the code uglier.

Well, the code is redundant and I don't see the point in
doing the writes when we don't have to ? We could maybe
restructure it a bit...

Sujith
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html