Hi Joe,
On Wed, 2017-06-28 at 13:43 -0700, Joe Perches wrote:
> On Wed, 2017-06-28 at 23:13 +0300, Luca Coelho wrote:
> > Print the queue for the existing debug message and add a new
> > debug message indicating where the RB ended.
>
> trivia:
>
> > diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
> > b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
>
> []
> > @@ -1137,8 +1141,8 @@ static void iwl_pcie_rx_handle_rb(struct iwl_trans
> > *trans,
> > FH_RSCSR_RXQ_POS);
> >
> > IWL_DEBUG_RX(trans,
> > -"cmd at offset %d: %s (%.2x.%2x, seq 0x%x)\n",
> > -rxcb._offset,
> > +"Q %d: cmd at offset %d: %s (%.2x.%2x, seq
> > 0x%x)\n",
> > +rxq->id, offset,
> > iwl_get_cmd_string(trans,
> > iwl_cmd_id(pkt->hdr.cmd,
> >pkt->hdr.group_id,
>
> Perhaps %02x.%02x instead of %.2x.%2x
>
> Most uses are %.2x.%.2x, but %02x.%02x seems clearer
> at least to me.
Sure, I tend to agree, but in this sort of debugging, people usually go
down into the code to see exactly what it means anyway... So we'll keep
it in mind for the next time, but we won't change this one right now.
Thanks!
--
Cheers,
Luca.
