Re: [PATCH RFC] ipw2200: select CFG80211_WEXT
Paul Bolle pebo...@tiscali.nl writes: Commit 24a0aa212ee2 (cfg80211: make WEXT compatibility unselectable) made it impossible to depend on CFG80211_WEXT. It does still allow to select that symbol. (Yes, the commit summary is confusing.) So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be built again. Signed-off-by: Paul Bolle pebo...@tiscali.nl Thanks, applied to wireless-drivers.git. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RFC] ipw2200: select CFG80211_WEXT
On Tue, 2014-12-23 at 08:52 +0200, Kalle Valo wrote: Paul Bolle pebo...@tiscali.nl writes: Commit 24a0aa212ee2 (cfg80211: make WEXT compatibility unselectable) made it impossible to depend on CFG80211_WEXT. It does still allow to select that symbol. (Yes, the commit summary is confusing.) So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be built again. I think the last sentence is a bit misleading (this isn't a compilation error, right?) No, it's not a compilation error. The reasoning here is that all code hidden behind a Kconfig symbol that cannot be set will, in practice, never be built. Sure, there are hoops one can jump through to try to bypass the generated .config, but no one should have to do that. and I would like to clarify it like this: So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be enabled in config again. Does that look ok? I understand the confusion my text might cause, so I'm fine with your amendment. Thanks, Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RFC] ipw2200: select CFG80211_WEXT
On Mon, 2014-12-22 at 19:10 +0100, Paul Bolle wrote: Commit 24a0aa212ee2 (cfg80211: make WEXT compatibility unselectable) made it impossible to depend on CFG80211_WEXT. It does still allow to select that symbol. (Yes, the commit summary is confusing.) So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be built again. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Johannes, Building v3.19-rc1 for an outdated ThinkPad X41 left me without the ipw2200 driver. It turns out this trivial patch is all that's needed to make ipw2200 buildable again. (A similar patch would be needed for the drivers behind Kconfig symbol HERMES. Ie, orinico and friends.) Yeah, config HERMES needs the same change. Kalle, do you want to take those through your tree, or should I fix it seeing that I introduced the bug in a sense? johannes -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RFC] ipw2200: select CFG80211_WEXT
Paul Bolle pebo...@tiscali.nl writes: On Tue, 2014-12-23 at 08:52 +0200, Kalle Valo wrote: Paul Bolle pebo...@tiscali.nl writes: Commit 24a0aa212ee2 (cfg80211: make WEXT compatibility unselectable) made it impossible to depend on CFG80211_WEXT. It does still allow to select that symbol. (Yes, the commit summary is confusing.) So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be built again. I think the last sentence is a bit misleading (this isn't a compilation error, right?) No, it's not a compilation error. The reasoning here is that all code hidden behind a Kconfig symbol that cannot be set will, in practice, never be built. Sure, there are hoops one can jump through to try to bypass the generated .config, but no one should have to do that. and I would like to clarify it like this: So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be enabled in config again. Does that look ok? I understand the confusion my text might cause, so I'm fine with your amendment. Thanks for checking. I'll modify the commit log and apply it to wireless-drivers.git. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RFC] ipw2200: select CFG80211_WEXT
Johannes Berg johan...@sipsolutions.net writes: On Mon, 2014-12-22 at 19:10 +0100, Paul Bolle wrote: Commit 24a0aa212ee2 (cfg80211: make WEXT compatibility unselectable) made it impossible to depend on CFG80211_WEXT. It does still allow to select that symbol. (Yes, the commit summary is confusing.) So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be built again. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Johannes, Building v3.19-rc1 for an outdated ThinkPad X41 left me without the ipw2200 driver. It turns out this trivial patch is all that's needed to make ipw2200 buildable again. (A similar patch would be needed for the drivers behind Kconfig symbol HERMES. Ie, orinico and friends.) Yeah, config HERMES needs the same change. Kalle, do you want to take those through your tree, or should I fix it seeing that I introduced the bug in a sense? To keep things simple I would prefer to take this through wireless-drivers.git, if it's ok for you. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RFC] ipw2200: select CFG80211_WEXT
Paul Bolle pebo...@tiscali.nl writes: Commit 24a0aa212ee2 (cfg80211: make WEXT compatibility unselectable) made it impossible to depend on CFG80211_WEXT. It does still allow to select that symbol. (Yes, the commit summary is confusing.) So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be built again. I think the last sentence is a bit misleading (this isn't a compilation error, right?) and I would like to clarify it like this: So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be enabled in config again. Does that look ok? -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
