Re: [V2][linux-yocto][linux-yocto v5.10/standard/sdkv5.10/xlnx-soc][PATCH 1/2] net: xilinx: fix compile warning due to typecheck
merged.
Bruce
In message: [V2][linux-yocto][linux-yocto
v5.10/standard/sdkv5.10/xlnx-soc][PATCH 1/2] net: xilinx: fix compile warning
due to typecheck
on 29/07/2021 quanyang.w...@windriver.com wrote:
> From: Quanyang Wang
>
> This warning is introduced by the SDK commit 1b5d1c43433b3 ("net: xilinx:
> axiethernet: Add check for transmit data FIFO vacancy").
>
> Change the type of flags from "u32" to "unsigned long" to avoid the
> compile warning as below:
>
> include/linux/spinlock.h:251:3: note: in expansion of macro ‘typecheck’
> 251 | typecheck(unsigned long, flags); \
> | ^
> drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1124:3: note: in expansion
> of macro ‘spin_lock_irqsave’
> 1124 | spin_lock_irqsave(>ptp_tx_lock, flags);
> | ^
>
> Signed-off-by: Quanyang Wang
> ---
> V1 ---> V2:
> Add the info of the commit which introduces this warning.
>
> ---
> drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index 5a52872ec1430..64de359e7697d 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> @@ -1067,7 +1067,7 @@ static int axienet_create_tsheader(u8 *buf, u8 msg_type,
> #endif
> u64 val;
> u32 tmp[MRMAC_TS_HEADER_WORDS];
> - u32 flags;
> + unsigned long flags;
> int i;
>
> #ifdef CONFIG_AXIENET_HAS_MCDMA
> --
> 2.25.1
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#10210):
https://lists.yoctoproject.org/g/linux-yocto/message/10210
Mute This Topic: https://lists.yoctoproject.org/mt/84522327/21656
Group Owner: linux-yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [V2][linux-yocto][linux-yocto v5.10/standard/sdkv5.10/xlnx-soc][PATCH 1/2] net: xilinx: fix compile warning due to typecheck
On 7/29/21 6:48 AM, quanyang.w...@windriver.com wrote:
> From: Quanyang Wang
>
> This warning is introduced by the SDK commit 1b5d1c43433b3 ("net: xilinx:
> axiethernet: Add check for transmit data FIFO vacancy").
>
> Change the type of flags from "u32" to "unsigned long" to avoid the
> compile warning as below:
>
> include/linux/spinlock.h:251:3: note: in expansion of macro ‘typecheck’
> 251 | typecheck(unsigned long, flags); \
> | ^
> drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1124:3: note: in expansion
> of macro ‘spin_lock_irqsave’
> 1124 | spin_lock_irqsave(>ptp_tx_lock, flags);
> | ^
>
> Signed-off-by: Quanyang Wang
> ---
> V1 ---> V2:
> Add the info of the commit which introduces this warning.
>
> ---
> drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index 5a52872ec1430..64de359e7697d 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> @@ -1067,7 +1067,7 @@ static int axienet_create_tsheader(u8 *buf, u8 msg_type,
> #endif
> u64 val;
> u32 tmp[MRMAC_TS_HEADER_WORDS];
> - u32 flags;
> + unsigned long flags;
> int i;
>
> #ifdef CONFIG_AXIENET_HAS_MCDMA
>
This looks good. I have also added it to xilinx tree.
Thanks,
Michal
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#10209):
https://lists.yoctoproject.org/g/linux-yocto/message/10209
Mute This Topic: https://lists.yoctoproject.org/mt/84522327/21656
Group Owner: linux-yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[V2][linux-yocto][linux-yocto v5.10/standard/sdkv5.10/xlnx-soc][PATCH 1/2] net: xilinx: fix compile warning due to typecheck
From: Quanyang Wang
This warning is introduced by the SDK commit 1b5d1c43433b3 ("net: xilinx:
axiethernet: Add check for transmit data FIFO vacancy").
Change the type of flags from "u32" to "unsigned long" to avoid the
compile warning as below:
include/linux/spinlock.h:251:3: note: in expansion of macro ‘typecheck’
251 | typecheck(unsigned long, flags); \
| ^
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1124:3: note: in expansion of
macro ‘spin_lock_irqsave’
1124 | spin_lock_irqsave(>ptp_tx_lock, flags);
| ^
Signed-off-by: Quanyang Wang
---
V1 ---> V2:
Add the info of the commit which introduces this warning.
---
drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index 5a52872ec1430..64de359e7697d 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -1067,7 +1067,7 @@ static int axienet_create_tsheader(u8 *buf, u8 msg_type,
#endif
u64 val;
u32 tmp[MRMAC_TS_HEADER_WORDS];
- u32 flags;
+ unsigned long flags;
int i;
#ifdef CONFIG_AXIENET_HAS_MCDMA
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#10205):
https://lists.yoctoproject.org/g/linux-yocto/message/10205
Mute This Topic: https://lists.yoctoproject.org/mt/84522327/21656
Group Owner: linux-yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
