Re: [linux-yocto] [linux-yocto/linux-yocto-dev 4.18][PATCH] perf arm64: Fix generate system call table failed with /tmp mounted with noexec

2018-10-18 Thread Hongxu Jia 

On 2018年10月18日 21:20, Bruce Ashfield wrote:

I tried to apply this to 4.18, but the commit which creates
the issue is only in 4.19+

commit 2b5882435606c209ebc052230f03505ea477a252
Author: Kim Phillips 
Date:   Fri Jul 6 16:34:43 2018 -0500

    perf arm64: Generate system call table from asm/unistd.h


% git tag --contains 2b5882435606c209ebc052230f03505ea477a252
v4.19-rc1
v4.19-rc2
v4.19-rc3
v4.19-rc4
v4.19-rc5
v4.19-rc6
v4.19-rc7
v4.19-rc8

So I'll merge this to linux-yocto-dev, but the other linux-yocto
variants should be unaffected.



Got it, thanks for the affected check, and I've submitted the fix to 
upstream

mailing list linux-perf-us...@vger.kernel.org

//Hongxu


Bruce

On 10/18/18 5:12 AM, Hongxu Jia wrote:

Which /tmp mounted with noexec, generate system call table failed.
[snip]
|perf-1.0/tools/perf/arch/arm64/entry/syscalls//mksyscalltbl:
/tmp/create-table-6VGPSt: Permission denied
[snip]

Add variable TMPDIR as prefix dir of the temporary file, if it is set,
replace default /tmp

Fixes: 2b5882435606 ("perf arm64: Generate system call table from 
asm/unistd.h")


Signed-off-by: Hongxu Jia 
---
  tools/perf/arch/arm64/entry/syscalls/mksyscalltbl | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl 
b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl

index 2dbb8cad..c88fd32 100755
--- a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
+++ b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
@@ -23,7 +23,7 @@ create_table_from_c()
  {
  local sc nr last_sc
  -    create_table_exe=`mktemp /tmp/create-table-XX`
+    create_table_exe=`mktemp ${TMPDIR:-/tmp}/create-table-XX`
    {






--
___
linux-yocto mailing list
linux-yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto

Re: [linux-yocto] [linux-yocto/linux-yocto-dev 4.18][PATCH] perf arm64: Fix generate system call table failed with /tmp mounted with noexec

2018-10-18 Thread Bruce Ashfield 

I tried to apply this to 4.18, but the commit which creates
the issue is only in 4.19+

commit 2b5882435606c209ebc052230f03505ea477a252
Author: Kim Phillips 
Date:   Fri Jul 6 16:34:43 2018 -0500

perf arm64: Generate system call table from asm/unistd.h


% git tag --contains 2b5882435606c209ebc052230f03505ea477a252
v4.19-rc1
v4.19-rc2
v4.19-rc3
v4.19-rc4
v4.19-rc5
v4.19-rc6
v4.19-rc7
v4.19-rc8

So I'll merge this to linux-yocto-dev, but the other linux-yocto
variants should be unaffected.

Bruce

On 10/18/18 5:12 AM, Hongxu Jia wrote:

Which /tmp mounted with noexec, generate system call table failed.
[snip]
|perf-1.0/tools/perf/arch/arm64/entry/syscalls//mksyscalltbl:
/tmp/create-table-6VGPSt: Permission denied
[snip]

Add variable TMPDIR as prefix dir of the temporary file, if it is set,
replace default /tmp

Fixes: 2b5882435606 ("perf arm64: Generate system call table from asm/unistd.h")

Signed-off-by: Hongxu Jia 
---
  tools/perf/arch/arm64/entry/syscalls/mksyscalltbl | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl 
b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
index 2dbb8cad..c88fd32 100755
--- a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
+++ b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
@@ -23,7 +23,7 @@ create_table_from_c()
  {
local sc nr last_sc
  
-	create_table_exe=`mktemp /tmp/create-table-XX`

+   create_table_exe=`mktemp ${TMPDIR:-/tmp}/create-table-XX`
  
  	{
  



--
___
linux-yocto mailing list
linux-yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto

Re: [linux-yocto] [linux-yocto/linux-yocto-dev 4.18][PATCH] perf arm64: Fix generate system call table failed with /tmp mounted with noexec

2018-10-18 Thread Bruce Ashfield 

On 10/18/18 5:12 AM, Hongxu Jia wrote:

Which /tmp mounted with noexec, generate system call table failed.
[snip]
|perf-1.0/tools/perf/arch/arm64/entry/syscalls//mksyscalltbl:
/tmp/create-table-6VGPSt: Permission denied
[snip]

Add variable TMPDIR as prefix dir of the temporary file, if it is set,
replace default /tmp

Fixes: 2b5882435606 ("perf arm64: Generate system call table from asm/unistd.h")


Looks good. Have you also sent this upstream ?

Bruce



Signed-off-by: Hongxu Jia 
---
  tools/perf/arch/arm64/entry/syscalls/mksyscalltbl | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl 
b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
index 2dbb8cad..c88fd32 100755
--- a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
+++ b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
@@ -23,7 +23,7 @@ create_table_from_c()
  {
local sc nr last_sc
  
-	create_table_exe=`mktemp /tmp/create-table-XX`

+   create_table_exe=`mktemp ${TMPDIR:-/tmp}/create-table-XX`
  
  	{
  



--
___
linux-yocto mailing list
linux-yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto

[linux-yocto] [linux-yocto/linux-yocto-dev 4.18][PATCH] perf arm64: Fix generate system call table failed with /tmp mounted with noexec

2018-10-18 Thread Hongxu Jia 
Which /tmp mounted with noexec, generate system call table failed.
[snip]
|perf-1.0/tools/perf/arch/arm64/entry/syscalls//mksyscalltbl:
/tmp/create-table-6VGPSt: Permission denied
[snip]

Add variable TMPDIR as prefix dir of the temporary file, if it is set,
replace default /tmp

Fixes: 2b5882435606 ("perf arm64: Generate system call table from asm/unistd.h")

Signed-off-by: Hongxu Jia 
---
 tools/perf/arch/arm64/entry/syscalls/mksyscalltbl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl 
b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
index 2dbb8cad..c88fd32 100755
--- a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
+++ b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
@@ -23,7 +23,7 @@ create_table_from_c()
 {
local sc nr last_sc
 
-   create_table_exe=`mktemp /tmp/create-table-XX`
+   create_table_exe=`mktemp ${TMPDIR:-/tmp}/create-table-XX`
 
{
 
-- 
2.7.4

-- 
___
linux-yocto mailing list
linux-yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto