Re: [PATCH 1/3] fsl_pq_mdio: Fix compiler/sparse warnings (part 1)
From: Anton Vorontsov avoront...@ru.mvista.com Date: Thu, 5 Nov 2009 01:52:56 +0300 commit 1d2397d742b7a2b39b2f09dd9da3b9d1463f55e9 (fsl_pq_mdio: Add Suport for etsec2.0 devices) introduced the following warnings: ... Signed-off-by: Anton Vorontsov avoront...@ru.mvista.com Applied. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 2/3] fsl_pq_mdio: Fix compiler/sparse warnings (part 2)
From: Anton Vorontsov avoront...@ru.mvista.com Date: Thu, 5 Nov 2009 01:52:57 +0300 This patch fixes following warnings: fsl_pq_mdio.c:112:38: warning: cast adds address space to expression (asn:2) fsl_pq_mdio.c:124:38: warning: cast adds address space to expression (asn:2) fsl_pq_mdio.c:133:38: warning: cast adds address space to expression (asn:2) fsl_pq_mdio.c:414:11: warning: cast adds address space to expression (asn:2) Instead of adding __force all over the place, introduce convenient fsl_pq_mdio_get_regs() call that does the ugly casting just once. Signed-off-by: Anton Vorontsov avoront...@ru.mvista.com Applied. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 3/3] gianfar: Fix compiler and sparse warnings
From: Anton Vorontsov avoront...@ru.mvista.com Date: Thu, 5 Nov 2009 01:53:00 +0300 commit fba4ed030cfae7efdb6b79a57b0c5a9d72c9de83 (gianfar: Add Multiple Queue Support) introduced the following warnings: ... Signed-off-by: Anton Vorontsov avoront...@ru.mvista.com Applied. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH RFC] gianfar: Make polling safe with IRQs disabled
From: Anton Vorontsov avoront...@ru.mvista.com Date: Thu, 5 Nov 2009 01:57:11 +0300 When using KGDBoE, gianfar driver spits 'Interrupt problem' messages, which appears to be a legitimate warning, i.e. we may end up calling netif_receive_skb() or vlan_hwaccel_receive_skb() with IRQs disabled. This patch reworks the RX path so that if netpoll is enabled (the only case when the driver don't know from what context the polling may be called), we check whether IRQs are disabled, and if so we fall back to safe variants of skb receiving functions. Signed-off-by: Anton Vorontsov avoront...@ru.mvista.com This is bogus, I'll tell you why. When you go into netif_receive_skb() we have a special check, if (netpoll_receive_skb(... that takes care of all of the details concerning doing a -poll() from IRQ disabled context via netpoll. So this code you're adding should not be necessary. Or, explain to me why no other driver needs special logic in their -poll() handler like this and does not run into any kinds of netpoll problems :-) ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH RFC] gianfar: Do not call skb recycling with disabled IRQs
From: Anton Vorontsov avoront...@ru.mvista.com Date: Thu, 5 Nov 2009 19:57:38 +0300 But that basically means that with skb recycling we can't safely use KGDBoE, though we can add something like this: Please stop adding special logic only to your driver to handle these things. Either it's a non-issue, or it's going to potentially be an issue for everyone using skb_recycle_check() in a NAPI driver, right? So why not add the in_interrupt() or whatever check to skb_recycle_check() and if the context is unsuitable return false (0) ok? ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [GIT PULL] perf_event/tracing/powerpc patches from Anton Blanchard
* Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Thu, 2009-10-29 at 07:55 +0100, Ingo Molnar wrote: * Paul Mackerras pau...@samba.org wrote: Here is a series of patches from Anton Blanchard that implement some nice tracing and perf_event features on powerpc. One of them is generic perf_event stuff (adding software events for alignment faults and instruction emulation faults). Since this touches the perf_event and tracing subsystems as well as the powerpc architecture code, I think the best way forward is for both Ingo and Ben to pull it into their trees. I have based it on the most recent point in Linus' tree that Ingo had pulled into his perf branches (as of yesterday or so). The generic perf bits look good to me - can pull it if Ben OKs the PowerPC bits. Yup. Just went through all of them, they look fine. I also test built on a number of default configs and it seems to pass. Pulled into tip:perf/powerpc (will keep it in a separate branch for a few days then it can go into perf/core), thanks guys! Ingo ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Allow overriding of CC in powerpc kernel build
arch/powerpc/Makefile uses make 'override' directives to add -m32 or -m64 depending on config to the CC variable, and matching options to the AS, LD and AR variables to correctly use a biarch compiler. Unfortunately this doesn't work as intended if you actually attempt to set CC from the make command line. They correctly augment the given CC variable in the top-level make instance, but at least some of the second-level make invocations don't include arch/powerpc/Makefile, so the command line override is used directly, and we attempt to compile without the correct -m64 or similar option. This patch alters the way we set up the biarch flags so that CC can be overriden from the command line as expected (this is useful when using ccontrol as a compiler wrapper). The approach is based roughly on the way x86 handles the analagous problem for i386/x86_64 biarch compilers, with some additional hacks to make the VDSO compilation work. Signed-off-by: David Gibson da...@gibson.dropbear.id.au Index: linux-a2/arch/powerpc/Makefile === --- linux-a2.orig/arch/powerpc/Makefile 2009-11-06 14:17:15.0 +1100 +++ linux-a2/arch/powerpc/Makefile 2009-11-06 15:36:05.0 +1100 @@ -57,10 +57,10 @@ endif UTS_MACHINE := $(OLDARCH) ifeq ($(HAS_BIARCH),y) -override AS+= -a$(CONFIG_WORD_SIZE) -override LD+= -m elf$(CONFIG_WORD_SIZE)ppc -override CC+= -m$(CONFIG_WORD_SIZE) -override AR:= GNUTARGET=elf$(CONFIG_WORD_SIZE)-powerpc $(AR) + KBUILD_AFLAGS += -m$(CONFIG_WORD_SIZE) + KBUILD_CFLAGS += -m$(CONFIG_WORD_SIZE) + LDFLAGS := -m elf$(CONFIG_WORD_SIZE)ppc + override AR := GNUTARGET=elf$(CONFIG_WORD_SIZE)-powerpc $(AR) endif LDFLAGS_vmlinux-yy := -Bstatic Index: linux-a2/arch/powerpc/kernel/vdso32/Makefile === --- linux-a2.orig/arch/powerpc/kernel/vdso32/Makefile 2009-11-06 15:45:36.0 +1100 +++ linux-a2/arch/powerpc/kernel/vdso32/Makefile2009-11-06 15:47:03.0 +1100 @@ -40,10 +40,13 @@ $(obj-vdso32): %.o: %.S $(call if_changed_dep,vdso32as) # actual build commands +biarch := $(call cc-option, -m32) +c_flags_32 = $(filter-out -m64,$(c_flags)) $(biarch) +a_flags_32 = $(filter-out -m64,$(a_flags)) $(biarch) quiet_cmd_vdso32ld = VDSO32L $@ - cmd_vdso32ld = $(CROSS32CC) $(c_flags) -Wl,-T $^ -o $@ + cmd_vdso32ld = $(CROSS32CC) $(c_flags_32) -Wl,-T $^ -o $@ quiet_cmd_vdso32as = VDSO32A $@ - cmd_vdso32as = $(CROSS32CC) $(a_flags) -c -o $@ $ + cmd_vdso32as = $(CROSS32CC) $(a_flags_32) -c -o $@ $ # install commands for the unstripped file quiet_cmd_vdso_install = INSTALL $@ -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [patch 09/16] powerpc: Replace old style lock initializer
Hi Thomas, On Sat, 07 Nov 2009 09:55:44 +1100 Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Fri, 2009-11-06 at 22:41 +, Thomas Gleixner wrote: plain text document attachment (power-replace-old-style-lock-init.patch) SPIN_LOCK_UNLOCKED is deprecated. Init the lock array at runtime instead. Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: linuxppc-...@ozlabs.org --- Looks reasonable. But iseries can be a bitch, so we do need to test it on monday. Tested-by: Stephen Rothwell s...@canb.auug.org.au -- Cheers, Stephen Rothwells...@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ pgp4dFj6q57e8.pgp Description: PGP signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
