Re: [PATCH 1/2] powerpc, mpc5200: update defconfig to fit with 2.6.37-rc4
On Sat, Dec 11, 2010 at 07:13:00AM +0100, Heiko Schocher wrote: Signed-off-by: Heiko Schocher h...@denx.de I'd say the two patches can be merged. Dunno what Grant prefers whom you should CC as he is the maintainer. cc: Wolfram Sang w.s...@pengutronix.de cc: linuxppc-dev@lists.ozlabs.org --- - based against 2.6.37-rc4 - I did the following steps to generate this patch: make mpc5200_defconfig make savedefconfig cp ./defconfig arch/powerpc/configs/mpc5200_defconfig arch/powerpc/configs/mpc5200_defconfig |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/configs/mpc5200_defconfig b/arch/powerpc/configs/mpc5200_defconfig index 7376e27..6f75623 100644 --- a/arch/powerpc/configs/mpc5200_defconfig +++ b/arch/powerpc/configs/mpc5200_defconfig @@ -1,5 +1,6 @@ CONFIG_EXPERIMENTAL=y CONFIG_SYSVIPC=y +CONFIG_SPARSE_IRQ=y CONFIG_LOG_BUF_SHIFT=14 CONFIG_BLK_DEV_INITRD=y # CONFIG_CC_OPTIMIZE_FOR_SIZE is not set @@ -20,7 +21,6 @@ CONFIG_PPC_BESTCOMM=y CONFIG_SIMPLE_GPIO=y CONFIG_NO_HZ=y CONFIG_HIGH_RES_TIMERS=y -CONFIG_SPARSE_IRQ=y CONFIG_PM=y CONFIG_NET=y CONFIG_PACKET=y @@ -52,7 +52,6 @@ CONFIG_PROC_DEVICETREE=y CONFIG_BLK_DEV_LOOP=y CONFIG_BLK_DEV_RAM=y CONFIG_BLK_DEV_RAM_SIZE=32768 -CONFIG_EEPROM_AT24=y NACK. CONFIG_SCSI_TGT=y CONFIG_BLK_DEV_SD=y CONFIG_CHR_DEV_SG=y @@ -114,7 +113,6 @@ CONFIG_RTC_DRV_DS1307=y CONFIG_EXT2_FS=y CONFIG_EXT3_FS=y # CONFIG_EXT3_DEFAULTS_TO_ORDERED is not set -CONFIG_INOTIFY=y Are you sure? CONFIG_MSDOS_FS=y CONFIG_VFAT_FS=y CONFIG_PROC_KCORE=y @@ -132,5 +130,4 @@ CONFIG_PRINTK_TIME=y CONFIG_DEBUG_KERNEL=y CONFIG_DETECT_HUNG_TASK=y CONFIG_DEBUG_INFO=y -# CONFIG_RCU_CPU_STALL_DETECTOR is not set # CONFIG_CRYPTO_ANSI_CPRNG is not set -- 1.7.2.3 -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH -mm 4/4] RapidIO: Add new sysfs attributes
On Fri, Dec 10, 2010 at 03:38:18PM -0500, Alexandre Bounine wrote: Add new sysfs attributes. Like Andrew pointed out, all sysfs files are required to have entries in Documentation/ABI. If the existing rapidio sysfs files are not documented, please document them in there _before_ adding new ones. thanks, greg k-h ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: Getting the IRQ number (Was: Basic driver devel questions ?)
On Fri, 2010-12-10 at 17:21 +0100, Guillaume Dargaud wrote: Hello all, Also turn on CONFIG_DEBUG_DRIVER and see if that gives you anything interesting. I see an unset CONFIG_DEBUG_KERNEL but no CONFIG_DEBUG_DRIVER in the .config of my current kernel. Right you'd need to turn on CONFIG_DEBUG_KERNEL first, and then CONFIG_DEBUG_DRIVER will appear. Does it need to be changed in the .config with a full kernel recompilation, or can I still benefit from it in my module only by doing a #define at the begining of my code ? Some #defines like DEBUG seem to work locally on things like dev_dbg but I doubt the CONFIG_* work the same... No you'd need to rebuild your kernel. DEBUG is the only #define I can think of that has an effect locally. Using different values for a CONFIG_ in the kernel vs modules will not work. Er. Not sure sorry. I can't see anything obviously wrong. Maybe post your driver code again. Err... I ran it again this morning and it worked farther. I now get into the probe function and can now register my interrupt, yeah!, but I don't see the ISR being called. I'm currently checking if it can be a hardware problem before coming back here for more questions ! Great! BTW, is errno/strerror used within the kernel ? Nope. cheers signature.asc Description: This is a digitally signed message part ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
[PATCH] powerpc/pseries: Fix VPHN build errors on non-SMP systems
From: Jesse Larrew jlar...@linux.vnet.ibm.com
The VPHN feature is only meaningful on NUMA systems that implement
the SPLPAR option, so exclude the VPHN code on systems without
SPLPAR enabled.
This patch fixes a build problem on non-SMP systems introduced by the
following commits:
3b7a27db3b6b5501e3d1c1628e6d5a547ffe76c6
9eff1a38407c051273fe1a20f03f8155bd32de35
Signed-off-by: Jesse Larrew jlar...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/topology.h | 20 +++-
arch/powerpc/mm/numa.c |3 +++
2 files changed, 14 insertions(+), 9 deletions(-)
diff --git a/arch/powerpc/include/asm/topology.h
b/arch/powerpc/include/asm/topology.h
index aed188b..a2832b8 100644
--- a/arch/powerpc/include/asm/topology.h
+++ b/arch/powerpc/include/asm/topology.h
@@ -93,9 +93,20 @@ extern void __init dump_numa_cpu_topology(void);
extern int sysfs_add_device_to_node(struct sys_device *dev, int nid);
extern void sysfs_remove_device_from_node(struct sys_device *dev, int nid);
+#ifdef CONFIG_SPLPAR
extern int start_topology_update(void);
extern int stop_topology_update(void);
#else
+static inline int start_topology_update(void)
+{
+ return 0;
+}
+static inline int stop_topology_update(void)
+{
+ return 0;
+}
+#endif /* CONFIG_SPLPAR */
+#else
static inline void dump_numa_cpu_topology(void) {}
@@ -108,15 +119,6 @@ static inline void sysfs_remove_device_from_node(struct
sys_device *dev,
int nid)
{
}
-
-static inline int start_topology_update(void)
-{
- return 0;
-}
-static inline int stop_topology_update(void)
-{
- return 0;
-}
#endif /* CONFIG_NUMA */
#include asm-generic/topology.h
diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
index 42aa7d1..0f50941 100644
--- a/arch/powerpc/mm/numa.c
+++ b/arch/powerpc/mm/numa.c
@@ -28,6 +28,7 @@
#include asm/smp.h
#include asm/firmware.h
#include asm/paca.h
+#include asm/hvcall.h
static int numa_enabled = 1;
@@ -1263,6 +1264,7 @@ int hot_add_scn_to_nid(unsigned long scn_addr)
#endif /* CONFIG_MEMORY_HOTPLUG */
/* Vrtual Processor Home Node (VPHN) support */
+#ifdef CONFIG_SPLPAR
#define VPHN_NR_CHANGE_CTRS (8)
static u8 vphn_cpu_change_counts[NR_CPUS][VPHN_NR_CHANGE_CTRS];
static cpumask_t cpu_associativity_changes_mask;
@@ -1505,3 +1507,4 @@ int stop_topology_update(void)
vphn_enabled = 0;
return del_timer_sync(topology_timer);
}
+#endif /* CONFIG_SPLPAR */
--
1.7.2.3
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH v2 1/2] video, sm501: add OF binding to support SM501
Hello Randy, Randy Dunlap wrote: On Sat, 11 Dec 2010 07:31:15 +0100 Heiko Schocher wrote: - add commandline options: sm501.fb_mode: sm501.mode: Sorry, type, should be sm501fb.mode, thanks! Specify resolution as xresxyres[-bpp][@refresh] sm501.bpp: Here too, sm501fb.bpp Specify bit-per-pixel if not specified mode --- Documentation/kernel-parameters.txt |7 + Documentation/powerpc/dts-bindings/sm501.txt | 30 +++ drivers/mfd/sm501.c | 141 -- drivers/video/sm501fb.c | 264 +- include/linux/sm501.h|8 + 5 files changed, 299 insertions(+), 151 deletions(-) create mode 100644 Documentation/powerpc/dts-bindings/sm501.txt diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index cdd2a6e..6341541 100644 --- a/Documentation/kernel-parameters.txt +++ b/Documentation/kernel-parameters.txt @@ -2301,6 +2301,13 @@ and is between 256 and 4096 characters. It is defined in the file merging on their own. For more information see Documentation/vm/slub.txt. +sm501.bpp= SM501 Display driver: +Specify bit-per-pixel if not specified mode Specifiy bits-per-pixel if not specified by 'mode' + +sm501fb.mode= SM501 Display driver: Shouldn't that be sm501.mode ? No, the name of the source file is sm501fb.c - sm501fb is right here. As the sm501 is a multifunction device, the fb is more precise here. +Specify resolution as +xresxyres[-bpp][@refresh] + smart2= [HW] Format: io1[,io2[,...,io8]] However, I think that these shouldn't be added to Documentation/kernel-parameters.txt but should be added to the Documentation/fb/ sub-directory either by adding to Documentation/fb/modedb.txt or by adding a new file Documentation/fb/sm501.txt. Ok, do this. Thanks for the review! bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 1/2] powerpc, mpc5200: update defconfig to fit with 2.6.37-rc4
Hello Wolfram, Wolfram Sang wrote: On Sat, Dec 11, 2010 at 07:13:00AM +0100, Heiko Schocher wrote: Signed-off-by: Heiko Schocher h...@denx.de I'd say the two patches can be merged. Dunno what Grant prefers whom you should CC as he is the maintainer. I prefer the split in two patches, so we can see, what is added by the charon board, and what by make mpc5200_defconfig ... cc: Wolfram Sang w.s...@pengutronix.de cc: linuxppc-dev@lists.ozlabs.org --- - based against 2.6.37-rc4 - I did the following steps to generate this patch: make mpc5200_defconfig make savedefconfig cp ./defconfig arch/powerpc/configs/mpc5200_defconfig arch/powerpc/configs/mpc5200_defconfig |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/configs/mpc5200_defconfig b/arch/powerpc/configs/mpc5200_defconfig index 7376e27..6f75623 100644 --- a/arch/powerpc/configs/mpc5200_defconfig +++ b/arch/powerpc/configs/mpc5200_defconfig @@ -1,5 +1,6 @@ CONFIG_EXPERIMENTAL=y CONFIG_SYSVIPC=y +CONFIG_SPARSE_IRQ=y CONFIG_LOG_BUF_SHIFT=14 CONFIG_BLK_DEV_INITRD=y # CONFIG_CC_OPTIMIZE_FOR_SIZE is not set @@ -20,7 +21,6 @@ CONFIG_PPC_BESTCOMM=y CONFIG_SIMPLE_GPIO=y CONFIG_NO_HZ=y CONFIG_HIGH_RES_TIMERS=y -CONFIG_SPARSE_IRQ=y CONFIG_PM=y CONFIG_NET=y CONFIG_PACKET=y @@ -52,7 +52,6 @@ CONFIG_PROC_DEVICETREE=y CONFIG_BLK_DEV_LOOP=y CONFIG_BLK_DEV_RAM=y CONFIG_BLK_DEV_RAM_SIZE=32768 -CONFIG_EEPROM_AT24=y NACK. ... I did just the steps above mentioned, so this is automagically done by make mpc5200_defconfig ! CONFIG_SCSI_TGT=y CONFIG_BLK_DEV_SD=y CONFIG_CHR_DEV_SG=y @@ -114,7 +113,6 @@ CONFIG_RTC_DRV_DS1307=y CONFIG_EXT2_FS=y CONFIG_EXT3_FS=y # CONFIG_EXT3_DEFAULTS_TO_ORDERED is not set -CONFIG_INOTIFY=y Are you sure? See comment above, did just the make mpc5200_defconfig step ... CONFIG_MSDOS_FS=y CONFIG_VFAT_FS=y CONFIG_PROC_KCORE=y @@ -132,5 +130,4 @@ CONFIG_PRINTK_TIME=y CONFIG_DEBUG_KERNEL=y CONFIG_DETECT_HUNG_TASK=y CONFIG_DEBUG_INFO=y -# CONFIG_RCU_CPU_STALL_DETECTOR is not set # CONFIG_CRYPTO_ANSI_CPRNG is not set -- 1.7.2.3 Thanks for the review! bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
