Re: [PATCH] drivers: char: hvc: add arm JTAG DCC console support

2011-01-14 Thread Tony Lindgren
* Stephen Boyd sb...@codeaurora.org [101207 11:00]:
 On 12/01/2010 12:20 PM, Stephen Boyd wrote:
  Definitely for TX since it seems like a redundant loop, but I agree RX
  code has changed. Instead of
 
  If RX buffer full
  Poll for RX buffer full
  Read character from RX buffer
 
  we would have
 
  If RX buffer full
  Read character from RX buffer
 
  which doesn't seem all that different assuming the RX buffer doesn't go
  from full to empty between the If and Poll steps. Hopefully Tony knows more.
 
 
 Tony, any thoughts?

Sorry for the delay, looks like I'm only 1 month behind with email..
Sounds like it should work to me. I can try it out if you point me
to a patch.

Regards,

Tony
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Re: [PATCH] drivers: char: hvc: add arm JTAG DCC console support

2011-01-14 Thread Stephen Boyd
On 01/14/2011 11:19 AM, Tony Lindgren wrote:
 * Stephen Boyd sb...@codeaurora.org [101207 11:00]:
 On 12/01/2010 12:20 PM, Stephen Boyd wrote:
 Definitely for TX since it seems like a redundant loop, but I agree RX
 code has changed. Instead of

 If RX buffer full
 Poll for RX buffer full
 Read character from RX buffer

 we would have

 If RX buffer full
 Read character from RX buffer

 which doesn't seem all that different assuming the RX buffer doesn't go
 from full to empty between the If and Poll steps. Hopefully Tony knows more.


 Tony, any thoughts?

 Sorry for the delay, looks like I'm only 1 month behind with email..
 Sounds like it should work to me. I can try it out if you point me
 to a patch.

I think you acked the patches to make this change. You can test them out
by applying the hvc_dcc cleanups and fixes patches (Message-Id:
1292875718-7980-1-git-send-email-sb...@codeaurora.org) on top of this
patch. They were sent as a reply to this thread.

Stephen

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev