Re: [PATCH 10/17] hid/picolcd: Remove flag FBINFO_FLAG_DEFAULT from fbdev driver

[Benjamin Tissoires]

On Mon, Jul 10, 2023 at 3:01 PM Thomas Zimmermann  wrote:
>
> The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct
> fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do
> not set it.
>
> Flags should signal differences from the default values. After cleaning
> up all occurences of FBINFO_FLAG_DEFAULT, the token can be removed.
>
> Signed-off-by: Thomas Zimmermann 
> Cc: "Bruno Prémont" 
> Cc: Jiri Kosina 
> Cc: Benjamin Tissoires 

Acked-by: Benjamin Tissoires 

Feel free to take this through the DRI tree (or any other that handles
FB) with the rest of the series if you want.

Cheers,
Benjamin

> ---
>  drivers/hid/hid-picolcd_fb.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c
> index dabcd054dad9..d726aaafb146 100644
> --- a/drivers/hid/hid-picolcd_fb.c
> +++ b/drivers/hid/hid-picolcd_fb.c
> @@ -527,7 +527,6 @@ int picolcd_init_framebuffer(struct picolcd_data *data)
> info->var = picolcdfb_var;
> info->fix = picolcdfb_fix;
> info->fix.smem_len   = PICOLCDFB_SIZE*8;
> -   info->flags = FBINFO_FLAG_DEFAULT;
>
> fbdata = info->par;
> spin_lock_init(>lock);
> --
> 2.41.0
>

Re: [PATCH v2 4/4] bus: Make remove callback return void

[Benjamin Tissoires]

On 7/6/21 5:48 PM, Uwe Kleine-König wrote:

The driver core ignores the return value of this callback because there
is only little it can do when a device disappears.

This is the final bit of a long lasting cleanup quest where several
buses were converted to also return void from their remove callback.
Additionally some resource leaks were fixed that were caused by drivers
returning an error code in the expectation that the driver won't go
away.

With struct bus_type::remove returning void it's prevented that newly
implemented buses return an ignored error code and so don't anticipate
wrong expectations for driver authors.

Acked-by: Russell King (Oracle)  (For ARM, Amba and 
related parts)
Acked-by: Mark Brown 
Acked-by: Chen-Yu Tsai  (for drivers/bus/sunxi-rsb.c)
Acked-by: Pali Rohár 
Acked-by: Mauro Carvalho Chehab  (for drivers/media)
Acked-by: Hans de Goede  (For drivers/platform)
Acked-by: Alexandre Belloni 
Acked-By: Vinod Koul 
Acked-by: Juergen Gross  (For Xen)
Acked-by: Lee Jones  (For drivers/mfd)
Acked-by: Johannes Thumshirn  (For drivers/mcb)
Acked-by: Johan Hovold 
Acked-by: Srinivas Kandagatla  (For 
drivers/slimbus)
Acked-by: Kirti Wankhede  (For drivers/vfio)
Acked-by: Maximilian Luz 
Acked-by: Heikki Krogerus  (For ulpi and typec)
Acked-by: Samuel Iglesias Gonsálvez  (For ipack)
Reviewed-by: Tom Rix  (For fpga)
Acked-by: Geoff Levand  (For ps3)
Signed-off-by: Uwe Kleine-König 
---



[...]


  drivers/hid/hid-core.c| 4 +---
  drivers/hid/intel-ish-hid/ishtp/bus.c | 4 +---


[...]


diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 7db332139f7d..dbed2524fd47 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -2302,7 +2302,7 @@ static int hid_device_probe(struct device *dev)
return ret;
  }
  
-static int hid_device_remove(struct device *dev)

+static void hid_device_remove(struct device *dev)
  {
struct hid_device *hdev = to_hid_device(dev);
struct hid_driver *hdrv;
@@ -2322,8 +2322,6 @@ static int hid_device_remove(struct device *dev)
  
  	if (!hdev->io_started)

up(>driver_input_lock);
-
-   return 0;
  }
  
  static ssize_t modalias_show(struct device *dev, struct device_attribute *a,

diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c 
b/drivers/hid/intel-ish-hid/ishtp/bus.c
index f0802b047ed8..8a51bd9cd093 100644
--- a/drivers/hid/intel-ish-hid/ishtp/bus.c
+++ b/drivers/hid/intel-ish-hid/ishtp/bus.c
@@ -255,7 +255,7 @@ static int ishtp_cl_bus_match(struct device *dev, struct 
device_driver *drv)
   *
   * Return: Return value from driver remove() call.
   */
-static int ishtp_cl_device_remove(struct device *dev)
+static void ishtp_cl_device_remove(struct device *dev)
  {
struct ishtp_cl_device *device = to_ishtp_cl_device(dev);
struct ishtp_cl_driver *driver = to_ishtp_cl_driver(dev->driver);
@@ -267,8 +267,6 @@ static int ishtp_cl_device_remove(struct device *dev)
  
  	if (driver->remove)

driver->remove(device);
-
-   return 0;
  }
  
  /**


For the HID part:

Acked-by: Benjamin Tissoires 

Cheers,
Benjamin