file removal issue in tools/testing/selftests/powerpc/mm/tlbie_test.c

[Colin King (gmail)]

Hi,

Static analysis with cppcheck has found an issue in the following commit:

commit 047e6575aec71d75b765c22111820c4776cd1c43
Author: Aneesh Kumar K.V 
Date:   Tue Sep 24 09:22:53 2019 +0530

powerpc/mm: Fixup tlbie vs mtpidr/mtlpidr ordering issue on POWER9


The issue in tools/testing/selftests/powerpc/mm/tlbie_test.c in 
end_verification_log() is as follows:


static inline void end_verification_log(unsigned int tid, unsigned 
nr_anamolies)

{
FILE *f = fp[tid];
char logfile[30];
char path[LOGDIR_NAME_SIZE + 30];
char separator[] = "/";

fclose(f);

if (nr_anamolies == 0) {
remove(path);
return;
}
 etc


in the case where nr_anamolies is zero the remove(path) call is using an 
uninitialized path, this potentially could contain uninitialized garbage 
on the stack (and if one is unlucky enough it may be a valid filename 
that one does not want to be removed).


Not sure what the original intention was, but this code looks incorrect 
to me.


Colin

[PATCH] powerpc: Fix spelling mistake "mesages" -> "messages" in Kconfig

[Colin King]

From: Colin Ian King 

There is a spelling mistake in the Kconfig text. Fix it.

Signed-off-by: Colin Ian King 
---
 arch/powerpc/platforms/ps3/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/ps3/Kconfig 
b/arch/powerpc/platforms/ps3/Kconfig
index a4048b8c8c50..610682caabc4 100644
--- a/arch/powerpc/platforms/ps3/Kconfig
+++ b/arch/powerpc/platforms/ps3/Kconfig
@@ -90,7 +90,7 @@ config PS3_VERBOSE_RESULT
bool "PS3 Verbose LV1 hypercall results" if PS3_ADVANCED
depends on PPC_PS3
help
- Enables more verbose log mesages for LV1 hypercall results.
+ Enables more verbose log messages for LV1 hypercall results.
 
  If in doubt, say N here and reduce the size of the kernel by a
  small amount.
-- 
2.31.1

[PATCH][next] ASoC: fsl: fsl_easrc: Fix uninitialized variable st2_mem_alloc

[Colin King]

From: Colin Ian King 

A previous cleanup commit removed the ininitialization of st2_mem_alloc.
Fix this by restoring the original behaviour by initializing it to zero.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: e80382fe721f ("ASoC: fsl: fsl_easrc: remove useless assignments")
Signed-off-by: Colin Ian King 
---
 sound/soc/fsl/fsl_easrc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/fsl/fsl_easrc.c b/sound/soc/fsl/fsl_easrc.c
index 725a5d3aaa02..e823c9c13764 100644
--- a/sound/soc/fsl/fsl_easrc.c
+++ b/sound/soc/fsl/fsl_easrc.c
@@ -710,7 +710,7 @@ static int fsl_easrc_max_ch_for_slot(struct fsl_asrc_pair 
*ctx,
 struct fsl_easrc_slot *slot)
 {
struct fsl_easrc_ctx_priv *ctx_priv = ctx->private;
-   int st1_mem_alloc = 0, st2_mem_alloc;
+   int st1_mem_alloc = 0, st2_mem_alloc = 0;
int pf_mem_alloc = 0;
int max_channels = 8 - slot->num_channel;
int channels = 0;
-- 
2.30.0

[PATCH][next] scsi: ibmvfc: Fix spelling mistake "succeded" -> "succeeded"

[Colin King]

From: Colin Ian King 

There is a spelling mistake in a ibmvfc_dbg debug message. Fix it.

Signed-off-by: Colin Ian King 
---
 drivers/scsi/ibmvscsi/ibmvfc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index 1db9e04f1ad3..755313b766b9 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.c
+++ b/drivers/scsi/ibmvscsi/ibmvfc.c
@@ -4808,7 +4808,7 @@ static void ibmvfc_channel_setup_done(struct ibmvfc_event 
*evt)
 
switch (mad_status) {
case IBMVFC_MAD_SUCCESS:
-   ibmvfc_dbg(vhost, "Channel Setup succeded\n");
+   ibmvfc_dbg(vhost, "Channel Setup succeeded\n");
flags = be32_to_cpu(setup->flags);
vhost->do_enquiry = 0;
active_queues = be32_to_cpu(setup->num_scsi_subq_channels);
-- 
2.29.2

[PATCH] powerpc/44x: fix spelling mistake in Kconfig "varients" -> "variants"

[Colin King]

From: Colin Ian King 

There is a spelling mistake in the Kconfig help text. Fix it.

Signed-off-by: Colin Ian King 
---
 arch/powerpc/platforms/44x/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/44x/Kconfig 
b/arch/powerpc/platforms/44x/Kconfig
index 78ac6d67a935..71068d89fcaa 100644
--- a/arch/powerpc/platforms/44x/Kconfig
+++ b/arch/powerpc/platforms/44x/Kconfig
@@ -5,7 +5,7 @@ config PPC_47x
select MPIC
help
  This option enables support for the 47x family of processors and is
- not currently compatible with other 44x or 46x varients
+ not currently compatible with other 44x or 46x variants
 
 config BAMBOO
bool "Bamboo"
-- 
2.29.2

[PATCH] powerpc: fix spelling mistake in Kconfig "seleted" -> "selected"

[Colin King]

From: Colin Ian King 

There is a spelling mistake in the help text of the Kconfig. Fix it.

Signed-off-by: Colin Ian King 
---
 arch/powerpc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 8fb61a285c76..4010bae52351 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -87,7 +87,7 @@ config PPC_WATCHDOG
help
  This is a placeholder when the powerpc hardlockup detector
  watchdog is selected (arch/powerpc/kernel/watchdog.c). It is
- seleted via the generic lockup detector menu which is why we
+ selected via the generic lockup detector menu which is why we
  have no standalone config option for it here.
 
 config STACKTRACE_SUPPORT
-- 
2.29.2

[PATCH][V2] macintosh: windfarm: remove detatch debug containing spelling mistakes

[Colin King]

From: Colin Ian King 

There are spelling mistakes in two debug messages. As recommended
by Wolfram Sang, these can be removed as there is plenty of debug
in the driver core.

Signed-off-by: Colin Ian King 
---

V2: remove the debug rather than fixing the spelling

---
 drivers/macintosh/windfarm_lm75_sensor.c | 2 --
 drivers/macintosh/windfarm_lm87_sensor.c | 2 --
 2 files changed, 4 deletions(-)

diff --git a/drivers/macintosh/windfarm_lm75_sensor.c 
b/drivers/macintosh/windfarm_lm75_sensor.c
index 1e5fa09845e7..29f48c2028b6 100644
--- a/drivers/macintosh/windfarm_lm75_sensor.c
+++ b/drivers/macintosh/windfarm_lm75_sensor.c
@@ -152,8 +152,6 @@ static int wf_lm75_remove(struct i2c_client *client)
 {
struct wf_lm75_sensor *lm = i2c_get_clientdata(client);
 
-   DBG("wf_lm75: i2c detatch called for %s\n", lm->sens.name);
-
/* Mark client detached */
lm->i2c = NULL;
 
diff --git a/drivers/macintosh/windfarm_lm87_sensor.c 
b/drivers/macintosh/windfarm_lm87_sensor.c
index d011899c0a8a..9fab0b47cd3d 100644
--- a/drivers/macintosh/windfarm_lm87_sensor.c
+++ b/drivers/macintosh/windfarm_lm87_sensor.c
@@ -149,8 +149,6 @@ static int wf_lm87_remove(struct i2c_client *client)
 {
struct wf_lm87_sensor *lm = i2c_get_clientdata(client);
 
-   DBG("wf_lm87: i2c detatch called for %s\n", lm->sens.name);
-
/* Mark client detached */
lm->i2c = NULL;
 
-- 
2.27.0

[PATCH] usb: gadget: fix spelling mistake "Dectected" -> "Detected"

[Colin King]

From: Colin Ian King 

There is a spelling mistake in a literal string. Fix it.

Signed-off-by: Colin Ian King 
---
 drivers/usb/gadget/udc/fsl_udc_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c 
b/drivers/usb/gadget/udc/fsl_udc_core.c
index b2638e83bb49..c79407f2d577 100644
--- a/drivers/usb/gadget/udc/fsl_udc_core.c
+++ b/drivers/usb/gadget/udc/fsl_udc_core.c
@@ -2061,7 +2061,7 @@ static int fsl_proc_read(struct seq_file *m, void *v)
"Sleep Enable: %d SOF Received Enable: %d "
"Reset Enable: %d\n"
"System Error Enable: %d "
-   "Port Change Dectected Enable: %d\n"
+   "Port Change Detected Enable: %d\n"
"USB Error Intr Enable: %d USB Intr Enable: %d\n\n",
(tmp_reg & USB_INTR_DEVICE_SUSPEND) ? 1 : 0,
(tmp_reg & USB_INTR_SOF_EN) ? 1 : 0,
-- 
2.27.0

[PATCH] macintosh: windfarm: fix spelling mistake "detatch" -> "detach"

[Colin King]

From: Colin Ian King 

There are spelling mistakes in DBG messages. Fix them.

Signed-off-by: Colin Ian King 
---
 drivers/macintosh/windfarm_lm75_sensor.c | 2 +-
 drivers/macintosh/windfarm_lm87_sensor.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/macintosh/windfarm_lm75_sensor.c 
b/drivers/macintosh/windfarm_lm75_sensor.c
index 1e5fa09845e7..a88f73af4d5e 100644
--- a/drivers/macintosh/windfarm_lm75_sensor.c
+++ b/drivers/macintosh/windfarm_lm75_sensor.c
@@ -152,7 +152,7 @@ static int wf_lm75_remove(struct i2c_client *client)
 {
struct wf_lm75_sensor *lm = i2c_get_clientdata(client);
 
-   DBG("wf_lm75: i2c detatch called for %s\n", lm->sens.name);
+   DBG("wf_lm75: i2c detach called for %s\n", lm->sens.name);
 
/* Mark client detached */
lm->i2c = NULL;
diff --git a/drivers/macintosh/windfarm_lm87_sensor.c 
b/drivers/macintosh/windfarm_lm87_sensor.c
index d011899c0a8a..de8ef76a0ac8 100644
--- a/drivers/macintosh/windfarm_lm87_sensor.c
+++ b/drivers/macintosh/windfarm_lm87_sensor.c
@@ -149,7 +149,7 @@ static int wf_lm87_remove(struct i2c_client *client)
 {
struct wf_lm87_sensor *lm = i2c_get_clientdata(client);
 
-   DBG("wf_lm87: i2c detatch called for %s\n", lm->sens.name);
+   DBG("wf_lm87: i2c detach called for %s\n", lm->sens.name);
 
/* Mark client detached */
lm->i2c = NULL;
-- 
2.27.0

[PATCH] powerpc/oprofile: fix spelling mistake "contex" -> "context"

[Colin King]

From: Colin Ian King 

There is a spelling mistake in a pr_debug message. Fix it.

Signed-off-by: Colin Ian King 
---
 arch/powerpc/oprofile/cell/spu_task_sync.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/oprofile/cell/spu_task_sync.c 
b/arch/powerpc/oprofile/cell/spu_task_sync.c
index df59d0bb121f..489f993100d5 100644
--- a/arch/powerpc/oprofile/cell/spu_task_sync.c
+++ b/arch/powerpc/oprofile/cell/spu_task_sync.c
@@ -572,7 +572,7 @@ void spu_sync_buffer(int spu_num, unsigned int *samples,
 * samples are recorded.
 * No big deal -- so we just drop a few samples.
 */
-   pr_debug("SPU_PROF: No cached SPU contex "
+   pr_debug("SPU_PROF: No cached SPU context "
  "for SPU #%d. Dropping samples.\n", spu_num);
goto out;
}
-- 
2.27.0

[PATCH][next] ASoC: fsl_easrc: fix spelling mistake "prefitler" -> "prefilter"

[Colin King]

From: Colin Ian King 

There is a spelling mistake in a deb_dbg message, fix it.

Signed-off-by: Colin Ian King 
---
 sound/soc/fsl/fsl_easrc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/fsl/fsl_easrc.c b/sound/soc/fsl/fsl_easrc.c
index 233f26ff885c..97658e1f4989 100644
--- a/sound/soc/fsl/fsl_easrc.c
+++ b/sound/soc/fsl/fsl_easrc.c
@@ -1769,7 +1769,7 @@ static void fsl_easrc_dump_firmware(struct fsl_asrc 
*easrc)
}
 
dev_dbg(dev, "Firmware v%u dump:\n", firm->firmware_version);
-   dev_dbg(dev, "Num prefitler scenarios: %u\n", firm->prefil_scen);
+   dev_dbg(dev, "Num prefilter scenarios: %u\n", firm->prefil_scen);
dev_dbg(dev, "Num interpolation scenarios: %u\n", firm->interp_scen);
dev_dbg(dev, "\nInterpolation scenarios:\n");
 
-- 
2.25.1

[PATCH] soc: fsl: qe: clean up an indentation issue

[Colin King]

From: Colin Ian King 

There is a statement that not indented correctly, remove the
extraneous space.

Signed-off-by: Colin Ian King 
---
 drivers/soc/fsl/qe/ucc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/fsl/qe/ucc.c b/drivers/soc/fsl/qe/ucc.c
index d6c93970df4d..cac0fb7693a0 100644
--- a/drivers/soc/fsl/qe/ucc.c
+++ b/drivers/soc/fsl/qe/ucc.c
@@ -519,7 +519,7 @@ int ucc_set_tdm_rxtx_clk(u32 tdm_num, enum qe_clock clock,
int clock_bits;
u32 shift;
struct qe_mux __iomem *qe_mux_reg;
-__be32 __iomem *cmxs1cr;
+   __be32 __iomem *cmxs1cr;
 
qe_mux_reg = _immr->qmx;
 
-- 
2.25.1

[PATCH][next] soc: fsl: dpio: fix dereference of pointer p before null check

[Colin King]

From: Colin Ian King 

Pointer p is currently being dereferenced before it is null
checked on a memory allocation failure check. Fix this by
checking if p is null before dereferencing it.

Addresses-Coverity: ("Dereference before null check")
Fixes: 3b2abda7d28c ("soc: fsl: dpio: Replace QMAN array mode with ring mode 
enqueue")
Signed-off-by: Colin Ian King 
---
 drivers/soc/fsl/dpio/qbman-portal.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/fsl/dpio/qbman-portal.c 
b/drivers/soc/fsl/dpio/qbman-portal.c
index 740ee0d19582..d1f49caa5b13 100644
--- a/drivers/soc/fsl/dpio/qbman-portal.c
+++ b/drivers/soc/fsl/dpio/qbman-portal.c
@@ -249,10 +249,11 @@ struct qbman_swp *qbman_swp_init(const struct 
qbman_swp_desc *d)
u32 mask_size;
u32 eqcr_pi;
 
-   spin_lock_init(>access_spinlock);
-
if (!p)
return NULL;
+
+   spin_lock_init(>access_spinlock);
+
p->desc = d;
p->mc.valid_bit = QB_VALID_BIT;
p->sdq = 0;
-- 
2.25.0

[PATCH] net/wan/fsl_ucc_hdlc: fix out of bounds write on array utdm_info

[Colin King]

From: Colin Ian King 

Array utdm_info is declared as an array of MAX_HDLC_NUM (4) elements
however up to UCC_MAX_NUM (8) elements are potentially being written
to it.  Currently we have an array out-of-bounds write error on the
last 4 elements. Fix this by making utdm_info UCC_MAX_NUM elements in
size.

Addresses-Coverity: ("Out-of-bounds write")
Fixes: c19b6d246a35 ("drivers/net: support hdlc function for QE-UCC")
Signed-off-by: Colin Ian King 
---
 drivers/net/wan/fsl_ucc_hdlc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
index 94e870f48e21..9edd94679283 100644
--- a/drivers/net/wan/fsl_ucc_hdlc.c
+++ b/drivers/net/wan/fsl_ucc_hdlc.c
@@ -73,7 +73,7 @@ static struct ucc_tdm_info utdm_primary_info = {
},
 };
 
-static struct ucc_tdm_info utdm_info[MAX_HDLC_NUM];
+static struct ucc_tdm_info utdm_info[UCC_MAX_NUM];
 
 static int uhdlc_init(struct ucc_hdlc_private *priv)
 {
-- 
2.24.0

[PATCH] serial: ucc_uart: remove redundant assignment to pointer bdp

[Colin King]

From: Colin Ian King 

The variable bdp is being initialized with a value that is never
read and it is being updated later with a new value. The initialization
is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King 
---
 drivers/tty/serial/ucc_uart.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c
index afc2a5d69202..99a069ed3636 100644
--- a/drivers/tty/serial/ucc_uart.c
+++ b/drivers/tty/serial/ucc_uart.c
@@ -336,8 +336,6 @@ static int qe_uart_tx_pump(struct uart_qe_port *qe_port)
struct uart_port *port = _port->port;
struct circ_buf *xmit = >state->xmit;
 
-   bdp = qe_port->rx_cur;
-
/* Handle xon/xoff */
if (port->x_char) {
/* Pick next descriptor and fill from buffer */
-- 
2.24.0

[PATCH][next] soc: fsl: fix spelling mistake "Firmaware" -> "Firmware"

[Colin King]

From: Colin Ian King 

There is a spelling mistake in a pr_err message. Fix it.

Signed-off-by: Colin Ian King 
---
 drivers/soc/fsl/dpaa2-console.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/fsl/dpaa2-console.c b/drivers/soc/fsl/dpaa2-console.c
index 9168d8ddc932..27243f706f37 100644
--- a/drivers/soc/fsl/dpaa2-console.c
+++ b/drivers/soc/fsl/dpaa2-console.c
@@ -73,7 +73,7 @@ static u64 get_mc_fw_base_address(void)
 
mcfbaregs = ioremap(mc_base_addr.start, resource_size(_base_addr));
if (!mcfbaregs) {
-   pr_err("could not map MC Firmaware Base registers\n");
+   pr_err("could not map MC Firmware Base registers\n");
return 0;
}
 
-- 
2.20.1

[PATCH][next] KVM: PPC: Book3S HV: XIVE: fix spelling mistake "acessing" -> "accessing"

[Colin King]

From: Colin Ian King 

There is a spelling mistake in a pr_err message, fix it.

Signed-off-by: Colin Ian King 
---
 arch/powerpc/kvm/book3s_xive_native.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kvm/book3s_xive_native.c 
b/arch/powerpc/kvm/book3s_xive_native.c
index 5e14df1a4403..6a8e698c4b6e 100644
--- a/arch/powerpc/kvm/book3s_xive_native.c
+++ b/arch/powerpc/kvm/book3s_xive_native.c
@@ -235,7 +235,7 @@ static vm_fault_t xive_native_esb_fault(struct vm_fault 
*vmf)
arch_spin_unlock(>lock);
 
if (WARN_ON(!page)) {
-   pr_err("%s: acessing invalid ESB page for source %lx !\n",
+   pr_err("%s: accessing invalid ESB page for source %lx !\n",
   __func__, irq);
return VM_FAULT_SIGBUS;
}
-- 
2.20.1

[PATCH][next] powerpc/mm: fix spelling mistake "Outisde" -> "Outside"

[Colin King]

From: Colin Ian King 

There are several identical spelling mistakes in warning messages,
fix these.

Signed-off-by: Colin Ian King 
---
 arch/powerpc/mm/hash_utils_64.c  | 4 ++--
 arch/powerpc/mm/pgtable-hash64.c | 2 +-
 arch/powerpc/mm/pgtable-radix.c  | 6 +++---
 arch/powerpc/mm/pgtable_64.c | 2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c
index f727197de713..6eb89643ce58 100644
--- a/arch/powerpc/mm/hash_utils_64.c
+++ b/arch/powerpc/mm/hash_utils_64.c
@@ -784,7 +784,7 @@ int hash__create_section_mapping(unsigned long start, 
unsigned long end, int nid
int rc;
 
if (end >= H_VMALLOC_START) {
-   pr_warn("Outisde the supported range\n");
+   pr_warn("Outside the supported range\n");
return -1;
}
 
@@ -932,7 +932,7 @@ static void __init htab_initialize(void)
base, size, prot);
 
if ((base + size) >= H_VMALLOC_START) {
-   pr_warn("Outisde the supported range\n");
+   pr_warn("Outside the supported range\n");
continue;
}
 
diff --git a/arch/powerpc/mm/pgtable-hash64.c b/arch/powerpc/mm/pgtable-hash64.c
index d934de4e2b3a..097a3b3538b1 100644
--- a/arch/powerpc/mm/pgtable-hash64.c
+++ b/arch/powerpc/mm/pgtable-hash64.c
@@ -115,7 +115,7 @@ int __meminit hash__vmemmap_create_mapping(unsigned long 
start,
int rc;
 
if ((start + page_size) >= H_VMEMMAP_END) {
-   pr_warn("Outisde the supported range\n");
+   pr_warn("Outside the supported range\n");
return -1;
}
 
diff --git a/arch/powerpc/mm/pgtable-radix.c b/arch/powerpc/mm/pgtable-radix.c
index e6d5065b0bc8..fcb0169e2d32 100644
--- a/arch/powerpc/mm/pgtable-radix.c
+++ b/arch/powerpc/mm/pgtable-radix.c
@@ -341,7 +341,7 @@ void __init radix_init_pgtable(void)
 */
 
if ((reg->base + reg->size) >= RADIX_VMALLOC_START) {
-   pr_warn("Outisde the supported range\n");
+   pr_warn("Outside the supported range\n");
continue;
}
 
@@ -902,7 +902,7 @@ static void __meminit remove_pagetable(unsigned long start, 
unsigned long end)
 int __meminit radix__create_section_mapping(unsigned long start, unsigned long 
end, int nid)
 {
if (end >= RADIX_VMALLOC_START) {
-   pr_warn("Outisde the supported range\n");
+   pr_warn("Outside the supported range\n");
return -1;
}
 
@@ -934,7 +934,7 @@ int __meminit radix__vmemmap_create_mapping(unsigned long 
start,
int ret;
 
if ((start + page_size) >= RADIX_VMEMMAP_END) {
-   pr_warn("Outisde the supported range\n");
+   pr_warn("Outside the supported range\n");
return -1;
}
 
diff --git a/arch/powerpc/mm/pgtable_64.c b/arch/powerpc/mm/pgtable_64.c
index 72f58c076e26..95ad2a09501c 100644
--- a/arch/powerpc/mm/pgtable_64.c
+++ b/arch/powerpc/mm/pgtable_64.c
@@ -122,7 +122,7 @@ void __iomem *__ioremap_at(phys_addr_t pa, void *ea, 
unsigned long size, pgprot_
return NULL;
 
if ((ea + size) >= (void *)IOREMAP_END) {
-   pr_warn("Outisde the supported range\n");
+   pr_warn("Outside the supported range\n");
return NULL;
}
 
-- 
2.20.1

[PATCH][next] ASoC: fsl: fix spelling mistake: "missign" -> "missing"

[Colin King]

From: Colin Ian King 

There is a spelling mistake in a dev_err message. Fix this.

Signed-off-by: Colin Ian King 
---
 sound/soc/fsl/imx-audmix.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/fsl/imx-audmix.c b/sound/soc/fsl/imx-audmix.c
index 72e37ca6cfbb..7983bd339c01 100644
--- a/sound/soc/fsl/imx-audmix.c
+++ b/sound/soc/fsl/imx-audmix.c
@@ -161,7 +161,7 @@ static int imx_audmix_probe(struct platform_device *pdev)
}
 
if (!audmix_np) {
-   dev_err(>dev, "Missign DT node for parent device.\n");
+   dev_err(>dev, "Missing DT node for parent device.\n");
return -EINVAL;
}
 
-- 
2.20.1

[PATCH] hotplug/drc-info: ininitialize fndit to zero

[Colin King]

From: Colin Ian King 

Currently variable fndit is not initialized and contains a
garbage value, later it is set to 1 if a drc entry is found.
Ensure fndit is not containing garbage by initializing it to
zero. Also remove an extraneous space at the end of an
sprintf call.

Detected by static analysis with cppcheck.

Fixes: 2fcf3ae508c2 ("hotplug/drc-info: Add code to search ibm,drc-info 
property")
Signed-off-by: Colin Ian King 
---
 drivers/pci/hotplug/rpaphp_core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/hotplug/rpaphp_core.c 
b/drivers/pci/hotplug/rpaphp_core.c
index bcd5d357ca23..28213f44f64a 100644
--- a/drivers/pci/hotplug/rpaphp_core.c
+++ b/drivers/pci/hotplug/rpaphp_core.c
@@ -230,7 +230,7 @@ static int rpaphp_check_drc_props_v2(struct device_node 
*dn, char *drc_name,
struct of_drc_info drc;
const __be32 *value;
char cell_drc_name[MAX_DRC_NAME_LEN];
-   int j, fndit;
+   int j, fndit = 0;
 
info = of_find_property(dn->parent, "ibm,drc-info", NULL);
if (info == NULL)
@@ -254,7 +254,7 @@ static int rpaphp_check_drc_props_v2(struct device_node 
*dn, char *drc_name,
/* Found it */
 
if (fndit)
-   sprintf(cell_drc_name, "%s%d", drc.drc_name_prefix, 
+   sprintf(cell_drc_name, "%s%d", drc.drc_name_prefix,
my_index);
 
if (((drc_name == NULL) ||
-- 
2.20.1

[PATCH][next] ptp_qoriq: don't pass a large struct by value but instead pass it by reference

[Colin King]

From: Colin Ian King 

Passing the struct ptp_clock_info caps by parameter is passing over 130 bytes
of data by value on the stack. Optimize this by passing it by reference instead.
Also shinks the object code size:

Before:
   textdata bss dec hex filename
  125962160  64   1482039e4 drivers/ptp/ptp_qoriq.o

After:
   textdata bss dec hex filename
  125672160  64   1479139c7 drivers/ptp/ptp_qoriq.o

Signed-off-by: Colin Ian King 
---
 drivers/net/ethernet/freescale/enetc/enetc_ptp.c | 2 +-
 drivers/ptp/ptp_qoriq.c  | 6 +++---
 include/linux/fsl/ptp_qoriq.h| 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/freescale/enetc/enetc_ptp.c 
b/drivers/net/ethernet/freescale/enetc/enetc_ptp.c
index dc2f58a7c9e5..8c1497e7d9c5 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc_ptp.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc_ptp.c
@@ -92,7 +92,7 @@ static int enetc_ptp_probe(struct pci_dev *pdev,
 
ptp_qoriq->dev = >dev;
 
-   err = ptp_qoriq_init(ptp_qoriq, base, enetc_ptp_caps);
+   err = ptp_qoriq_init(ptp_qoriq, base, _ptp_caps);
if (err)
goto err_no_clock;
 
diff --git a/drivers/ptp/ptp_qoriq.c b/drivers/ptp/ptp_qoriq.c
index 42d3654f77f0..53775362aac6 100644
--- a/drivers/ptp/ptp_qoriq.c
+++ b/drivers/ptp/ptp_qoriq.c
@@ -459,7 +459,7 @@ static int ptp_qoriq_auto_config(struct ptp_qoriq 
*ptp_qoriq,
 }
 
 int ptp_qoriq_init(struct ptp_qoriq *ptp_qoriq, void __iomem *base,
-  const struct ptp_clock_info caps)
+  const struct ptp_clock_info *caps)
 {
struct device_node *node = ptp_qoriq->dev->of_node;
struct ptp_qoriq_registers *regs;
@@ -468,7 +468,7 @@ int ptp_qoriq_init(struct ptp_qoriq *ptp_qoriq, void 
__iomem *base,
u32 tmr_ctrl;
 
ptp_qoriq->base = base;
-   ptp_qoriq->caps = caps;
+   ptp_qoriq->caps = *caps;
 
if (of_property_read_u32(node, "fsl,cksel", _qoriq->cksel))
ptp_qoriq->cksel = DEFAULT_CKSEL;
@@ -605,7 +605,7 @@ static int ptp_qoriq_probe(struct platform_device *dev)
goto no_ioremap;
}
 
-   err = ptp_qoriq_init(ptp_qoriq, base, ptp_qoriq_caps);
+   err = ptp_qoriq_init(ptp_qoriq, base, _qoriq_caps);
if (err)
goto no_clock;
 
diff --git a/include/linux/fsl/ptp_qoriq.h b/include/linux/fsl/ptp_qoriq.h
index f127adb71041..992bf9fa1729 100644
--- a/include/linux/fsl/ptp_qoriq.h
+++ b/include/linux/fsl/ptp_qoriq.h
@@ -183,7 +183,7 @@ static inline void qoriq_write_le(unsigned __iomem *addr, 
u32 val)
 
 irqreturn_t ptp_qoriq_isr(int irq, void *priv);
 int ptp_qoriq_init(struct ptp_qoriq *ptp_qoriq, void __iomem *base,
-  const struct ptp_clock_info caps);
+  const struct ptp_clock_info *caps);
 void ptp_qoriq_free(struct ptp_qoriq *ptp_qoriq);
 int ptp_qoriq_adjfine(struct ptp_clock_info *ptp, long scaled_ppm);
 int ptp_qoriq_adjtime(struct ptp_clock_info *ptp, s64 delta);
-- 
2.20.1

[PATCH][next] soc: fsl: dpio: fix memory leak of a struct qbman on error exit path

[Colin King]

From: Colin Ian King 

Currently the error check for a null reg leaks a struct qbman
that was allocated earlier. Fix this by kfree'ing p on the error exit
path.

Signed-off-by: Colin Ian King 
---
 drivers/soc/fsl/dpio/qbman-portal.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/fsl/dpio/qbman-portal.c 
b/drivers/soc/fsl/dpio/qbman-portal.c
index 0bddb85c0ae5..5a73397ae79e 100644
--- a/drivers/soc/fsl/dpio/qbman-portal.c
+++ b/drivers/soc/fsl/dpio/qbman-portal.c
@@ -180,6 +180,7 @@ struct qbman_swp *qbman_swp_init(const struct 
qbman_swp_desc *d)
reg = qbman_read_register(p, QBMAN_CINH_SWP_CFG);
if (!reg) {
pr_err("qbman: the portal is not enabled!\n");
+   kfree(p);
return NULL;
}
 
-- 
2.20.1

[PATCH] Documentation: fix spelling mistake, EACCESS -> EACCES

[Colin King]

From: Colin Ian King 

Trivial fix to a spelling mistake of the error access name EACCESS,
rename to EACCES

Signed-off-by: Colin Ian King 
---
 Documentation/filesystems/spufs.txt | 2 +-
 Documentation/gpu/drm-uapi.rst  | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/filesystems/spufs.txt 
b/Documentation/filesystems/spufs.txt
index 1343d118a9b2..eb9e3aa63026 100644
--- a/Documentation/filesystems/spufs.txt
+++ b/Documentation/filesystems/spufs.txt
@@ -452,7 +452,7 @@ RETURN VALUE
 
 
 ERRORS
-   EACCESS
+   EACCES
   The  current  user does not have write access on the spufs mount
   point.
 
diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uapi.rst
index a2214cc1f821..f2f079e91b4c 100644
--- a/Documentation/gpu/drm-uapi.rst
+++ b/Documentation/gpu/drm-uapi.rst
@@ -190,11 +190,11 @@ ENOSPC:
 
 Simply running out of kernel/system memory is signalled through ENOMEM.
 
-EPERM/EACCESS:
+EPERM/EACCES:
 Returned for an operation that is valid, but needs more privileges.
 E.g. root-only or much more common, DRM master-only operations return
 this when when called by unpriviledged clients. There's no clear
-difference between EACCESS and EPERM.
+difference between EACCES and EPERM.
 
 ENODEV:
 Feature (like PRIME, modesetting, GEM) is not supported by the driver.
-- 
2.19.1

[PATCH] fsl: remove redundant pointer 'priv'

[Colin King]

From: Colin Ian King 

Pointer 'priv' is being assigned but is never used hence it is
redundant and can be removed.

Cleans up clang warning:
variable 'priv' set but not used [-Wunused-but-set-variable]

Signed-off-by: Colin Ian King 
---
 drivers/soc/fsl/dpio/dpio-driver.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/soc/fsl/dpio/dpio-driver.c 
b/drivers/soc/fsl/dpio/dpio-driver.c
index b60b77bfaffa..e58fcc9096e8 100644
--- a/drivers/soc/fsl/dpio/dpio-driver.c
+++ b/drivers/soc/fsl/dpio/dpio-driver.c
@@ -50,13 +50,10 @@ static void unregister_dpio_irq_handlers(struct 
fsl_mc_device *dpio_dev)
 
 static int register_dpio_irq_handlers(struct fsl_mc_device *dpio_dev, int cpu)
 {
-   struct dpio_priv *priv;
int error;
struct fsl_mc_device_irq *irq;
cpumask_t mask;
 
-   priv = dev_get_drvdata(_dev->dev);
-
irq = dpio_dev->irqs[0];
error = devm_request_irq(_dev->dev,
 irq->msi_desc->irq,
-- 
2.17.1

[PATCH] powerpc/powermac: fix spelling mistake "Usupported" -> "Unsupported"

[Colin King]

From: Colin Ian King 

Trivial fix to spelling mistake in bootx_printf message text.

Signed-off-by: Colin Ian King 
---
 arch/powerpc/platforms/powermac/bootx_init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/powermac/bootx_init.c 
b/arch/powerpc/platforms/powermac/bootx_init.c
index ba0964c17620..3b3b0b9b3577 100644
--- a/arch/powerpc/platforms/powermac/bootx_init.c
+++ b/arch/powerpc/platforms/powermac/bootx_init.c
@@ -519,7 +519,7 @@ void __init bootx_init(unsigned long r3, unsigned long r4)
;
}
if (bi->architecture != BOOT_ARCH_PCI) {
-   bootx_printf(" !!! WARNING - Usupported machine"
+   bootx_printf(" !!! WARNING - Unsupported machine"
 " architecture !\n");
for (;;)
;
-- 
2.17.0

[PATCH] powerpc-opal: fix spelling mistake "Uniterrupted" -> "Uninterrupted"

[Colin King]

From: Colin Ian King 

Trivial fix to spelling mistake in hmi_error_types text

Signed-off-by: Colin Ian King 
---
 arch/powerpc/platforms/powernv/opal-hmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/powernv/opal-hmi.c 
b/arch/powerpc/platforms/powernv/opal-hmi.c
index 4efc95b4c7d4..586ec71a4e17 100644
--- a/arch/powerpc/platforms/powernv/opal-hmi.c
+++ b/arch/powerpc/platforms/powernv/opal-hmi.c
@@ -177,7 +177,7 @@ static void print_hmi_event_info(struct OpalHMIEvent 
*hmi_evt)
"Processor recovery occurred for masked error",
"Timer facility experienced an error",
"TFMR SPR is corrupted",
-   "UPS (Uniterrupted Power System) Overflow indication",
+   "UPS (Uninterrupted Power System) Overflow indication",
"An XSCOM operation failure",
"An XSCOM operation completed",
"SCOM has set a reserved FIR bit to cause recovery",
-- 
2.17.0

[PATCH] powerpc: fix spelling mistake: "Discharching" -> "Discharging"

[Colin King]

From: Colin Ian King 

Trivial fix to spelling mistake in battery_charging array

Signed-off-by: Colin Ian King 
---
 arch/powerpc/kernel/rtas-proc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kernel/rtas-proc.c b/arch/powerpc/kernel/rtas-proc.c
index d49063d0baa4..ed0ed0c9b7b3 100644
--- a/arch/powerpc/kernel/rtas-proc.c
+++ b/arch/powerpc/kernel/rtas-proc.c
@@ -504,7 +504,7 @@ static void ppc_rtas_process_sensor(struct seq_file *m,
"EPOW power off" };
const char * battery_cyclestate[]  = { "None", "In progress", 
"Requested" };
-   const char * battery_charging[]= { "Charging", "Discharching", 
+   const char * battery_charging[]= { "Charging", "Discharging",
"No current flow" };
const char * ibm_drconnector[] = { "Empty", "Present", "Unusable", 
"Exchange" };
-- 
2.17.0

[PATCH] macintosh/windfarm: fix spelling mistake: "ttarged" -> "ttarget"

[Colin King]

From: Colin Ian King 

Trivial fix to spelling mistake in debug messages of a structure
field name

Signed-off-by: Colin Ian King 
---
 drivers/macintosh/windfarm_pm121.c | 2 +-
 drivers/macintosh/windfarm_pm81.c  | 2 +-
 drivers/macintosh/windfarm_pm91.c  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/macintosh/windfarm_pm121.c 
b/drivers/macintosh/windfarm_pm121.c
index 4d72d8f58cb6..97634e030991 100644
--- a/drivers/macintosh/windfarm_pm121.c
+++ b/drivers/macintosh/windfarm_pm121.c
@@ -710,7 +710,7 @@ static void pm121_create_cpu_fans(void)
wf_cpu_pid_init(_cpu_state->pid, _param);
 
pr_debug("pm121: CPU Fan control initialized.\n");
-   pr_debug("   ttarged=%d.%03d, tmax=%d.%03d, min=%d RPM, max=%d 
RPM,\n",
+   pr_debug("   ttarget=%d.%03d, tmax=%d.%03d, min=%d RPM, max=%d 
RPM,\n",
 FIX32TOPRINT(pid_param.ttarget), FIX32TOPRINT(pid_param.tmax),
 pid_param.min, pid_param.max);
 
diff --git a/drivers/macintosh/windfarm_pm81.c 
b/drivers/macintosh/windfarm_pm81.c
index d9ea45581b9e..346c9172 100644
--- a/drivers/macintosh/windfarm_pm81.c
+++ b/drivers/macintosh/windfarm_pm81.c
@@ -455,7 +455,7 @@ static void wf_smu_create_cpu_fans(void)
wf_cpu_pid_init(_smu_cpu_fans->pid, _param);
 
DBG("wf: CPU Fan control initialized.\n");
-   DBG("ttarged=%d.%03d, tmax=%d.%03d, min=%d RPM, max=%d RPM\n",
+   DBG("ttarget=%d.%03d, tmax=%d.%03d, min=%d RPM, max=%d RPM\n",
FIX32TOPRINT(pid_param.ttarget), FIX32TOPRINT(pid_param.tmax),
pid_param.min, pid_param.max);
 
diff --git a/drivers/macintosh/windfarm_pm91.c 
b/drivers/macintosh/windfarm_pm91.c
index 7fd73dcb2b0a..a8a47c62a74b 100644
--- a/drivers/macintosh/windfarm_pm91.c
+++ b/drivers/macintosh/windfarm_pm91.c
@@ -200,7 +200,7 @@ static void wf_smu_create_cpu_fans(void)
wf_cpu_pid_init(_smu_cpu_fans->pid, _param);
 
DBG("wf: CPU Fan control initialized.\n");
-   DBG("ttarged=%d.%03d, tmax=%d.%03d, min=%d RPM, max=%d RPM\n",
+   DBG("ttarget=%d.%03d, tmax=%d.%03d, min=%d RPM, max=%d RPM\n",
FIX32TOPRINT(pid_param.ttarget), FIX32TOPRINT(pid_param.tmax),
pid_param.min, pid_param.max);
 
-- 
2.17.0

[PATCH] crypto: nx: fix spelling mistake: "seqeunce" -> "sequence"

[Colin King]

From: Colin Ian King 

Trivial fix to spelling mistake in CSB_ERR error message text

Signed-off-by: Colin Ian King 
---
 drivers/crypto/nx/nx-842-powernv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/nx/nx-842-powernv.c 
b/drivers/crypto/nx/nx-842-powernv.c
index 1e87637c412d..36afd6d8753c 100644
--- a/drivers/crypto/nx/nx-842-powernv.c
+++ b/drivers/crypto/nx/nx-842-powernv.c
@@ -334,7 +334,7 @@ static int wait_for_csb(struct nx842_workmem *wmem,
return -EPROTO;
case CSB_CC_SEQUENCE:
/* should not happen, we don't use chained CRBs */
-   CSB_ERR(csb, "CRB seqeunce number error");
+   CSB_ERR(csb, "CRB sequence number error");
return -EPROTO;
case CSB_CC_UNKNOWN_CODE:
CSB_ERR(csb, "Unknown subfunction code");
-- 
2.17.0

[PATCH] net: ethernet: ucc: fix spelling mistake: "tx-late-collsion" -> "tx-late-collision"

[Colin King]

From: Colin Ian King 

Trivial fix to spelling mistake in tx_fw_stat_gstrings text

Signed-off-by: Colin Ian King 
---
 drivers/net/ethernet/freescale/ucc_geth_ethtool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/ucc_geth_ethtool.c 
b/drivers/net/ethernet/freescale/ucc_geth_ethtool.c
index 4df282ed22c7..0beee2cc2ddd 100644
--- a/drivers/net/ethernet/freescale/ucc_geth_ethtool.c
+++ b/drivers/net/ethernet/freescale/ucc_geth_ethtool.c
@@ -61,7 +61,7 @@ static const char hw_stat_gstrings[][ETH_GSTRING_LEN] = {
 static const char tx_fw_stat_gstrings[][ETH_GSTRING_LEN] = {
"tx-single-collision",
"tx-multiple-collision",
-   "tx-late-collsion",
+   "tx-late-collision",
"tx-aborted-frames",
"tx-lost-frames",
"tx-carrier-sense-errors",
-- 
2.17.0

[PATCH] powerpc: fix spelling mistake: "Usupported" -> "Unsupported"

[Colin King]

From: Colin Ian King 

Trivial fix to spelling mistake in bootx_printf message text

Signed-off-by: Colin Ian King 
---
 arch/powerpc/platforms/powermac/bootx_init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/powermac/bootx_init.c 
b/arch/powerpc/platforms/powermac/bootx_init.c
index c3c9bbb3573a..ca60f3ef7ef6 100644
--- a/arch/powerpc/platforms/powermac/bootx_init.c
+++ b/arch/powerpc/platforms/powermac/bootx_init.c
@@ -519,7 +519,7 @@ void __init bootx_init(unsigned long r3, unsigned long r4)
;
}
if (bi->architecture != BOOT_ARCH_PCI) {
-   bootx_printf(" !!! WARNING - Usupported machine"
+   bootx_printf(" !!! WARNING - Unsupported machine"
 " architecture !\n");
for (;;)
;
-- 
2.15.1

[PATCH] ocxl: fix signed comparison with less than zero

[Colin King]

From: Colin Ian King 

Currently the comparison of used < 0 is always false because
uses is a size_t. Fix this by making used a ssize_t type.

Detected by Coccinelle:
drivers/misc/ocxl/file.c:320:6-10: WARNING: Unsigned expression
compared with zero: used < 0

Fixes: 5ef3166e8a32 ("ocxl: Driver code for 'generic' opencapi devices")
Signed-off-by: Colin Ian King 
---
 drivers/misc/ocxl/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c
index c90c1a578d2f..1287e4430e6b 100644
--- a/drivers/misc/ocxl/file.c
+++ b/drivers/misc/ocxl/file.c
@@ -277,7 +277,7 @@ static ssize_t afu_read(struct file *file, char __user 
*buf, size_t count,
struct ocxl_context *ctx = file->private_data;
struct ocxl_kernel_event_header header;
ssize_t rc;
-   size_t used = 0;
+   ssize_t used = 0;
DEFINE_WAIT(event_wait);
 
memset(, 0, sizeof(header));
-- 
2.15.1

[PATCH] powerpc/xmon: use ARRAY_SIZE on various array sizing calculations

[Colin King]

From: Colin Ian King 

Use the ARRAY_SIZE macro on several arrays to determine their size.
Improvement suggested by coccinelle.

Signed-off-by: Colin Ian King 
---
 arch/powerpc/xmon/ppc-opc.c | 12 
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/arch/powerpc/xmon/ppc-opc.c b/arch/powerpc/xmon/ppc-opc.c
index ac2b55b1332e..f3f57a12d43b 100644
--- a/arch/powerpc/xmon/ppc-opc.c
+++ b/arch/powerpc/xmon/ppc-opc.c
@@ -966,8 +966,7 @@ const struct powerpc_operand powerpc_operands[] =
   { 0xff, 11, NULL, NULL, PPC_OPERAND_SIGNOPT },
 };
 
-const unsigned int num_powerpc_operands = (sizeof (powerpc_operands)
-  / sizeof (powerpc_operands[0]));
+const unsigned int num_powerpc_operands = ARRAY_SIZE(powerpc_operands);
 
 /* The functions used to insert and extract complicated operands.  */
 
@@ -6980,8 +6979,7 @@ const struct powerpc_opcode powerpc_opcodes[] = {
 {"fcfidu.",XRC(63,974,1),  XRA_MASK, POWER7|PPCA2, PPCVLE, {FRT, 
FRB}},
 };
 
-const int powerpc_num_opcodes =
-  sizeof (powerpc_opcodes) / sizeof (powerpc_opcodes[0]);
+const int powerpc_num_opcodes = ARRAY_SIZE(powerpc_opcodes);
 
 /* The VLE opcode table.
 
@@ -7219,8 +7217,7 @@ const struct powerpc_opcode vle_opcodes[] = {
 {"se_bl",  BD8(58,0,1),BD8_MASK,   PPCVLE, 0,  {B8}},
 };
 
-const int vle_num_opcodes =
-  sizeof (vle_opcodes) / sizeof (vle_opcodes[0]);
+const int vle_num_opcodes = ARRAY_SIZE(vle_opcodes);
 
 /* The macro table.  This is only used by the assembler.  */
 
@@ -7288,5 +7285,4 @@ const struct powerpc_macro powerpc_macros[] = {
 {"e_clrlslwi",4, PPCVLE, "e_rlwinm %0,%1,%3,(%2)-(%3),31-(%3)"},
 };
 
-const int powerpc_num_macros =
-  sizeof (powerpc_macros) / sizeof (powerpc_macros[0]);
+const int powerpc_num_macros = ARRAY_SIZE(powerpc_macros);
-- 
2.14.1

[PATCH] USB: gadget: udc: fix spelling mistake "unexpect" -> "unexpected"

[Colin King]

From: Colin Ian King 

Trival fix to spelling mistake in ERR message

Signed-off-by: Colin Ian King 
---
 drivers/usb/gadget/udc/fsl_udc_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c 
b/drivers/usb/gadget/udc/fsl_udc_core.c
index d606d4f13098..e5b4ee96c4bf 100644
--- a/drivers/usb/gadget/udc/fsl_udc_core.c
+++ b/drivers/usb/gadget/udc/fsl_udc_core.c
@@ -1543,7 +1543,7 @@ static void ep0_req_complete(struct fsl_udc *udc, struct 
fsl_ep *ep0,
udc->ep0_state = WAIT_FOR_SETUP;
break;
case WAIT_FOR_SETUP:
-   ERR("Unexpect ep0 packets\n");
+   ERR("Unexpected ep0 packets\n");
break;
default:
ep0stall(udc);
-- 
2.14.1

[PATCH][V2] crypto/nx: fix spelling mistake: "availavle" -> "available"

[Colin King]

From: Colin Ian King 

Trivial fix to spelling mistake in pr_err error message text. Also
fix spelling mistake in proceeding comment.

Signed-off-by: Colin Ian King 
---
 drivers/crypto/nx/nx-842-powernv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/nx/nx-842-powernv.c 
b/drivers/crypto/nx/nx-842-powernv.c
index f2246a5abcf6..1e87637c412d 100644
--- a/drivers/crypto/nx/nx-842-powernv.c
+++ b/drivers/crypto/nx/nx-842-powernv.c
@@ -743,8 +743,8 @@ static int nx842_open_percpu_txwins(void)
}
 
if (!per_cpu(cpu_txwin, i)) {
-   /* shoudn't happen, Each chip will have NX engine */
-   pr_err("NX engine is not availavle for CPU %d\n", i);
+   /* shouldn't happen, Each chip will have NX engine */
+   pr_err("NX engine is not available for CPU %d\n", i);
return -EINVAL;
}
}
-- 
2.14.1

[PATCH] crypto/nx: fix spelling mistake: "availavle" -> "available"

[Colin King]

From: Colin Ian King 

Trivial fix to spelling mistake in pr_err error message text

Signed-off-by: Colin Ian King 
---
 drivers/crypto/nx/nx-842-powernv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/nx/nx-842-powernv.c 
b/drivers/crypto/nx/nx-842-powernv.c
index f2246a5abcf6..9c01d11f255a 100644
--- a/drivers/crypto/nx/nx-842-powernv.c
+++ b/drivers/crypto/nx/nx-842-powernv.c
@@ -744,7 +744,7 @@ static int nx842_open_percpu_txwins(void)
 
if (!per_cpu(cpu_txwin, i)) {
/* shoudn't happen, Each chip will have NX engine */
-   pr_err("NX engine is not availavle for CPU %d\n", i);
+   pr_err("NX engine is not available for CPU %d\n", i);
return -EINVAL;
}
}
-- 
2.14.1

[PATCH] ASoC: fsl_spdif: make const arrays rate static

[Colin King]

From: Colin Ian King 

Don't populate the const arrays rate on the stack, instead make them
static. Makes the object code smaller by 220 bytes:

Before:
   textdata bss dec hex filename
  243859776 128   3428985f1 sound/soc/fsl/fsl_spdif.o

After:
   textdata bss dec hex filename
  240059936 128   340698515 sound/soc/fsl/fsl_spdif.o

Signed-off-by: Colin Ian King 
---
 sound/soc/fsl/fsl_spdif.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
index 7e6cc4da0088..4f7469c1864c 100644
--- a/sound/soc/fsl/fsl_spdif.c
+++ b/sound/soc/fsl/fsl_spdif.c
@@ -1110,7 +1110,7 @@ static u32 fsl_spdif_txclk_caldiv(struct fsl_spdif_priv 
*spdif_priv,
struct clk *clk, u64 savesub,
enum spdif_txrate index, bool round)
 {
-   const u32 rate[] = { 32000, 44100, 48000, 96000, 192000 };
+   static const u32 rate[] = { 32000, 44100, 48000, 96000, 192000 };
bool is_sysclk = clk_is_match(clk, spdif_priv->sysclk);
u64 rate_ideal, rate_actual, sub;
u32 sysclk_dfmin, sysclk_dfmax;
@@ -1169,7 +1169,7 @@ static u32 fsl_spdif_txclk_caldiv(struct fsl_spdif_priv 
*spdif_priv,
 static int fsl_spdif_probe_txclk(struct fsl_spdif_priv *spdif_priv,
enum spdif_txrate index)
 {
-   const u32 rate[] = { 32000, 44100, 48000, 96000, 192000 };
+   static const u32 rate[] = { 32000, 44100, 48000, 96000, 192000 };
struct platform_device *pdev = spdif_priv->pdev;
struct device *dev = >dev;
u64 savesub = 10, ret;
-- 
2.14.1

[PATCH] powerpc/pseries: fix spelling mistake: "Attemping" -> "Attempting"

[Colin King]

From: Colin Ian King 

Trivial fix to spelling mistake in pr_debug message

Signed-off-by: Colin Ian King 
---
 arch/powerpc/platforms/pseries/hotplug-cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c 
b/arch/powerpc/platforms/pseries/hotplug-cpu.c
index 7bc0e91f8715..6afd1efd3633 100644
--- a/arch/powerpc/platforms/pseries/hotplug-cpu.c
+++ b/arch/powerpc/platforms/pseries/hotplug-cpu.c
@@ -554,7 +554,7 @@ static ssize_t dlpar_cpu_remove(struct device_node *dn, u32 
drc_index)
 {
int rc;
 
-   pr_debug("Attemping to remove CPU %s, drc index: %x\n",
+   pr_debug("Attempting to remove CPU %s, drc index: %x\n",
 dn->name, drc_index);
 
rc = dlpar_offline_cpu(dn);
-- 
2.11.0

[PATCH] fsl_udc_core: fix spelling mistake: "Dectected" -> "Detected"

[Colin King]

From: Colin Ian King 

Trivial fix to spelling mistake in seq_printf text

Signed-off-by: Colin Ian King 
---
 drivers/usb/gadget/udc/fsl_udc_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c 
b/drivers/usb/gadget/udc/fsl_udc_core.c
index 6f2f71c054be..63ab3d50f3f6 100644
--- a/drivers/usb/gadget/udc/fsl_udc_core.c
+++ b/drivers/usb/gadget/udc/fsl_udc_core.c
@@ -2067,7 +2067,7 @@ static int fsl_proc_read(struct seq_file *m, void *v)
"Sleep Enable: %d SOF Received Enable: %d "
"Reset Enable: %d\n"
"System Error Enable: %d "
-   "Port Change Dectected Enable: %d\n"
+   "Port Change Detected Enable: %d\n"
"USB Error Intr Enable: %d USB Intr Enable: %d\n\n",
(tmp_reg & USB_INTR_DEVICE_SUSPEND) ? 1 : 0,
(tmp_reg & USB_INTR_SOF_EN) ? 1 : 0,
-- 
2.11.0

[PATCH] drivers/tty/hvc: fix spelling mistake: "missmanaged" -> "mismanaged"

[Colin King]

From: Colin Ian King 

Trivial fix to spelling mistake in printk message

Signed-off-by: Colin Ian King 
---
 drivers/tty/hvc/hvcs.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/tty/hvc/hvcs.c b/drivers/tty/hvc/hvcs.c
index 7823d6d998cf..2113c64d565d 100644
--- a/drivers/tty/hvc/hvcs.c
+++ b/drivers/tty/hvc/hvcs.c
@@ -1242,8 +1242,7 @@ static void hvcs_close(struct tty_struct *tty, struct 
file *filp)
free_irq(irq, hvcsd);
return;
} else if (hvcsd->port.count < 0) {
-   printk(KERN_ERR "HVCS: vty-server@%X open_count: %d"
-   " is missmanaged.\n",
+   printk(KERN_ERR "HVCS: vty-server@%X open_count: %d is 
mismanaged.\n",
hvcsd->vdev->unit_address, hvcsd->port.count);
}
 
-- 
2.11.0

[PATCH] powerpc/xive: fix spelling mistake: "initialize"

[Colin King]

From: Colin Ian King 

Trivial fix to spelling mistake in pr_info message.

Signed-off-by: Colin Ian King 
---
 arch/powerpc/sysdev/xive/common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/sysdev/xive/common.c 
b/arch/powerpc/sysdev/xive/common.c
index d9cd7f705f21..480364c1293c 100644
--- a/arch/powerpc/sysdev/xive/common.c
+++ b/arch/powerpc/sysdev/xive/common.c
@@ -1287,7 +1287,7 @@ bool xive_core_init(const struct xive_ops *ops, void 
__iomem *area, u32 offset,
/* Get ready for interrupts */
xive_setup_cpu();
 
-   pr_info("Interrupt handling intialized with %s backend\n",
+   pr_info("Interrupt handling initialized with %s backend\n",
xive_ops->name);
pr_info("Using priority %d for all interrupts\n", max_prio);
 
-- 
2.11.0

[PATCH] ps3_gelic: fix spelling mistake in debug message

[Colin King]

From: Colin Ian King 

Trivial fix to spelling mistake "unmached" to "unmatched" in
debug message.

Signed-off-by: Colin Ian King 
---
 drivers/net/ethernet/toshiba/ps3_gelic_wireless.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c 
b/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c
index b3abd02..eed18f8 100644
--- a/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c
+++ b/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c
@@ -1694,7 +1694,7 @@ struct gelic_wl_scan_info *gelic_wl_find_best_bss(struct 
gelic_wl_info *wl)
pr_debug("%s: bssid matched\n", __func__);
break;
} else {
-   pr_debug("%s: bssid unmached\n", __func__);
+   pr_debug("%s: bssid unmatched\n", __func__);
continue;
}
}
-- 
2.10.2

[PATCH] soc/fsl: fix spelling mistakes in critical error messages

[Colin King]

From: Colin Ian King 

Trivial fix to spelling mistake "uncommited" to "uncommitted" in
critical error messages.

Signed-off-by: Colin Ian King 
---
 drivers/soc/fsl/qbman/bman.c | 2 +-
 drivers/soc/fsl/qbman/qman.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/fsl/qbman/bman.c b/drivers/soc/fsl/qbman/bman.c
index ffa48fd..48b7eb6 100644
--- a/drivers/soc/fsl/qbman/bman.c
+++ b/drivers/soc/fsl/qbman/bman.c
@@ -391,7 +391,7 @@ static void bm_rcr_finish(struct bm_portal *portal)
 
i = bm_in(portal, BM_REG_RCR_PI_CINH) & (BM_RCR_SIZE - 1);
if (i != rcr_ptr2idx(rcr->cursor))
-   pr_crit("losing uncommited RCR entries\n");
+   pr_crit("losing uncommitted RCR entries\n");
 
i = bm_in(portal, BM_REG_RCR_CI_CINH) & (BM_RCR_SIZE - 1);
if (i != rcr->ci)
diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c
index 119054b..deeacd5 100644
--- a/drivers/soc/fsl/qbman/qman.c
+++ b/drivers/soc/fsl/qbman/qman.c
@@ -443,7 +443,7 @@ static inline void qm_eqcr_finish(struct qm_portal *portal)
 
DPAA_ASSERT(!eqcr->busy);
if (pi != eqcr_ptr2idx(eqcr->cursor))
-   pr_crit("losing uncommited EQCR entries\n");
+   pr_crit("losing uncommitted EQCR entries\n");
if (ci != eqcr->ci)
pr_crit("missing existing EQCR completions\n");
if (eqcr->ci != eqcr_ptr2idx(eqcr->cursor))
-- 
2.10.2

[PATCH] powerpc/pseries: fix spelling mistake: "Attemping" -> "Attempting"

[Colin King]

From: Colin Ian King 

trivial fix to spelling mistake in pr_debug message

Signed-off-by: Colin Ian King 
---
 arch/powerpc/platforms/pseries/hotplug-cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c 
b/arch/powerpc/platforms/pseries/hotplug-cpu.c
index a1b63e0..c8929cb 100644
--- a/arch/powerpc/platforms/pseries/hotplug-cpu.c
+++ b/arch/powerpc/platforms/pseries/hotplug-cpu.c
@@ -553,7 +553,7 @@ static ssize_t dlpar_cpu_remove(struct device_node *dn, u32 
drc_index)
 {
int rc;
 
-   pr_debug("Attemping to remove CPU %s, drc index: %x\n",
+   pr_debug("Attempting to remove CPU %s, drc index: %x\n",
 dn->name, drc_index);
 
rc = dlpar_offline_cpu(dn);
-- 
2.9.3

[PATCH] net: ps3_gelic: Add missing \n to end of deb_dbg message

[Colin King]

From: Colin Ian King 

Trival fix, dev_dbg message is missing a \n, so add it.

Signed-off-by: Colin Ian King 
---
 drivers/net/ethernet/toshiba/ps3_gelic_net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c 
b/drivers/net/ethernet/toshiba/ps3_gelic_net.c
index bc258d7..272f2b1 100644
--- a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
+++ b/drivers/net/ethernet/toshiba/ps3_gelic_net.c
@@ -1769,7 +1769,7 @@ static int ps3_gelic_driver_probe(struct 
ps3_system_bus_device *dev)
gelic_ether_setup_netdev_ops(netdev, >napi);
result = gelic_net_setup_netdev(netdev, card);
if (result) {
-   dev_dbg(>core, "%s: setup_netdev failed %d",
+   dev_dbg(>core, "%s: setup_netdev failed %d\n",
__func__, result);
goto fail_setup_netdev;
}
-- 
2.9.3

[PATCH] powerpc/32: add missing \n at end of printk warning message

[Colin King]

From: Colin Ian King 

The message is missing a \n, add it.

Signed-off-by: Colin Ian King 
---
 arch/powerpc/mm/init_32.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/mm/init_32.c b/arch/powerpc/mm/init_32.c
index 448685f..b532dd9 100644
--- a/arch/powerpc/mm/init_32.c
+++ b/arch/powerpc/mm/init_32.c
@@ -137,7 +137,7 @@ void __init MMU_init(void)
if (memblock.memory.cnt > 1) {
 #ifndef CONFIG_WII
memblock_enforce_memory_limit(memblock.memory.regions[0].size);
-   printk(KERN_WARNING "Only using first contiguous memory 
region");
+   printk(KERN_WARNING "Only using first contiguous memory 
region\n");
 #else
wii_memory_fixups();
 #endif
-- 
2.9.3

[PATCH] ASoC: fsl_esai: fix spelling mistake "Transmition" -> "Transmission"

[Colin King]

From: Colin Ian King 

Trivial fix to spelling mistakes in dev_dbg messages

Signed-off-by: Colin Ian King 
---
 sound/soc/fsl/fsl_esai.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c
index 26a90e1..e927955 100644
--- a/sound/soc/fsl/fsl_esai.c
+++ b/sound/soc/fsl/fsl_esai.c
@@ -77,19 +77,19 @@ static irqreturn_t esai_isr(int irq, void *devid)
regmap_read(esai_priv->regmap, REG_ESAI_ESR, );
 
if (esr & ESAI_ESR_TINIT_MASK)
-   dev_dbg(>dev, "isr: Transmition Initialized\n");
+   dev_dbg(>dev, "isr: Transmission Initialized\n");
 
if (esr & ESAI_ESR_RFF_MASK)
dev_warn(>dev, "isr: Receiving overrun\n");
 
if (esr & ESAI_ESR_TFE_MASK)
-   dev_warn(>dev, "isr: Transmition underrun\n");
+   dev_warn(>dev, "isr: Transmission underrun\n");
 
if (esr & ESAI_ESR_TLS_MASK)
dev_dbg(>dev, "isr: Just transmitted the last slot\n");
 
if (esr & ESAI_ESR_TDE_MASK)
-   dev_dbg(>dev, "isr: Transmition data exception\n");
+   dev_dbg(>dev, "isr: Transmission data exception\n");
 
if (esr & ESAI_ESR_TED_MASK)
dev_dbg(>dev, "isr: Transmitting even slots\n");
-- 
2.9.3

[PATCH] net: ucc_geth: fix spelling mistake "propperty" -> "property"

[Colin King]

From: Colin Ian King 

Trivial fix to spelling mistake in dev_warn message.

Signed-off-by: Colin Ian King 
---
 drivers/net/ethernet/freescale/ucc_geth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/ucc_geth.c 
b/drivers/net/ethernet/freescale/ucc_geth.c
index 5bf1ade..186ef8f 100644
--- a/drivers/net/ethernet/freescale/ucc_geth.c
+++ b/drivers/net/ethernet/freescale/ucc_geth.c
@@ -3756,7 +3756,7 @@ static int ucc_geth_probe(struct platform_device* ofdev)
return -EINVAL;
}
if ((*prop < QE_CLK_NONE) || (*prop > QE_CLK24)) {
-   pr_err("invalid rx-clock propperty\n");
+   pr_err("invalid rx-clock property\n");
return -EINVAL;
}
ug_info->uf_info.rx_clock = *prop;
-- 
2.9.3

[PATCH] powerpc/ps3: fix spelling mistake in function name

[Colin King]

From: Colin Ian King 

Trivial fix to spelling mistake in dev_warn message and remove
extraneous trailing whitespace at end of the message.

Signed-off-by: Colin Ian King 
---
 arch/powerpc/platforms/ps3/device-init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/ps3/device-init.c 
b/arch/powerpc/platforms/ps3/device-init.c
index 57caaf1..d3eabd1 100644
--- a/arch/powerpc/platforms/ps3/device-init.c
+++ b/arch/powerpc/platforms/ps3/device-init.c
@@ -62,7 +62,7 @@ static int __init ps3_register_lpm_devices(void)
>lpm.rights);
 
if (result) {
-   pr_debug("%s:%d: ps3_repository_read_lpm_privleges failed \n",
+   pr_debug("%s:%d: ps3_repository_read_lpm_privileges failed\n",
__func__, __LINE__);
goto fail_read_repo;
}
-- 
2.9.3

[PATCH] wan/fsl_ucc_hdlc: fix spelling mistake "prameter" -> "parameter"

[Colin King]

From: Colin Ian King 

Trivial fix to spelling mistake in dev_err message.

Signed-off-by: Colin Ian King 
---
 drivers/net/wan/fsl_ucc_hdlc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
index 6f04445..5fbf83d 100644
--- a/drivers/net/wan/fsl_ucc_hdlc.c
+++ b/drivers/net/wan/fsl_ucc_hdlc.c
@@ -162,7 +162,7 @@ static int uhdlc_init(struct ucc_hdlc_private *priv)
ALIGNMENT_OF_UCC_HDLC_PRAM);
 
if (priv->ucc_pram_offset < 0) {
-   dev_err(priv->dev, "Can not allocate MURAM for hdlc 
prameter.\n");
+   dev_err(priv->dev, "Can not allocate MURAM for hdlc 
parameter.\n");
ret = -ENOMEM;
goto free_tx_bd;
}
-- 
2.9.3

[PATCH] ASoC: fsl_spdif: fix spelling mistake: "receivce" -> "receive"

[Colin King]

From: Colin Ian King 

trivial fix to spelling mistake in dev_err message

Signed-off-by: Colin Ian King 
---
 sound/soc/fsl/fsl_spdif.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
index 151849f..beec793 100644
--- a/sound/soc/fsl/fsl_spdif.c
+++ b/sound/soc/fsl/fsl_spdif.c
@@ -172,7 +172,7 @@ static void spdif_irq_uqrx_full(struct fsl_spdif_priv 
*spdif_priv, char name)
if (*pos >= size * 2) {
*pos = 0;
} else if (unlikely((*pos % size) + 3 > size)) {
-   dev_err(>dev, "User bit receivce buffer overflow\n");
+   dev_err(>dev, "User bit receive buffer overflow\n");
return;
}
 
-- 
2.8.1

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH][V2] powerpc/fadump: trivial fix of spelling mistake, clean up message

[Colin King]

From: Colin Ian King 

Fix trivial spelling mistake "rgistration". Also use pr_err
instead of printk and unsplit the string to keep it all on one
line.

Signed-off-by: Colin Ian King 
---
 arch/powerpc/kernel/fadump.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c
index 3cb3b02a..09cb2a7 100644
--- a/arch/powerpc/kernel/fadump.c
+++ b/arch/powerpc/kernel/fadump.c
@@ -1009,9 +1009,9 @@ static int fadump_invalidate_dump(struct 
fadump_mem_struct *fdm)
} while (wait_time);
 
if (rc) {
-   printk(KERN_ERR "Failed to invalidate firmware-assisted dump "
-   "rgistration. unexpected error(%d).\n", rc);
-   return rc;
+   pr_err("Failed to invalidate firmware-assisted dump 
registration. Unexpected error (%d).\n",
+  rc);
+   return rc
}
fw_dump.dump_active = 0;
fdm_active = NULL;
-- 
2.8.1

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] powerpc/fadump: trivial fix of spelling mistake, clean up message

[Colin King]

From: Colin Ian King 

trivial fix to spelling mistake "rgistration" and minor clean up
of the printk error message

Signed-off-by: Colin Ian King 
---
 arch/powerpc/kernel/fadump.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c
index 3cb3b02a..0358f5b 100644
--- a/arch/powerpc/kernel/fadump.c
+++ b/arch/powerpc/kernel/fadump.c
@@ -1010,7 +1010,7 @@ static int fadump_invalidate_dump(struct 
fadump_mem_struct *fdm)
 
if (rc) {
printk(KERN_ERR "Failed to invalidate firmware-assisted dump "
-   "rgistration. unexpected error(%d).\n", rc);
+   "registration. Unexpected error (%d).\n", rc);
return rc;
}
fw_dump.dump_active = 0;
-- 
2.8.1

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] powerpc/powernv: spelling mistake: "Retrived" -> "Retrieved"

[Colin King]

From: Colin Ian King 

trivial fix to spelling mistake in pr_debug message

Signed-off-by: Colin Ian King 
---
 arch/powerpc/platforms/powernv/opal-memory-errors.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/powernv/opal-memory-errors.c 
b/arch/powerpc/platforms/powernv/opal-memory-errors.c
index 00a2943..4495f42 100644
--- a/arch/powerpc/platforms/powernv/opal-memory-errors.c
+++ b/arch/powerpc/platforms/powernv/opal-memory-errors.c
@@ -44,7 +44,7 @@ static void handle_memory_error_event(struct 
OpalMemoryErrorData *merr_evt)
 {
uint64_t paddr_start, paddr_end;
 
-   pr_debug("%s: Retrived memory error event, type: 0x%x\n",
+   pr_debug("%s: Retrieved memory error event, type: 0x%x\n",
  __func__, merr_evt->type);
switch (merr_evt->type) {
case OPAL_MEM_ERR_TYPE_RESILIENCE:
-- 
2.8.1

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] powerpc/pseries/hvcserver: don't memset pi_buff if it is null

[Colin King]

From: Colin Ian King 

pi_buff is being memset before it is sanity checked. Move the
memset after the null pi_buff sanity check to avoid an oops.

Signed-off-by: Colin Ian King 
---
 arch/powerpc/platforms/pseries/hvcserver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/pseries/hvcserver.c 
b/arch/powerpc/platforms/pseries/hvcserver.c
index eedb645..94a6e56 100644
--- a/arch/powerpc/platforms/pseries/hvcserver.c
+++ b/arch/powerpc/platforms/pseries/hvcserver.c
@@ -142,11 +142,11 @@ int hvcs_get_partner_info(uint32_t unit_address, struct 
list_head *head,
int more = 1;
int retval;
 
-   memset(pi_buff, 0x00, PAGE_SIZE);
/* invalid parameters */
if (!head || !pi_buff)
return -EINVAL;
 
+   memset(pi_buff, 0x00, PAGE_SIZE);
last_p_partition_ID = last_p_unit_address = ~0UL;
INIT_LIST_HEAD(head);
 
-- 
2.5.0

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] ps3-vuart: BUG_ON on null drv before dereferencing it on dev_dbg

[Colin King]

From: Colin Ian King 

On the unlikely event that drv is null, the current code will
perform a null pointer dereference with it when printing a dev_dbg
message.  Instead, the BUG_ON check on drv should be performed
before we emit the dev_dbg message.

Signed-off-by: Colin Ian King 
---
 drivers/ps3/ps3-vuart.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/ps3/ps3-vuart.c b/drivers/ps3/ps3-vuart.c
index d6db822..632701a 100644
--- a/drivers/ps3/ps3-vuart.c
+++ b/drivers/ps3/ps3-vuart.c
@@ -1000,12 +1000,11 @@ static int ps3_vuart_probe(struct ps3_system_bus_device 
*dev)
dev_dbg(>core, "%s:%d\n", __func__, __LINE__);
 
drv = ps3_system_bus_dev_to_vuart_drv(dev);
+   BUG_ON(!drv);
 
dev_dbg(>core, "%s:%d: (%s)\n", __func__, __LINE__,
drv->core.core.name);
 
-   BUG_ON(!drv);
-
if (dev->port_number >= PORT_COUNT) {
BUG();
return -EINVAL;
-- 
2.5.0

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] cxl: remove redundant increment of hwirq

[Colin King]

From: Colin Ian King colin.k...@canonical.com

Recent commit 80fa93fce37d3490f
(cxl: Name interrupts in /proc/interrupt) introduced a
redundant increment of hwirq which is not used or even
initialised at the point it is incremented. Detected by
cppcheck:

[drivers/misc/cxl/irq.c:439]: (error) Uninitialized
  variable: hwirq

Simple fix, remove the redundant increment.

Signed-off-by: Colin Ian King colin.k...@canonical.com
---
 drivers/misc/cxl/irq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/cxl/irq.c b/drivers/misc/cxl/irq.c
index c294925..68ab608 100644
--- a/drivers/misc/cxl/irq.c
+++ b/drivers/misc/cxl/irq.c
@@ -436,7 +436,7 @@ int afu_register_irqs(struct cxl_context *ctx, u32 count)
 */
INIT_LIST_HEAD(ctx-irq_names);
for (r = 1; r  CXL_IRQ_RANGES; r++) {
-   for (i = 0; i  ctx-irqs.range[r]; hwirq++, i++) {
+   for (i = 0; i  ctx-irqs.range[r]; i++) {
irq_name = kmalloc(sizeof(struct cxl_irq_name),
   GFP_KERNEL);
if (!irq_name)
-- 
2.1.4

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] cxl: remove redundant increment of hwirq

[Colin King]

From: Colin Ian King colin.k...@canonical.com

hwirq has not been initialized, however it is being incremented
and also not being referenced in a loop.  This error was detected with
cppcheck:

[drivers/misc/cxl/irq.c:439]: (error) Uninitialized variable: hwirq

Commit 80fa93fce37d (cxl: Name interrupts in /proc/interrupt) 
introduced this error.

This is a simple fix that removes the redundant increment.

Signed-off-by: Colin Ian King colin.k...@canonical.com
---
 drivers/misc/cxl/irq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/cxl/irq.c b/drivers/misc/cxl/irq.c
index c294925..68ab608 100644
--- a/drivers/misc/cxl/irq.c
+++ b/drivers/misc/cxl/irq.c
@@ -436,7 +436,7 @@ int afu_register_irqs(struct cxl_context *ctx, u32 count)
 */
INIT_LIST_HEAD(ctx-irq_names);
for (r = 1; r  CXL_IRQ_RANGES; r++) {
-   for (i = 0; i  ctx-irqs.range[r]; hwirq++, i++) {
+   for (i = 0; i  ctx-irqs.range[r]; i++) {
irq_name = kmalloc(sizeof(struct cxl_irq_name),
   GFP_KERNEL);
if (!irq_name)
-- 
2.1.4

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev