Re: [RFC] sound: ppc: keywest: check if DEQ was already instantiated
Hi, I applied this patch (check if DEQ was already instantiated) on top of sound: ppc: keywest: drop using attach adapter and sound works great. Everything works as expected. Below is my dmesg output. Regards, Dan On Sat, 5/23/15, Wolfram Sang w...@the-dreams.de wrote: Due to changes in i2c-powermac, for some Macs the DEQ is instantiated now in i2c-powermac while some need the instantiation here in the keywest sound driver. The proper fix is to convert this driver to AOA. Until then support both ways of instantiation. Before this patch, some Macs lost sound because the sound driver failed when instantiating the DEQ for the second time. Signed-off-by: Wolfram Sang w...@the-dreams.de --- Dan, Mark: I hope I found a generic but not too intrusive solution to the doubled instantiation problem. Can you please test this patch on top of this one sound: ppc: keywest: drop using attach adapter from last time? Check if you have sound and send the dmesg output, please. I hope it compiles even, couldn't test that this time. ~$ dmesg [0.00] Using PowerMac machine description [0.00] Total memory = 640MB; using 2048kB for hash table (at c7e0) [0.00] Initializing cgroup subsys cpuset [0.00] Initializing cgroup subsys cpu [0.00] Initializing cgroup subsys cpuacct [0.00] Linux version 3.16.7-ckt9-custom4 (root@icebook) (gcc version 4.9.2 (Debian 4.9.2-10) ) #5 Mon May 25 23:52:51 PDT 2015 [0.00] Found initrd at 0xc150:0xc220b000 [0.00] Found UniNorth memory controller host bridge @ 0xf800 revision: 0xc0 [0.00] Mapped at 0xff7c [0.00] Found a Pangea mac-io controller, rev: 0, mapped at 0xff74 [0.00] Processor NAP mode on idle enabled. [0.00] PowerMac motherboard: iBook 2 rev. 2 [0.00] via-pmu: Server Mode is disabled [0.00] PMU driver v2 initialized for Core99, firmware: 0c [0.00] bootconsole [udbg0] enabled [0.00] Found UniNorth PCI host bridge at 0xf000. Firmware bus number: 0-0 [0.00] PCI host bridge /pci@f000 ranges: [0.00] MEM 0xf100..0xf1ff - 0xf100 [0.00] IO 0xf000..0xf07f - 0x [0.00] MEM 0x9000..0x9fff - 0x9000 [0.00] Found UniNorth PCI host bridge at 0xf200. Firmware bus number: 0-0 [0.00] PCI host bridge /pci@f200 (primary) ranges: [0.00] MEM 0xf300..0xf3ff - 0xf300 [0.00] IO 0xf200..0xf27f - 0x [0.00] MEM 0x8000..0x8fff - 0x8000 [0.00] Found UniNorth PCI host bridge at 0xf400. Firmware bus number: 0-0 [0.00] PCI host bridge /pci@f400 ranges: [0.00] MEM 0xf500..0xf5ff - 0xf500 [0.00] IO 0xf400..0xf47f - 0x [0.00] nvram: Checking bank 0... [0.00] nvram: gen0=1100, gen1=1101 [0.00] nvram: Active bank is: 1 [0.00] nvram: OF partition at 0x410 [0.00] nvram: XP partition at 0x1020 [0.00] nvram: NR partition at 0x1120 [0.00] Top of RAM: 0x2800, Total RAM: 0x2800 [0.00] Memory hole size: 0MB [0.00] Zone ranges: [0.00] DMA [mem 0x-0x27ff] [0.00] Normal empty [0.00] HighMem empty [0.00] Movable zone start for each node [0.00] Early memory node ranges [0.00] node 0: [mem 0x-0x27ff] [0.00] On node 0 totalpages: 163840 [0.00] free_area_init_node: node 0, pgdat c05ebf0c, node_mem_map c076b000 [0.00] DMA zone: 1280 pages used for memmap [0.00] DMA zone: 0 pages reserved [0.00] DMA zone: 163840 pages, LIFO batch:31 [0.00] pcpu-alloc: s0 r0 d32768 u32768 alloc=1*32768 [0.00] pcpu-alloc: [0] 0 [0.00] Built 1 zonelists in Zone order, mobility grouping on. Total pages: 162560 [0.00] Kernel command line: root=UUID=97b477c4-04c2-476e-9225-4eda6ca97833 ro nomodeset video=offb:off video=radeonfb:1024x768-32 [0.00] PID hash table entries: 4096 (order: 2, 16384 bytes) [0.00] Dentry cache hash table entries: 131072 (order: 7, 524288 bytes) [0.00] Inode-cache hash table entries: 65536 (order: 6, 262144 bytes) [0.00] Sorting __ex_table... [0.00] Memory: 626160K/655360K available (4252K kernel code, 320K rwdata, 1268K rodata, 292K init, 1395K bss, 29200K reserved, 0K highmem) [0.00] Kernel virtual memory layout: [0.00] * 0xfffcf000..0xf000 : fixmap [0.00] * 0xff80..0xffc0 : highmem PTEs [0.00] * 0xfde72000..0xff80 : early ioremap [0.00] *
Re: [PATCH] i2c: powermac: don't workaround for keywest
Hi, Sorry for the delay, I found this message in my spam folder. Anyway, for my machine model, cat /proc/device-tree/compatible returns: PowerBook4,3MacRISC2MacRISCPower Macintosh It's a 14 in. iBook G3 700 MHz. Regards, Dan On Mon, 5/11/15, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: Subject: Re: [PATCH] i2c: powermac: don't workaround for keywest To: w...@the-dreams.de Cc: linux-...@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Dan DeVoto dand1...@yahoo.com, Mark Elliott txliteb...@gmail.com Date: Monday, May 11, 2015, 4:26 PM On Mon, 2015-05-11 at 09:34 +0200, w...@the-dreams.de wrote: On Mon, May 11, 2015 at 08:14:47AM +1000, Benjamin Herrenschmidt wrote: On Sun, 2015-05-10 at 20:34 +0200, Wolfram Sang wrote: Okay, so this patch is bogus. I understand now that onyx uses another codec than TAS, so this change will regress on other machines. However, it shows that this unconditional instantiation of the TAS breaks sound on Macintoshs which still need non-aoa sound support. I assume there will be noone in the near future to convert Keywest to AOA, so we'll need to find a hackish way around this instantiation problem. Converting the old macs that use TAS shouldn't be *that* hard, main problem is I don't have the hardware to test... Dan and Mark (on CC) have been very helpful with testing. Maybe they are also in to test the proper solution? Possibly, depends how many machines we can cover. I also have extremely little time, so I'm not that keen on volunteering :-) I'll *try* to have a look some time this or next week. The main problem is the difference in the way the layout of the codec etc... is reported from the DT by the firmware. Otherwise the HW is the same between pre-AOA and post-AOA really ... I do have a bunch of DT snapshots lying around, so I can try to figure out something. Dan, Mark, what machine models specifically do you have ? (compatible property in the DT pls, ie, /proc/device-tree/compatible). Cheers, Ben. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
