Re: [PATCH v3 6/7] mm/gup: remove vmas parameter from pin_user_pages()

[Dennis Dalessandro]

On 4/15/23 8:09 AM, Lorenzo Stoakes wrote:
> After the introduction of FOLL_SAME_FILE we no longer require vmas for any
> invocation of pin_user_pages(), so eliminate this parameter from the
> function and all callers.
> 
> This clears the way to removing the vmas parameter from GUP altogether.
> 
> Signed-off-by: Lorenzo Stoakes 
> ---
>  arch/powerpc/mm/book3s64/iommu_api.c   | 2 +-
>  drivers/infiniband/hw/qib/qib_user_pages.c | 2 +-
>  drivers/infiniband/hw/usnic/usnic_uiom.c   | 2 +-
>  drivers/infiniband/sw/siw/siw_mem.c| 2 +-
>  drivers/media/v4l2-core/videobuf-dma-sg.c  | 2 +-
>  drivers/vdpa/vdpa_user/vduse_dev.c | 2 +-
>  drivers/vhost/vdpa.c   | 2 +-
>  include/linux/mm.h | 3 +--
>  io_uring/rsrc.c| 2 +-
>  mm/gup.c   | 9 +++--
>  mm/gup_test.c  | 9 -
>  net/xdp/xdp_umem.c | 2 +-
>  12 files changed, 17 insertions(+), 22 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/qib/qib_user_pages.c 
> b/drivers/infiniband/hw/qib/qib_user_pages.c
> index f693bc753b6b..1bb7507325bc 100644
> --- a/drivers/infiniband/hw/qib/qib_user_pages.c
> +++ b/drivers/infiniband/hw/qib/qib_user_pages.c
> @@ -111,7 +111,7 @@ int qib_get_user_pages(unsigned long start_page, size_t 
> num_pages,
>   ret = pin_user_pages(start_page + got * PAGE_SIZE,
>num_pages - got,
>FOLL_LONGTERM | FOLL_WRITE,
> -  p + got, NULL);
> +  p + got);
>   if (ret < 0) {
>       mmap_read_unlock(current->mm);
>   goto bail_release;

For Qib...

Acked-by: Dennis Dalessandro 

Re: [PATCH 11/22] rdmavt: Replace comments with C99 initializers

[Dennis Dalessandro]

On 3/27/22 3:04 AM, Leon Romanovsky wrote:
> On Sat, Mar 26, 2022 at 05:58:58PM +0100, Benjamin Stürz wrote:
>> This replaces comments with C99's designated
>> initializers because the kernel supports them now.
>>
>> Signed-off-by: Benjamin Stürz 
>> ---
>>  drivers/infiniband/sw/rdmavt/rc.c | 62 +++
>>  1 file changed, 31 insertions(+), 31 deletions(-)
>>
>> diff --git a/drivers/infiniband/sw/rdmavt/rc.c 
>> b/drivers/infiniband/sw/rdmavt/rc.c
>> index 4e5d4a27633c..121b8a23ac07 100644
>> --- a/drivers/infiniband/sw/rdmavt/rc.c
>> +++ b/drivers/infiniband/sw/rdmavt/rc.c
>> @@ -10,37 +10,37 @@
>>   * Convert the AETH credit code into the number of credits.
>>   */
>>  static const u16 credit_table[31] = {
>> -0,  /* 0 */
>> -1,  /* 1 */
>> -2,  /* 2 */
>> -3,  /* 3 */
>> -4,  /* 4 */
>> -6,  /* 5 */
>> -8,  /* 6 */
>> -12, /* 7 */
>> -16, /* 8 */
>> -24, /* 9 */
>> -32, /* A */
>> -48, /* B */
>> -64, /* C */
>> -96, /* D */
>> -128,/* E */
>> -192,/* F */
>> -256,/* 10 */
>> -384,/* 11 */
>> -512,/* 12 */
>> -768,/* 13 */
>> -1024,   /* 14 */
>> -1536,   /* 15 */
>> -2048,   /* 16 */
>> -3072,   /* 17 */
>> -4096,   /* 18 */
>> -6144,   /* 19 */
>> -8192,   /* 1A */
>> -12288,  /* 1B */
>> -16384,  /* 1C */
>> -24576,  /* 1D */
>> -32768   /* 1E */
>> +[0x00] = 0,
>> +[0x01] = 1,
>> +[0x02] = 2,
>> +[0x03] = 3,
>> +[0x04] = 4,
>> +[0x05] = 6,
>> +[0x06] = 8,
>> +[0x07] = 12,
>> +[0x08] = 16,
>> +[0x09] = 24,
>> +[0x0A] = 32,
>> +[0x0B] = 48,
>> +[0x0C] = 64,
>> +[0x0D] = 96,
>> +[0x0E] = 128,
>> +[0x0F] = 192,
>> +[0x10] = 256,
>> +[0x11] = 384,
>> +[0x12] = 512,
>> +[0x13] = 768,
>> +[0x14] = 1024,
>> +[0x15] = 1536,
>> +[0x16] = 2048,
>> +[0x17] = 3072,
>> +[0x18] = 4096,
>> +[0x19] = 6144,
>> +[0x1A] = 8192,
>> +[0x1B] = 12288,
>> +[0x1C] = 16384,
>> +[0x1D] = 24576,
>> +[0x1E] = 32768
>>  };
> 
> I have hard time to see any value in this commit, why is this change needed?
> 

I tend to agree. This doesn't really improve things. It's a NAK from me.

-Denny