Re: [PATCH] MAINTAINERS: adjust file entries after crypto vmx file movement
On Thu, Feb 1, 2024 at 6:51 AM Herbert Xu wrote: > > On Mon, Jan 29, 2024 at 02:17:29PM +0100, Lukas Bulwahn wrote: > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 2fb944964be5..15bc79e80e28 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -10307,12 +10307,12 @@ M: Nayna Jain > > M: Paulo Flabiano Smorigo > > L: linux-cry...@vger.kernel.org > > S: Supported > > -F: drivers/crypto/vmx/Kconfig > > -F: drivers/crypto/vmx/Makefile > > -F: drivers/crypto/vmx/aes* > > -F: drivers/crypto/vmx/ghash* > > -F: drivers/crypto/vmx/ppc-xlate.pl > > -F: drivers/crypto/vmx/vmx.c > > +F: arch/powerpc/crypto/Kconfig > > +F: arch/powerpc/crypto/Makefile > > +F: arch/powerpc/crypto/aes* > > Are you sure about this? There are non-vmx aes* files in that > directory. Perhaps something more specific is needed here? > sorry for the late reply. I revisited this patch and now keep the match exact in my patch v2: https://lore.kernel.org/lkml/20240208093327.23926-1-lukas.bulw...@gmail.com/ Herbert, I hope you are fine to pick this patch v2. Lukas
[PATCH v2] MAINTAINERS: adjust file entries after crypto vmx file movement
Commit 109303336a0c ("crypto: vmx - Move to arch/powerpc/crypto") moves the
crypto vmx files to arch/powerpc, but misses to adjust the file entries for
IBM Power VMX Cryptographic instructions and LINUX FOR POWERPC.
Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about
broken references.
Adjust these file entries accordingly. To keep the matched files exact
after the movement, spell out each file name in the new directory.
Signed-off-by: Lukas Bulwahn
---
v1: https://lore.kernel.org/lkml/20240129131729.4311-1-lukas.bulw...@gmail.com/
v1 -> v2:
- address Herbert Xu's feedback:
keep the matched files exactly those which were in the vmx directory
Danny, please ack.
Herbert, please pick this minor clean-up patch on your -next tree.
MAINTAINERS | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 58845a852ab1..1820f661bfe1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10329,12 +10329,17 @@ M:Nayna Jain
M: Paulo Flabiano Smorigo
L: linux-cry...@vger.kernel.org
S: Supported
-F: drivers/crypto/vmx/Kconfig
-F: drivers/crypto/vmx/Makefile
-F: drivers/crypto/vmx/aes*
-F: drivers/crypto/vmx/ghash*
-F: drivers/crypto/vmx/ppc-xlate.pl
-F: drivers/crypto/vmx/vmx.c
+F: arch/powerpc/crypto/Kconfig
+F: arch/powerpc/crypto/Makefile
+F: arch/powerpc/crypto/aes.c
+F: arch/powerpc/crypto/aes_cbc.c
+F: arch/powerpc/crypto/aes_ctr.c
+F: arch/powerpc/crypto/aes_xts.c
+F: arch/powerpc/crypto/aesp8-ppc.*
+F: arch/powerpc/crypto/ghash.c
+F: arch/powerpc/crypto/ghashp8-ppc.pl
+F: arch/powerpc/crypto/ppc-xlate.pl
+F: arch/powerpc/crypto/vmx.c
IBM ServeRAID RAID DRIVER
S: Orphan
@@ -12428,7 +12433,6 @@ F: drivers/*/*/*pasemi*
F: drivers/*/*pasemi*
F: drivers/char/tpm/tpm_ibmvtpm*
F: drivers/crypto/nx/
-F: drivers/crypto/vmx/
F: drivers/i2c/busses/i2c-opal.c
F: drivers/net/ethernet/ibm/ibmveth.*
F: drivers/net/ethernet/ibm/ibmvnic.*
--
2.17.1
[PATCH] MAINTAINERS: adjust file entries after crypto vmx file movement
Commit 109303336a0c ("crypto: vmx - Move to arch/powerpc/crypto") moves the
crypto vmx files to arch/powerpc, but misses to adjust the file entries for
IBM Power VMX Cryptographic instructions and LINUX FOR POWERPC.
Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about
broken references.
Adjust these file entries accordingly.
Signed-off-by: Lukas Bulwahn
---
Danny, please ack.
Herbert, please pick this minor clean-up patch on your -next tree.
MAINTAINERS | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 2fb944964be5..15bc79e80e28 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10307,12 +10307,12 @@ M:Nayna Jain
M: Paulo Flabiano Smorigo
L: linux-cry...@vger.kernel.org
S: Supported
-F: drivers/crypto/vmx/Kconfig
-F: drivers/crypto/vmx/Makefile
-F: drivers/crypto/vmx/aes*
-F: drivers/crypto/vmx/ghash*
-F: drivers/crypto/vmx/ppc-xlate.pl
-F: drivers/crypto/vmx/vmx.c
+F: arch/powerpc/crypto/Kconfig
+F: arch/powerpc/crypto/Makefile
+F: arch/powerpc/crypto/aes*
+F: arch/powerpc/crypto/ghash*
+F: arch/powerpc/crypto/ppc-xlate.pl
+F: arch/powerpc/crypto/vmx.c
IBM ServeRAID RAID DRIVER
S: Orphan
@@ -12397,7 +12397,6 @@ F: drivers/*/*/*pasemi*
F: drivers/*/*pasemi*
F: drivers/char/tpm/tpm_ibmvtpm*
F: drivers/crypto/nx/
-F: drivers/crypto/vmx/
F: drivers/i2c/busses/i2c-opal.c
F: drivers/net/ethernet/ibm/ibmveth.*
F: drivers/net/ethernet/ibm/ibmvnic.*
--
2.17.1
In-flight collision: DRM_AMD_DC_DCN renaming
Dear Michael, dear Harry, dear Alex,
The commit 4652ae7a51b7 ("drm/amd/display: Rename DCN config to FP")
renames config DRM_AMD_DC_DCN to config DRM_AMD_DC_FP. The concurrent
commit 78f0929884d4 ("powerpc/64: Always build with 128-bit long
double") overrides the renaming change for the select in config
DRM_AMD_DC, and this leads to selecting the non-existent
DRM_AMD_DC_DCN.
It is easy to fix, adjust this one line to the renaming and 'select
DRM_AMD_DC_FP' once both commits are merged. For now, I am just
reporting to let you know; probably, it is best to get a quick fix-up
patch with -rc2, once all the changes landed in -rc1.
Best regards,
Lukas
Re: Question about the dependency on the config SOC_FSL in CPM_QMC
On Tue, Mar 14, 2023 at 8:57 AM Herve Codina wrote: > > Hi Lukas, > > On Tue, 14 Mar 2023 08:21:50 +0100 > Lukas Bulwahn wrote: > > > Dear Herve, > > > > In your patch below, you added the config CPM_QMC which depends on the > > non-existing config SOC_FSL: > > > > https://lore.kernel.org/r/20230217145645.1768659-7-herve.cod...@bootlin.com > > > > Up to my knowledge, the config SOC_FSL never existed in the mainline > > tree. Is this dependency really required or can the expression simply > > be reduced to COMPILE_TEST and we drop the dependency to SOC_FSL? > > > > Note: This patch has now shown up in linux-next with commit > > 3178d58e0b97. Currently, it would not be possible to compile test this > > driver, as the dependency on SOC_FSL is never met. > > > > > > Best regards, > > > > Lukas > > My bad :( > > The dependency must be FSL_SOC instead of SOC_FSL. Herve, are you going to send a quick fix to your patch or ask Mark if your original patch can simply be replaced with a new one with this change added? Lukas > I mean: > diff --git a/drivers/soc/fsl/qe/Kconfig b/drivers/soc/fsl/qe/Kconfig > index f90cfdf0c763..7268c2fbcbc1 100644 > --- a/drivers/soc/fsl/qe/Kconfig > +++ b/drivers/soc/fsl/qe/Kconfig > @@ -47,7 +47,7 @@ config CPM_TSA > config CPM_QMC > tristate "CPM QMC support" > depends on OF && HAS_IOMEM > - depends on CPM1 || (SOC_FSL && COMPILE_TEST) > + depends on CPM1 || (FSL_SOC && COMPILE_TEST) > depends on CPM_TSA > help > Freescale CPM QUICC Multichannel Controller > > > > -- > Hervé Codina, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
Question about the dependency on the config SOC_FSL in CPM_QMC
Dear Herve, In your patch below, you added the config CPM_QMC which depends on the non-existing config SOC_FSL: https://lore.kernel.org/r/20230217145645.1768659-7-herve.cod...@bootlin.com Up to my knowledge, the config SOC_FSL never existed in the mainline tree. Is this dependency really required or can the expression simply be reduced to COMPILE_TEST and we drop the dependency to SOC_FSL? Note: This patch has now shown up in linux-next with commit 3178d58e0b97. Currently, it would not be possible to compile test this driver, as the dependency on SOC_FSL is never met. Best regards, Lukas
Re: [PATCH] powerpc: update config files
On Fri, Sep 30, 2022 at 9:42 AM Michael Ellerman wrote:
>
> Lukas Bulwahn writes:
> > Clean up config files by:
> > - removing configs that were deleted in the past
> > - removing configs not in tree and without recently pending patches
> > - adding new configs that are replacements for old configs in the file
> >
> > For some detailed information, see Link.
> >
> > Link:
> > https://lore.kernel.org/kernel-janitors/20220929090645.1389-1-lukas.bulw...@gmail.com/
>
> Ideally I'd like a list in the change log of each symbol and why they're
> being removed/changed. It's pretty easy to accidentally drop something
> otherwise.
>
> I think this is the list in this case:
>
> Renamed:
> - CONFIG_PPC_PTDUMP -> CONFIG_GENERIC_PTDUMP
> e084728393a5 ("powerpc/ptdump: Convert powerpc to GENERIC_PTDUMP")
>
> Removed:
> - CONFIG_BLK_DEV_CRYPTOLOOP
> 47e9624616c8 ("block: remove support for cryptoloop and the xor transfer")
>
> - CONFIG_CRYPTO_RMD128
> b21b9a5e0aef ("crypto: rmd128 - remove RIPE-MD 128 hash algorithm")
>
> - CONFIG_CRYPTO_RMD256
> c15d4167f0b0 ("crypto: rmd256 - remove RIPE-MD 256 hash algorithm")
>
> - CONFIG_CRYPTO_RMD320
> 93f64202926f ("crypto: rmd320 - remove RIPE-MD 320 hash algorithm")
>
> - CONFIG_CRYPTO_SALSA20
> 663f63ee6d9c ("crypto: salsa20 - remove Salsa20 stream cipher algorithm")
>
> - CONFIG_CRYPTO_TGR192
> 87cd723f8978 ("crypto: tgr192 - remove Tiger 128/160/192 hash algorithms")
>
> - CONFIG_HARDENED_USERCOPY_PAGESPAN
> 1109a5d90701 ("usercopy: Remove HARDENED_USERCOPY_PAGESPAN")
>
> - CONFIG_RAPIDIO_TSI568, CONFIG_RAPIDIO_TSI57X
> 612d4904191f ("rapidio: remove not used code about RIO_VID_TUNDRA")
>
> - CONFIG_RAW_DRIVER
> 603e4922f1c8 ("remove the raw driver")
>
> - CONFIG_ROCKETPORT
> 3b00b6af7a5b ("tty: rocket, remove the driver")
>
> - CONFIG_ENABLE_MUST_CHECK
> 196793946264 ("Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK")
>
>
> I'll fold that into the change log.
>
Sure. Go ahead. I have provided all information I collected in the
linked email (and this information drove my scripts to take actions)
and I am happy to provide it in any form a maintainer may think is
good for them. But I assume you did this with a simple script
yourself.
After going through the changes of Kconfig from the last decade, it
seems feasible that the information on Kconfig changes is actually
maintained somewhere and that would allow updating of arbitrary kernel
configs to newer kernel versions. It is not completely out of reach at
least.
And to really improve the situation, I would like to reduce all these
defconfigs in the repository to minimal kernel fragments that really
focus on what these config for specific machines intend to tell. E.g.,
these configs below (powerpc-configs) are about ensuring specific
hardware support, not about setting "CONFIG_CRYPTO_XYZ" one way or the
other. That is actually just "noise". I do not know how to do this
right yet, but with a bit of experimentation and investigation, I
might come with a first idea and then we will see.
Lukas
> cheers
>
> > Signed-off-by: Lukas Bulwahn
> > ---
> > arch/powerpc/configs/83xx/mpc837x_rdb_defconfig | 1 -
> > arch/powerpc/configs/85xx/ge_imp3a_defconfig| 1 -
> > arch/powerpc/configs/85xx/ppa8548_defconfig | 2 --
> > arch/powerpc/configs/cell_defconfig | 1 -
> > arch/powerpc/configs/g5_defconfig | 1 -
> > arch/powerpc/configs/mpc512x_defconfig | 1 -
> > arch/powerpc/configs/mpc885_ads_defconfig | 2 +-
> > arch/powerpc/configs/pasemi_defconfig | 1 -
> > arch/powerpc/configs/pmac32_defconfig | 1 -
> > arch/powerpc/configs/powernv_defconfig | 3 ---
> > arch/powerpc/configs/ppc64_defconfig| 3 ---
> > arch/powerpc/configs/ppc64e_defconfig | 3 ---
> > arch/powerpc/configs/ppc6xx_defconfig | 7 ---
> > arch/powerpc/configs/ps3_defconfig | 1 -
> > arch/powerpc/configs/pseries_defconfig | 3 ---
> > arch/powerpc/configs/skiroot_defconfig | 2 --
> > arch/powerpc/configs/storcenter_defconfig | 1 -
> > 17 files changed, 1 insertion(+), 33 deletions(-)
> >
> > diff --git a/arch/powerpc/configs/83xx/mpc837x_rdb_defconfig
> > b/arch/powerpc/configs/83xx/mpc837x_rdb_defconfig
> > index cbcae2a927e9..4e3373381ab6 100644
> > --- a/arch/powerpc/configs/83xx/mpc837x_rdb_defconfig
> > +++ b/arch/po
[PATCH] powerpc: update config files
Clean up config files by: - removing configs that were deleted in the past - removing configs not in tree and without recently pending patches - adding new configs that are replacements for old configs in the file For some detailed information, see Link. Link: https://lore.kernel.org/kernel-janitors/20220929090645.1389-1-lukas.bulw...@gmail.com/ Signed-off-by: Lukas Bulwahn --- arch/powerpc/configs/83xx/mpc837x_rdb_defconfig | 1 - arch/powerpc/configs/85xx/ge_imp3a_defconfig| 1 - arch/powerpc/configs/85xx/ppa8548_defconfig | 2 -- arch/powerpc/configs/cell_defconfig | 1 - arch/powerpc/configs/g5_defconfig | 1 - arch/powerpc/configs/mpc512x_defconfig | 1 - arch/powerpc/configs/mpc885_ads_defconfig | 2 +- arch/powerpc/configs/pasemi_defconfig | 1 - arch/powerpc/configs/pmac32_defconfig | 1 - arch/powerpc/configs/powernv_defconfig | 3 --- arch/powerpc/configs/ppc64_defconfig| 3 --- arch/powerpc/configs/ppc64e_defconfig | 3 --- arch/powerpc/configs/ppc6xx_defconfig | 7 --- arch/powerpc/configs/ps3_defconfig | 1 - arch/powerpc/configs/pseries_defconfig | 3 --- arch/powerpc/configs/skiroot_defconfig | 2 -- arch/powerpc/configs/storcenter_defconfig | 1 - 17 files changed, 1 insertion(+), 33 deletions(-) diff --git a/arch/powerpc/configs/83xx/mpc837x_rdb_defconfig b/arch/powerpc/configs/83xx/mpc837x_rdb_defconfig index cbcae2a927e9..4e3373381ab6 100644 --- a/arch/powerpc/configs/83xx/mpc837x_rdb_defconfig +++ b/arch/powerpc/configs/83xx/mpc837x_rdb_defconfig @@ -77,6 +77,5 @@ CONFIG_NFS_FS=y CONFIG_NFS_V4=y CONFIG_ROOT_NFS=y CONFIG_CRC_T10DIF=y -# CONFIG_ENABLE_MUST_CHECK is not set CONFIG_CRYPTO_ECB=m CONFIG_CRYPTO_PCBC=m diff --git a/arch/powerpc/configs/85xx/ge_imp3a_defconfig b/arch/powerpc/configs/85xx/ge_imp3a_defconfig index e7672c186325..ea719898b581 100644 --- a/arch/powerpc/configs/85xx/ge_imp3a_defconfig +++ b/arch/powerpc/configs/85xx/ge_imp3a_defconfig @@ -74,7 +74,6 @@ CONFIG_MTD_PHYSMAP_OF=y CONFIG_MTD_RAW_NAND=y CONFIG_MTD_NAND_FSL_ELBC=y CONFIG_BLK_DEV_LOOP=m -CONFIG_BLK_DEV_CRYPTOLOOP=m CONFIG_BLK_DEV_NBD=m CONFIG_BLK_DEV_RAM=y CONFIG_BLK_DEV_RAM_SIZE=131072 diff --git a/arch/powerpc/configs/85xx/ppa8548_defconfig b/arch/powerpc/configs/85xx/ppa8548_defconfig index 190978a5b7d5..4bd5f993d26a 100644 --- a/arch/powerpc/configs/85xx/ppa8548_defconfig +++ b/arch/powerpc/configs/85xx/ppa8548_defconfig @@ -7,9 +7,7 @@ CONFIG_RAPIDIO=y CONFIG_FSL_RIO=y CONFIG_RAPIDIO_DMA_ENGINE=y CONFIG_RAPIDIO_ENUM_BASIC=y -CONFIG_RAPIDIO_TSI57X=y CONFIG_RAPIDIO_CPS_XX=y -CONFIG_RAPIDIO_TSI568=y CONFIG_RAPIDIO_CPS_GEN2=y CONFIG_ADVANCED_OPTIONS=y CONFIG_LOWMEM_SIZE_BOOL=y diff --git a/arch/powerpc/configs/cell_defconfig b/arch/powerpc/configs/cell_defconfig index 7fd9e596ea33..06391cc2af3a 100644 --- a/arch/powerpc/configs/cell_defconfig +++ b/arch/powerpc/configs/cell_defconfig @@ -195,7 +195,6 @@ CONFIG_NLS_ISO8859_9=m CONFIG_NLS_ISO8859_13=m CONFIG_NLS_ISO8859_14=m CONFIG_NLS_ISO8859_15=m -# CONFIG_ENABLE_MUST_CHECK is not set CONFIG_MAGIC_SYSRQ=y CONFIG_DEBUG_KERNEL=y CONFIG_DEBUG_MUTEXES=y diff --git a/arch/powerpc/configs/g5_defconfig b/arch/powerpc/configs/g5_defconfig index 9d6212a8b195..71d9d112c0b6 100644 --- a/arch/powerpc/configs/g5_defconfig +++ b/arch/powerpc/configs/g5_defconfig @@ -119,7 +119,6 @@ CONFIG_INPUT_EVDEV=y # CONFIG_SERIO_I8042 is not set # CONFIG_SERIO_SERPORT is not set # CONFIG_HW_RANDOM is not set -CONFIG_RAW_DRIVER=y CONFIG_I2C_CHARDEV=y CONFIG_AGP=m CONFIG_AGP_UNINORTH=m diff --git a/arch/powerpc/configs/mpc512x_defconfig b/arch/powerpc/configs/mpc512x_defconfig index e75d3f3060c9..10fe061c5e6d 100644 --- a/arch/powerpc/configs/mpc512x_defconfig +++ b/arch/powerpc/configs/mpc512x_defconfig @@ -114,5 +114,4 @@ CONFIG_NFS_FS=y CONFIG_ROOT_NFS=y CONFIG_NLS_CODEPAGE_437=y CONFIG_NLS_ISO8859_1=y -# CONFIG_ENABLE_MUST_CHECK is not set # CONFIG_CRYPTO_HW is not set diff --git a/arch/powerpc/configs/mpc885_ads_defconfig b/arch/powerpc/configs/mpc885_ads_defconfig index 700115d85d6f..56b876e418e9 100644 --- a/arch/powerpc/configs/mpc885_ads_defconfig +++ b/arch/powerpc/configs/mpc885_ads_defconfig @@ -78,4 +78,4 @@ CONFIG_DEBUG_VM_PGTABLE=y CONFIG_DETECT_HUNG_TASK=y CONFIG_BDI_SWITCH=y CONFIG_PPC_EARLY_DEBUG=y -CONFIG_PPC_PTDUMP=y +CONFIG_GENERIC_PTDUMP=y diff --git a/arch/powerpc/configs/pasemi_defconfig b/arch/powerpc/configs/pasemi_defconfig index e00a703581c3..96aa5355911f 100644 --- a/arch/powerpc/configs/pasemi_defconfig +++ b/arch/powerpc/configs/pasemi_defconfig @@ -92,7 +92,6 @@ CONFIG_LEGACY_PTY_COUNT=4 CONFIG_SERIAL_8250=y CONFIG_SERIAL_8250_CONSOLE=y CONFIG_HW_RANDOM=y -CONFIG_RAW_DRIVER=y CONFIG_I2C_CHARDEV=y CONFIG_I2C_PASEMI=y CONFIG_SENSORS_LM85=y diff --git a/arch/powerpc/configs/pmac32_defconfig b/arch/powerpc/configs/pmac32_defconfig index
State of RFC PATCH Remove CONFIG_DCACHE_WORD_ACCESS
Hi Joe, hi Ben, While reviewing some kernel config, I came across CONFIG_DCACHE_WORD_ACCESS and tried to understand its purpose. Then, I discovered this RFC patch from 2014 that seems never to have been integrated: https://lore.kernel.org/all/1393964591.20435.58.camel@joe-AO722/ [RFC] Remove CONFIG_DCACHE_WORD_ACCESS The discussion seemed to just not continue and the patch was just not integrated by anyone. In the meantime, the use of CONFIG_DCACHE_WORD_ACCESS has spread into a few more files, but replacing it with CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS still seems feasible. Are you aware of reasons that this patch from 2014 should not be integrated? I would spend some time to move the integration of this patch further if you consider that the patch is not completely wrong. Best regards, Lukas
Re: [PATCH v2] powerpc: select HAVE_PATA_PLATFORM in PPC instead of creating a PPC dependency
On Fri, Sep 9, 2022 at 1:09 PM Arnd Bergmann wrote:
>
> On Fri, Sep 9, 2022, at 11:03 AM, Lukas Bulwahn wrote:
> > Commit cc18e0fea790 ("LIBATA: Add HAVE_PATA_PLATFORM to select
> > PATA_PLATFORM driver") introduces config HAVE_PATA_PLATFORM, and expects
> > that all architectures simply select this config when the architecture
> > supports using the PATA_PLATFORM driver.
> >
> > This is properly implemented already for all architectures except for the
> > powerpc architecture. Implement this for powerpc now.
> >
> > Adjust the config of the powerpc architecture to use the config
> > HAVE_PATA_PLATFORM and simplify the config PATA_PLATFORM to not mention
> > any specific architecture anymore.
> >
> > Signed-off-by: Lukas Bulwahn
> > ---
> > arch/powerpc/Kconfig | 1 +
> > drivers/ata/Kconfig | 2 +-
> > 2 files changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> > index 39d71d7701bd..2575e21b6e6b 100644
> > --- a/arch/powerpc/Kconfig
> > +++ b/arch/powerpc/Kconfig
> > @@ -237,6 +237,7 @@ config PPC
> > select HAVE_MOD_ARCH_SPECIFIC
> > select HAVE_NMI if PERF_EVENTS || (PPC64 &&
> > PPC_BOOK3S)
> > select HAVE_OPTPROBES
> > + select HAVE_PATA_PLATFORM
> > select HAVE_PERF_EVENTS
> > select HAVE_PERF_EVENTS_NMI if PPC64
> > select HAVE_PERF_REGS
>
> I don't see a single powerpc machine that creates a
> name="pata_platform" platform_device. I suspect this was
> only needed bwfore 2007 commit 9cd55be4d223 ("[POWERPC] pasemi:
> Move electra-ide to pata_of_platform"), so the "|| PPC"
> bit should just get removed without adding the HAVE_PATA_PLATFORM
> bit.
>
Thanks for your investigation. I will send a corresponding patch v3.
Lukas
Re: [PATCH 6/6] init/Kconfig: remove confusing config EMBEDDED
> > init/Kconfig | 8 > > 1 file changed, 8 deletions(-) > > > > diff --git a/init/Kconfig b/init/Kconfig > > index 9e3fd79b089c..d7429e0b8cae 100644 > > --- a/init/Kconfig > > +++ b/init/Kconfig > > @@ -1818,14 +1818,6 @@ config DEBUG_RSEQ > > > > If unsure, say N. > > > > -config EMBEDDED > > - bool "Embedded system" > > - select EXPERT > > - help > > - This option should be enabled if compiling the kernel for > > - an embedded system so certain expert options are available > > - for configuration. > > - > > config HAVE_PERF_EVENTS > > bool > > help > > That's fine, but what happens to existing defconfigs then ? > > $ git grep -w CONFIG_EMBEDDED arch/powerpc/ > arch/powerpc/configs/40x/klondike_defconfig:CONFIG_EMBEDDED=y > arch/powerpc/configs/44x/fsp2_defconfig:CONFIG_EMBEDDED=y > arch/powerpc/configs/52xx/tqm5200_defconfig:CONFIG_EMBEDDED=y > arch/powerpc/configs/mgcoge_defconfig:CONFIG_EMBEDDED=y > arch/powerpc/configs/microwatt_defconfig:CONFIG_EMBEDDED=y > arch/powerpc/configs/ps3_defconfig:CONFIG_EMBEDDED=y > > They need to get converted to selecting CONFIG_EXPERT instead. > > And that needs to be done before you remove CONFIG_EMBEDDED. > Agree. Let us get the first five patches included. Then adjust the configs for all architectures and then delete the CONFIG_EMBEDDED. Lukas
Re: [PATCH] ppc: select HAVE_PATA_PLATFORM in PPC instead of creating a PPC dependency
On Fri, Sep 9, 2022 at 11:04 AM Lukas Bulwahn wrote:
>
> Commit cc18e0fea790 ("LIBATA: Add HAVE_PATA_PLATFORM to select
> PATA_PLATFORM driver") introduces config HAVE_PATA_PLATFORM, and expects
> that all architectures simply select this config when the architecture
> supports using the PATA_PLATFORM driver.
>
> This is properly implemented already for all architectures except for the
> powerpc architecture. Implement this for powerpc now.
>
> Adjust the config of the powerpc architecture to use the config
> HAVE_PATA_PLATFORM and simplify the config PATA_PLATFORM to not mention
> any specific architecture anymore.
>
> Signed-off-by: Lukas Bulwahn
Please ignore this patch and pick:
https://lore.kernel.org/linuxppc-dev/20220909090343.21886-1-lukas.bulw...@gmail.com/
Lukas
> ---
> arch/powerpc/Kconfig | 1 +
> drivers/ata/Kconfig | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index 39d71d7701bd..2575e21b6e6b 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -237,6 +237,7 @@ config PPC
> select HAVE_MOD_ARCH_SPECIFIC
> select HAVE_NMI if PERF_EVENTS || (PPC64 &&
> PPC_BOOK3S)
> select HAVE_OPTPROBES
> + select HAVE_PATA_PLATFORM
> select HAVE_PERF_EVENTS
> select HAVE_PERF_EVENTS_NMI if PPC64
> select HAVE_PERF_REGS
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 1c9f4fb2595d..ed3547165528 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -1103,7 +1103,7 @@ config PATA_PCMCIA
>
> config PATA_PLATFORM
> tristate "Generic platform device PATA support"
> - depends on EXPERT || PPC || HAVE_PATA_PLATFORM
> + depends on EXPERT || HAVE_PATA_PLATFORM
> help
> This option enables support for generic directly connected ATA
> devices commonly found on embedded systems.
> --
> 2.17.1
>
Re: [PATCH] ppc: select HAVE_PATA_PLATFORM in PPC instead of creating a PPC dependency
On Fri, Sep 9, 2022 at 10:55 AM Lukas Bulwahn wrote:
>
> Commit cc18e0fea790 ("LIBATA: Add HAVE_PATA_PLATFORM to select
> PATA_PLATFORM driver") introduces config HAVE_PATA_PLATFORM, and expects
> that all architectures simply select this config when the architecture
> supports using the PATA_PLATFORM driver.
>
> This is properly implemented already for all architectures except for the
> powerpc architecture. Implement this for powerpc now.
>
> Adjust the config of the powerpc architecture to use the config
> HAVE_PATA_PLATFORM and simplify the config PATA_PLATFORM to not mention
> any specific architecture anymore.
>
> Signed-off-by: Lukas Bulwahn
Please ignore this patch and pick:
https://lore.kernel.org/linuxppc-dev/20220909090343.21886-1-lukas.bulw...@gmail.com/
Lukas
> ---
> arch/powerpc/Kconfig | 1 +
> drivers/ata/Kconfig | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index 39d71d7701bd..2575e21b6e6b 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -237,6 +237,7 @@ config PPC
> select HAVE_MOD_ARCH_SPECIFIC
> select HAVE_NMI if PERF_EVENTS || (PPC64 &&
> PPC_BOOK3S)
> select HAVE_OPTPROBES
> + select HAVE_PATA_PLATFORM
> select HAVE_PERF_EVENTS
> select HAVE_PERF_EVENTS_NMI if PPC64
> select HAVE_PERF_REGS
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 1c9f4fb2595d..ed3547165528 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -1103,7 +1103,7 @@ config PATA_PCMCIA
>
> config PATA_PLATFORM
> tristate "Generic platform device PATA support"
> - depends on EXPERT || PPC || HAVE_PATA_PLATFORM
> + depends on EXPERT || HAVE_PATA_PLATFORM
> help
> This option enables support for generic directly connected ATA
> devices commonly found on embedded systems.
> --
> 2.17.1
>
[PATCH] ppc: select HAVE_PATA_PLATFORM in PPC instead of creating a PPC dependency
Commit cc18e0fea790 ("LIBATA: Add HAVE_PATA_PLATFORM to select
PATA_PLATFORM driver") introduces config HAVE_PATA_PLATFORM, and expects
that all architectures simply select this config when the architecture
supports using the PATA_PLATFORM driver.
This is properly implemented already for all architectures except for the
powerpc architecture. Implement this for powerpc now.
Adjust the config of the powerpc architecture to use the config
HAVE_PATA_PLATFORM and simplify the config PATA_PLATFORM to not mention
any specific architecture anymore.
Signed-off-by: Lukas Bulwahn
---
arch/powerpc/Kconfig | 1 +
drivers/ata/Kconfig | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 39d71d7701bd..2575e21b6e6b 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -237,6 +237,7 @@ config PPC
select HAVE_MOD_ARCH_SPECIFIC
select HAVE_NMI if PERF_EVENTS || (PPC64 &&
PPC_BOOK3S)
select HAVE_OPTPROBES
+ select HAVE_PATA_PLATFORM
select HAVE_PERF_EVENTS
select HAVE_PERF_EVENTS_NMI if PPC64
select HAVE_PERF_REGS
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 1c9f4fb2595d..ed3547165528 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -1103,7 +1103,7 @@ config PATA_PCMCIA
config PATA_PLATFORM
tristate "Generic platform device PATA support"
- depends on EXPERT || PPC || HAVE_PATA_PLATFORM
+ depends on EXPERT || HAVE_PATA_PLATFORM
help
This option enables support for generic directly connected ATA
devices commonly found on embedded systems.
--
2.17.1
[PATCH v2] powerpc: select HAVE_PATA_PLATFORM in PPC instead of creating a PPC dependency
Commit cc18e0fea790 ("LIBATA: Add HAVE_PATA_PLATFORM to select
PATA_PLATFORM driver") introduces config HAVE_PATA_PLATFORM, and expects
that all architectures simply select this config when the architecture
supports using the PATA_PLATFORM driver.
This is properly implemented already for all architectures except for the
powerpc architecture. Implement this for powerpc now.
Adjust the config of the powerpc architecture to use the config
HAVE_PATA_PLATFORM and simplify the config PATA_PLATFORM to not mention
any specific architecture anymore.
Signed-off-by: Lukas Bulwahn
---
arch/powerpc/Kconfig | 1 +
drivers/ata/Kconfig | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 39d71d7701bd..2575e21b6e6b 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -237,6 +237,7 @@ config PPC
select HAVE_MOD_ARCH_SPECIFIC
select HAVE_NMI if PERF_EVENTS || (PPC64 &&
PPC_BOOK3S)
select HAVE_OPTPROBES
+ select HAVE_PATA_PLATFORM
select HAVE_PERF_EVENTS
select HAVE_PERF_EVENTS_NMI if PPC64
select HAVE_PERF_REGS
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 1c9f4fb2595d..ed3547165528 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -1103,7 +1103,7 @@ config PATA_PCMCIA
config PATA_PLATFORM
tristate "Generic platform device PATA support"
- depends on EXPERT || PPC || HAVE_PATA_PLATFORM
+ depends on EXPERT || HAVE_PATA_PLATFORM
help
This option enables support for generic directly connected ATA
devices commonly found on embedded systems.
--
2.17.1
[PATCH] ppc: select HAVE_PATA_PLATFORM in PPC instead of creating a PPC dependency
Commit cc18e0fea790 ("LIBATA: Add HAVE_PATA_PLATFORM to select
PATA_PLATFORM driver") introduces config HAVE_PATA_PLATFORM, and expects
that all architectures simply select this config when the architecture
supports using the PATA_PLATFORM driver.
This is properly implemented already for all architectures except for the
powerpc architecture. Implement this for powerpc now.
Adjust the config of the powerpc architecture to use the config
HAVE_PATA_PLATFORM and simplify the config PATA_PLATFORM to not mention
any specific architecture anymore.
Signed-off-by: Lukas Bulwahn
---
arch/powerpc/Kconfig | 1 +
drivers/ata/Kconfig | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 39d71d7701bd..2575e21b6e6b 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -237,6 +237,7 @@ config PPC
select HAVE_MOD_ARCH_SPECIFIC
select HAVE_NMI if PERF_EVENTS || (PPC64 &&
PPC_BOOK3S)
select HAVE_OPTPROBES
+ select HAVE_PATA_PLATFORM
select HAVE_PERF_EVENTS
select HAVE_PERF_EVENTS_NMI if PPC64
select HAVE_PERF_REGS
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 1c9f4fb2595d..ed3547165528 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -1103,7 +1103,7 @@ config PATA_PCMCIA
config PATA_PLATFORM
tristate "Generic platform device PATA support"
- depends on EXPERT || PPC || HAVE_PATA_PLATFORM
+ depends on EXPERT || HAVE_PATA_PLATFORM
help
This option enables support for generic directly connected ATA
devices commonly found on embedded systems.
--
2.17.1
[PATCH] powerpc/ptdump: fix conversion to GENERIC_PTDUMP
Commit e084728393a5 ("powerpc/ptdump: Convert powerpc to GENERIC_PTDUMP")
replaces the use of the powerpc-specific config PPC_DEBUG_WX by the
generic DEBUG_WX. The commit misses the use of PPC_DEBUG_WX in the
function note_prot_wx().
Replace this last occurrence of PPC_DEBUG_WX to complete the conversion.
This issue is identified with the script ./scripts/checkkconfigsymbols.py.
Fixes: e084728393a5 ("powerpc/ptdump: Convert powerpc to GENERIC_PTDUMP")
Signed-off-by: Lukas Bulwahn
---
arch/powerpc/mm/ptdump/ptdump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/mm/ptdump/ptdump.c b/arch/powerpc/mm/ptdump/ptdump.c
index 031956d0ee84..be120e09aa3e 100644
--- a/arch/powerpc/mm/ptdump/ptdump.c
+++ b/arch/powerpc/mm/ptdump/ptdump.c
@@ -183,7 +183,7 @@ static void note_prot_wx(struct pg_state *st, unsigned long
addr)
{
pte_t pte = __pte(st->current_flags);
- if (!IS_ENABLED(CONFIG_PPC_DEBUG_WX) || !st->check_wx)
+ if (!IS_ENABLED(CONFIG_DEBUG_WX) || !st->check_wx)
return;
if (!pte_write(pte) || !pte_exec(pte))
--
2.17.1
code conditional on non-existing PPC_EARLY_DEBUG_MICROWATT.
Dear Benjamin, dear Paul, dear Michael,
with commit 48b545b8018d ("powerpc/microwatt: Use standard 16550 UART
for console"), you have some code in arch/powerpc/kernel/udbg_16550.c,
conditional on the Kconfig symbol PPC_EARLY_DEBUG_MICROWATT. However,
since then, the definition of this Kconfig symbol was never introduced
to the mainline repository or current linux-next, nor am I finding any
pending patch for that.
Are you going to add this config definition soon? Or did you identify
that this setup code in udbg_16550.c is not actually needed and can we
simply drop this code again?
This issue was identified with the script ./scripts/checkkconfigsymbols.py.
Best regards,
Lukas
[PATCH v2 2/2] powerpc: rectify selection to ARCH_ENABLE_SPLIT_PMD_PTLOCK
Commit 66f24fa766e3 ("mm: drop redundant ARCH_ENABLE_SPLIT_PMD_PTLOCK")
selects the non-existing config ARCH_ENABLE_PMD_SPLIT_PTLOCK in
./arch/powerpc/platforms/Kconfig.cputype, but clearly it intends to select
ARCH_ENABLE_SPLIT_PMD_PTLOCK here (notice the word swapping!), as this
commit does select that for all other architectures.
Rectify selection to ARCH_ENABLE_SPLIT_PMD_PTLOCK instead.
Fixes: 66f24fa766e3 ("mm: drop redundant ARCH_ENABLE_SPLIT_PMD_PTLOCK")
Signed-off-by: Lukas Bulwahn
---
arch/powerpc/platforms/Kconfig.cputype | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/Kconfig.cputype
b/arch/powerpc/platforms/Kconfig.cputype
index 6794145603de..a208997ade88 100644
--- a/arch/powerpc/platforms/Kconfig.cputype
+++ b/arch/powerpc/platforms/Kconfig.cputype
@@ -98,7 +98,7 @@ config PPC_BOOK3S_64
select PPC_HAVE_PMU_SUPPORT
select HAVE_ARCH_TRANSPARENT_HUGEPAGE
select ARCH_ENABLE_HUGEPAGE_MIGRATION if HUGETLB_PAGE && MIGRATION
- select ARCH_ENABLE_PMD_SPLIT_PTLOCK
+ select ARCH_ENABLE_SPLIT_PMD_PTLOCK
select ARCH_ENABLE_THP_MIGRATION if TRANSPARENT_HUGEPAGE
select ARCH_SUPPORTS_HUGETLBFS
select ARCH_SUPPORTS_NUMA_BALANCING
--
2.26.2
[PATCH v2 0/2] Kconfig symbol fixes on powerpc
Dear powerpc maintainers, The script ./scripts/checkkconfigsymbols.py warns on invalid references to Kconfig symbols (often, minor typos, name confusions or outdated references). This patch series addresses all issues reported by ./scripts/checkkconfigsymbols.py in ./drivers/usb/ for Kconfig and Makefile files. Issues in the Kconfig and Makefile files indicate some shortcomings in the overall build definitions, and often are true actionable issues to address. These issues can be identified and filtered by: ./scripts/checkkconfigsymbols.py | grep -E "arch/powerpc/.*(Kconfig|Makefile)" -B 1 -A 1 After applying this patch series on linux-next (next-20210817), the command above yields just two false positives (SHELL, r13) due to tool shortcomings. As these two patches are fixes, please consider if they are suitable for backporting to stable. v1 -> v2: Followed Christophe Leroy's comment and drop the obsolete select. Lukas Lukas Bulwahn (2): powerpc: kvm: remove obsolete and unneeded select powerpc: rectify selection to ARCH_ENABLE_SPLIT_PMD_PTLOCK arch/powerpc/kvm/Kconfig | 1 - arch/powerpc/platforms/Kconfig.cputype | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) -- 2.26.2
[PATCH v2 1/2] powerpc: kvm: remove obsolete and unneeded select
Commit a278e7ea608b ("powerpc: Fix compile issue with force DAWR")
selects the non-existing config PPC_DAWR_FORCE_ENABLE for config
KVM_BOOK3S_64_HANDLER. As this commit also introduces a config PPC_DAWR
and this config PPC_DAWR is selected with PPC if PPC64, there is no
need for any further select in the KVM_BOOK3S_64_HANDLER.
Remove an obsolete and unneeded select in config KVM_BOOK3S_64_HANDLER.
The issue was identified with ./scripts/checkkconfigsymbols.py.
Fixes: a278e7ea608b ("powerpc: Fix compile issue with force DAWR")
Signed-off-by: Lukas Bulwahn
---
arch/powerpc/kvm/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
index e45644657d49..ff581d70f20c 100644
--- a/arch/powerpc/kvm/Kconfig
+++ b/arch/powerpc/kvm/Kconfig
@@ -38,7 +38,6 @@ config KVM_BOOK3S_32_HANDLER
config KVM_BOOK3S_64_HANDLER
bool
select KVM_BOOK3S_HANDLER
- select PPC_DAWR_FORCE_ENABLE
config KVM_BOOK3S_PR_POSSIBLE
bool
--
2.26.2
Re: [PATCH 1/2] powerpc: kvm: rectify selection to PPC_DAWR
On Thu, Aug 19, 2021 at 11:45 AM Christophe Leroy
wrote:
>
>
>
> Le 19/08/2021 à 11:32, Lukas Bulwahn a écrit :
> > Commit a278e7ea608b ("powerpc: Fix compile issue with force DAWR")
> > selects the non-existing config PPC_DAWR_FORCE_ENABLE for config
> > KVM_BOOK3S_64_HANDLER. As this commit also introduces a config PPC_DAWR,
> > it probably intends to select PPC_DAWR instead.
> >
> > Rectify the selection in config KVM_BOOK3S_64_HANDLER to PPC_DAWR.
> >
> > The issue was identified with ./scripts/checkkconfigsymbols.py.
> >
> > Fixes: a278e7ea608b ("powerpc: Fix compile issue with force DAWR")
> > Signed-off-by: Lukas Bulwahn
> > ---
> > arch/powerpc/kvm/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
> > index e45644657d49..aa29ea56c80a 100644
> > --- a/arch/powerpc/kvm/Kconfig
> > +++ b/arch/powerpc/kvm/Kconfig
> > @@ -38,7 +38,7 @@ config KVM_BOOK3S_32_HANDLER
> > config KVM_BOOK3S_64_HANDLER
> > bool
> > select KVM_BOOK3S_HANDLER
> > - select PPC_DAWR_FORCE_ENABLE
> > + select PPC_DAWR
>
> That's useless, see
> https://elixir.bootlin.com/linux/v5.14-rc6/source/arch/powerpc/Kconfig#L267
>
> In arch/powerpc/Kconfig, you already have:
>
> select PPC_DAWR if PPC64
>
Ah, I see. Then, it is just a needless and non-effective select here,
and then select can be deleted completely.
I will send a patch series v2.
Lukas
[PATCH 2/2] powerpc: rectify selection to ARCH_ENABLE_SPLIT_PMD_PTLOCK
Commit 66f24fa766e3 ("mm: drop redundant ARCH_ENABLE_SPLIT_PMD_PTLOCK")
selects the non-existing config ARCH_ENABLE_PMD_SPLIT_PTLOCK in
./arch/powerpc/platforms/Kconfig.cputype, but clearly it intends to select
ARCH_ENABLE_SPLIT_PMD_PTLOCK here (notice the word swapping!), as this
commit does select that for all other architectures.
Rectify selection to ARCH_ENABLE_SPLIT_PMD_PTLOCK instead.
Fixes: 66f24fa766e3 ("mm: drop redundant ARCH_ENABLE_SPLIT_PMD_PTLOCK")
Signed-off-by: Lukas Bulwahn
---
arch/powerpc/platforms/Kconfig.cputype | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/Kconfig.cputype
b/arch/powerpc/platforms/Kconfig.cputype
index 6794145603de..a208997ade88 100644
--- a/arch/powerpc/platforms/Kconfig.cputype
+++ b/arch/powerpc/platforms/Kconfig.cputype
@@ -98,7 +98,7 @@ config PPC_BOOK3S_64
select PPC_HAVE_PMU_SUPPORT
select HAVE_ARCH_TRANSPARENT_HUGEPAGE
select ARCH_ENABLE_HUGEPAGE_MIGRATION if HUGETLB_PAGE && MIGRATION
- select ARCH_ENABLE_PMD_SPLIT_PTLOCK
+ select ARCH_ENABLE_SPLIT_PMD_PTLOCK
select ARCH_ENABLE_THP_MIGRATION if TRANSPARENT_HUGEPAGE
select ARCH_SUPPORTS_HUGETLBFS
select ARCH_SUPPORTS_NUMA_BALANCING
--
2.26.2
[PATCH 1/2] powerpc: kvm: rectify selection to PPC_DAWR
Commit a278e7ea608b ("powerpc: Fix compile issue with force DAWR")
selects the non-existing config PPC_DAWR_FORCE_ENABLE for config
KVM_BOOK3S_64_HANDLER. As this commit also introduces a config PPC_DAWR,
it probably intends to select PPC_DAWR instead.
Rectify the selection in config KVM_BOOK3S_64_HANDLER to PPC_DAWR.
The issue was identified with ./scripts/checkkconfigsymbols.py.
Fixes: a278e7ea608b ("powerpc: Fix compile issue with force DAWR")
Signed-off-by: Lukas Bulwahn
---
arch/powerpc/kvm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
index e45644657d49..aa29ea56c80a 100644
--- a/arch/powerpc/kvm/Kconfig
+++ b/arch/powerpc/kvm/Kconfig
@@ -38,7 +38,7 @@ config KVM_BOOK3S_32_HANDLER
config KVM_BOOK3S_64_HANDLER
bool
select KVM_BOOK3S_HANDLER
- select PPC_DAWR_FORCE_ENABLE
+ select PPC_DAWR
config KVM_BOOK3S_PR_POSSIBLE
bool
--
2.26.2
[PATCH 0/2] Kconfig symbol fixes on powerpc
Dear powerpc maintainers, The script ./scripts/checkkconfigsymbols.py warns on invalid references to Kconfig symbols (often, minor typos, name confusions or outdated references). This patch series addresses all issues reported by ./scripts/checkkconfigsymbols.py in ./drivers/usb/ for Kconfig and Makefile files. Issues in the Kconfig and Makefile files indicate some shortcomings in the overall build definitions, and often are true actionable issues to address. These issues can be identified and filtered by: ./scripts/checkkconfigsymbols.py | grep -E "arch/powerpc/.*(Kconfig|Makefile)" -B 1 -A 1 After applying this patch series on linux-next (next-20210817), the command above yields just two false positives (SHELL, r13) due to tool shortcomings. As these two patches are fixes, please consider if they are suitable for backporting to stable. Lukas Lukas Bulwahn (2): powerpc: kvm: rectify selection to PPC_DAWR powerpc: rectify selection to ARCH_ENABLE_SPLIT_PMD_PTLOCK arch/powerpc/kvm/Kconfig | 2 +- arch/powerpc/platforms/Kconfig.cputype | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 2.26.2
[PATCH] arch: Kconfig: clean up obsolete use of HAVE_IDE
The arch-specific Kconfig files use HAVE_IDE to indicate if IDE is
supported.
As IDE support and the HAVE_IDE config vanishes with commit b7fb14d3ac63
("ide: remove the legacy ide driver"), there is no need to mention
HAVE_IDE in all those arch-specific Kconfig files.
The issue was identified with ./scripts/checkkconfigsymbols.py.
Fixes: b7fb14d3ac63 ("ide: remove the legacy ide driver")
Suggested-by: Randy Dunlap
Signed-off-by: Lukas Bulwahn
---
arch/alpha/Kconfig| 1 -
arch/arm/Kconfig | 6 --
arch/arm/mach-davinci/Kconfig | 1 -
arch/h8300/Kconfig.cpu| 1 -
arch/ia64/Kconfig | 1 -
arch/m68k/Kconfig | 1 -
arch/mips/Kconfig | 1 -
arch/parisc/Kconfig | 1 -
arch/powerpc/Kconfig | 1 -
arch/sh/Kconfig | 1 -
arch/sparc/Kconfig| 1 -
arch/x86/Kconfig | 1 -
arch/xtensa/Kconfig | 1 -
13 files changed, 18 deletions(-)
diff --git a/arch/alpha/Kconfig b/arch/alpha/Kconfig
index 77d3280dc678..a6d4c2f744e3 100644
--- a/arch/alpha/Kconfig
+++ b/arch/alpha/Kconfig
@@ -14,7 +14,6 @@ config ALPHA
select PCI_SYSCALL if PCI
select HAVE_AOUT
select HAVE_ASM_MODVERSIONS
- select HAVE_IDE
select HAVE_PCSPKR_PLATFORM
select HAVE_PERF_EVENTS
select NEED_DMA_MAP_STATE
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 82f908fa5676..2fb7012c3246 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -95,7 +95,6 @@ config ARM
select HAVE_FUNCTION_TRACER if !XIP_KERNEL
select HAVE_GCC_PLUGINS
select HAVE_HW_BREAKPOINT if PERF_EVENTS && (CPU_V6 || CPU_V6K ||
CPU_V7)
- select HAVE_IDE if PCI || ISA || PCMCIA
select HAVE_IRQ_TIME_ACCOUNTING
select HAVE_KERNEL_GZIP
select HAVE_KERNEL_LZ4
@@ -361,7 +360,6 @@ config ARCH_FOOTBRIDGE
bool "FootBridge"
select CPU_SA110
select FOOTBRIDGE
- select HAVE_IDE
select NEED_MACH_IO_H if !MMU
select NEED_MACH_MEMORY_H
help
@@ -430,7 +428,6 @@ config ARCH_PXA
select GENERIC_IRQ_MULTI_HANDLER
select GPIO_PXA
select GPIOLIB
- select HAVE_IDE
select IRQ_DOMAIN
select PLAT_PXA
select SPARSE_IRQ
@@ -446,7 +443,6 @@ config ARCH_RPC
select ARM_HAS_SG_CHAIN
select CPU_SA110
select FIQ
- select HAVE_IDE
select HAVE_PATA_PLATFORM
select ISA_DMA_API
select LEGACY_TIMER_TICK
@@ -469,7 +465,6 @@ config ARCH_SA1100
select CPU_SA1100
select GENERIC_IRQ_MULTI_HANDLER
select GPIOLIB
- select HAVE_IDE
select IRQ_DOMAIN
select ISA
select NEED_MACH_MEMORY_H
@@ -505,7 +500,6 @@ config ARCH_OMAP1
select GENERIC_IRQ_CHIP
select GENERIC_IRQ_MULTI_HANDLER
select GPIOLIB
- select HAVE_IDE
select HAVE_LEGACY_CLK
select IRQ_DOMAIN
select NEED_MACH_IO_H if PCCARD
diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
index de11030748d0..1d3aef84287d 100644
--- a/arch/arm/mach-davinci/Kconfig
+++ b/arch/arm/mach-davinci/Kconfig
@@ -9,7 +9,6 @@ menuconfig ARCH_DAVINCI
select PM_GENERIC_DOMAINS_OF if PM && OF
select REGMAP_MMIO
select RESET_CONTROLLER
- select HAVE_IDE
select PINCTRL_SINGLE
if ARCH_DAVINCI
diff --git a/arch/h8300/Kconfig.cpu b/arch/h8300/Kconfig.cpu
index 2b9cbaf41cd0..e4467d40107d 100644
--- a/arch/h8300/Kconfig.cpu
+++ b/arch/h8300/Kconfig.cpu
@@ -44,7 +44,6 @@ config H8300_H8MAX
bool "H8MAX"
select H83069
select RAMKERNEL
- select HAVE_IDE
help
H8MAX Evaluation Board Support
More Information. (Japanese Only)
diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig
index cf425c2c63af..4993c7ac7ff6 100644
--- a/arch/ia64/Kconfig
+++ b/arch/ia64/Kconfig
@@ -25,7 +25,6 @@ config IA64
select HAVE_ASM_MODVERSIONS
select HAVE_UNSTABLE_SCHED_CLOCK
select HAVE_EXIT_THREAD
- select HAVE_IDE
select HAVE_KPROBES
select HAVE_KRETPROBES
select HAVE_FTRACE_MCOUNT_RECORD
diff --git a/arch/m68k/Kconfig b/arch/m68k/Kconfig
index 96989ad46f66..d632a1d576f9 100644
--- a/arch/m68k/Kconfig
+++ b/arch/m68k/Kconfig
@@ -23,7 +23,6 @@ config M68K
select HAVE_DEBUG_BUGVERBOSE
select HAVE_EFFICIENT_UNALIGNED_ACCESS if !CPU_HAS_NO_UNALIGNED
select HAVE_FUTEX_CMPXCHG if MMU && FUTEX
- select HAVE_IDE
select HAVE_MOD_ARCH_SPECIFIC
select HAVE_UID16
select MMU_GATHER_NO_RANGE if MMU
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index cee6087cd686..6dfb27d531dd 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -71,7 +71,6 @@ config MIPS
select HAVE_FUNCTION_TRACER
select HAVE_GCC_PLUGINS
[PATCH] MAINTAINERS: Update remaining @linux.vnet.ibm.com addresses
Paul McKenney attempted to update all email addresses @linux.vnet.ibm.com
to @linux.ibm.com in commit 1dfddcdb95c4
("MAINTAINERS: Update from @linux.vnet.ibm.com to @linux.ibm.com"), but
some still remained.
We update the remaining email addresses in MAINTAINERS, hopefully finally
catching all cases for good.
Fixes: 1dfddcdb95c4 ("MAINTAINERS: Update from @linux.vnet.ibm.com to
@linux.ibm.com")
Signed-off-by: Lukas Bulwahn
---
Tyrel, please take this patch. Thanks.
MAINTAINERS | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 2359e12e4c41..454b3cf36aa4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7439,14 +7439,14 @@ F: drivers/crypto/vmx/ghash*
F: drivers/crypto/vmx/ppc-xlate.pl
IBM Power PCI Hotplug Driver for RPA-compliant PPC64 platform
-M: Tyrel Datwyler
+M: Tyrel Datwyler
L: linux-...@vger.kernel.org
L: linuxppc-dev@lists.ozlabs.org
S: Supported
F: drivers/pci/hotplug/rpaphp*
IBM Power IO DLPAR Driver for RPA-compliant PPC64 platform
-M: Tyrel Datwyler
+M: Tyrel Datwyler
L: linux-...@vger.kernel.org
L: linuxppc-dev@lists.ozlabs.org
S: Supported
@@ -10388,7 +10388,7 @@ F: arch/arm/mach-mmp/
MMU GATHER AND TLB INVALIDATION
M: Will Deacon
-M: "Aneesh Kumar K.V"
+M: "Aneesh Kumar K.V"
M: Andrew Morton
M: Nick Piggin
M: Peter Zijlstra
--
2.17.1
