Re: [PATCH -next 11/13] hwrng: st - use devm_platform_ioremap_resource() to simplify code
Hi
On 10/16/19 12:46 PM, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing
> ---
> drivers/char/hw_random/st-rng.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/char/hw_random/st-rng.c b/drivers/char/hw_random/st-rng.c
> index 8634483..783c24e 100644
> --- a/drivers/char/hw_random/st-rng.c
> +++ b/drivers/char/hw_random/st-rng.c
> @@ -72,7 +72,6 @@ static int st_rng_read(struct hwrng *rng, void *data,
> size_t max, bool wait)
> static int st_rng_probe(struct platform_device *pdev)
> {
> struct st_rng_data *ddata;
> - struct resource *res;
> struct clk *clk;
> void __iomem *base;
> int ret;
> @@ -81,8 +80,7 @@ static int st_rng_probe(struct platform_device *pdev)
> if (!ddata)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - base = devm_ioremap_resource(&pdev->dev, res);
> + base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(base))
> return PTR_ERR(base);
>
Reviewed-by: Patrice Chotard
Thanks
Re: [PATCH v2 29/34] dt-bindings: arm: Convert ST STi board/soc bindings to json-schema
Hi Rob On 12/3/18 10:32 PM, Rob Herring wrote: > Convert ST STi SoC bindings to DT schema format using json-schema. > > Cc: Patrice Chotard > Cc: Mark Rutland > Cc: devicet...@vger.kernel.org > Signed-off-by: Rob Herring > --- > Documentation/devicetree/bindings/arm/sti.txt | 23 --- > .../devicetree/bindings/arm/sti.yaml | 23 +++ > 2 files changed, 23 insertions(+), 23 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/arm/sti.txt > create mode 100644 Documentation/devicetree/bindings/arm/sti.yaml > > diff --git a/Documentation/devicetree/bindings/arm/sti.txt > b/Documentation/devicetree/bindings/arm/sti.txt > deleted file mode 100644 > index 8d27f6b084c7.. > --- a/Documentation/devicetree/bindings/arm/sti.txt > +++ /dev/null > @@ -1,23 +0,0 @@ > -ST STi Platforms Device Tree Bindings > > - > -Boards with the ST STiH415 SoC shall have the following properties: > -Required root node property: > -compatible = "st,stih415"; > - > -Boards with the ST STiH416 SoC shall have the following properties: > -Required root node property: > -compatible = "st,stih416"; > - > -Boards with the ST STiH407 SoC shall have the following properties: > -Required root node property: > -compatible = "st,stih407"; > - > -Boards with the ST STiH410 SoC shall have the following properties: > -Required root node property: > -compatible = "st,stih410"; > - > -Boards with the ST STiH418 SoC shall have the following properties: > -Required root node property: > -compatible = "st,stih418"; > - > diff --git a/Documentation/devicetree/bindings/arm/sti.yaml > b/Documentation/devicetree/bindings/arm/sti.yaml > new file mode 100644 > index ..47f9b8eebaa0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/sti.yaml > @@ -0,0 +1,23 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/sti.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ST STi Platforms Device Tree Bindings > + > +maintainers: > + - Patrice Chotard > + > +properties: > + $nodename: > +const: '/' > + compatible: > +items: > + - enum: > + - st,stih415 > + - st,stih416 > + - st,stih407 > + - st,stih410 > + - st,stih418 > +... > Acked-by: Patrice Chotard Thanks
Re: [PATCH 32/36] dt-bindings: arm: Convert ST STi board/soc bindings to json-schema
Hi Rob On 10/05/2018 06:58 PM, Rob Herring wrote: > Convert ST STi SoC bindings to DT schema format using json-schema. > > Cc: Patrice Chotard > Cc: Mark Rutland > Cc: devicet...@vger.kernel.org > Signed-off-by: Rob Herring > --- > Documentation/devicetree/bindings/arm/sti.txt | 23 --- > .../devicetree/bindings/arm/sti.yaml | 23 +++ > 2 files changed, 23 insertions(+), 23 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/arm/sti.txt > create mode 100644 Documentation/devicetree/bindings/arm/sti.yaml > > diff --git a/Documentation/devicetree/bindings/arm/sti.txt > b/Documentation/devicetree/bindings/arm/sti.txt > deleted file mode 100644 > index 8d27f6b084c7.. > --- a/Documentation/devicetree/bindings/arm/sti.txt > +++ /dev/null > @@ -1,23 +0,0 @@ > -ST STi Platforms Device Tree Bindings > > - > -Boards with the ST STiH415 SoC shall have the following properties: > -Required root node property: > -compatible = "st,stih415"; > - > -Boards with the ST STiH416 SoC shall have the following properties: > -Required root node property: > -compatible = "st,stih416"; > - > -Boards with the ST STiH407 SoC shall have the following properties: > -Required root node property: > -compatible = "st,stih407"; > - > -Boards with the ST STiH410 SoC shall have the following properties: > -Required root node property: > -compatible = "st,stih410"; > - > -Boards with the ST STiH418 SoC shall have the following properties: > -Required root node property: > -compatible = "st,stih418"; > - > diff --git a/Documentation/devicetree/bindings/arm/sti.yaml > b/Documentation/devicetree/bindings/arm/sti.yaml > new file mode 100644 > index ..10814334cfc9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/sti.yaml > @@ -0,0 +1,23 @@ > +# SPDX-License-Identifier: None > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/bindings/arm/sti.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ST STi Platforms Device Tree Bindings > + > +maintainers: > + - Maxime Coquelin Maxime has left STMicroelectronics, you can replace its email by mine Patrice Chotard Thanks Patrice > + > +properties: > + $nodename: > +const: '/' > + compatible: > +items: > + - enum: > + - st,stih415 > + - st,stih416 > + - st,stih407 > + - st,stih410 > + - st,stih418 > +... >
Re: [PATCH v3] watchdog: add SPDX identifiers for watchdog subsystem
HI Marcus On 02/21/2018 01:27 PM, Marcus Folkesson wrote: > - Add SPDX identifier > - Remove boiler plate license text > - If MODULE_LICENSE and boiler plate does not match, go for boiler plate >license > > Signed-off-by: Marcus Folkesson > Acked-by: Adam Thomson > Acked-by: Charles Keepax > Acked-by: Mans Rullgard > Acked-by: Matthias Brugger > Acked-by: Michal Simek > Acked-by: Neil Armstrong > Acked-by: Nicolas Ferre > Acked-by: Thierry Reding > Reviewed-by: Eric Anholt > --- > > Notes: > v3: > - Keep license text for ebc-c384_wdt > v2: > - Put back removed copyright texts for meson_gxbb_wdt and coh901327_wdt > - Change to BSD-3-Clause for meson_gxbb_wdt > v1: Please have an extra look at meson_gxbb_wdt.c > [...] > diff --git a/drivers/watchdog/st_lpc_wdt.c b/drivers/watchdog/st_lpc_wdt.c > index e6100e447dd8..177829b379da 100644 > --- a/drivers/watchdog/st_lpc_wdt.c > +++ b/drivers/watchdog/st_lpc_wdt.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-2.0+ > /* >* ST's LPC Watchdog >* > @@ -5,11 +6,6 @@ >* >* Author: David Paris for STMicroelectronics >* Lee Jones for STMicroelectronics > - * > - * This program is free software; you can redistribute it and/or > - * modify it under the terms of the GNU General Public Licence > - * as published by the Free Software Foundation; either version > - * 2 of the Licence, or (at your option) any later version. >*/ > For st_lpc_wdt.c Acked-by: Patrice Chotard Thanks
Re: [PATCH] watchdog: add SPDX identifiers for watchdog subsystem
Hi Marcus On 02/20/2018 10:31 AM, Marcus Folkesson wrote: > - Add SPDX identifier > - Remove boiler plate license text > - If MODULE_LICENSE and boiler plate does not match, go for boiler plate >license > > Signed-off-by: Marcus Folkesson > --- > > Notes: > v1: Please have an extra look at meson_gxbb_wdt.c > [...] > diff --git a/drivers/watchdog/st_lpc_wdt.c b/drivers/watchdog/st_lpc_wdt.c > index e6100e447dd8..177829b379da 100644 > --- a/drivers/watchdog/st_lpc_wdt.c > +++ b/drivers/watchdog/st_lpc_wdt.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-2.0+ > /* >* ST's LPC Watchdog >* > @@ -5,11 +6,6 @@ >* >* Author: David Paris for STMicroelectronics >* Lee Jones for STMicroelectronics > - * > - * This program is free software; you can redistribute it and/or > - * modify it under the terms of the GNU General Public Licence > - * as published by the Free Software Foundation; either version > - * 2 of the Licence, or (at your option) any later version. >*/ > For st_lpc_wdt.c Acked-by: Patrice Chotard Thanks
Re: [PATCH] cpufreq: Convert to using %pOF instead of full_name
On 07/18/2017 11:42 PM, Rob Herring wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
>
> Signed-off-by: Rob Herring
> Cc: "Rafael J. Wysocki"
> Cc: Viresh Kumar
> Cc: Benjamin Herrenschmidt
> Cc: Paul Mackerras
> Cc: Michael Ellerman
> Cc: Patrice Chotard
> Cc: linux...@vger.kernel.org
> Cc: linuxppc-dev@lists.ozlabs.org
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: ker...@stlinux.com
> ---
> drivers/cpufreq/pmac64-cpufreq.c | 2 +-
> drivers/cpufreq/sti-cpufreq.c| 8
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/cpufreq/pmac64-cpufreq.c
> b/drivers/cpufreq/pmac64-cpufreq.c
> index 267e0894c62d..be623dd7b9f2 100644
> --- a/drivers/cpufreq/pmac64-cpufreq.c
> +++ b/drivers/cpufreq/pmac64-cpufreq.c
> @@ -516,7 +516,7 @@ static int __init g5_pm72_cpufreq_init(struct device_node
> *cpunode)
> goto bail;
> }
>
> - DBG("cpufreq: i2c clock chip found: %s\n", hwclock->full_name);
> + DBG("cpufreq: i2c clock chip found: %pOF\n", hwclock);
>
> /* Now get all the platform functions */
> pfunc_cpu_getfreq =
> diff --git a/drivers/cpufreq/sti-cpufreq.c b/drivers/cpufreq/sti-cpufreq.c
> index d2d0430d09d4..47105735df12 100644
> --- a/drivers/cpufreq/sti-cpufreq.c
> +++ b/drivers/cpufreq/sti-cpufreq.c
> @@ -65,8 +65,8 @@ static int sti_cpufreq_fetch_major(void) {
> ret = of_property_read_u32_index(np, "st,syscfg",
>MAJOR_ID_INDEX, &major_offset);
> if (ret) {
> - dev_err(dev, "No major number offset provided in %s [%d]\n",
> - np->full_name, ret);
> + dev_err(dev, "No major number offset provided in %pOF [%d]\n",
> + np, ret);
> return ret;
> }
>
> @@ -92,8 +92,8 @@ static int sti_cpufreq_fetch_minor(void)
>MINOR_ID_INDEX, &minor_offset);
> if (ret) {
> dev_err(dev,
> - "No minor number offset provided %s [%d]\n",
> - np->full_name, ret);
> + "No minor number offset provided %pOF [%d]\n",
> + np, ret);
> return ret;
> }
>
> --
> 2.11.0
>
For ST cpufreq:
Acked-by: Patrice Chotard
Thanks
Re: [STLinux Kernel] [PATCH v2 1/6] ARM: dts: STiH407: DT fix s/interrupts-names/interrupt-names/
On 10/21/2016 12:11 PM, Peter Griffin wrote: > On Fri, 21 Oct 2016, Geert Uytterhoeven wrote: > >> Signed-off-by: Geert Uytterhoeven >> Acked-by: Rob Herring >> --- >> v2: >> - Add Acked-by. >> --- > > Acked-by: Peter Griffin > applied with Peter Acked-by Thanks Geert
Re: [STLinux Kernel] [PATCH] i2c: don't print error when adding adapter fails
On 08/09/2016 01:36 PM, Wolfram Sang wrote: > Since v4.8-rc1, the I2C core will print detailed information when adding an > I2C > adapter fails. So, drivers can skip this now. > > I am still undecided if I apply this as a single patch or break it out. But > for > reviewing, avoiding the patch bomb is probably a good thing. > > Should go via subsystem tree, I'd think. > > Wolfram Sang (1): > i2c: don't print error when adding adapter fails > > drivers/i2c/busses/i2c-st.c | 4 +--- > For i2c-st.c Acked-by: Patrice Chotard Thanks
Re: [PATCH V2] tty: serial: Add const to struct uart_ops declarations
Hi On 04/05/2015 08:24 PM, Joe Perches wrote: These structs can be const, so make them const. Miscellanea: o Add static to struct uart_ops declaration in bfin_sport_uart Signed-off-by: Joe Perches --- [...] for drivers/tty/serial/st-asc.c | 2 +- Acked-by: Patrice Chotard Thanks ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 05/35 linux-next] tty: constify of_device_id array
Hi Fabian On 03/16/2015 08:17 PM, Fabian Frederick wrote: of_device_id is always used as const. (See driver.of_match_table and open firmware functions) Signed-off-by: Fabian Frederick --- drivers/tty/serial/st-asc.c | 2 +- For this driver Acked-by: Patrice Chotard Thanks ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
