[PATCH] crypto: DRBG - select SHA512

[Stephan Mueller]

With the swtich to use HMAC(SHA-512) as the default DRBG type, the
configuration must now also select SHA-512.

Fixes: 9b7b94683a9b "crypto: DRBG - switch to HMAC SHA512 DRBG as default
DRBG"
Reported-by: Sachin Sant 
Signed-off-by: Stephan Mueller 
---
 crypto/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/Kconfig b/crypto/Kconfig
index ca3b02dcbbfa..64b772c5d1c9 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -1768,7 +1768,7 @@ config CRYPTO_DRBG_HMAC
bool
default y
select CRYPTO_HMAC
-   select CRYPTO_SHA256
+   select CRYPTO_SHA512
 
 config CRYPTO_DRBG_HASH
bool "Enable Hash DRBG"
-- 
2.31.1

Re: [PATCH 2/2] crypto: vmx - Adding support for XTS

[Stephan Mueller]

Am Montag, 11. Juli 2016, 16:07:40 CEST schrieb Paulo Flabiano Smorigo:

Hi Paulo,

> From: "Leonidas S. Barbosa" 
> 
> This patch add XTS support using VMX-crypto driver.
> 
> Signed-off-by: Leonidas S. Barbosa 
> Signed-off-by: Paulo Flabiano Smorigo 
> ---
>  drivers/crypto/vmx/Makefile  |   2 +-
>  drivers/crypto/vmx/aes_xts.c | 187
> +++ drivers/crypto/vmx/vmx.c | 
>  2 +
>  3 files changed, 190 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/crypto/vmx/aes_xts.c
> 
> diff --git a/drivers/crypto/vmx/Makefile b/drivers/crypto/vmx/Makefile
> index d28ab96..de6e241 100644
> --- a/drivers/crypto/vmx/Makefile
> +++ b/drivers/crypto/vmx/Makefile
> @@ -1,5 +1,5 @@
>  obj-$(CONFIG_CRYPTO_DEV_VMX_ENCRYPT) += vmx-crypto.o
> -vmx-crypto-objs := vmx.o aesp8-ppc.o ghashp8-ppc.o aes.o aes_cbc.o
> aes_ctr.o ghash.o +vmx-crypto-objs := vmx.o aesp8-ppc.o ghashp8-ppc.o aes.o
> aes_cbc.o aes_ctr.o aes_xts.o ghash.o
> 
>  ifeq ($(CONFIG_CPU_LITTLE_ENDIAN),y)
>  TARGET := linux-ppc64le
> diff --git a/drivers/crypto/vmx/aes_xts.c b/drivers/crypto/vmx/aes_xts.c
> new file mode 100644
> index 000..62e698c
> --- /dev/null
> +++ b/drivers/crypto/vmx/aes_xts.c
> @@ -0,0 +1,187 @@
> +/**
> + * AES XTS routines supporting VMX In-core instructions on Power 8
> + *
> + * Copyright (C) 2015 International Business Machines Inc.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundations; version 2 only.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY of FITNESS FOR A PARTICUPAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
> + *
> + * Author: Leonidas S. Barbosa 
> + */
> +
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +
> +#include "aesp8-ppc.h"
> +
> +struct p8_aes_xts_ctx {
> + struct crypto_blkcipher *fallback;
> + struct aes_key enc_key;
> + struct aes_key dec_key;
> + struct aes_key tweak_key;
> +};
> +
> +static int p8_aes_xts_init(struct crypto_tfm *tfm)
> +{
> + const char *alg;
> + struct crypto_blkcipher *fallback;
> + struct p8_aes_xts_ctx *ctx = crypto_tfm_ctx(tfm);
> +
> + if (!(alg = crypto_tfm_alg_name(tfm))) {
> + printk(KERN_ERR "Failed to get algorithm name.\n");
> + return -ENOENT;
> + }
> +
> + fallback =
> + crypto_alloc_blkcipher(alg, 0, CRYPTO_ALG_NEED_FALLBACK);
> + if (IS_ERR(fallback)) {
> + printk(KERN_ERR
> + "Failed to allocate transformation for '%s': %ld\n",
> + alg, PTR_ERR(fallback));
> + return PTR_ERR(fallback);
> + }
> + printk(KERN_INFO "Using '%s' as fallback implementation.\n",
> + crypto_tfm_alg_driver_name((struct crypto_tfm *) fallback));
> +
> + crypto_blkcipher_set_flags(
> + fallback,
> + crypto_blkcipher_get_flags((struct crypto_blkcipher *)tfm));
> + ctx->fallback = fallback;
> +
> + return 0;
> +}
> +
> +static void p8_aes_xts_exit(struct crypto_tfm *tfm)
> +{
> + struct p8_aes_xts_ctx *ctx = crypto_tfm_ctx(tfm);
> +
> + if (ctx->fallback) {
> + crypto_free_blkcipher(ctx->fallback);
> + ctx->fallback = NULL;
> + }
> +}
> +
> +static int p8_aes_xts_setkey(struct crypto_tfm *tfm, const u8 *key,
> +  unsigned int keylen)
> +{
> + int ret;
> + struct p8_aes_xts_ctx *ctx = crypto_tfm_ctx(tfm);
> +
> + if (keylen % 2)
> + return -EINVAL;

Please use xts_check_key instead of this check.
> +
> + preempt_disable();
> + pagefault_disable();
> + enable_kernel_vsx();
> + ret = aes_p8_set_encrypt_key(key + keylen/2, (keylen/2) * 8,
> >tweak_key); +   ret += aes_p8_set_encrypt_key(key, (keylen/2) * 8,
> >enc_key); + ret += aes_p8_set_decrypt_key(key, (keylen/2) * 8,
> >dec_key); + disable_kernel_vsx();
> + pagefault_enable();
> + preempt_enable();
> +
> + ret += crypto_blkcipher_setkey(ctx->fallback, key, keylen);
> + return ret;
> +}
> +
> +static int p8_aes_xts_crypt(struct blkcipher_desc *desc,
> + struct scatterlist *dst,
> + struct scatterlist *src,
> + unsigned int nbytes, int enc)
> +{
> + int ret;
> + u8 tweak[AES_BLOCK_SIZE];
> + u8 *iv;
> + struct blkcipher_walk walk;
> + 

Re: [PATCH 5/6] [RFC] crypto/testmgr: add null test for 842 algorithm

[Stephan Mueller]

Am Donnerstag, 2. Juli 2015, 15:41:19 schrieb Nishanth Aravamudan:

Hi Nishanth,

Currently, when the nx-842-pseries driver loads, the following message
is emitted:

alg: No test for 842 (842-nx)

It seems like the simplest way to fix this message (other than adding a
proper test) is to just insert the null test into the list in the
testmgr.

Signed-off-by: Nishanth Aravamudan n...@linux.vnet.ibm.com

---
 crypto/testmgr.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/crypto/testmgr.c b/crypto/testmgr.c
index d0a42bd3aae9..ff0f76e0d0b4 100644
--- a/crypto/testmgr.c
+++ b/crypto/testmgr.c
@@ -1982,6 +1982,9 @@ static int alg_test_null(const struct alg_test_desc
*desc, /* Please keep this list sorted by algorithm name. */
 static const struct alg_test_desc alg_test_descs[] = {
   {
+  .alg = 842,
+  .test = alg_test_null,
+  }, {
   .alg = __cbc-cast5-avx,
   .test = alg_test_null,

As this is a compression algo, it is safe to add fips_allowed = 1 here as 
otherwise the algo is not available in fips=1

   }, {


Ciao
Stephan
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev