RE: [PATCH 12/12] drm/ast: Call open_key before enable_mmio in POST code
Tested-by: Y.C. Chen <yc_c...@aspeedtech.com> -Original Message- From: Benjamin Herrenschmidt [mailto:b...@kernel.crashing.org] Sent: Friday, February 24, 2017 6:54 AM To: dri-de...@lists.freedesktop.org Cc: YC Chen <yc_c...@aspeedtech.com>; airl...@redhat.com; e...@suse.come; linuxppc-...@ozlabs.org Subject: [PATCH 12/12] drm/ast: Call open_key before enable_mmio in POST code From: "Y.C. Chen" <yc_c...@aspeedtech.com> open_key enables access the registers used by enable_mmio Signed-off-by: Y.C. Chen <yc_c...@aspeedtech.com> Signed-off-by: Benjamin Herrenschmidt <b...@kernel.crashing.org>
RE: [PATCH 11/12] drm/ast: Fix test for VGA enabled
Tested-by: Y.C. Chen <yc_c...@aspeedtech.com> -Original Message- From: Benjamin Herrenschmidt [mailto:b...@kernel.crashing.org] Sent: Friday, February 24, 2017 6:54 AM To: dri-de...@lists.freedesktop.org Cc: YC Chen <yc_c...@aspeedtech.com>; airl...@redhat.com; e...@suse.come; linuxppc-...@ozlabs.org Subject: [PATCH 11/12] drm/ast: Fix test for VGA enabled From: "Y.C. Chen" <yc_c...@aspeedtech.com> (Get better description from Aspeed) Signed-off-by: Y.C. Chen <yc_c...@aspeedtech.com> Signed-off-by: Benjamin Herrenschmidt <b...@kernel.crashing.org>
RE: [PATCH 09/12] drm/ast: Rename ast_init_dram_2300 to ast_post_chip_2300
Tested-by: Y.C. Chen <yc_c...@aspeedtech.com> -Original Message- From: Benjamin Herrenschmidt [mailto:b...@kernel.crashing.org] Sent: Friday, February 24, 2017 6:54 AM To: dri-de...@lists.freedesktop.org Cc: YC Chen <yc_c...@aspeedtech.com>; airl...@redhat.com; e...@suse.come; linuxppc-...@ozlabs.org Subject: [PATCH 09/12] drm/ast: Rename ast_init_dram_2300 to ast_post_chip_2300 The function does more than initializing the DRAM and in turns calls other functions to do the actual init. This will keeping things more consistent with the upcoming AST2500 POST code. Signed-off-by: Benjamin Herrenschmidt <b...@kernel.crashing.org>
RE: [PATCH 08/12] drm/ast: Factor mmc_test code in POST code
Tested-by: Y.C. Chen <yc_c...@aspeedtech.com> -Original Message- From: Benjamin Herrenschmidt [mailto:b...@kernel.crashing.org] Sent: Friday, February 24, 2017 6:54 AM To: dri-de...@lists.freedesktop.org Cc: YC Chen <yc_c...@aspeedtech.com>; airl...@redhat.com; e...@suse.come; linuxppc-...@ozlabs.org Subject: [PATCH 08/12] drm/ast: Factor mmc_test code in POST code There's a some duplication for what's essentially copies of two loops, so factor it. The upcoming AST2500 POST code adds more of them. Also cleanup return types for the test functions, most of them return a boolean, some return a u32. Signed-off-by: Benjamin Herrenschmidt <b...@kernel.crashing.org>
RE: [PATCH 07/12] drm/ast: Fixed vram size incorrect issue on POWER
Tested-by: Y.C. Chen <yc_c...@aspeedtech.com> -Original Message- From: Benjamin Herrenschmidt [mailto:b...@kernel.crashing.org] Sent: Friday, February 24, 2017 6:54 AM To: dri-de...@lists.freedesktop.org Cc: YC Chen <yc_c...@aspeedtech.com>; airl...@redhat.com; e...@suse.come; linuxppc-...@ozlabs.org Subject: [PATCH 07/12] drm/ast: Fixed vram size incorrect issue on POWER From: "Y.C. Chen" <yc_c...@aspeedtech.com> The default value of VGA scratch may incorrect. Should initial h/w before get vram info. Signed-off-by: Y.C. Chen <yc_c...@aspeedtech.com>
RE: [PATCH 05/12] drm/ast: Fix calculation of MCLK
Tested-by: Y.C. Chen <yc_c...@aspeedtech.com> -Original Message- From: Benjamin Herrenschmidt [mailto:b...@kernel.crashing.org] Sent: Friday, February 24, 2017 6:54 AM To: dri-de...@lists.freedesktop.org Cc: YC Chen <yc_c...@aspeedtech.com>; airl...@redhat.com; e...@suse.come; linuxppc-...@ozlabs.org Subject: [PATCH 05/12] drm/ast: Fix calculation of MCLK Some braces were missing causing an incorrect calculation. Y.C. Chen from Aspeed provided me with the right formula which I tested on AST2400 and 2500. The MCLK isn't currently used by the driver (it will eventually to filter modes) so the issue isn't catastrophic. Also make the printed value a bit more meaningful Signed-off-by: Benjamin Herrenschmidt <b...@kernel.crashing.org>
RE: [PATCH 02/12] drm/ast: Handle configuration without P2A bridge
Tested-by: Y.C. Chen <yc_c...@aspeedtech.com> -Original Message- From: Benjamin Herrenschmidt [mailto:b...@kernel.crashing.org] Sent: Friday, February 24, 2017 6:54 AM To: dri-de...@lists.freedesktop.org Cc: YC Chen <yc_c...@aspeedtech.com>; airl...@redhat.com; e...@suse.come; linuxppc-...@ozlabs.org Subject: [PATCH 02/12] drm/ast: Handle configuration without P2A bridge From: Russell Currey <rus...@russell.cc> The ast driver configures a window to enable access into BMC memory space in order to read some configuration registers. If this window is disabled, which it can be from the BMC side, the ast driver can't function. Closing this window is a necessity for security if a machine's host side and BMC side are controlled by different parties; i.e. a cloud provider offering machines "bare metal". A recent patch went in to try to check if that window is open but it does so by trying to access the registers in question and testing if the result is 0x. This method will trigger a PCIe error when the window is closed which on some systems will be fatal (it will trigger an EEH for example on POWER which will take out the device). This patch improves this in two ways: - First, if the firmware has put properties in the device-tree containing the relevant configuration information, we use these. - Otherwise, a bit in one of the SCU scratch registers (which are readable via the VGA register space and writeable by the BMC) will indicate if the BMC has closed the window. This bit has been defined by Y.C Chen from Aspeed. If the window is closed and the configuration isn't available from the device-tree, some sane defaults are used. Those defaults are hopefully sufficient for standard video modes used on a server. Signed-off-by: Russell Currey <rus...@russell.cc> Signed-off-by: Benjamin Herrenschmidt <b...@kernel.crashing.org>
RE: [PATCH 01/12] drm/ast: Fix AST2400 POST failure without BMC FW or VBIOS
Tested-by: Y.C. Chen <yc_c...@aspeedtech.com> -Original Message- From: Benjamin Herrenschmidt [mailto:b...@kernel.crashing.org] Sent: Friday, February 24, 2017 6:54 AM To: dri-de...@lists.freedesktop.org Cc: YC Chen <yc_c...@aspeedtech.com>; airl...@redhat.com; e...@suse.come; linuxppc-...@ozlabs.org Subject: [PATCH 01/12] drm/ast: Fix AST2400 POST failure without BMC FW or VBIOS From: "Y.C. Chen" <yc_c...@aspeedtech.com> The current POST code for the AST2300/2400 family doesn't work properly if the chip hasn't been initialized previously by either the BMC own FW or the VBIOS. This fixes it. Signed-off-by: Y.C. Chen <yc_c...@aspeedtech.com> Signed-off-by: Benjamin Herrenschmidt <b...@kernel.crashing.org>
