Re: [Intel-wired-lan] [PATCH net-next v2 00/10] Remove unnecessary (void*) conversions
On 2023/7/11 16:53, Paul Menzel wrote: Dear Su, Thank you for your patch. Am 10.07.23 um 08:38 schrieb Su Hui: From: wuych Can you please write the full name correctly? Maybe Yun Chuan? git config --global user.name "Yun Chuan" git commit --amend --author="Yun Chuan " Dear Paul Menzel, Thanks for your reminder! I have already changed this to my full name "Wu Yunchuan". Should I resend all these patches to change the author name? I only got the cover letter by the way. s Maybe the network met some problems. I will send this patchset to you separately. Wu Yunchuan Kind regards, Paul
[PATCH net-next v3 01/10] net: wan: Remove unnecessary (void*) conversions
From: wuych
Pointer variables of void * type do not require type cast.
Signed-off-by: Wu Yunchuan
---
drivers/net/wan/fsl_ucc_hdlc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
index 47c2ad7a3e42..91e37c3dcbee 100644
--- a/drivers/net/wan/fsl_ucc_hdlc.c
+++ b/drivers/net/wan/fsl_ucc_hdlc.c
@@ -350,7 +350,7 @@ static int uhdlc_init(struct ucc_hdlc_private *priv)
static netdev_tx_t ucc_hdlc_tx(struct sk_buff *skb, struct net_device *dev)
{
hdlc_device *hdlc = dev_to_hdlc(dev);
- struct ucc_hdlc_private *priv = (struct ucc_hdlc_private *)hdlc->priv;
+ struct ucc_hdlc_private *priv = hdlc->priv;
struct qe_bd *bd;
u16 bd_status;
unsigned long flags;
--
2.30.2
Re: [PATCH net-next v2 01/10] net: wan: Remove unnecessary (void*) conversions
On 2023/7/11 00:34, Andrew Lunn wrote:
On Mon, Jul 10, 2023 at 02:39:33PM +0800, Su Hui wrote:
From: wuych
Pointer variables of void * type do not require type cast.
Signed-off-by: wuych
---
drivers/net/wan/fsl_ucc_hdlc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
index 47c2ad7a3e42..73c73d8f4bb2 100644
--- a/drivers/net/wan/fsl_ucc_hdlc.c
+++ b/drivers/net/wan/fsl_ucc_hdlc.c
@@ -350,11 +350,11 @@ static int uhdlc_init(struct ucc_hdlc_private *priv)
static netdev_tx_t ucc_hdlc_tx(struct sk_buff *skb, struct net_device *dev)
{
hdlc_device *hdlc = dev_to_hdlc(dev);
- struct ucc_hdlc_private *priv = (struct ucc_hdlc_private *)hdlc->priv;
- struct qe_bd *bd;
- u16 bd_status;
+ struct ucc_hdlc_private *priv = hdlc->priv;
unsigned long flags;
__be16 *proto_head;
+ struct qe_bd *bd;
+ u16 bd_status;
When dealing with existing broken reverse Christmas tree, please don't
make it worse with a change. But actually fixing it should be in a
different patch.
We want patches to be obviously correct. By removing the cast and
moving variables around, it is less obvious it is correct, than having
two patches.
Got it, thanks.
I will resend the v3 later which remove the change of reverse Christmas
tree.
So sorry for this!
Wu Yunchuan
Andrew
Re: [PATCH net-next v2 01/10] net: wan: Remove unnecessary (void*) conversions
On 2023/7/10 15:29, Dan Carpenter wrote:
On Mon, Jul 10, 2023 at 02:39:33PM +0800, Su Hui wrote:
From: wuych
^
This doesn't look like a real name.
Hi, Dan,
My full name is wuyunchan， but that is too long.
So I use the wuych as simplification.
I will change it to my full name, thanks for your adivce!
Pointer variables of void * type do not require type cast.
Signed-off-by: wuych
---
drivers/net/wan/fsl_ucc_hdlc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
index 47c2ad7a3e42..73c73d8f4bb2 100644
--- a/drivers/net/wan/fsl_ucc_hdlc.c
+++ b/drivers/net/wan/fsl_ucc_hdlc.c
@@ -350,11 +350,11 @@ static int uhdlc_init(struct ucc_hdlc_private *priv)
static netdev_tx_t ucc_hdlc_tx(struct sk_buff *skb, struct net_device *dev)
{
hdlc_device *hdlc = dev_to_hdlc(dev);
- struct ucc_hdlc_private *priv = (struct ucc_hdlc_private *)hdlc->priv;
- struct qe_bd *bd;
- u16 bd_status;
+ struct ucc_hdlc_private *priv = hdlc->priv;
unsigned long flags;
__be16 *proto_head;
+ struct qe_bd *bd;
+ u16 bd_status;
Don't move the other variables around. That's unrelated to the cast.
(Same applies to all the other patches).
I want to move the declarations to be reverse xmas tree.
Maybe moving them is more better?
wuych
regards,
dan carpenter
Re: [PATCH net-next 00/10] Remove unnecessary (void*) conversions
On 2023/6/28 22:39, Andrew Lunn wrote: On Wed, Jun 28, 2023 at 04:37:43PM +0200, Andrew Lunn wrote: Hi, Hao Lan, Sorry for that, I just compiled these patches in the mainline branch. I know now, it's also necessary to compile patches in net and net-next branch. Thanks for your reply! net-next is also closed at the moment due to the merge window. Please wait two weeks before reposting, by which time net-next will be open again. Hi, Andrew Lunn, Understand, and thanks for your reminding! Your email threading also seems to be broken, there is no threading. That might cause pathworks an issue. Sometimes it doesn't work, but I also receive email from email list. So I can read your email from email list although something is broken. Thanks again！ wuych Andrew
Re: [PATCH net-next 00/10] Remove unnecessary (void*) conversions
On 2023/6/28 15:41, Hao Lan wrote: On 2023/6/28 10:41, wuych wrote: Remove (void*) conversions under "drivers/net" directory. According to the suggestion[1] of Jakub Kicinski, send these patches in series of 10. wuych (10): net: dsa: ar9331: remove unnecessary (void*) conversions net: dsa: qca8k: remove unnecessary (void*) conversions atlantic:hw_atl2:hw_atl2_utils_fw: Remove unnecessary (void*) conversions ice: Remove unnecessary (void*) conversions ethernet: smsc: remove unnecessary (void*) conversions net: hns: Remove unnecessary (void*) conversions net: hns3: remove unnecessary (void*) conversions net: mdio: Remove unnecessary (void*) conversions net: ppp: remove unnecessary (void*) conversions net: wan: Remove unnecessary (void*) conversions Hi wuych, Thank you for your patch. The following two patches conflict with the net-next branch, and others have modified the related code. Please compile your series in net and net-next branch and upload your series again. net: dsa: ar9331: remove unnecessary (void*) conversions net: dsa: qca8k: remove unnecessary (void*) conversions Hi, Hao Lan, Sorry for that, I just compiled these patches in the mainline branch. I know now, it's also necessary to compile patches in net and net-next branch. Thanks for your reply! wuych Yours, Hao Lan
