[BUILD FAILURE 04] Next April 9 : PPC64 randconfig [drivers/net/ibm_newemac/core.c]
Observed the following build error: CC drivers/net/ibm_newemac/core.o drivers/net/ibm_newemac/core.c: In function ‘emac_probe’: drivers/net/ibm_newemac/core.c:2831: error: ‘struct net_device’ has no member named ‘open’ drivers/net/ibm_newemac/core.c:2834: error: ‘struct net_device’ has no member named ‘tx_timeout’ drivers/net/ibm_newemac/core.c:2836: error: ‘struct net_device’ has no member named ‘stop’ drivers/net/ibm_newemac/core.c:2837: error: ‘struct net_device’ has no member named ‘get_stats’ drivers/net/ibm_newemac/core.c:2838: error: ‘struct net_device’ has no member named ‘set_multicast_list’ drivers/net/ibm_newemac/core.c:2839: error: ‘struct net_device’ has no member named ‘do_ioctl’ drivers/net/ibm_newemac/core.c:2841: error: ‘struct net_device’ has no member named ‘hard_start_xmit’ drivers/net/ibm_newemac/core.c:2842: error: ‘struct net_device’ has no member named ‘change_mtu’ drivers/net/ibm_newemac/core.c:2845: error: ‘struct net_device’ has no member named ‘hard_start_xmit’ make[3]: *** [drivers/net/ibm_newemac/core.o] Error 1 make[2]: *** [drivers/net/ibm_newemac] Error 2 make[1]: *** [drivers/net] Error 2 make: *** [drivers] Error 2 Regards-- Subrata # # Automatically generated make config: don't edit # Linux kernel version: 2.6.30-rc1 # Thu Apr 9 06:28:20 2009 # CONFIG_PPC64=y # # Processor support # CONFIG_PPC_BOOK3S=y # CONFIG_POWER4_ONLY is not set CONFIG_POWER3=y CONFIG_POWER4=y CONFIG_TUNE_CELL=y CONFIG_PPC_FPU=y CONFIG_ALTIVEC=y CONFIG_VSX=y CONFIG_PPC_STD_MMU=y CONFIG_PPC_STD_MMU_64=y # CONFIG_PPC_MM_SLICES is not set # CONFIG_VIRT_CPU_ACCOUNTING is not set CONFIG_SMP=y CONFIG_NR_CPUS=32 CONFIG_64BIT=y CONFIG_WORD_SIZE=64 CONFIG_ARCH_PHYS_ADDR_T_64BIT=y CONFIG_MMU=y CONFIG_GENERIC_CMOS_UPDATE=y CONFIG_GENERIC_TIME=y CONFIG_GENERIC_TIME_VSYSCALL=y CONFIG_GENERIC_CLOCKEVENTS=y CONFIG_GENERIC_HARDIRQS=y CONFIG_HAVE_SETUP_PER_CPU_AREA=y CONFIG_IRQ_PER_CPU=y CONFIG_STACKTRACE_SUPPORT=y CONFIG_HAVE_LATENCYTOP_SUPPORT=y CONFIG_TRACE_IRQFLAGS_SUPPORT=y CONFIG_LOCKDEP_SUPPORT=y CONFIG_RWSEM_XCHGADD_ALGORITHM=y CONFIG_ARCH_HAS_ILOG2_U32=y CONFIG_ARCH_HAS_ILOG2_U64=y CONFIG_GENERIC_HWEIGHT=y CONFIG_GENERIC_CALIBRATE_DELAY=y CONFIG_GENERIC_FIND_NEXT_BIT=y CONFIG_ARCH_NO_VIRT_TO_BUS=y CONFIG_PPC=y CONFIG_EARLY_PRINTK=y CONFIG_COMPAT=y CONFIG_SYSVIPC_COMPAT=y CONFIG_SCHED_OMIT_FRAME_POINTER=y CONFIG_ARCH_MAY_HAVE_PC_FDC=y CONFIG_PPC_OF=y CONFIG_OF=y CONFIG_PPC_UDBG_16550=y CONFIG_GENERIC_TBSYNC=y CONFIG_AUDIT_ARCH=y CONFIG_GENERIC_BUG=y # CONFIG_DEFAULT_UIMAGE is not set # CONFIG_PPC_DCR_NATIVE is not set CONFIG_PPC_DCR_MMIO=y CONFIG_PPC_DCR=y CONFIG_PPC_OF_PLATFORM_PCI=y CONFIG_ARCH_SUPPORTS_DEBUG_PAGEALLOC=y CONFIG_DEFCONFIG_LIST=/lib/modules/$UNAME_RELEASE/.config # # General setup # CONFIG_EXPERIMENTAL=y CONFIG_LOCK_KERNEL=y CONFIG_INIT_ENV_ARG_LIMIT=32 CONFIG_LOCALVERSION= CONFIG_LOCALVERSION_AUTO=y CONFIG_SYSVIPC=y # CONFIG_POSIX_MQUEUE is not set # CONFIG_BSD_PROCESS_ACCT is not set CONFIG_TASKSTATS=y CONFIG_TASK_DELAY_ACCT=y CONFIG_TASK_XACCT=y CONFIG_TASK_IO_ACCOUNTING=y CONFIG_AUDIT=y CONFIG_AUDITSYSCALL=y CONFIG_AUDIT_TREE=y # # RCU Subsystem # CONFIG_CLASSIC_RCU=y # CONFIG_TREE_RCU is not set # CONFIG_PREEMPT_RCU is not set # CONFIG_TREE_RCU_TRACE is not set # CONFIG_PREEMPT_RCU_TRACE is not set CONFIG_IKCONFIG=y CONFIG_LOG_BUF_SHIFT=17 # CONFIG_GROUP_SCHED is not set # CONFIG_CGROUPS is not set CONFIG_SYSFS_DEPRECATED=y CONFIG_SYSFS_DEPRECATED_V2=y # CONFIG_RELAY is not set CONFIG_NAMESPACES=y CONFIG_UTS_NS=y CONFIG_IPC_NS=y CONFIG_USER_NS=y CONFIG_PID_NS=y # CONFIG_NET_NS is not set # CONFIG_BLK_DEV_INITRD is not set CONFIG_CC_OPTIMIZE_FOR_SIZE=y CONFIG_ANON_INODES=y CONFIG_EMBEDDED=y # CONFIG_SYSCTL_SYSCALL is not set CONFIG_KALLSYMS=y CONFIG_KALLSYMS_ALL=y CONFIG_KALLSYMS_EXTRA_PASS=y # CONFIG_HOTPLUG is not set CONFIG_PRINTK=y CONFIG_BUG=y CONFIG_ELF_CORE=y CONFIG_PCSPKR_PLATFORM=y CONFIG_BASE_FULL=y # CONFIG_FUTEX is not set # CONFIG_EPOLL is not set # CONFIG_SIGNALFD is not set CONFIG_TIMERFD=y CONFIG_EVENTFD=y CONFIG_SHMEM=y CONFIG_AIO=y CONFIG_VM_EVENT_COUNTERS=y CONFIG_PCI_QUIRKS=y # CONFIG_SLUB_DEBUG is not set CONFIG_COMPAT_BRK=y # CONFIG_SLAB is not set CONFIG_SLUB=y # CONFIG_SLQB is not set # CONFIG_SLOB is not set CONFIG_PROFILING=y CONFIG_TRACEPOINTS=y CONFIG_MARKERS=y # CONFIG_OPROFILE is not set CONFIG_HAVE_OPROFILE=y CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS=y CONFIG_HAVE_SYSCALL_WRAPPERS=y CONFIG_HAVE_IOREMAP_PROT=y CONFIG_HAVE_KPROBES=y CONFIG_HAVE_KRETPROBES=y CONFIG_HAVE_ARCH_TRACEHOOK=y CONFIG_HAVE_DMA_ATTRS=y CONFIG_USE_GENERIC_SMP_HELPERS=y CONFIG_SLOW_WORK=y # CONFIG_HAVE_GENERIC_DMA_COHERENT is not set CONFIG_BASE_SMALL=0 # CONFIG_MODULES is not set # CONFIG_BLOCK is not set # CONFIG_FREEZER is not set CONFIG_PPC_MSI_BITMAP=y # # Platform support # CONFIG_PPC_PSERIES=y # CONFIG_PPC_SPLPAR is not set CONFIG_EEH=y CONFIG_PSERIES_MSI=y CONFIG_SCANLOG=y CONFIG_LPARCFG=y CONFIG_PPC_PSERIES_DEBUG=y CONFIG_PPC_SMLPAR=y CONFIG_CMM=y # CONFIG_PPC_ISERIES
Re: [BUILD FAILURE 04] Next April 9 : PPC64 randconfig [drivers/net/ibm_newemac/core.c]
On Apr 9, 2009, at 8:52 AM, Subrata Modak wrote: Observed the following build error: CC drivers/net/ibm_newemac/core.o drivers/net/ibm_newemac/core.c: In function ‘emac_probe’: drivers/net/ibm_newemac/core.c:2831: error: ‘struct net_device’ has no member named ‘open’ drivers/net/ibm_newemac/core.c:2834: error: ‘struct net_device’ has no member named ‘tx_timeout’ drivers/net/ibm_newemac/core.c:2836: error: ‘struct net_device’ has no member named ‘stop’ drivers/net/ibm_newemac/core.c:2837: error: ‘struct net_device’ has no member named ‘get_stats’ drivers/net/ibm_newemac/core.c:2838: error: ‘struct net_device’ has no member named ‘set_multicast_list’ drivers/net/ibm_newemac/core.c:2839: error: ‘struct net_device’ has no member named ‘do_ioctl’ drivers/net/ibm_newemac/core.c:2841: error: ‘struct net_device’ has no member named ‘hard_start_xmit’ drivers/net/ibm_newemac/core.c:2842: error: ‘struct net_device’ has no member named ‘change_mtu’ drivers/net/ibm_newemac/core.c:2845: error: ‘struct net_device’ has no member named ‘hard_start_xmit’ make[3]: *** [drivers/net/ibm_newemac/core.o] Error 1 make[2]: *** [drivers/net/ibm_newemac] Error 2 make[1]: *** [drivers/net] Error 2 make: *** [drivers] Error 2 Regards-- Subrata randconfig4-ppc64-next20090409.txt This is because CONFIG_COMPAT_NET_DEV_OPS isnt set and needs to be for this driver to build. I've asked the netdev guys about either fixing the driver or adding the proper thing to Kconfig to select CONFIG_COMPAT_NET_DEV_OPS. - k ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [BUILD FAILURE 04] Next April 9 : PPC64 randconfig [drivers/net/ibm_newemac/core.c]
On Thu, Apr 09, 2009 at 09:28:23AM -0500, Kumar Gala wrote: On Apr 9, 2009, at 8:52 AM, Subrata Modak wrote: Observed the following build error: CC drivers/net/ibm_newemac/core.o drivers/net/ibm_newemac/core.c: In function ‘emac_probe’: drivers/net/ibm_newemac/core.c:2831: error: ‘struct net_device’ has no member named ‘open’ drivers/net/ibm_newemac/core.c:2834: error: ‘struct net_device’ has no member named ‘tx_timeout’ drivers/net/ibm_newemac/core.c:2836: error: ‘struct net_device’ has no member named ‘stop’ drivers/net/ibm_newemac/core.c:2837: error: ‘struct net_device’ has no member named ‘get_stats’ drivers/net/ibm_newemac/core.c:2838: error: ‘struct net_device’ has no member named ‘set_multicast_list’ drivers/net/ibm_newemac/core.c:2839: error: ‘struct net_device’ has no member named ‘do_ioctl’ drivers/net/ibm_newemac/core.c:2841: error: ‘struct net_device’ has no member named ‘hard_start_xmit’ drivers/net/ibm_newemac/core.c:2842: error: ‘struct net_device’ has no member named ‘change_mtu’ drivers/net/ibm_newemac/core.c:2845: error: ‘struct net_device’ has no member named ‘hard_start_xmit’ make[3]: *** [drivers/net/ibm_newemac/core.o] Error 1 make[2]: *** [drivers/net/ibm_newemac] Error 2 make[1]: *** [drivers/net] Error 2 make: *** [drivers] Error 2 Regards-- Subrata randconfig4-ppc64-next20090409.txt This is because CONFIG_COMPAT_NET_DEV_OPS isnt set and needs to be for this driver to build. I've asked the netdev guys about either fixing the driver or adding the proper thing to Kconfig to select CONFIG_COMPAT_NET_DEV_OPS. Thanks! If someone has pointers on what needs to be done to fix it, let me know. josh ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [BUILD FAILURE 04] Next April 9 : PPC64 randconfig [drivers/net/ibm_newemac/core.c]
On Thu, Apr 09, 2009 at 10:31:12AM -0400, Josh Boyer wrote:
On Thu, Apr 09, 2009 at 09:28:23AM -0500, Kumar Gala wrote:
On Apr 9, 2009, at 8:52 AM, Subrata Modak wrote:
Observed the following build error:
CC drivers/net/ibm_newemac/core.o
drivers/net/ibm_newemac/core.c: In function ???emac_probe???:
drivers/net/ibm_newemac/core.c:2831: error: ???struct net_device??? has no
member named ???open???
drivers/net/ibm_newemac/core.c:2834: error: ???struct net_device??? has no
member named ???tx_timeout???
drivers/net/ibm_newemac/core.c:2836: error: ???struct net_device??? has no
member named ???stop???
drivers/net/ibm_newemac/core.c:2837: error: ???struct net_device??? has no
member named ???get_stats???
drivers/net/ibm_newemac/core.c:2838: error: ???struct net_device??? has no
member named ???set_multicast_list???
drivers/net/ibm_newemac/core.c:2839: error: ???struct net_device??? has no
member named ???do_ioctl???
drivers/net/ibm_newemac/core.c:2841: error: ???struct net_device??? has no
member named ???hard_start_xmit???
drivers/net/ibm_newemac/core.c:2842: error: ???struct net_device??? has no
member named ???change_mtu???
drivers/net/ibm_newemac/core.c:2845: error: ???struct net_device??? has no
member named ???hard_start_xmit???
make[3]: *** [drivers/net/ibm_newemac/core.o] Error 1
make[2]: *** [drivers/net/ibm_newemac] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2
Regards--
Subrata
randconfig4-ppc64-next20090409.txt
This is because CONFIG_COMPAT_NET_DEV_OPS isnt set and needs to be for
this driver to build. I've asked the netdev guys about either fixing
the driver or adding the proper thing to Kconfig to select
CONFIG_COMPAT_NET_DEV_OPS.
Thanks!
If someone has pointers on what needs to be done to fix it, let me know.
From: Alexander Beregalov a.berega...@gmail.com
Subject: [PATCH] ibm_newemac: convert to netdev_ops
Reported-by: Subrata Modak subr...@linux.vnet.ibm.com
Signed-off-by: Alexander Beregalov a.berega...@gmail.com
---
drivers/net/ibm_newemac/core.c | 41 ---
1 files changed, 29 insertions(+), 12 deletions(-)
diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c
index 77e4b5b..806533c 100644
--- a/drivers/net/ibm_newemac/core.c
+++ b/drivers/net/ibm_newemac/core.c
@@ -2686,6 +2686,32 @@ static int __devinit emac_init_config(struct
emac_instance *dev)
return 0;
}
+static const struct net_device_ops emac_netdev_ops = {
+ .ndo_open = emac_open,
+ .ndo_stop = emac_close,
+ .ndo_get_stats = emac_stats,
+ .ndo_set_multicast_list = emac_set_multicast_list,
+ .ndo_do_ioctl = emac_ioctl,
+ .ndo_tx_timeout = emac_tx_timeout,
+ .ndo_validate_addr = eth_validate_addr,
+ .ndo_set_mac_address= eth_mac_addr,
+ .ndo_start_xmit = emac_start_xmit,
+ .ndo_change_mtu = eth_change_mtu,
+};
+
+static const struct net_device_ops emac_gige_netdev_ops = {
+ .ndo_open = emac_open,
+ .ndo_stop = emac_close,
+ .ndo_get_stats = emac_stats,
+ .ndo_set_multicast_list = emac_set_multicast_list,
+ .ndo_do_ioctl = emac_ioctl,
+ .ndo_tx_timeout = emac_tx_timeout,
+ .ndo_validate_addr = eth_validate_addr,
+ .ndo_set_mac_address= eth_mac_addr,
+ .ndo_start_xmit = emac_start_xmit_sg,
+ .ndo_change_mtu = emac_change_mtu,
+};
+
static int __devinit emac_probe(struct of_device *ofdev,
const struct of_device_id *match)
{
@@ -2827,23 +2853,14 @@ static int __devinit emac_probe(struct of_device *ofdev,
if (err != 0)
goto err_detach_tah;
- /* Fill in the driver function table */
- ndev-open = emac_open;
if (dev-tah_dev)
ndev-features |= NETIF_F_IP_CSUM | NETIF_F_SG;
- ndev-tx_timeout = emac_tx_timeout;
ndev-watchdog_timeo = 5 * HZ;
- ndev-stop = emac_close;
- ndev-get_stats = emac_stats;
- ndev-set_multicast_list = emac_set_multicast_list;
- ndev-do_ioctl = emac_ioctl;
if (emac_phy_supports_gige(dev-phy_mode)) {
- ndev-hard_start_xmit = emac_start_xmit_sg;
- ndev-change_mtu = emac_change_mtu;
+ ndev-netdev_ops = emac_gige_netdev_ops;
dev-commac.ops = emac_commac_sg_ops;
- } else {
- ndev-hard_start_xmit = emac_start_xmit;
- }
+ } else
+ ndev-netdev_ops = emac_netdev_ops;
SET_ETHTOOL_OPS(ndev, emac_ethtool_ops);
netif_carrier_off(ndev);
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
