Re: [Bug 206695] New: kmemleak reports leaks in drivers/macintosh/windfarm

[Michael Ellerman]

Can you try this patch?

diff --git a/drivers/macintosh/windfarm_pm112.c 
b/drivers/macintosh/windfarm_pm112.c
index 4150301a89a5..a16f43a1def9 100644
--- a/drivers/macintosh/windfarm_pm112.c
+++ b/drivers/macintosh/windfarm_pm112.c
@@ -125,7 +125,7 @@ static int create_cpu_loop(int cpu)
 {
int chip = cpu / 2;
int core = cpu & 1;
-   struct smu_sdbp_header *hdr;
+   struct smu_sdbp_header *hdr, *hdr2;
struct smu_sdbp_cpupiddata *piddata;
struct wf_cpu_pid_param pid;
struct wf_control *main_fan = cpu_fans[0];
@@ -141,9 +141,9 @@ static int create_cpu_loop(int cpu)
piddata = (struct smu_sdbp_cpupiddata *)[1];
 
/* Get FVT params to get Tmax; if not found, assume default */
-   hdr = smu_sat_get_sdb_partition(chip, 0xC4 + core, NULL);
-   if (hdr) {
-   struct smu_sdbp_fvt *fvt = (struct smu_sdbp_fvt *)[1];
+   hdr2 = smu_sat_get_sdb_partition(chip, 0xC4 + core, NULL);
+   if (hdr2) {
+   struct smu_sdbp_fvt *fvt = (struct smu_sdbp_fvt *)[1];
tmax = fvt->maxtemp << 16;
} else
tmax = 95 << 16;/* default to 95 degrees C */
@@ -174,6 +174,10 @@ static int create_cpu_loop(int cpu)
pid.min = fmin;
 
wf_cpu_pid_init(_pid[cpu], );
+
+   kfree(hdr);
+   kfree(hdr2);
+
return 0;
 }
 

[Bug 206695] New: kmemleak reports leaks in drivers/macintosh/windfarm

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=206695

Bug ID: 206695
   Summary: kmemleak reports leaks in drivers/macintosh/windfarm
   Product: Platform Specific/Hardware
   Version: 2.5
Kernel Version: 5.6-rc3
  Hardware: PPC-64
OS: Linux
  Tree: Mainline
Status: NEW
  Severity: normal
  Priority: P1
 Component: PPC-64
  Assignee: platform_ppc...@kernel-bugs.osdl.org
  Reporter: erhar...@mailbox.org
Regression: No

Created attachment 287687
  --> https://bugzilla.kernel.org/attachment.cgi?id=287687=edit
kmemleak output (kernel 5.6-rc3, PowerMac G5 11,2)

kmemleak reports leaks from the windfarm module of my PowerMac G5 11,2:

[...]
unreferenced object 0xc0047081f840 (size 32):
  comm "kwindfarm", pid 203, jiffies 4294880630 (age 5552.877s)
  hex dump (first 32 bytes):
c8 06 02 7f ff 02 ff 01 fb bf 00 41 00 20 00 00  ...A. ..
00 07 89 37 00 a0 00 00 00 00 00 00 00 00 00 00  ...7
  backtrace:
[<83f0a65c>] .smu_sat_get_sdb_partition+0xc4/0x2d0
[windfarm_smu_sat]
[<3010fcb7>] .pm112_wf_notify+0x104c/0x13bc [windfarm_pm112]
[] .notifier_call_chain+0xa8/0x180
[<70490868>] .blocking_notifier_call_chain+0x64/0x90
[<131d8149>] .wf_thread_func+0x114/0x1a0
[<0d54838d>] .kthread+0x13c/0x190
[<669b72bc>] .ret_from_kernel_thread+0x58/0x64
unreferenced object 0xc004737089f0 (size 16):
  comm "kwindfarm", pid 203, jiffies 4294880879 (age 5552.050s)
  hex dump (first 16 bytes):
c4 04 01 7f 22 11 e0 e6 ff 55 7b 12 ec 11 00 00  "U{.
  backtrace:
[<83f0a65c>] .smu_sat_get_sdb_partition+0xc4/0x2d0
[windfarm_smu_sat]
[] .pm112_wf_notify+0x1294/0x13bc [windfarm_pm112]
[] .notifier_call_chain+0xa8/0x180
[<70490868>] .blocking_notifier_call_chain+0x64/0x90
[<131d8149>] .wf_thread_func+0x114/0x1a0
[<0d54838d>] .kthread+0x13c/0x190
[<669b72bc>] .ret_from_kernel_thread+0x58/0x64
unreferenced object 0xc0047081fdc0 (size 32):
  comm "kwindfarm", pid 203, jiffies 4294881067 (age 5551.427s)
  hex dump (first 32 bytes):
c9 06 02 7f ff 02 ff 01 fb bf 00 41 00 20 00 00  ...A. ..
00 07 89 37 00 a0 00 00 00 00 00 00 00 00 00 00  ...7
  backtrace:
[<83f0a65c>] .smu_sat_get_sdb_partition+0xc4/0x2d0
[windfarm_smu_sat]
[<3010fcb7>] .pm112_wf_notify+0x104c/0x13bc [windfarm_pm112]
[] .notifier_call_chain+0xa8/0x180
[<70490868>] .blocking_notifier_call_chain+0x64/0x90
[<131d8149>] .wf_thread_func+0x114/0x1a0
[<0d54838d>] .kthread+0x13c/0x190
[<669b72bc>] .ret_from_kernel_thread+0x58/0x64
unreferenced object 0xc00473708b60 (size 16):
  comm "kwindfarm", pid 203, jiffies 4294881320 (age 5550.587s)
  hex dump (first 16 bytes):
c5 04 01 7f 22 11 e0 e6 ff 55 7b 12 ec 11 00 00  "U{.
  backtrace:
[<83f0a65c>] .smu_sat_get_sdb_partition+0xc4/0x2d0
[windfarm_smu_sat]
[] .pm112_wf_notify+0x1294/0x13bc [windfarm_pm112]
[] .notifier_call_chain+0xa8/0x180
[<70490868>] .blocking_notifier_call_chain+0x64/0x90
[<131d8149>] .wf_thread_func+0x114/0x1a0
[<0d54838d>] .kthread+0x13c/0x190
[<669b72bc>] .ret_from_kernel_thread+0x58/0x64

-- 
You are receiving this mail because:
You are watching the assignee of the bug.