Re: [PATCH][next] powerpc/xmon: Fix -Wswitch-unreachable warning in bpt_cmds

[Michael Ellerman]

On Fri, 16 Sep 2022 15:15:04 +0100, Gustavo A. R. Silva wrote:
> When building with automatic stack variable initialization, GCC 12
> complains about variables defined outside of switch case statements.
> Move the variable into the case that uses it, which silences the warning:
> 
> arch/powerpc/xmon/xmon.c: In function ‘bpt_cmds’:
> arch/powerpc/xmon/xmon.c:1529:13: warning: statement will never be executed 
> [-Wswitch-unreachable]
>  1529 | int mode;
>   | ^~~~
> 
> [...]

Applied to powerpc/next.

[1/1] powerpc/xmon: Fix -Wswitch-unreachable warning in bpt_cmds
  https://git.kernel.org/powerpc/c/1c4a4a4c8410be4a231a58b23e7a30923ff954ac

cheers

Re: [PATCH][next] powerpc/xmon: Fix -Wswitch-unreachable warning in bpt_cmds

[Kees Cook]

On Fri, Sep 16, 2022 at 03:15:04PM +0100, Gustavo A. R. Silva wrote:
> When building with automatic stack variable initialization, GCC 12
> complains about variables defined outside of switch case statements.
> Move the variable into the case that uses it, which silences the warning:
> 
> arch/powerpc/xmon/xmon.c: In function ‘bpt_cmds’:
> arch/powerpc/xmon/xmon.c:1529:13: warning: statement will never be executed 
> [-Wswitch-unreachable]
>  1529 | int mode;
>   | ^~~~
> 
> Fixes: 09b6c1129f89 ("powerpc/xmon: Fix compile error with PPC_8xx=y")
> Signed-off-by: Gustavo A. R. Silva 

Reviewed-by: Kees Cook 

-- 
Kees Cook

[PATCH][next] powerpc/xmon: Fix -Wswitch-unreachable warning in bpt_cmds

[Gustavo A. R. Silva]

When building with automatic stack variable initialization, GCC 12
complains about variables defined outside of switch case statements.
Move the variable into the case that uses it, which silences the warning:

arch/powerpc/xmon/xmon.c: In function ‘bpt_cmds’:
arch/powerpc/xmon/xmon.c:1529:13: warning: statement will never be executed 
[-Wswitch-unreachable]
 1529 | int mode;
  | ^~~~

Fixes: 09b6c1129f89 ("powerpc/xmon: Fix compile error with PPC_8xx=y")
Signed-off-by: Gustavo A. R. Silva 
---
 arch/powerpc/xmon/xmon.c | 7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
index 26ef3388c24c..df91dfc7ff72 100644
--- a/arch/powerpc/xmon/xmon.c
+++ b/arch/powerpc/xmon/xmon.c
@@ -1525,9 +1525,9 @@ bpt_cmds(void)
cmd = inchar();
 
switch (cmd) {
-   static const char badaddr[] = "Only kernel addresses are permitted for 
breakpoints\n";
-   int mode;
-   case 'd':   /* bd - hardware data breakpoint */
+   case 'd': { /* bd - hardware data breakpoint */
+   static const char badaddr[] = "Only kernel addresses are 
permitted for breakpoints\n";
+   int mode;
if (xmon_is_ro) {
printf(xmon_ro_msg);
break;
@@ -1560,6 +1560,7 @@ bpt_cmds(void)
 
force_enable_xmon();
break;
+   }
 
case 'i':   /* bi - hardware instr breakpoint */
if (xmon_is_ro) {
-- 
2.34.1