Re: [PATCH] Documentation: Clarify better about the rwsem non-owner release issue
On Tue, Mar 24, 2020 at 08:15:39AM +, Will Deacon wrote: > On Mon, Mar 23, 2020 at 02:23:49PM -0400, Joel Fernandes wrote: > > On Sun, Mar 22, 2020 at 08:51:15AM +0200, Kalle Valo wrote: > > > "Joel Fernandes (Google)" writes: > > > > > > > Reword and clarify better about the rwsem non-owner release issue. > > > > > > > > Link: > > > > https://lore.kernel.org/linux-pci/20200321212144.ga6...@google.com/ > > > > > > > > Signed-off-by: Joel Fernandes (Google) > > > > > > There's something wrong with your linux-pci and linux-usb addresses: > > > > > > "linux-...@vger.kernel.org Felipe Balbi" , > > > > > > > > > "linux-...@vger.kernel.org Kalle Valo" , > > > > Not sure. It appears fine in the archive. > > Hmm, I don't think it does. Here's the copy from LKML: > > https://lore.kernel.org/lkml/20200322021938.175736-1-j...@joelfernandes.org/ > > Which works because it's in the To: correctly. But both linux-pci and > linux-usb were *not* CC'd: > > "linux-...@vger.kernel.org Kalle Valo" > "linux-...@vger.kernel.org Felipe Balbi" > > and searching for the message in the linux-pci archives doesn't find it: > > https://lore.kernel.org/linux-pci/?q=Reword+and+clarify+better+about+the+rwsem+non-owner+release+issue > > So it looks like there is an issue with your mail setup. Hi Will and Kalle, Thank you for confirming it. You are right, the archive shows the issue. I will double check my client and see what's going on. thanks, - Joel
Re: [PATCH] Documentation: Clarify better about the rwsem non-owner release issue
On Mon, Mar 23, 2020 at 02:23:49PM -0400, Joel Fernandes wrote: > On Sun, Mar 22, 2020 at 08:51:15AM +0200, Kalle Valo wrote: > > "Joel Fernandes (Google)" writes: > > > > > Reword and clarify better about the rwsem non-owner release issue. > > > > > > Link: https://lore.kernel.org/linux-pci/20200321212144.ga6...@google.com/ > > > > > > Signed-off-by: Joel Fernandes (Google) > > > > There's something wrong with your linux-pci and linux-usb addresses: > > > > "linux-...@vger.kernel.org Felipe Balbi" , > > > > > > "linux-...@vger.kernel.org Kalle Valo" , > > Not sure. It appears fine in the archive. Hmm, I don't think it does. Here's the copy from LKML: https://lore.kernel.org/lkml/20200322021938.175736-1-j...@joelfernandes.org/ Which works because it's in the To: correctly. But both linux-pci and linux-usb were *not* CC'd: "linux-...@vger.kernel.org Kalle Valo" "linux-...@vger.kernel.org Felipe Balbi" and searching for the message in the linux-pci archives doesn't find it: https://lore.kernel.org/linux-pci/?q=Reword+and+clarify+better+about+the+rwsem+non-owner+release+issue So it looks like there is an issue with your mail setup. Will
Re: [PATCH] Documentation: Clarify better about the rwsem non-owner release issue
On Sun, Mar 22, 2020 at 08:51:15AM +0200, Kalle Valo wrote: > "Joel Fernandes (Google)" writes: > > > Reword and clarify better about the rwsem non-owner release issue. > > > > Link: https://lore.kernel.org/linux-pci/20200321212144.ga6...@google.com/ > > > > Signed-off-by: Joel Fernandes (Google) > > There's something wrong with your linux-pci and linux-usb addresses: > > "linux-...@vger.kernel.org Felipe Balbi" , > > > "linux-...@vger.kernel.org Kalle Valo" , Not sure. It appears fine in the archive. Thomas, let me know if you wanted me to resend the diff patch. Hopefully it squashed fine into your original patch. thanks, - Joel
Re: [PATCH] Documentation: Clarify better about the rwsem non-owner release issue
"Joel Fernandes (Google)" writes: > Reword and clarify better about the rwsem non-owner release issue. > > Link: https://lore.kernel.org/linux-pci/20200321212144.ga6...@google.com/ > > Signed-off-by: Joel Fernandes (Google) There's something wrong with your linux-pci and linux-usb addresses: "linux-...@vger.kernel.org Felipe Balbi" , "linux-...@vger.kernel.org Kalle Valo" , -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
[PATCH] Documentation: Clarify better about the rwsem non-owner release issue
Reword and clarify better about the rwsem non-owner release issue. Link: https://lore.kernel.org/linux-pci/20200321212144.ga6...@google.com/ Signed-off-by: Joel Fernandes (Google) --- Documentation/locking/locktypes.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/locking/locktypes.rst b/Documentation/locking/locktypes.rst index 6f2c0f5b041e..656dce72f11f 100644 --- a/Documentation/locking/locktypes.rst +++ b/Documentation/locking/locktypes.rst @@ -292,7 +292,7 @@ implementations to provide priority inheritance for all lock types except the truly spinning ones. Priority inheritance on ownerless locks is obviously impossible. -For now the rwsem non-owner release excludes code which utilizes it from -being used on PREEMPT_RT enabled kernels. In same cases this can be -mitigated by disabling portions of the code, in other cases the complete -functionality has to be disabled until a workable solution has been found. +For now, a PREEMPT_RT kernel just disables code sections that perform a +non-owner release of an rwsem. In some cases, parts of the code are disabled. +In other cases, the complete functionality has to be disabled until a workable +solution has been found. -- 2.25.1.696.g5e7596f4ac-goog
