Re: [PATCH] I2C: Explicitly include correct DT includes

2023-08-14 Thread Wolfram Sang 
On Fri, Jul 14, 2023 at 11:46:16AM -0600, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
> 
> Signed-off-by: Rob Herring 

Applied to for-next, thanks!



signature.asc
Description: PGP signature

Re: [PATCH] I2C: Explicitly include correct DT includes

2023-07-26 Thread Andi Shyti 
Hi Rob,

On Fri, Jul 14, 2023 at 11:46:16AM -0600, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
> 
> Signed-off-by: Rob Herring 

I went through all of the changes and they look fine to me.

Reviewed-by: Andi Shyti  

Thanks,
Andi

[PATCH] I2C: Explicitly include correct DT includes

2023-07-14 Thread Rob Herring 
The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.

Signed-off-by: Rob Herring 
---
 drivers/i2c/busses/i2c-at91-core.c| 1 -
 drivers/i2c/busses/i2c-at91-master.c  | 1 -
 drivers/i2c/busses/i2c-bcm-iproc.c| 2 +-
 drivers/i2c/busses/i2c-bcm2835.c  | 2 +-
 drivers/i2c/busses/i2c-cpm.c  | 4 ++--
 drivers/i2c/busses/i2c-davinci.c  | 2 +-
 drivers/i2c/busses/i2c-emev2.c| 2 +-
 drivers/i2c/busses/i2c-exynos5.c  | 4 +---
 drivers/i2c/busses/i2c-gxp.c  | 3 ++-
 drivers/i2c/busses/i2c-ibm_iic.c  | 3 ++-
 drivers/i2c/busses/i2c-imx-lpi2c.c| 1 -
 drivers/i2c/busses/i2c-imx.c  | 1 -
 drivers/i2c/busses/i2c-jz4780.c   | 2 +-
 drivers/i2c/busses/i2c-lpc2k.c| 1 -
 drivers/i2c/busses/i2c-meson.c| 1 -
 drivers/i2c/busses/i2c-mlxbf.c| 2 +-
 drivers/i2c/busses/i2c-mpc.c  | 3 ++-
 drivers/i2c/busses/i2c-mt65xx.c   | 4 +---
 drivers/i2c/busses/i2c-mt7621.c   | 3 ++-
 drivers/i2c/busses/i2c-mxs.c  | 1 -
 drivers/i2c/busses/i2c-npcm7xx.c  | 1 -
 drivers/i2c/busses/i2c-owl.c  | 3 ++-
 drivers/i2c/busses/i2c-pca-platform.c | 1 -
 drivers/i2c/busses/i2c-pxa-pci.c  | 1 -
 drivers/i2c/busses/i2c-rcar.c | 2 +-
 drivers/i2c/busses/i2c-riic.c | 1 -
 drivers/i2c/busses/i2c-s3c2410.c  | 1 -
 drivers/i2c/busses/i2c-sh_mobile.c| 2 +-
 drivers/i2c/busses/i2c-sprd.c | 1 -
 drivers/i2c/busses/i2c-tegra-bpmp.c   | 2 +-
 drivers/i2c/busses/i2c-tegra.c| 2 +-
 drivers/i2c/muxes/i2c-mux-gpmux.c | 2 +-
 drivers/i2c/muxes/i2c-mux-ltc4306.c   | 1 -
 33 files changed, 25 insertions(+), 38 deletions(-)

diff --git a/drivers/i2c/busses/i2c-at91-core.c 
b/drivers/i2c/busses/i2c-at91-core.c
index 05ad3bc3578a..3563a7fd75db 100644
--- a/drivers/i2c/busses/i2c-at91-core.c
+++ b/drivers/i2c/busses/i2c-at91-core.c
@@ -19,7 +19,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/i2c/busses/i2c-at91-master.c 
b/drivers/i2c/busses/i2c-at91-master.c
index c0c35785a0dc..94cff1cd527e 100644
--- a/drivers/i2c/busses/i2c-at91-master.c
+++ b/drivers/i2c/busses/i2c-at91-master.c
@@ -23,7 +23,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c 
b/drivers/i2c/busses/i2c-bcm-iproc.c
index 2d8342fdc25d..37d559bc51c4 100644
--- a/drivers/i2c/busses/i2c-bcm-iproc.c
+++ b/drivers/i2c/busses/i2c-bcm-iproc.c
@@ -7,7 +7,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 
diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c
index 8ce6d3f49551..2743e59184b3 100644
--- a/drivers/i2c/busses/i2c-bcm2835.c
+++ b/drivers/i2c/busses/i2c-bcm2835.c
@@ -12,7 +12,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 
diff --git a/drivers/i2c/busses/i2c-cpm.c b/drivers/i2c/busses/i2c-cpm.c
index 732daf6a932b..9a664abf734d 100644
--- a/drivers/i2c/busses/i2c-cpm.c
+++ b/drivers/i2c/busses/i2c-cpm.c
@@ -26,10 +26,10 @@
 #include 
 #include 
 #include 
+#include 
 #include 
-#include 
 #include 
-#include 
+#include 
 #include 
 #include 
 
diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
index 71b60778c643..927ea9ba74ab 100644
--- a/drivers/i2c/busses/i2c-davinci.c
+++ b/drivers/i2c/busses/i2c-davinci.c
@@ -25,7 +25,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 
diff --git a/drivers/i2c/busses/i2c-emev2.c b/drivers/i2c/busses/i2c-emev2.c
index 4ba93cd91c0f..557409410445 100644
--- a/drivers/i2c/busses/i2c-emev2.c
+++ b/drivers/i2c/busses/i2c-emev2.c
@@ -16,7 +16,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 
diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers/i2c/busses/i2c-exynos5.c
index f378cd479e55..7668210a59d5 100644
--- a/drivers/i2c/busses/i2c-exynos5.c
+++ b/drivers/i2c/busses/i2c-exynos5.c
@@ -18,9 +18,7 @@
 #include 
 #include 
 #include 
-#include 
-#include 
-#include 
+#include 
 #include 
 
 /*
diff --git a/drivers/i2c/busses/i2c-gxp.c b/drivers/i2c/busses/i2c-gxp.c
index 70b0de07ed99..efafc0528c44 100644
--- a/drivers/i2c/busses/i2c-gxp.c
+++ b/drivers/i2c/busses/i2c-gxp.c
@@ -4,8 +4,9 @@
 #include 
 #include 
 #include 
+#include 
 #include 
-#include 
+#include 
 #include 
 #include 
 
diff --git a/drivers/i2c/busses/i2c-ibm_iic.c b/drivers/i2c/busses/i2c-ibm_iic.c
index 1ad9d3b26dd3..408820319ec4 100644
---