The constants are 64bit but not explicitly declared UL resulting
in sparse warnings. Fixed by declaring the constants UL.
Signed-off-by: Nicholas Mc Guire
---
sparse fallout from compile checking book3s_hv.c:
arch/powerpc/kvm/book3s_hv.c:141:9: warning: constant 0x164520C62609AECA is so
big it is long
arch/powerpc/kvm/book3s_hv.c:142:9: warning: constant 0x164520C62609AECA is so
big it is long
arch/powerpc/kvm/book3s_hv.c:143:9: warning: constant 0x7FFF2908450D8DA9 is so
big it is long
arch/powerpc/kvm/book3s_hv.c:144:9: warning: constant 0x164520C62609AECA is so
big it is long
arch/powerpc/kvm/book3s_hv.c:145:9: warning: constant 0x199A421245058DA9 is so
big it is long
arch/powerpc/kvm/book3s_hv.c:146:9: warning: constant 0x164520C62609AECA is so
big it is long
arch/powerpc/kvm/book3s_hv.c:147:9: warning: constant 0x164520C62609AECA is so
big it is long
arch/powerpc/kvm/book3s_hv.c:148:9: warning: constant 0x164520C62609AECA is so
big it is long
arch/powerpc/kvm/book3s_hv.c:149:9: warning: constant 0x164520C62609AECA is so
big it is long
arch/powerpc/kvm/book3s_hv.c:1667:60: warning: constant 0xf3ff is
so big it is unsigned long
arch/powerpc/kvm/book3s_hv.c:2896:42: warning: constant 0x164520C62609AECA is
so big it is long
most of the warnings are local constants in book3s_hv.c, PSSCR_GUEST_VIS
from reg.h is not. Although PSSCR_GUEST_VIS is not #ifdef CONFIG_PPC_BOOK3S
it seems only to be used in that particular platform (check with cscope).
The constants fit in the target variables so the size declaration
discrepancy does not actually cause a problem here.
Patch was compiletested with: ppc64_defconfig (implies
CONFIG_KVM=y, CONFIG_KVM_BOOK3S_64_HV=m)
Patch is against 4.18-rc3 (localversion-next is next-20180705)
arch/powerpc/include/asm/reg.h | 2 +-
arch/powerpc/kvm/book3s_hv.c | 16
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/powerpc/include/asm/reg.h b/arch/powerpc/include/asm/reg.h
index 5625684..858aa79 100644
--- a/arch/powerpc/include/asm/reg.h
+++ b/arch/powerpc/include/asm/reg.h
@@ -161,7 +161,7 @@
#define PSSCR_ESL 0x0020 /* Enable State Loss */
#define PSSCR_SD 0x0040 /* Status Disable */
#define PSSCR_PLS 0xf000 /* Power-saving Level Status */
-#define PSSCR_GUEST_VIS0xf3ff /* Guest-visible PSSCR
fields */
+#define PSSCR_GUEST_VIS0xf3ffUL /* Guest-visible PSSCR
fields */
#define PSSCR_FAKE_SUSPEND 0x0400 /* Fake-suspend bit (P9 DD2.2) */
#define PSSCR_FAKE_SUSPEND_LG 10 /* Fake-suspend bit position */
diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c
index ee4a885..c517859 100644
--- a/arch/powerpc/kvm/book3s_hv.c
+++ b/arch/powerpc/kvm/book3s_hv.c
@@ -128,14 +128,14 @@ static int kvmppc_hv_setup_htab_rma(struct kvm_vcpu
*vcpu);
* and SPURR count and should be set according to the number of
* online threads in the vcore being run.
*/
-#define RWMR_RPA_P8_1THREAD0x164520C62609AECA
-#define RWMR_RPA_P8_2THREAD0x7FFF2908450D8DA9
-#define RWMR_RPA_P8_3THREAD0x164520C62609AECA
-#define RWMR_RPA_P8_4THREAD0x199A421245058DA9
-#define RWMR_RPA_P8_5THREAD0x164520C62609AECA
-#define RWMR_RPA_P8_6THREAD0x164520C62609AECA
-#define RWMR_RPA_P8_7THREAD0x164520C62609AECA
-#define RWMR_RPA_P8_8THREAD0x164520C62609AECA
+#define RWMR_RPA_P8_1THREAD0x164520C62609AECAUL
+#define RWMR_RPA_P8_2THREAD0x7FFF2908450D8DA9UL
+#define RWMR_RPA_P8_3THREAD0x164520C62609AECAUL
+#define RWMR_RPA_P8_4THREAD0x199A421245058DA9UL
+#define RWMR_RPA_P8_5THREAD0x164520C62609AECAUL
+#define RWMR_RPA_P8_6THREAD0x164520C62609AECAUL
+#define RWMR_RPA_P8_7THREAD0x164520C62609AECAUL
+#define RWMR_RPA_P8_8THREAD0x164520C62609AECAUL
static unsigned long p8_rwmr_values[MAX_SMT_THREADS + 1] = {
RWMR_RPA_P8_1THREAD,
--
2.1.4
