Re: [PATCH] KVM: PPC: Use the arg->size directly for kvm_vm_ioctl_create_spapr_tce

[Michael Ellerman]

On Sun, 3 Jul 2022 13:29:32 -0400, Deming Wang wrote:
> Use arg->size directly may be better for code readability.Because, the
> variable of size has not been found for special purpose  at present.
> Also,We can reduce the use of a variable.
> 
> 

Applied to powerpc/next.

[1/1] KVM: PPC: Use the arg->size directly for kvm_vm_ioctl_create_spapr_tce
  https://git.kernel.org/powerpc/c/6fa1efeaa6671fb7339a6c62ceeec19e8e787963

cheers

[PATCH] KVM: PPC: Use the arg->size directly for kvm_vm_ioctl_create_spapr_tce

[Deming Wang]

Use arg->size directly may be better for code readability.Because, the
variable of size has not been found for special purpose  at present.
Also,We can reduce the use of a variable.

Signed-off-by: Deming Wang 
---
 arch/powerpc/kvm/book3s_64_vio.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/kvm/book3s_64_vio.c b/arch/powerpc/kvm/book3s_64_vio.c
index d6589c4fe889..5f74ffb88e82 100644
--- a/arch/powerpc/kvm/book3s_64_vio.c
+++ b/arch/powerpc/kvm/book3s_64_vio.c
@@ -294,14 +294,14 @@ long kvm_vm_ioctl_create_spapr_tce(struct kvm *kvm,
struct kvmppc_spapr_tce_table *stt = NULL;
struct kvmppc_spapr_tce_table *siter;
struct mm_struct *mm = kvm->mm;
-   unsigned long npages, size = args->size;
+   unsigned long npages;
int ret;
 
if (!args->size || args->page_shift < 12 || args->page_shift > 34 ||
(args->offset + args->size > (ULLONG_MAX >> args->page_shift)))
return -EINVAL;
 
-   npages = kvmppc_tce_pages(size);
+   npages = kvmppc_tce_pages(args->size);
ret = account_locked_vm(mm, kvmppc_stt_pages(npages), true);
if (ret)
return ret;
@@ -314,7 +314,7 @@ long kvm_vm_ioctl_create_spapr_tce(struct kvm *kvm,
stt->liobn = args->liobn;
stt->page_shift = args->page_shift;
stt->offset = args->offset;
-   stt->size = size;
+   stt->size = args->size;
stt->kvm = kvm;
mutex_init(>alloc_lock);
INIT_LIST_HEAD_RCU(>iommu_tables);
-- 
2.27.0