Re: [PATCH] Pass actual dev ptr to dma_* in ucc and cpm_uart serial
On Sep 8, 2008, at 2:56 PM, Scott Wood wrote: Becky Bruce wrote: We're currently passing NULL, and really shouldn't be. This patch doesn't change that for cpm2, since port.dev is never initialized. :-P Signed-off-by: Becky Bruce [EMAIL PROTECTED] --- drivers/serial/cpm_uart/cpm_uart_cpm2.c |6 +++--- drivers/serial/ucc_uart.c |4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) cpm_uart_cpm1.c has the same problem. -Scott Good catch, thanks! Will respin. Cheers, B ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] Pass actual dev ptr to dma_* in ucc and cpm_uart serial
On Mon, Sep 8, 2008 at 2:56 PM, Scott Wood [EMAIL PROTECTED] wrote: This patch doesn't change that for cpm2, since port.dev is never initialized. :-P I don't initialize port-dev in the UCC UART driver, but it's still non-zero, so why isn't it initialized in the CPM UART driver? (P.S. Becky - please CC: me on any UCC UART or QE LIB patches) -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] Pass actual dev ptr to dma_* in ucc and cpm_uart serial
Timur Tabi wrote: On Mon, Sep 8, 2008 at 2:56 PM, Scott Wood [EMAIL PROTECTED] wrote: This patch doesn't change that for cpm2, since port.dev is never initialized. :-P I don't initialize port-dev in the UCC UART driver, Yes you do -- check line 1403. -Scott ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] Pass actual dev ptr to dma_* in ucc and cpm_uart serial
Becky Bruce wrote: We're currently passing NULL, and really shouldn't be. This patch doesn't change that for cpm2, since port.dev is never initialized. :-P Signed-off-by: Becky Bruce [EMAIL PROTECTED] --- drivers/serial/cpm_uart/cpm_uart_cpm2.c |6 +++--- drivers/serial/ucc_uart.c |4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) cpm_uart_cpm1.c has the same problem. -Scott ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
