RE: [PATCH] fsl/fman: add dependency on HAS_DMA
> -Original Message-
> From: geert.uytterhoe...@gmail.com [mailto:geert.uytterhoe...@gmail.com]
> On Behalf Of Geert Uytterhoeven
> Sent: Monday, June 26, 2017 7:17 PM
> To: Fabio Estevam
> Cc: Madalin-cristian Bucur ;
> net...@vger.kernel.org; David S. Miller ; linuxppc-
> d...@lists.ozlabs.org; linux-kernel
> Subject: Re: [PATCH] fsl/fman: add dependency on HAS_DMA
>
> On Mon, Jun 26, 2017 at 5:20 PM, Fabio Estevam wrote:
> > On Mon, Jun 26, 2017 at 12:12 PM, Madalin Bucur
> wrote:
> >> A previous commit inserted a dependency on DMA API that requires
> >> HAS_DMA to be added in Kconfig.
> >
> > It would be nice to specify the commit that caused this.
>
> That would be commit 5567e989198b5a8d ("fsl/fman: propagate dma_ops").
>
> However, none of the fman code uses any DMA API calls, so IMHO
> the set_dma_ops() should be done somewhere else.
The Ethernet driver is making use of the DMA ops set here.
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker.
> But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
Re: [PATCH] fsl/fman: add dependency on HAS_DMA
On Mon, Jun 26, 2017 at 5:20 PM, Fabio Estevam wrote:
> On Mon, Jun 26, 2017 at 12:12 PM, Madalin Bucur wrote:
>> A previous commit inserted a dependency on DMA API that requires
>> HAS_DMA to be added in Kconfig.
>
> It would be nice to specify the commit that caused this.
That would be commit 5567e989198b5a8d ("fsl/fman: propagate dma_ops").
However, none of the fman code uses any DMA API calls, so IMHO
the set_dma_ops() should be done somewhere else.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
RE: [PATCH] fsl/fman: add dependency on HAS_DMA
> -Original Message- > From: Fabio Estevam [mailto:feste...@gmail.com] > Sent: Monday, June 26, 2017 6:21 PM > To: Madalin-cristian Bucur > Cc: net...@vger.kernel.org; David S. Miller ; Geert > Uytterhoeven ; linuxppc-dev@lists.ozlabs.org; linux- > kernel > Subject: Re: [PATCH] fsl/fman: add dependency on HAS_DMA > > On Mon, Jun 26, 2017 at 12:12 PM, Madalin Bucur > wrote: > > A previous commit inserted a dependency on DMA API that requires > > HAS_DMA to be added in Kconfig. > > It would be nice to specify the commit that caused this. Sent v2, thanks. Madalin
Re: [PATCH] fsl/fman: add dependency on HAS_DMA
On Mon, Jun 26, 2017 at 12:12 PM, Madalin Bucur wrote: > A previous commit inserted a dependency on DMA API that requires > HAS_DMA to be added in Kconfig. It would be nice to specify the commit that caused this.
[PATCH] fsl/fman: add dependency on HAS_DMA
A previous commit inserted a dependency on DMA API that requires HAS_DMA to be added in Kconfig. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/freescale/fman/Kconfig b/drivers/net/ethernet/freescale/fman/Kconfig index dc0850b..8870a9a 100644 --- a/drivers/net/ethernet/freescale/fman/Kconfig +++ b/drivers/net/ethernet/freescale/fman/Kconfig @@ -2,6 +2,7 @@ config FSL_FMAN tristate "FMan support" depends on FSL_SOC || ARCH_LAYERSCAPE || COMPILE_TEST select GENERIC_ALLOCATOR + depends on HAS_DMA select PHYLIB default n help -- 2.1.0
