Re: [PATCH] gianfar: fix coalescing setup in ethtool support

2009-07-30 Thread David Miller
From: Li Yang 
Date: Wed, 29 Jul 2009 16:51:57 +0800

> Parameter order for using mk_ic_value(count, time) was reversed,
> the patch fixes this.
> 
> Signed-off-by: Jiajun Wu 
> Signed-off-by: Li Yang 

Applied, thanks.
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


[PATCH] gianfar: fix coalescing setup in ethtool support

2009-07-29 Thread Li Yang
From: Jiajun Wu 

Parameter order for using mk_ic_value(count, time) was reversed,
the patch fixes this.

Signed-off-by: Jiajun Wu 
Signed-off-by: Li Yang 
---
 drivers/net/gianfar_ethtool.c |   10 --
 1 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/net/gianfar_ethtool.c b/drivers/net/gianfar_ethtool.c
index 2a7edfa..3109f4b 100644
--- a/drivers/net/gianfar_ethtool.c
+++ b/drivers/net/gianfar_ethtool.c
@@ -373,9 +373,8 @@ static int gfar_scoalesce(struct net_device *dev, struct 
ethtool_coalesce *cvals
return -EINVAL;
}
 
-   priv->rxic = mk_ic_value(
-   gfar_usecs2ticks(priv, cvals->rx_coalesce_usecs),
-   cvals->rx_max_coalesced_frames);
+   priv->rxic = mk_ic_value(cvals->rx_max_coalesced_frames,
+   gfar_usecs2ticks(priv, cvals->rx_coalesce_usecs));
 
/* Set up tx coalescing */
if ((cvals->tx_coalesce_usecs == 0) ||
@@ -397,9 +396,8 @@ static int gfar_scoalesce(struct net_device *dev, struct 
ethtool_coalesce *cvals
return -EINVAL;
}
 
-   priv->txic = mk_ic_value(
-   gfar_usecs2ticks(priv, cvals->tx_coalesce_usecs),
-   cvals->tx_max_coalesced_frames);
+   priv->txic = mk_ic_value(cvals->tx_max_coalesced_frames,
+   gfar_usecs2ticks(priv, cvals->tx_coalesce_usecs));
 
gfar_write(&priv->regs->rxic, 0);
if (priv->rxcoalescing)
-- 
1.5.6.3

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev