Re: [PATCH] leds-PowerNV: Delete an error message for a failed memory allocation in powernv_led_create()

[Jacek Anaszewski]

Hi Markus,

Thanks for the patch.

On 08/27/2017 10:10 PM, SF Markus Elfring wrote:
> From: Markus Elfring 
> Date: Sun, 27 Aug 2017 22:00:22 +0200
> 
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring 
> ---
>  drivers/leds/leds-powernv.c | 6 +-
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/leds/leds-powernv.c b/drivers/leds/leds-powernv.c
> index b2a98c7b521b..b1adbd70ce2e 100644
> --- a/drivers/leds/leds-powernv.c
> +++ b/drivers/leds/leds-powernv.c
> @@ -224,12 +224,8 @@ static int powernv_led_create(struct device *dev,
>   powernv_led->cdev.name = devm_kasprintf(dev, GFP_KERNEL, "%s:%s",
>   powernv_led->loc_code,
>   led_type_desc);
> - if (!powernv_led->cdev.name) {
> - dev_err(dev,
> - "%s: Memory allocation failed for classdev name\n",
> - __func__);
> + if (!powernv_led->cdev.name)
>   return -ENOMEM;
> - }
>  
>   powernv_led->cdev.brightness_set_blocking = powernv_brightness_set;
>   powernv_led->cdev.brightness_get = powernv_brightness_get;
> 

Applied.

-- 
Best regards,
Jacek Anaszewski

Re: [PATCH] leds-PowerNV: Delete an error message for a failed memory allocation in powernv_led_create()

[Pavel Machek]

On Sun 2017-08-27 22:10:08, SF Markus Elfring wrote:
> From: Markus Elfring 
> Date: Sun, 27 Aug 2017 22:00:22 +0200
> 
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring 

Acked-by: Pavel Machek 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


signature.asc
Description: Digital signature

[PATCH] leds-PowerNV: Delete an error message for a failed memory allocation in powernv_led_create()

[SF Markus Elfring]

From: Markus Elfring 
Date: Sun, 27 Aug 2017 22:00:22 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
---
 drivers/leds/leds-powernv.c | 6 +-
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/leds/leds-powernv.c b/drivers/leds/leds-powernv.c
index b2a98c7b521b..b1adbd70ce2e 100644
--- a/drivers/leds/leds-powernv.c
+++ b/drivers/leds/leds-powernv.c
@@ -224,12 +224,8 @@ static int powernv_led_create(struct device *dev,
powernv_led->cdev.name = devm_kasprintf(dev, GFP_KERNEL, "%s:%s",
powernv_led->loc_code,
led_type_desc);
-   if (!powernv_led->cdev.name) {
-   dev_err(dev,
-   "%s: Memory allocation failed for classdev name\n",
-   __func__);
+   if (!powernv_led->cdev.name)
return -ENOMEM;
-   }
 
powernv_led->cdev.brightness_set_blocking = powernv_brightness_set;
powernv_led->cdev.brightness_get = powernv_brightness_get;
-- 
2.14.1