Re: [PATCH] lib: Consolidate DEBUG_STACK_USAGE option

2011-05-18 Thread Benjamin Herrenschmidt
On Fri, 2011-05-06 at 22:57 -0700, Stephen Boyd wrote:
 Most arches define CONFIG_DEBUG_STACK_USAGE exactly the same way.
 Move it to lib/Kconfig.debug so each arch doesn't have to define
 it. This obviously makes the option generic, but that's fine
 because the config is already used in generic code.
 
 It's not obvious to me that sysrq-P actually does anything
 different with this option enabled, but I erred on the side of
 caution by keeping the most inclusive wording.

Sorry for the delay...

For powerpc:

Acked-by: Benjamin Herrenschmidt b...@kernel.crashing.org

Cheers,
Ben.


___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Re: [PATCH] lib: Consolidate DEBUG_STACK_USAGE option

2011-05-10 Thread Ralf Baechle
On Fri, May 06, 2011 at 10:57:11PM -0700, Stephen Boyd wrote:

Acked-by: Ralf Baechle r...@linux-mips.org

  Ralf
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Re: [PATCH] lib: Consolidate DEBUG_STACK_USAGE option

2011-05-07 Thread David Miller
From: Stephen Boyd sb...@codeaurora.org
Date: Fri,  6 May 2011 22:57:11 -0700

 Most arches define CONFIG_DEBUG_STACK_USAGE exactly the same way.
 Move it to lib/Kconfig.debug so each arch doesn't have to define
 it. This obviously makes the option generic, but that's fine
 because the config is already used in generic code.
 
 It's not obvious to me that sysrq-P actually does anything
 different with this option enabled, but I erred on the side of
 caution by keeping the most inclusive wording.
 
 Cc: linux-a...@vger.kernel.org
 Cc: linux-arm-ker...@lists.infradead.org
 Cc: uclinux-dist-de...@blackfin.uclinux.org
 Cc: linux-m...@ml.linux-m32r.org
 Cc: linux-m...@linux-mips.org
 Cc: linuxppc-dev@lists.ozlabs.org
 Cc: linux...@vger.kernel.org
 Cc: sparcli...@vger.kernel.org
 Cc: Chris Metcalf cmetc...@tilera.com
 Cc: user-mode-linux-de...@lists.sourceforge.net
 Cc: x...@kernel.org
 Signed-off-by: Stephen Boyd sb...@codeaurora.org

Acked-by: David S. Miller da...@davemloft.net
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Re: [PATCH] lib: Consolidate DEBUG_STACK_USAGE option

2011-05-07 Thread richard -rw- weinberger
On Sat, May 7, 2011 at 7:57 AM, Stephen Boyd sb...@codeaurora.org wrote:
 Most arches define CONFIG_DEBUG_STACK_USAGE exactly the same way.
 Move it to lib/Kconfig.debug so each arch doesn't have to define
 it. This obviously makes the option generic, but that's fine
 because the config is already used in generic code.

 It's not obvious to me that sysrq-P actually does anything
 different with this option enabled, but I erred on the side of
 caution by keeping the most inclusive wording.

 Cc: linux-a...@vger.kernel.org
 Cc: linux-arm-ker...@lists.infradead.org
 Cc: uclinux-dist-de...@blackfin.uclinux.org
 Cc: linux-m...@ml.linux-m32r.org
 Cc: linux-m...@linux-mips.org
 Cc: linuxppc-dev@lists.ozlabs.org
 Cc: linux...@vger.kernel.org
 Cc: sparcli...@vger.kernel.org
 Cc: Chris Metcalf cmetc...@tilera.com
 Cc: user-mode-linux-de...@lists.sourceforge.net
 Cc: x...@kernel.org
 Signed-off-by: Stephen Boyd sb...@codeaurora.org
 ---

Acked-by: Richard Weinberger rich...@nod.at

-- 
Thanks,
//richard
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Re: [PATCH] lib: Consolidate DEBUG_STACK_USAGE option

2011-05-07 Thread Mike Frysinger
On Sat, May 7, 2011 at 01:57, Stephen Boyd wrote:
 Most arches define CONFIG_DEBUG_STACK_USAGE exactly the same way.
 Move it to lib/Kconfig.debug so each arch doesn't have to define
 it. This obviously makes the option generic, but that's fine
 because the config is already used in generic code.

 It's not obvious to me that sysrq-P actually does anything
 different with this option enabled, but I erred on the side of
 caution by keeping the most inclusive wording.

 Cc: uclinux-dist-de...@blackfin.uclinux.org
  arch/blackfin/Kconfig.debug  |    9 -

Acked-by: Mike Frysinger vap...@gentoo.org
-mike
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] lib: Consolidate DEBUG_STACK_USAGE option

2011-05-06 Thread Stephen Boyd
Most arches define CONFIG_DEBUG_STACK_USAGE exactly the same way.
Move it to lib/Kconfig.debug so each arch doesn't have to define
it. This obviously makes the option generic, but that's fine
because the config is already used in generic code.

It's not obvious to me that sysrq-P actually does anything
different with this option enabled, but I erred on the side of
caution by keeping the most inclusive wording.

Cc: linux-a...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: uclinux-dist-de...@blackfin.uclinux.org
Cc: linux-m...@ml.linux-m32r.org
Cc: linux-m...@linux-mips.org
Cc: linuxppc-dev@lists.ozlabs.org
Cc: linux...@vger.kernel.org
Cc: sparcli...@vger.kernel.org
Cc: Chris Metcalf cmetc...@tilera.com
Cc: user-mode-linux-de...@lists.sourceforge.net
Cc: x...@kernel.org
Signed-off-by: Stephen Boyd sb...@codeaurora.org
---

This is on top of mmotm's lib-conslidate-debug_per_cpu_maps patch.

 arch/arm/Kconfig.debug   |7 ---
 arch/blackfin/Kconfig.debug  |9 -
 arch/m32r/Kconfig.debug  |9 -
 arch/mips/Kconfig.debug  |9 -
 arch/powerpc/Kconfig.debug   |9 -
 arch/score/Kconfig.debug |9 -
 arch/sh/Kconfig.debug|9 -
 arch/sparc/Kconfig.debug |9 -
 arch/tile/Kconfig.debug  |9 -
 arch/um/Kconfig.debug|9 -
 arch/unicore32/Kconfig.debug |7 ---
 arch/x86/Kconfig.debug   |9 -
 lib/Kconfig.debug|9 +
 13 files changed, 9 insertions(+), 104 deletions(-)

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 03d01d7..81cbe40 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -63,13 +63,6 @@ config DEBUG_USER
  8 - SIGSEGV faults
 16 - SIGBUS faults
 
-config DEBUG_STACK_USAGE
-   bool Enable stack utilization instrumentation
-   depends on DEBUG_KERNEL
-   help
- Enables the display of the minimum amount of free stack which each
- task has ever had available in the sysrq-T output.
-
 # These options are only for real kernel hackers who want to get their hands 
dirty.
 config DEBUG_LL
bool Kernel low-level debugging functions
diff --git a/arch/blackfin/Kconfig.debug b/arch/blackfin/Kconfig.debug
index 2641731..19ccfb3 100644
--- a/arch/blackfin/Kconfig.debug
+++ b/arch/blackfin/Kconfig.debug
@@ -9,15 +9,6 @@ config DEBUG_STACKOVERFLOW
  This option will cause messages to be printed if free stack space
  drops below a certain limit.
 
-config DEBUG_STACK_USAGE
-   bool Enable stack utilization instrumentation
-   depends on DEBUG_KERNEL
-   help
- Enables the display of the minimum amount of free stack which each
- task has ever had available in the sysrq-T output.
-
- This option will slow down process creation somewhat.
-
 config DEBUG_VERBOSE
bool Verbose fault messages
default y
diff --git a/arch/m32r/Kconfig.debug b/arch/m32r/Kconfig.debug
index 2e1019d..bb1afc1 100644
--- a/arch/m32r/Kconfig.debug
+++ b/arch/m32r/Kconfig.debug
@@ -9,15 +9,6 @@ config DEBUG_STACKOVERFLOW
  This option will cause messages to be printed if free stack space
  drops below a certain limit.
 
-config DEBUG_STACK_USAGE
-   bool Stack utilization instrumentation
-   depends on DEBUG_KERNEL
-   help
- Enables the display of the minimum amount of free stack which each
- task has ever had available in the sysrq-T and sysrq-P debug output.
-
- This option will slow down process creation somewhat.
-
 config DEBUG_PAGEALLOC
bool Debug page memory allocations
depends on DEBUG_KERNEL  BROKEN
diff --git a/arch/mips/Kconfig.debug b/arch/mips/Kconfig.debug
index 5358f90..83ed00a 100644
--- a/arch/mips/Kconfig.debug
+++ b/arch/mips/Kconfig.debug
@@ -76,15 +76,6 @@ config DEBUG_STACKOVERFLOW
  provides another way to check stack overflow happened on kernel mode
  stack usually caused by nested interruption.
 
-config DEBUG_STACK_USAGE
-   bool Enable stack utilization instrumentation
-   depends on DEBUG_KERNEL
-   help
- Enables the display of the minimum amount of free stack which each
- task has ever had available in the sysrq-T and sysrq-P debug output.
-
- This option will slow down process creation somewhat.
-
 config SMTC_IDLE_HOOK_DEBUG
bool Enable additional debug checks before going into CPU idle loop
depends on DEBUG_KERNEL  MIPS_MT_SMTC
diff --git a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug
index 12a8d18..f862fc0 100644
--- a/arch/powerpc/Kconfig.debug
+++ b/arch/powerpc/Kconfig.debug
@@ -35,15 +35,6 @@ config DEBUG_STACKOVERFLOW
  This option will cause messages to be printed if free stack space
  drops below a certain limit.
 
-config DEBUG_STACK_USAGE
-   bool Stack utilization instrumentation
-