Re: [PATCH] powerpc/32: add missing \n at end of printk warning message
Christophe Leroy writes: > Le 12/09/2016 à 12:12, Colin King a écrit : >> diff --git a/arch/powerpc/mm/init_32.c b/arch/powerpc/mm/init_32.c >> index 448685f..b532dd9 100644 >> --- a/arch/powerpc/mm/init_32.c >> +++ b/arch/powerpc/mm/init_32.c >> @@ -137,7 +137,7 @@ void __init MMU_init(void) >> if (memblock.memory.cnt > 1) { >> #ifndef CONFIG_WII >> memblock_enforce_memory_limit(memblock.memory.regions[0].size); >> -printk(KERN_WARNING "Only using first contiguous memory >> region"); >> +printk(KERN_WARNING "Only using first contiguous memory >> region\n"); > > This line was already 81 characters long. It is now 83. That doesn't really bother me. > I would suggest to use pr_warn() instead in order to shorten the line. But I do like pr_warn(), it's less shouty. I'll fix it up when I apply it. cheers
Re: [PATCH] powerpc/32: add missing \n at end of printk warning message
On 12/09/16 17:34, Joe Perches wrote: > On Mon, 2016-09-12 at 11:12 +0100, Colin King wrote: >> From: Colin Ian King >> The message is missing a \n, add it. > > Was this found via inspection or a tool? > grep
Re: [PATCH] powerpc/32: add missing \n at end of printk warning message
On Mon, 2016-09-12 at 11:12 +0100, Colin King wrote: > From: Colin Ian King > The message is missing a \n, add it. Was this found via inspection or a tool?
Re: [PATCH] powerpc/32: add missing \n at end of printk warning message
Le 12/09/2016 à 12:12, Colin King a écrit : From: Colin Ian King The message is missing a \n, add it. Signed-off-by: Colin Ian King --- arch/powerpc/mm/init_32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/mm/init_32.c b/arch/powerpc/mm/init_32.c index 448685f..b532dd9 100644 --- a/arch/powerpc/mm/init_32.c +++ b/arch/powerpc/mm/init_32.c @@ -137,7 +137,7 @@ void __init MMU_init(void) if (memblock.memory.cnt > 1) { #ifndef CONFIG_WII memblock_enforce_memory_limit(memblock.memory.regions[0].size); - printk(KERN_WARNING "Only using first contiguous memory region"); + printk(KERN_WARNING "Only using first contiguous memory region\n"); This line was already 81 characters long. It is now 83. I would suggest to use pr_warn() instead in order to shorten the line. Christophe #else wii_memory_fixups(); #endif
[PATCH] powerpc/32: add missing \n at end of printk warning message
From: Colin Ian King The message is missing a \n, add it. Signed-off-by: Colin Ian King --- arch/powerpc/mm/init_32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/mm/init_32.c b/arch/powerpc/mm/init_32.c index 448685f..b532dd9 100644 --- a/arch/powerpc/mm/init_32.c +++ b/arch/powerpc/mm/init_32.c @@ -137,7 +137,7 @@ void __init MMU_init(void) if (memblock.memory.cnt > 1) { #ifndef CONFIG_WII memblock_enforce_memory_limit(memblock.memory.regions[0].size); - printk(KERN_WARNING "Only using first contiguous memory region"); + printk(KERN_WARNING "Only using first contiguous memory region\n"); #else wii_memory_fixups(); #endif -- 2.9.3