[PATCH] powerpc/4xx: Fix warning in kilauea.dtb
Currently I see:
DTC arch/powerpc/boot/kilauea.dtb
Warning (reg_format): reg property in /plb/ppc4xx-msi@C1000 has invalid
length (12 bytes) (#address-cells == 1, #size-cells == 1)
It appears that unlike the other platforms handled by 3fb7933850fa
powerpc/4xx: Adding PCIe MSI support this platform does not use
address-cells=2.
Signed-off-by: Ian Campbell ian.campb...@citrix.com
Acked-by: Josh Boyer jwbo...@gmail.com
Cc: Rupjyoti Sarmah rsar...@apm.com
Cc: Tirumala R Marri tma...@apm.com
Cc: Benjamin Herrenschmidt b...@kernel.crashing.org
Cc: Paul Mackerras pau...@samba.org
Cc: devicet...@vger.kernel.org (open list:OPEN FIRMWARE AND...)
Cc: linuxppc-dev@lists.ozlabs.org
Cc: linux-ker...@vger.kernel.org
---
Resending, this hasn't been picked up since June
http://patchwork.ozlabs.org/patch/248234/
---
arch/powerpc/boot/dts/kilauea.dts |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/boot/dts/kilauea.dts
b/arch/powerpc/boot/dts/kilauea.dts
index 1613d6e..5ba7f01 100644
--- a/arch/powerpc/boot/dts/kilauea.dts
+++ b/arch/powerpc/boot/dts/kilauea.dts
@@ -406,7 +406,7 @@
MSI: ppc4xx-msi@C1000 {
compatible = amcc,ppc4xx-msi, ppc4xx-msi;
- reg = 0x0 0xEF62 0x100;
+ reg = 0xEF62 0x100;
sdr-base = 0x4B0;
msi-data = 0x;
msi-mask = 0x;
--
1.7.10.4
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH] powerpc/4xx: Fix warning in kilauea.dtb
On Mon, Nov 25, 2013 at 4:40 AM, Ian Campbell ian.campb...@citrix.com wrote:
Currently I see:
DTC arch/powerpc/boot/kilauea.dtb
Warning (reg_format): reg property in /plb/ppc4xx-msi@C1000 has invalid
length (12 bytes) (#address-cells == 1, #size-cells == 1)
It appears that unlike the other platforms handled by 3fb7933850fa
powerpc/4xx: Adding PCIe MSI support this platform does not use
address-cells=2.
Signed-off-by: Ian Campbell ian.campb...@citrix.com
Acked-by: Josh Boyer jwbo...@gmail.com
Cc: Rupjyoti Sarmah rsar...@apm.com
Cc: Tirumala R Marri tma...@apm.com
Cc: Benjamin Herrenschmidt b...@kernel.crashing.org
Cc: Paul Mackerras pau...@samba.org
Cc: devicet...@vger.kernel.org (open list:OPEN FIRMWARE AND...)
Cc: linuxppc-dev@lists.ozlabs.org
Cc: linux-ker...@vger.kernel.org
---
Resending, this hasn't been picked up since June
http://patchwork.ozlabs.org/patch/248234/
Ben, please pick this up.
josh
---
arch/powerpc/boot/dts/kilauea.dts |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/boot/dts/kilauea.dts
b/arch/powerpc/boot/dts/kilauea.dts
index 1613d6e..5ba7f01 100644
--- a/arch/powerpc/boot/dts/kilauea.dts
+++ b/arch/powerpc/boot/dts/kilauea.dts
@@ -406,7 +406,7 @@
MSI: ppc4xx-msi@C1000 {
compatible = amcc,ppc4xx-msi, ppc4xx-msi;
- reg = 0x0 0xEF62 0x100;
+ reg = 0xEF62 0x100;
sdr-base = 0x4B0;
msi-data = 0x;
msi-mask = 0x;
--
1.7.10.4
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH] powerpc/4xx: Fix warning in kilauea.dtb
On Mon, 2013-06-03 at 09:36 -0400, Josh Boyer wrote:
On Mon, Jun 03, 2013 at 12:00:24PM +0100, Ian Campbell wrote:
Currently I see:
DTC arch/powerpc/boot/kilauea.dtb
Warning (reg_format): reg property in /plb/ppc4xx-msi@C1000 has
invalid length (12 bytes) (#address-cells == 1, #size-cells == 1)
It appears that unlike the other plarforms handled by 3fb7933850fa
powerpc/4xx: Adding PCIe MSI support this platform does not use
address-cells=2.
Right, it's a 405, not a 440. I should have caught that in the initial
review.
Signed-off-by: Ian Campbell ian.campb...@citrix.com
Cc: Rupjyoti Sarmah rsar...@apm.com
Cc: Tirumala R Marri tma...@apm.com
Cc: Josh Boyer jwbo...@linux.vnet.ibm.com
That address should bounce. It hasn't been active in almost 2 years.
Cc: Benjamin Herrenschmidt b...@kernel.crashing.org
Cc: Paul Mackerras pau...@samba.org
Cc: linuxppc-dev@lists.ozlabs.org
Cc: linux-ker...@vger.kernel.org
Acked-by: Josh Boyer jwbo...@gmail.com
This still doesn't appear to be fixed v3.12-rc2. Ping?
---
arch/powerpc/boot/dts/kilauea.dts |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/boot/dts/kilauea.dts
b/arch/powerpc/boot/dts/kilauea.dts
index 1613d6e..5ba7f01 100644
--- a/arch/powerpc/boot/dts/kilauea.dts
+++ b/arch/powerpc/boot/dts/kilauea.dts
@@ -406,7 +406,7 @@
MSI: ppc4xx-msi@C1000 {
compatible = amcc,ppc4xx-msi, ppc4xx-msi;
-reg = 0x0 0xEF62 0x100;
+reg = 0xEF62 0x100;
sdr-base = 0x4B0;
msi-data = 0x;
msi-mask = 0x;
--
1.7.10.4
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
[PATCH] powerpc/4xx: Fix warning in kilauea.dtb
Currently I see:
DTC arch/powerpc/boot/kilauea.dtb
Warning (reg_format): reg property in /plb/ppc4xx-msi@C1000 has invalid
length (12 bytes) (#address-cells == 1, #size-cells == 1)
It appears that unlike the other plarforms handled by 3fb7933850fa
powerpc/4xx: Adding PCIe MSI support this platform does not use
address-cells=2.
Signed-off-by: Ian Campbell ian.campb...@citrix.com
Cc: Rupjyoti Sarmah rsar...@apm.com
Cc: Tirumala R Marri tma...@apm.com
Cc: Josh Boyer jwbo...@linux.vnet.ibm.com
Cc: Benjamin Herrenschmidt b...@kernel.crashing.org
Cc: Paul Mackerras pau...@samba.org
Cc: linuxppc-dev@lists.ozlabs.org
Cc: linux-ker...@vger.kernel.org
---
arch/powerpc/boot/dts/kilauea.dts |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/boot/dts/kilauea.dts
b/arch/powerpc/boot/dts/kilauea.dts
index 1613d6e..5ba7f01 100644
--- a/arch/powerpc/boot/dts/kilauea.dts
+++ b/arch/powerpc/boot/dts/kilauea.dts
@@ -406,7 +406,7 @@
MSI: ppc4xx-msi@C1000 {
compatible = amcc,ppc4xx-msi, ppc4xx-msi;
- reg = 0x0 0xEF62 0x100;
+ reg = 0xEF62 0x100;
sdr-base = 0x4B0;
msi-data = 0x;
msi-mask = 0x;
--
1.7.10.4
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH] powerpc/4xx: Fix warning in kilauea.dtb
On Mon, Jun 03, 2013 at 12:00:24PM +0100, Ian Campbell wrote:
Currently I see:
DTC arch/powerpc/boot/kilauea.dtb
Warning (reg_format): reg property in /plb/ppc4xx-msi@C1000 has invalid
length (12 bytes) (#address-cells == 1, #size-cells == 1)
It appears that unlike the other plarforms handled by 3fb7933850fa
powerpc/4xx: Adding PCIe MSI support this platform does not use
address-cells=2.
Right, it's a 405, not a 440. I should have caught that in the initial
review.
Signed-off-by: Ian Campbell ian.campb...@citrix.com
Cc: Rupjyoti Sarmah rsar...@apm.com
Cc: Tirumala R Marri tma...@apm.com
Cc: Josh Boyer jwbo...@linux.vnet.ibm.com
That address should bounce. It hasn't been active in almost 2 years.
Cc: Benjamin Herrenschmidt b...@kernel.crashing.org
Cc: Paul Mackerras pau...@samba.org
Cc: linuxppc-dev@lists.ozlabs.org
Cc: linux-ker...@vger.kernel.org
Acked-by: Josh Boyer jwbo...@gmail.com
---
arch/powerpc/boot/dts/kilauea.dts |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/boot/dts/kilauea.dts
b/arch/powerpc/boot/dts/kilauea.dts
index 1613d6e..5ba7f01 100644
--- a/arch/powerpc/boot/dts/kilauea.dts
+++ b/arch/powerpc/boot/dts/kilauea.dts
@@ -406,7 +406,7 @@
MSI: ppc4xx-msi@C1000 {
compatible = amcc,ppc4xx-msi, ppc4xx-msi;
- reg = 0x0 0xEF62 0x100;
+ reg = 0xEF62 0x100;
sdr-base = 0x4B0;
msi-data = 0x;
msi-mask = 0x;
--
1.7.10.4
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH] powerpc/4xx: Fix warning in kilauea.dtb
On Mon, 2013-06-03 at 09:36 -0400, Josh Boyer wrote:
On Mon, Jun 03, 2013 at 12:00:24PM +0100, Ian Campbell wrote:
Currently I see:
DTC arch/powerpc/boot/kilauea.dtb
Warning (reg_format): reg property in /plb/ppc4xx-msi@C1000 has
invalid length (12 bytes) (#address-cells == 1, #size-cells == 1)
It appears that unlike the other plarforms handled by 3fb7933850fa
powerpc/4xx: Adding PCIe MSI support this platform does not use
address-cells=2.
Right, it's a 405, not a 440. I should have caught that in the initial
review.
Signed-off-by: Ian Campbell ian.campb...@citrix.com
Cc: Rupjyoti Sarmah rsar...@apm.com
Cc: Tirumala R Marri tma...@apm.com
Cc: Josh Boyer jwbo...@linux.vnet.ibm.com
That address should bounce. It hasn't been active in almost 2 years.
Funnily enough the previous patch to this file (where I nabbed the
address from) was approximately that long ago ;-)
I've updated my local copy with your Ack with the correct address,
thanks.
I also corrected the plarforms typo which I just spotted...
Ian.
Cc: Benjamin Herrenschmidt b...@kernel.crashing.org
Cc: Paul Mackerras pau...@samba.org
Cc: linuxppc-dev@lists.ozlabs.org
Cc: linux-ker...@vger.kernel.org
Acked-by: Josh Boyer jwbo...@gmail.com
---
arch/powerpc/boot/dts/kilauea.dts |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/boot/dts/kilauea.dts
b/arch/powerpc/boot/dts/kilauea.dts
index 1613d6e..5ba7f01 100644
--- a/arch/powerpc/boot/dts/kilauea.dts
+++ b/arch/powerpc/boot/dts/kilauea.dts
@@ -406,7 +406,7 @@
MSI: ppc4xx-msi@C1000 {
compatible = amcc,ppc4xx-msi, ppc4xx-msi;
-reg = 0x0 0xEF62 0x100;
+reg = 0xEF62 0x100;
sdr-base = 0x4B0;
msi-data = 0x;
msi-mask = 0x;
--
1.7.10.4
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
