Re: [PATCH] powerpc/ep8248e: Mark driver as non removable

2023-08-10 Thread Michael Ellerman
On Wed, 26 Jul 2023 10:14:42 +0200, Uwe Kleine-König wrote:
> Instead of resorting to BUG() ensure that the driver isn't unbound by
> suppressing its bind and unbind sysfs attributes. As the driver is
> built-in there is no way to remove a device once bound.
> 
> As a nice side effect this allows to drop the remove function.
> 
> 
> [...]

Applied to powerpc/next.

[1/1] powerpc/ep8248e: Mark driver as non removable
  https://git.kernel.org/powerpc/c/bbfa509d632946578d4f19aa2cedf1ca2f34565d

cheers


[PATCH] powerpc/ep8248e: Mark driver as non removable

2023-07-26 Thread Uwe Kleine-König
Instead of resorting to BUG() ensure that the driver isn't unbound by
suppressing its bind and unbind sysfs attributes. As the driver is
built-in there is no way to remove a device once bound.

As a nice side effect this allows to drop the remove function.

Signed-off-by: Uwe Kleine-König 
---
 arch/powerpc/platforms/82xx/ep8248e.c | 8 +---
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/arch/powerpc/platforms/82xx/ep8248e.c 
b/arch/powerpc/platforms/82xx/ep8248e.c
index 8f1856ba692e..3409cf04b630 100644
--- a/arch/powerpc/platforms/82xx/ep8248e.c
+++ b/arch/powerpc/platforms/82xx/ep8248e.c
@@ -140,12 +140,6 @@ static int ep8248e_mdio_probe(struct platform_device 
*ofdev)
return ret;
 }
 
-static int ep8248e_mdio_remove(struct platform_device *ofdev)
-{
-   BUG();
-   return 0;
-}
-
 static const struct of_device_id ep8248e_mdio_match[] = {
{
.compatible = "fsl,ep8248e-mdio-bitbang",
@@ -157,9 +151,9 @@ static struct platform_driver ep8248e_mdio_driver = {
.driver = {
.name = "ep8248e-mdio-bitbang",
.of_match_table = ep8248e_mdio_match,
+   .suppress_bind_attrs = true,
},
.probe = ep8248e_mdio_probe,
-   .remove = ep8248e_mdio_remove,
 };
 
 struct cpm_pin {

base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5
-- 
2.39.2