Re: [PATCH] powerpc/kexec_file: fix implicit decl error

[Michael Ellerman]

On Sat, 4 Feb 2023 09:22:06 -0800, Randy Dunlap wrote:
> kexec (PPC64) code calls memory_hotplug_max(). Add the header declaration
> for it from . Using  does not work since
> the #include for  depends on CONFIG_NUMA=y, which is not
> set in this kernel config file.
> 
> Fixes this build error/warning:
> 
> [...]

Applied to powerpc/fixes.

[1/1] powerpc/kexec_file: fix implicit decl error
  https://git.kernel.org/powerpc/c/97e45d469eb180a7bd2809e4e079331552c73e42

cheers

Re: [PATCH] powerpc/kexec_file: fix implicit decl error

[Sourabh Jain]

On 04/02/23 22:52, Randy Dunlap wrote:

kexec (PPC64) code calls memory_hotplug_max(). Add the header declaration
for it from . Using  does not work since
the #include for  depends on CONFIG_NUMA=y, which is not
set in this kernel config file.


I didn't realize that linux/mmzone.h includes asm/mmzone.h under 
CONFIG_NUMA.


from linux/mmzone.h

#else /* CONFIG_NUMA */

#include 

#endif /* !CONFIG_NUMA */



Fixes this build error/warning:

../arch/powerpc/kexec/file_load_64.c: In function 'kexec_extra_fdt_size_ppc64':
../arch/powerpc/kexec/file_load_64.c:993:33: error: implicit declaration of 
function 'memory_hotplug_max' [-Werror=implicit-function-declaration]
   993 | usm_entries = ((memory_hotplug_max() / 
drmem_lmb_size()) +
   | ^~

Fixes: fc546faa5595 ("powerpc/kexec_file: Count hot-pluggable memory in FDT 
estimate")
Signed-off-by: Randy Dunlap 
Cc: Sourabh Jain 
Cc: Michael Ellerman 
Cc: linuxppc-dev@lists.ozlabs.org
---
  arch/powerpc/kexec/file_load_64.c |1 +
  1 file changed, 1 insertion(+)

diff -- a/arch/powerpc/kexec/file_load_64.c b/arch/powerpc/kexec/file_load_64.c
--- a/arch/powerpc/kexec/file_load_64.c
+++ b/arch/powerpc/kexec/file_load_64.c
@@ -26,6 +26,7 @@
  #include 
  #include 
  #include 
+#include 


Yes including the asm/mmzone.h will fix the build issue.

- Sourabh


  #include 
  
  struct umem_info {

[PATCH] powerpc/kexec_file: fix implicit decl error

[Randy Dunlap]

kexec (PPC64) code calls memory_hotplug_max(). Add the header declaration
for it from . Using  does not work since
the #include for  depends on CONFIG_NUMA=y, which is not
set in this kernel config file.

Fixes this build error/warning:

../arch/powerpc/kexec/file_load_64.c: In function 'kexec_extra_fdt_size_ppc64':
../arch/powerpc/kexec/file_load_64.c:993:33: error: implicit declaration of 
function 'memory_hotplug_max' [-Werror=implicit-function-declaration]
  993 | usm_entries = ((memory_hotplug_max() / 
drmem_lmb_size()) +
  | ^~

Fixes: fc546faa5595 ("powerpc/kexec_file: Count hot-pluggable memory in FDT 
estimate")
Signed-off-by: Randy Dunlap 
Cc: Sourabh Jain 
Cc: Michael Ellerman 
Cc: linuxppc-dev@lists.ozlabs.org
---
 arch/powerpc/kexec/file_load_64.c |1 +
 1 file changed, 1 insertion(+)

diff -- a/arch/powerpc/kexec/file_load_64.c b/arch/powerpc/kexec/file_load_64.c
--- a/arch/powerpc/kexec/file_load_64.c
+++ b/arch/powerpc/kexec/file_load_64.c
@@ -26,6 +26,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 struct umem_info {