Re: [PATCH] powerpc/microwatt: Add litesd

2022-09-30 Thread Matt Johnston
On Thu, 2022-09-29 at 11:55 +0930, Joel Stanley wrote:
> This is the register layout of the litesd peripheral for the fusesoc
> based Microwatt SoC.

The register layout looks right, but the upstream litemmc driver also now
needs the property

clocks = <_clk>;

(and associated sys_clk node).

"non-removable" has a typo, though I'm not sure we want non-removable anyway?
Most devices have a SD or microSD socket, and eMMC needs other driver litemmc
changes.

Cheers,
Matt


> Signed-off-by: Joel Stanley 
> ---
>  arch/powerpc/boot/dts/microwatt.dts | 15 +++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/powerpc/boot/dts/microwatt.dts 
> b/arch/powerpc/boot/dts/microwatt.dts
> index b69db1d275cd..0a2e82ca1c79 100644
> --- a/arch/powerpc/boot/dts/microwatt.dts
> +++ b/arch/powerpc/boot/dts/microwatt.dts
> @@ -141,6 +141,21 @@ ethernet@802 {
>   litex,slot-size = <0x800>;
>   interrupts = <0x11 0x1>;
>   };
> +
> + mmc@804 {
> + compatible = "litex,mmc";
> + reg = <0x8042800 0x800
> + 0x8041000 0x800
> + 0x8040800 0x800
> + 0x8042000 0x800
> + 0x8041800 0x800>;
> + reg-names = "phy", "core", "reader", "writer", "irq";
> + bus-width = <4>;
> + interrupts = <0x13 1>;
> + cap-sd-highspeed;
> + non-removeable;
> + status = "disabled";
> + };
>   };
>  
>   chosen {



[PATCH] powerpc/microwatt: Add litesd

2022-09-28 Thread Joel Stanley
This is the register layout of the litesd peripheral for the fusesoc
based Microwatt SoC.

Signed-off-by: Joel Stanley 
---
 arch/powerpc/boot/dts/microwatt.dts | 15 +++
 1 file changed, 15 insertions(+)

diff --git a/arch/powerpc/boot/dts/microwatt.dts 
b/arch/powerpc/boot/dts/microwatt.dts
index b69db1d275cd..0a2e82ca1c79 100644
--- a/arch/powerpc/boot/dts/microwatt.dts
+++ b/arch/powerpc/boot/dts/microwatt.dts
@@ -141,6 +141,21 @@ ethernet@802 {
litex,slot-size = <0x800>;
interrupts = <0x11 0x1>;
};
+
+   mmc@804 {
+   compatible = "litex,mmc";
+   reg = <0x8042800 0x800
+   0x8041000 0x800
+   0x8040800 0x800
+   0x8042000 0x800
+   0x8041800 0x800>;
+   reg-names = "phy", "core", "reader", "writer", "irq";
+   bus-width = <4>;
+   interrupts = <0x13 1>;
+   cap-sd-highspeed;
+   non-removeable;
+   status = "disabled";
+   };
};
 
chosen {
-- 
2.35.1