Re: [PATCH] powerpc/mm/radix: Add missing tlb flush

2016-05-11 Thread Balbir Singh
On Wed, 2016-05-11 at 10:48 +0530, Aneesh Kumar K.V wrote:
> This should not have any impact on hash, because hash does tlb
> invalidate with every pte update and we don't implement
> flush_tlb_* functions for hash. With radix we should make an explicit
> call to flush tlb outside pte update.
> 
> Signed-off-by: Aneesh Kumar K.V 
> + flush_tlb_range(vma, address, address + HPAGE_PMD_SIZE);

Acked-by: Balbir Singh 


___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] powerpc/mm/radix: Add missing tlb flush

2016-05-10 Thread Aneesh Kumar K.V
This should not have any impact on hash, because hash does tlb
invalidate with every pte update and we don't implement
flush_tlb_* functions for hash. With radix we should make an explicit
call to flush tlb outside pte update.

Signed-off-by: Aneesh Kumar K.V 
---
 arch/powerpc/mm/pgtable-book3s64.c | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/powerpc/mm/pgtable-book3s64.c 
b/arch/powerpc/mm/pgtable-book3s64.c
index eb4451144746..670318766545 100644
--- a/arch/powerpc/mm/pgtable-book3s64.c
+++ b/arch/powerpc/mm/pgtable-book3s64.c
@@ -33,10 +33,7 @@ int pmdp_set_access_flags(struct vm_area_struct *vma, 
unsigned long address,
changed = !pmd_same(*(pmdp), entry);
if (changed) {
__ptep_set_access_flags(pmdp_ptep(pmdp), pmd_pte(entry));
-   /*
-* Since we are not supporting SW TLB systems, we don't
-* have any thing similar to flush_tlb_page_nohash()
-*/
+   flush_tlb_range(vma, address, address + HPAGE_PMD_SIZE);
}
return changed;
 }
-- 
2.7.4

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev