Re: [PATCH] powerpc/mpc85xx:Add initial device tree support of T104x
On Mon, 2013-09-16 at 21:11 -0500, Kushwaha Prabhakar-B32579 wrote: > > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Tuesday, September 17, 2013 2:49 AM > > To: Kushwaha Prabhakar-B32579 > > Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org; > > ga...@kernel.crashing.org; Aggrwal Poonam-B10812; Jain Priyanka-B32167; > > Sethi Varun-B16395 > > Subject: Re: [PATCH] powerpc/mpc85xx:Add initial device tree support of > > T104x > > > > On Fri, 2013-09-13 at 02:30 -0500, Kushwaha Prabhakar-B32579 wrote: > > > > I also question the need to define separate t1040 compatible values > > > > for all of these, if the only difference is whether the onboard > > > > switch is enabled or not. > > > > > > > > > > so should I use T104x as compatible field. and in T1040 device tree add > > extra node for l2 switch. > > I am using T1042 as base dts and T1040 includes T1040 + l2switch. > > so if I use T1042 in compatible. It will give wrong field for someone working > on T1040QDS. What is wrong about it? It is compatible, right? -Scott ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
RE: [PATCH] powerpc/mpc85xx:Add initial device tree support of T104x
> -Original Message- > From: Wood Scott-B07421 > Sent: Tuesday, September 17, 2013 2:49 AM > To: Kushwaha Prabhakar-B32579 > Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org; > ga...@kernel.crashing.org; Aggrwal Poonam-B10812; Jain Priyanka-B32167; > Sethi Varun-B16395 > Subject: Re: [PATCH] powerpc/mpc85xx:Add initial device tree support of > T104x > > On Fri, 2013-09-13 at 02:30 -0500, Kushwaha Prabhakar-B32579 wrote: > > > I also question the need to define separate t1040 compatible values > > > for all of these, if the only difference is whether the onboard > > > switch is enabled or not. > > > > > > > so should I use T104x as compatible field. and in T1040 device tree add > extra node for l2 switch. I am using T1042 as base dts and T1040 includes T1040 + l2switch. so if I use T1042 in compatible. It will give wrong field for someone working on T1040QDS. best solution should be to have a) have T1042 in compatible field. b) T1040 dts override T1042 to t1040 in compatible field. it will give correct picture Regards, Prabhakar ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH] powerpc/mpc85xx:Add initial device tree support of T104x
On Fri, 2013-09-13 at 02:30 -0500, Kushwaha Prabhakar-B32579 wrote:
> > I also question the need to define separate t1040 compatible values for
> > all of these, if the only difference is whether the onboard switch is
> > enabled or not.
> >
>
> so should I use T104x as compatible field. and in T1040 device tree add extra
> node for l2 switch.
No, because we don't know if there will be (e.g) a t1043 that is
different. Just use t1040 as the canonical name.
> > Please update the clock stuff based on
> > http://patchwork.ozlabs.org/patch/274134/
> >
>
> this patch is still under discussion. May I have to wait for the final patch.
> or may I rebase on v4.
You can wait for the final patch, or you can update based on the current
state of the discussion, and be ready to update again if anything
changes.
> > > +/include/ "qoriq-dma-0.dtsi"
> > > + dma@100300 {
> > > + fsl,iommu-parent = <&pamu0>;
> > > + fsl,liodn-reg = <&guts 0x580>; /* DMA1LIODNR */
> > > + };
> > > +
> > > +/include/ "qoriq-dma-1.dtsi"
> > > + dma@101300 {
> > > + fsl,iommu-parent = <&pamu0>;
> > > + fsl,liodn-reg = <&guts 0x584>; /* DMA2LIODNR */
> > > + };
> >
> > These are elo3:
> > http://patchwork.ozlabs.org/patch/271238/
>
> This patch is still under discussion.
> I am not sure, I should wait for final patch or change code as per v9
> version.
I think that patch is pretty well settled at this point. Just make it a
prerequisite for this patch.
-Scott
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH] powerpc/mpc85xx:Add initial device tree support of T104x
On 09/13/2013 04:53 PM, Kumar Gala wrote:
> On Sep 13, 2013, at 4:14 AM, Valentin Longchamp wrote:
>> On 09/11/2013 08:58 AM, Prabhakar Kushwaha wrote:
>>> +
>>> +&pci0 {
>>> + compatible = "fsl,t1042-pcie", "fsl,qoriq-pcie-v2.4", "fsl,qoriq-pcie";
>>> + device_type = "pci";
>>> + #size-cells = <2>;
>>> + #address-cells = <3>;
>>> + bus-range = <0x0 0xff>;
>>> + interrupts = <20 2 0 0>;
>>> + fsl,iommu-parent = <&pamu0>;
>>> + pcie@0 {
>>> + reg = <0 0 0 0 0>;
>>> + #interrupt-cells = <1>;
>>> + #size-cells = <2>;
>>> + #address-cells = <3>;
>>> + device_type = "pci";
>>> + interrupts = <20 2 0 0>;
>>> + interrupt-map-mask = <0xf800 0 0 7>;
>>> + interrupt-map = <
>>> + /* IDSEL 0x0 */
>>> + 0 0 1 &mpic 40 1 0 0
>>> + 0 0 2 &mpic 1 1 0 0
>>> + 0 0 3 &mpic 2 1 0 0
>>> + 0 0 4 &mpic 3 1 0 0
>>> + >;
>>> + };
>>> +};
>>> +
>>> +&pci1 {
>>> + compatible = "fsl,t1042-pcie", "fsl,qoriq-pcie-v2.4", "fsl,qoriq-pcie";
>>> + device_type = "pci";
>>> + #size-cells = <2>;
>>> + #address-cells = <3>;
>>> + bus-range = <0 0xff>;
>>> + interrupts = <21 2 0 0>;
>>> + fsl,iommu-parent = <&pamu0>;
>>> + pcie@0 {
>>> + reg = <0 0 0 0 0>;
>>> + #interrupt-cells = <1>;
>>> + #size-cells = <2>;
>>> + #address-cells = <3>;
>>> + device_type = "pci";
>>> + interrupts = <21 2 0 0>;
>>> + interrupt-map-mask = <0xf800 0 0 7>;
>>> + interrupt-map = <
>>> + /* IDSEL 0x0 */
>>> + 0 0 1 &mpic 41 1 0 0
>>> + 0 0 2 &mpic 5 1 0 0
>>> + 0 0 3 &mpic 6 1 0 0
>>> + 0 0 4 &mpic 7 1 0 0
>>> + >;
>>> + };
>>> +};
>>> +
>>> +&pci2 {
>>> + compatible = "fsl,t1042-pcie", "fsl,qoriq-pcie-v2.4", "fsl,qoriq-pcie";
>>> + device_type = "pci";
>>> + #size-cells = <2>;
>>> + #address-cells = <3>;
>>> + bus-range = <0x0 0xff>;
>>> + interrupts = <22 2 0 0>;
>>> + fsl,iommu-parent = <&pamu0>;
>>> + pcie@0 {
>>> + reg = <0 0 0 0 0>;
>>> + #interrupt-cells = <1>;
>>> + #size-cells = <2>;
>>> + #address-cells = <3>;
>>> + device_type = "pci";
>>> + interrupts = <22 2 0 0>;
>>> + interrupt-map-mask = <0xf800 0 0 7>;
>>> + interrupt-map = <
>>> + /* IDSEL 0x0 */
>>> + 0 0 1 &mpic 42 1 0 0
>>> + 0 0 2 &mpic 9 1 0 0
>>> + 0 0 3 &mpic 10 1 0 0
>>> + 0 0 4 &mpic 11 1 0 0
>>> + >;
>>> + };
>>> +};
>>> +
>>> +&pci3 {
>>> + compatible = "fsl,t1042-pcie", "fsl,qoriq-pcie-v2.4", "fsl,qoriq-pcie";
>>> + device_type = "pci";
>>> + #size-cells = <2>;
>>> + #address-cells = <3>;
>>> + bus-range = <0x0 0xff>;
>>> + interrupts = <23 2 0 0>;
>>> + fsl,iommu-parent = <&pamu0>;
>>> + pcie@0 {
>>> + reg = <0 0 0 0 0>;
>>> + #interrupt-cells = <1>;
>>> + #size-cells = <2>;
>>> + #address-cells = <3>;
>>> + device_type = "pci";
>>> + interrupts = <23 2 0 0>;
>>> + interrupt-map-mask = <0xf800 0 0 7>;
>>> + interrupt-map = <
>>> + /* IDSEL 0x0 */
>>> + 0 0 1 &mpic 43 1 0 0
>>> + 0 0 2 &mpic 0 1 0 0
>>> + 0 0 3 &mpic 4 1 0 0
>>> + 0 0 4 &mpic 8 1 0 0
>>> + >;
>>> + };
>>> +};
>>> +
>>
>> The above 4 nodes have the consequence that it will then be mandatory that a
>> board support .dts file that would like to inlcude the SOC-NAMEsi-post.dtsi
>> defines the pci0, pci1, pci2, pci3 aliases.
>>
>> Now it is possible that a board does not implement pci1 for instance. So its
>> .dts file would ideally not define a node for it, and thus not define the
>> respective alias. However, this triggers this dtc compile error (which is
>> correct):
>>
>>> [chlongv1@chber1-10533x linux-km]$ make kmp204x.dtb
>>> DTC arch/powerpc/boot/kmp204x.dtb
>>> Error: arch/powerpc/boot/dts/fsl/p2041si-post.dtsi:98.2-3 label or path,
>>> 'pci1', not found
>>> FATAL ERROR: Syntax error parsing input tree
>>> make[1]: *** [arch/powerpc/boot/kmp204x.dtb] Error 1
>>> make: *** [kmp204x.dtb] Error 2
>>
>> The solution I have found is to define a "dummy" disabled node so that I can
>> define the alias, but I am not really happy about this:
>>
>>> pci1: pcie@ffe201000 {
>>> status = "disabled";
>>> };
>>
>> I am here missing something obvious or shouldn't it be possible that such
>> .dtsi
>> files allow not to define unused/unnecessary nodes ?
>
> Isn't this correct, that you are disabling the PCIe1 interface
Re: [PATCH] powerpc/mpc85xx:Add initial device tree support of T104x
On Sep 13, 2013, at 4:14 AM, Valentin Longchamp wrote:
> On 09/11/2013 08:58 AM, Prabhakar Kushwaha wrote:
>> The QorIQ T1040/T1042 processor support four integrated 64-bit e5500 PA
>> processor cores with high-performance data path acceleration architecture
>> and network peripheral interfaces required for networking &
>> telecommunications.
>>
>> T1042 personality is a reduced personality of T1040 without Integrated 8-port
>> Gigabit Ethernet switch.
>>
>> The T1040/T1042 SoC includes the following function and features:
>>
>> - Four e5500 cores, each with a private 256 KB L2 cache
>> - 256 KB shared L3 CoreNet platform cache (CPC)
>> - Interconnect CoreNet platform
>> - 32-/64-bit DDR3L/DDR4 SDRAM memory controller with ECC and interleaving
>> support
>> - Data Path Acceleration Architecture (DPAA) incorporating acceleration
>> for the following functions:
>>- Packet parsing, classification, and distribution
>>- Queue management for scheduling, packet sequencing, and congestion
>> management
>>- Cryptography Acceleration (SEC 5.0)
>>- RegEx Pattern Matching Acceleration (PME 2.2)
>>- IEEE Std 1588 support
>>- Hardware buffer management for buffer allocation and deallocation
>> - Ethernet interfaces
>>- Integrated 8-port Gigabit Ethernet switch (T1040 only)
>>- Four 1 Gbps Ethernet controllers
>> - Two RGMII interfaces or one RGMII and one MII interfaces
>> - High speed peripheral interfaces
>> - Four PCI Express 2.0 controllers running at up to 5 GHz
>> - Two SATA controllers supporting 1.5 and 3.0 Gb/s operation
>> - Upto two QSGMII interface
>> - Upto six SGMII interface supporting 1000 Mbps
>> - One SGMII interface supporting upto 2500 Mbps
>> - Additional peripheral interfaces
>> - Two USB 2.0 controllers with integrated PHY
>> - SD/eSDHC/eMMC
>> - eSPI controller
>> - Four I2C controllers
>> - Four UARTs
>> - Four GPIO controllers
>> - Integrated flash controller (IFC)
>> - Change this to LCD/ HDMI interface (DIU) with 12 bit dual data rate
>> - TDM interface
>> - Multicore programmable interrupt controller (PIC)
>> - Two 8-channel DMA engines
>> - Single source clocking implementation
>> - Deep Sleep power implementaion (wakeup from GPIO/Timer/Ethernet/USB)
>>
>> Signed-off-by: Poonam Aggrwal
>> Signed-off-by: Priyanka Jain
>> Signed-off-by: Varun Sethi
>> Signed-off-by: Prabhakar Kushwaha
>> ---
>> Based upon git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linux.git
>>
>> TODO: Add noded for ethernet
>>
>> arch/powerpc/boot/dts/fsl/t1040si-post.dtsi | 116
>> arch/powerpc/boot/dts/fsl/t1042si-post.dtsi | 430
>> +++
>> arch/powerpc/boot/dts/fsl/t104xsi-pre.dtsi | 111 +++
>> 3 files changed, 657 insertions(+)
>> create mode 100644 arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
>> create mode 100644 arch/powerpc/boot/dts/fsl/t1042si-post.dtsi
>> create mode 100644 arch/powerpc/boot/dts/fsl/t104xsi-pre.dtsi
>>
>
> I am currently working on a design bases on the p2041 but my issue seems to be
> generic to all the QorIQ dtsi files since the structure is exactly the same,
> so
> I pick the opportunity that such a file is submitted to the mailing-list to
> raise it.
>
> DISCLAIMER: I am no DTS expert, so there may be a way to achieve what I want
> to
> I have not seen.
>
> My understanding is that the SOC-NAMEsi-post.dtsi and SOC-NAMEsi-pre.dtsi are
> files that describe the SoC internals. They will be maintained when new
> drivers
> are merged or changed and therefore they should be used by all boards using
> the
> SoCs. Can someone confirm this or am I already wrong (since there are on
> Freescale boards that use them in mainline) ?
That is the intent. of the SOC*.dtsi files.
>
> [snip]
>
>> +
>> +&pci0 {
>> +compatible = "fsl,t1042-pcie", "fsl,qoriq-pcie-v2.4", "fsl,qoriq-pcie";
>> +device_type = "pci";
>> +#size-cells = <2>;
>> +#address-cells = <3>;
>> +bus-range = <0x0 0xff>;
>> +interrupts = <20 2 0 0>;
>> +fsl,iommu-parent = <&pamu0>;
>> +pcie@0 {
>> +reg = <0 0 0 0 0>;
>> +#interrupt-cells = <1>;
>> +#size-cells = <2>;
>> +#address-cells = <3>;
>> +device_type = "pci";
>> +interrupts = <20 2 0 0>;
>> +interrupt-map-mask = <0xf800 0 0 7>;
>> +interrupt-map = <
>> +/* IDSEL 0x0 */
>> + 0 0 1 &mpic 40 1 0 0
>> + 0 0 2 &mpic 1 1 0 0
>> + 0 0 3 &mpic 2 1 0 0
>> + 0 0 4 &mpic 3 1 0 0
>> +>;
>> +};
>> +};
>> +
>> +&pci1 {
>> +compatible = "fsl,t1042-pcie", "fsl,qoriq-pcie-v2.4", "fsl,qoriq-pcie";
>> +device_type = "pci";
>> +#size-cells = <2>;
>> +#address-cells = <3>;
>> +bus-range = <0 0xff>;
>> +interrupts = <21 2 0 0>;
>> +fsl,iommu-parent = <&pamu0>;
>> +pcie@0
Re: [PATCH] powerpc/mpc85xx:Add initial device tree support of T104x
On 09/11/2013 08:58 AM, Prabhakar Kushwaha wrote:
> The QorIQ T1040/T1042 processor support four integrated 64-bit e5500 PA
> processor cores with high-performance data path acceleration architecture
> and network peripheral interfaces required for networking &
> telecommunications.
>
> T1042 personality is a reduced personality of T1040 without Integrated 8-port
> Gigabit Ethernet switch.
>
> The T1040/T1042 SoC includes the following function and features:
>
> - Four e5500 cores, each with a private 256 KB L2 cache
> - 256 KB shared L3 CoreNet platform cache (CPC)
> - Interconnect CoreNet platform
> - 32-/64-bit DDR3L/DDR4 SDRAM memory controller with ECC and interleaving
>support
> - Data Path Acceleration Architecture (DPAA) incorporating acceleration
> for the following functions:
> - Packet parsing, classification, and distribution
> - Queue management for scheduling, packet sequencing, and congestion
> management
> - Cryptography Acceleration (SEC 5.0)
> - RegEx Pattern Matching Acceleration (PME 2.2)
> - IEEE Std 1588 support
> - Hardware buffer management for buffer allocation and deallocation
> - Ethernet interfaces
> - Integrated 8-port Gigabit Ethernet switch (T1040 only)
> - Four 1 Gbps Ethernet controllers
> - Two RGMII interfaces or one RGMII and one MII interfaces
> - High speed peripheral interfaces
>- Four PCI Express 2.0 controllers running at up to 5 GHz
>- Two SATA controllers supporting 1.5 and 3.0 Gb/s operation
>- Upto two QSGMII interface
>- Upto six SGMII interface supporting 1000 Mbps
>- One SGMII interface supporting upto 2500 Mbps
> - Additional peripheral interfaces
>- Two USB 2.0 controllers with integrated PHY
>- SD/eSDHC/eMMC
>- eSPI controller
>- Four I2C controllers
>- Four UARTs
>- Four GPIO controllers
>- Integrated flash controller (IFC)
>- Change this to LCD/ HDMI interface (DIU) with 12 bit dual data rate
>- TDM interface
> - Multicore programmable interrupt controller (PIC)
> - Two 8-channel DMA engines
> - Single source clocking implementation
> - Deep Sleep power implementaion (wakeup from GPIO/Timer/Ethernet/USB)
>
> Signed-off-by: Poonam Aggrwal
> Signed-off-by: Priyanka Jain
> Signed-off-by: Varun Sethi
> Signed-off-by: Prabhakar Kushwaha
> ---
> Based upon git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linux.git
>
> TODO: Add noded for ethernet
>
> arch/powerpc/boot/dts/fsl/t1040si-post.dtsi | 116
> arch/powerpc/boot/dts/fsl/t1042si-post.dtsi | 430
> +++
> arch/powerpc/boot/dts/fsl/t104xsi-pre.dtsi | 111 +++
> 3 files changed, 657 insertions(+)
> create mode 100644 arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
> create mode 100644 arch/powerpc/boot/dts/fsl/t1042si-post.dtsi
> create mode 100644 arch/powerpc/boot/dts/fsl/t104xsi-pre.dtsi
>
I am currently working on a design bases on the p2041 but my issue seems to be
generic to all the QorIQ dtsi files since the structure is exactly the same, so
I pick the opportunity that such a file is submitted to the mailing-list to
raise it.
DISCLAIMER: I am no DTS expert, so there may be a way to achieve what I want to
I have not seen.
My understanding is that the SOC-NAMEsi-post.dtsi and SOC-NAMEsi-pre.dtsi are
files that describe the SoC internals. They will be maintained when new drivers
are merged or changed and therefore they should be used by all boards using the
SoCs. Can someone confirm this or am I already wrong (since there are on
Freescale boards that use them in mainline) ?
[snip]
> +
> +&pci0 {
> + compatible = "fsl,t1042-pcie", "fsl,qoriq-pcie-v2.4", "fsl,qoriq-pcie";
> + device_type = "pci";
> + #size-cells = <2>;
> + #address-cells = <3>;
> + bus-range = <0x0 0xff>;
> + interrupts = <20 2 0 0>;
> + fsl,iommu-parent = <&pamu0>;
> + pcie@0 {
> + reg = <0 0 0 0 0>;
> + #interrupt-cells = <1>;
> + #size-cells = <2>;
> + #address-cells = <3>;
> + device_type = "pci";
> + interrupts = <20 2 0 0>;
> + interrupt-map-mask = <0xf800 0 0 7>;
> + interrupt-map = <
> + /* IDSEL 0x0 */
> + 0 0 1 &mpic 40 1 0 0
> + 0 0 2 &mpic 1 1 0 0
> + 0 0 3 &mpic 2 1 0 0
> + 0 0 4 &mpic 3 1 0 0
> + >;
> + };
> +};
> +
> +&pci1 {
> + compatible = "fsl,t1042-pcie", "fsl,qoriq-pcie-v2.4", "fsl,qoriq-pcie";
> + device_type = "pci";
> + #size-cells = <2>;
> + #address-cells = <3>;
> + bus-range = <0 0xff>;
> + interrupts = <21 2 0 0>;
> + fsl,iommu-parent = <&pamu0>;
> + pcie@0 {
> + reg = <0 0 0 0 0>;
> + #interrupt-cells = <1>;
> + #size-cells = <2>;
> + #address-cells = <3>;
> + device_type =
RE: [PATCH] powerpc/mpc85xx:Add initial device tree support of T104x
thanks Scott for review.
Please find my reply in-lined.
Regards,
Prabhakar
> -Original Message-
> From: Wood Scott-B07421
> Sent: Thursday, September 12, 2013 4:54 AM
> To: Kushwaha Prabhakar-B32579
> Cc: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org; Aggrwal
> Poonam-B10812; Jain Priyanka-B32167; Sethi Varun-B16395
> Subject: Re: [PATCH] powerpc/mpc85xx:Add initial device tree support of
> T104x
>
> On Wed, 2013-09-11 at 12:28 +0530, Prabhakar Kushwaha wrote:
> > The QorIQ T1040/T1042 processor support four integrated 64-bit e5500
> > PA processor cores with high-performance data path acceleration
> > architecture and network peripheral interfaces required for networking
> & telecommunications.
> >
> > T1042 personality is a reduced personality of T1040 without Integrated
> > 8-port Gigabit Ethernet switch.
> >
> > The T1040/T1042 SoC includes the following function and features:
> >
> > - Four e5500 cores, each with a private 256 KB L2 cache
> > - 256 KB shared L3 CoreNet platform cache (CPC)
> > - Interconnect CoreNet platform
> > - 32-/64-bit DDR3L/DDR4 SDRAM memory controller with ECC and
> interleaving
> >support
> > - Data Path Acceleration Architecture (DPAA) incorporating
> > acceleration for the following functions:
> > - Packet parsing, classification, and distribution
> > - Queue management for scheduling, packet sequencing, and
> congestion
> > management
> > - Cryptography Acceleration (SEC 5.0)
> > - RegEx Pattern Matching Acceleration (PME 2.2)
> > - IEEE Std 1588 support
> > - Hardware buffer management for buffer allocation and
> > deallocation
> > - Ethernet interfaces
> > - Integrated 8-port Gigabit Ethernet switch (T1040 only)
> > - Four 1 Gbps Ethernet controllers
> > - Two RGMII interfaces or one RGMII and one MII interfaces
> > - High speed peripheral interfaces
> >- Four PCI Express 2.0 controllers running at up to 5 GHz
> >- Two SATA controllers supporting 1.5 and 3.0 Gb/s operation
> >- Upto two QSGMII interface
> >- Upto six SGMII interface supporting 1000 Mbps
> >- One SGMII interface supporting upto 2500 Mbps
> > - Additional peripheral interfaces
> >- Two USB 2.0 controllers with integrated PHY
> >- SD/eSDHC/eMMC
> >- eSPI controller
> >- Four I2C controllers
> >- Four UARTs
> >- Four GPIO controllers
> >- Integrated flash controller (IFC)
> >- Change this to LCD/ HDMI interface (DIU) with 12 bit dual data
> rate
> >- TDM interface
> > - Multicore programmable interrupt controller (PIC)
> > - Two 8-channel DMA engines
> > - Single source clocking implementation
> > - Deep Sleep power implementaion (wakeup from
> > GPIO/Timer/Ethernet/USB)
> >
> > Signed-off-by: Poonam Aggrwal
> > Signed-off-by: Priyanka Jain
> > Signed-off-by: Varun Sethi
> > Signed-off-by: Prabhakar Kushwaha
> > ---
> > Based upon
> > git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linux.git
>
> Everything in there has already been pulled by Linus, so there's no
> reason to use that tree as a base right now.
>
I will rebase this patch.
> > +/include/ "t1042si-post.dtsi"
> [snip]
> > + serdes: serdes@ea000 {
> > + compatible = "fsl,t1040-serdes";
> > + reg= <0xea000 0x4000>;
> > + };
> > +
> > + sdhc@114000 {
> > + compatible = "fsl,t1040-esdhc", "fsl,esdhc";
> > + sdhci,auto-cmd12;
> > + };
>
> Why does sdhci,auto-cmd12 need to be specified here? It's already in
> t1042si-post.dtsi which you've included. Likewise with reg on the serdes
> node.
>
I will take care of this.
> I also question the need to define separate t1040 compatible values for
> all of these, if the only difference is whether the onboard switch is
> enabled or not.
>
so should I use T104x as compatible field. and in T1040 device tree add extra
node for l2 switch.
> > + clockgen: global-utilities@e1000 {
> > + compatible = "fsl,t1042-clockgen", "fsl,qoriq-clockgen-2.0",
> > + "fixed-clock";
> > + reg = <0xe1000 0x1000>;
> > + clock-output-names = "sysclk";
> > + #clock-cells = <0>;
> > +
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + pll0: pl
Re: [PATCH] powerpc/mpc85xx:Add initial device tree support of T104x
On Wed, 2013-09-11 at 12:28 +0530, Prabhakar Kushwaha wrote:
> The QorIQ T1040/T1042 processor support four integrated 64-bit e5500 PA
> processor cores with high-performance data path acceleration architecture
> and network peripheral interfaces required for networking &
> telecommunications.
>
> T1042 personality is a reduced personality of T1040 without Integrated 8-port
> Gigabit Ethernet switch.
>
> The T1040/T1042 SoC includes the following function and features:
>
> - Four e5500 cores, each with a private 256 KB L2 cache
> - 256 KB shared L3 CoreNet platform cache (CPC)
> - Interconnect CoreNet platform
> - 32-/64-bit DDR3L/DDR4 SDRAM memory controller with ECC and interleaving
>support
> - Data Path Acceleration Architecture (DPAA) incorporating acceleration
> for the following functions:
> - Packet parsing, classification, and distribution
> - Queue management for scheduling, packet sequencing, and congestion
> management
> - Cryptography Acceleration (SEC 5.0)
> - RegEx Pattern Matching Acceleration (PME 2.2)
> - IEEE Std 1588 support
> - Hardware buffer management for buffer allocation and deallocation
> - Ethernet interfaces
> - Integrated 8-port Gigabit Ethernet switch (T1040 only)
> - Four 1 Gbps Ethernet controllers
> - Two RGMII interfaces or one RGMII and one MII interfaces
> - High speed peripheral interfaces
>- Four PCI Express 2.0 controllers running at up to 5 GHz
>- Two SATA controllers supporting 1.5 and 3.0 Gb/s operation
>- Upto two QSGMII interface
>- Upto six SGMII interface supporting 1000 Mbps
>- One SGMII interface supporting upto 2500 Mbps
> - Additional peripheral interfaces
>- Two USB 2.0 controllers with integrated PHY
>- SD/eSDHC/eMMC
>- eSPI controller
>- Four I2C controllers
>- Four UARTs
>- Four GPIO controllers
>- Integrated flash controller (IFC)
>- Change this to LCD/ HDMI interface (DIU) with 12 bit dual data rate
>- TDM interface
> - Multicore programmable interrupt controller (PIC)
> - Two 8-channel DMA engines
> - Single source clocking implementation
> - Deep Sleep power implementaion (wakeup from GPIO/Timer/Ethernet/USB)
>
> Signed-off-by: Poonam Aggrwal
> Signed-off-by: Priyanka Jain
> Signed-off-by: Varun Sethi
> Signed-off-by: Prabhakar Kushwaha
> ---
> Based upon git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linux.git
Everything in there has already been pulled by Linus, so there's no
reason to use that tree as a base right now.
> +/include/ "t1042si-post.dtsi"
[snip]
> + serdes: serdes@ea000 {
> + compatible = "fsl,t1040-serdes";
> + reg= <0xea000 0x4000>;
> + };
> +
> + sdhc@114000 {
> + compatible = "fsl,t1040-esdhc", "fsl,esdhc";
> + sdhci,auto-cmd12;
> + };
Why does sdhci,auto-cmd12 need to be specified here? It's already in
t1042si-post.dtsi which you've included. Likewise with reg on the
serdes node.
I also question the need to define separate t1040 compatible values for
all of these, if the only difference is whether the onboard switch is
enabled or not.
> + clockgen: global-utilities@e1000 {
> + compatible = "fsl,t1042-clockgen", "fsl,qoriq-clockgen-2.0",
> +"fixed-clock";
> + reg = <0xe1000 0x1000>;
> + clock-output-names = "sysclk";
> + #clock-cells = <0>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> + pll0: pll0@800 {
> + #clock-cells = <1>;
> + reg = <0x800>;
> + compatible = "fsl,core-pll-clock";
> + clocks = <&clockgen>;
> + clock-output-names = "pll0", "pll0-div2", "pll0-div4";
> + };
> + pll1: pll1@820 {
> + #clock-cells = <1>;
> + reg = <0x820>;
> + compatible = "fsl,core-pll-clock";
> + clocks = <&clockgen>;
> + clock-output-names = "pll1", "pll1-div2", "pll1-div4";
> + };
> + mux0: mux0@0 {
> + #clock-cells = <0>;
> + reg = <0x0>;
> + compatible = "fsl,core-mux-clock";
Please update the clock stuff based on
http://patchwork.ozlabs.org/patch/274134/
> +/include/ "qoriq-dma-0.dtsi"
> + dma@100300 {
> + fsl,iommu-parent = <&pamu0>;
> + fsl,liodn-reg = <&guts 0x580>; /* DMA1LIODNR */
> + };
> +
> +/include/ "qoriq-dma-1.dtsi"
> + dma@101300 {
> + fsl,iommu-parent = <&pamu0>;
> + fsl,liodn-reg = <&guts 0x584>; /* DMA2LIODNR */
> + };
These are elo3:
http://patchwork.ozlabs.org/patch/271238/
> + display@18 {
> +compatible = "fsl,diu", "fsl,t1042-diu";
> +reg = <0x18 1000>;
> +
[PATCH] powerpc/mpc85xx:Add initial device tree support of T104x
The QorIQ T1040/T1042 processor support four integrated 64-bit e5500 PA
processor cores with high-performance data path acceleration architecture
and network peripheral interfaces required for networking & telecommunications.
T1042 personality is a reduced personality of T1040 without Integrated 8-port
Gigabit Ethernet switch.
The T1040/T1042 SoC includes the following function and features:
- Four e5500 cores, each with a private 256 KB L2 cache
- 256 KB shared L3 CoreNet platform cache (CPC)
- Interconnect CoreNet platform
- 32-/64-bit DDR3L/DDR4 SDRAM memory controller with ECC and interleaving
support
- Data Path Acceleration Architecture (DPAA) incorporating acceleration
for the following functions:
- Packet parsing, classification, and distribution
- Queue management for scheduling, packet sequencing, and congestion
management
- Cryptography Acceleration (SEC 5.0)
- RegEx Pattern Matching Acceleration (PME 2.2)
- IEEE Std 1588 support
- Hardware buffer management for buffer allocation and deallocation
- Ethernet interfaces
- Integrated 8-port Gigabit Ethernet switch (T1040 only)
- Four 1 Gbps Ethernet controllers
- Two RGMII interfaces or one RGMII and one MII interfaces
- High speed peripheral interfaces
- Four PCI Express 2.0 controllers running at up to 5 GHz
- Two SATA controllers supporting 1.5 and 3.0 Gb/s operation
- Upto two QSGMII interface
- Upto six SGMII interface supporting 1000 Mbps
- One SGMII interface supporting upto 2500 Mbps
- Additional peripheral interfaces
- Two USB 2.0 controllers with integrated PHY
- SD/eSDHC/eMMC
- eSPI controller
- Four I2C controllers
- Four UARTs
- Four GPIO controllers
- Integrated flash controller (IFC)
- Change this to LCD/ HDMI interface (DIU) with 12 bit dual data rate
- TDM interface
- Multicore programmable interrupt controller (PIC)
- Two 8-channel DMA engines
- Single source clocking implementation
- Deep Sleep power implementaion (wakeup from GPIO/Timer/Ethernet/USB)
Signed-off-by: Poonam Aggrwal
Signed-off-by: Priyanka Jain
Signed-off-by: Varun Sethi
Signed-off-by: Prabhakar Kushwaha
---
Based upon git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linux.git
TODO: Add noded for ethernet
arch/powerpc/boot/dts/fsl/t1040si-post.dtsi | 116
arch/powerpc/boot/dts/fsl/t1042si-post.dtsi | 430 +++
arch/powerpc/boot/dts/fsl/t104xsi-pre.dtsi | 111 +++
3 files changed, 657 insertions(+)
create mode 100644 arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
create mode 100644 arch/powerpc/boot/dts/fsl/t1042si-post.dtsi
create mode 100644 arch/powerpc/boot/dts/fsl/t104xsi-pre.dtsi
diff --git a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
new file mode 100644
index 000..6ef27fe
--- /dev/null
+++ b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
@@ -0,0 +1,116 @@
+/*
+ * T1040 Silicon/SoC Device Tree Source (post include)
+ *
+ * Copyright 2013 Freescale Semiconductor Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ * * Neither the name of Freescale Semiconductor nor the
+ * names of its contributors may be used to endorse or promote products
+ * derived from this software without specific prior written permission.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of the
+ * GNU General Public License ("GPL") as published by the Free Software
+ * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * THIS SOFTWARE IS PROVIDED BY Freescale Semiconductor ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL Freescale Semiconductor BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+/include/ "t1042si-post.dtsi"
+
+&pci0 {
+ compatible = "fsl,t1040-pcie", "fsl,qoriq-pcie-v2.4", "fsl,qoriq-pcie";
+};
+
+&pci1 {
+
