Re: [PATCH] powerpc/prom: bump up maximum size of properties

2012-02-26 Thread Benjamin Herrenschmidt
On Fri, 2012-02-24 at 16:23 -0800, Nishanth Aravamudan wrote:
 On a 16TB system (using AMS/CMO), I get:
 
 WARNING: ignoring large property [/ibm,dynamic-reconfiguration-memory] 
 ibm,dynamic-memory length 0x0017ffec
 
 and significantly less memory is thus shown to the partition. As far as
 I can tell, the constant used is arbitrary, but bump it up to 2MB, which
 covers the above property (approximately 1.5MB).
 
 With this patch, the kernel does see all of the system memory on the
 16TB system.

Why not go all the way to either removing the limit, or setting it to
something much bigger ? That's just asking to break again when we get an
even bigger system.

The limit was originally set because of Apple machines carrying ROM
images in the device-tree, at a time where we were much more memory
constrained than we are now.

But even then, it never represented such a large gain and in the end,
was probably not -that- useful.

I'd say bump it to something really large like 16M or remove the limit
alltogether.

Cheers,
Ben.

 Signed-off-by: Nishanth Aravamudan n...@us.ibm.com
 Cc: Anton Blanchard an...@au1.ibm.com
 Cc: Paul Mackerras pau...@samba.org
 Cc: Robert Jennings r...@linux.vnet.ibm.com
 Cc: linuxppc-dev@lists.ozlabs.org
 ---
  arch/powerpc/kernel/prom_init.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
 
 diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
 index eca626e..0bf0ccc 100644
 --- a/arch/powerpc/kernel/prom_init.c
 +++ b/arch/powerpc/kernel/prom_init.c
 @@ -53,7 +53,7 @@
   * ensure that we don't lose things like the interrupt-map property
   * on a PCI-PCI bridge.
   */
 -#define MAX_PROPERTY_LENGTH  (1UL * 1024 * 1024)
 +#define MAX_PROPERTY_LENGTH  (2UL * 1024 * 1024)
  
  /*
   * Eventually bump that one up


___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


[PATCH] powerpc/prom: bump up maximum size of properties

2012-02-24 Thread Nishanth Aravamudan
On a 16TB system (using AMS/CMO), I get:

WARNING: ignoring large property [/ibm,dynamic-reconfiguration-memory] 
ibm,dynamic-memory length 0x0017ffec

and significantly less memory is thus shown to the partition. As far as
I can tell, the constant used is arbitrary, but bump it up to 2MB, which
covers the above property (approximately 1.5MB).

With this patch, the kernel does see all of the system memory on the
16TB system.

Signed-off-by: Nishanth Aravamudan n...@us.ibm.com
Cc: Anton Blanchard an...@au1.ibm.com
Cc: Paul Mackerras pau...@samba.org
Cc: Robert Jennings r...@linux.vnet.ibm.com
Cc: linuxppc-dev@lists.ozlabs.org
---
 arch/powerpc/kernel/prom_init.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
index eca626e..0bf0ccc 100644
--- a/arch/powerpc/kernel/prom_init.c
+++ b/arch/powerpc/kernel/prom_init.c
@@ -53,7 +53,7 @@
  * ensure that we don't lose things like the interrupt-map property
  * on a PCI-PCI bridge.
  */
-#define MAX_PROPERTY_LENGTH(1UL * 1024 * 1024)
+#define MAX_PROPERTY_LENGTH(2UL * 1024 * 1024)
 
 /*
  * Eventually bump that one up
-- 
1.7.5.4

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev