[PATCH] powerpc/pseries: Quieten relocation on exceptions warning

[Anton Blanchard]

The H_SET_MODE hcall returns H_P2 if a function is not implemented
and all callers should handle this case.

The call to enable relocation on exceptions currently prints an error
message if the feature is not implemented. While H_SET_MODE was
first introduced on POWER8 (which has relocation on exceptions), it
has been now added on some POWER7 configurations (which does not).

Check for H_P2 and print an informational message instead.

Signed-off-by: Anton Blanchard an...@samba.org
---
 arch/powerpc/platforms/pseries/setup.c | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/pseries/setup.c 
b/arch/powerpc/platforms/pseries/setup.c
index 125c589..fcc9227 100644
--- a/arch/powerpc/platforms/pseries/setup.c
+++ b/arch/powerpc/platforms/pseries/setup.c
@@ -499,7 +499,11 @@ static void __init pSeries_setup_arch(void)
 
if (firmware_has_feature(FW_FEATURE_SET_MODE)) {
long rc;
-   if ((rc = pSeries_enable_reloc_on_exc()) != H_SUCCESS) {
+
+   rc = pSeries_enable_reloc_on_exc();
+   if (rc == H_P2) {
+   pr_info(Relocation on exceptions not supported\n);
+   } else if (rc != H_SUCCESS) {
pr_warn(Unable to enable relocation on exceptions: 
%ld\n, rc);
}
-- 
1.9.1

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] powerpc/pseries: Quieten relocation on exceptions warning

[Anton Blanchard]

The hypervisor returns H_P2 if relocation on exceptions are
not supported. If we get this, just print a lower priority
informational message.

Signed-off-by: Anton Blanchard an...@samba.org
---
 arch/powerpc/platforms/pseries/setup.c | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/pseries/setup.c 
b/arch/powerpc/platforms/pseries/setup.c
index 125c589..fcc9227 100644
--- a/arch/powerpc/platforms/pseries/setup.c
+++ b/arch/powerpc/platforms/pseries/setup.c
@@ -499,7 +499,11 @@ static void __init pSeries_setup_arch(void)
 
if (firmware_has_feature(FW_FEATURE_SET_MODE)) {
long rc;
-   if ((rc = pSeries_enable_reloc_on_exc()) != H_SUCCESS) {
+
+   rc = pSeries_enable_reloc_on_exc();
+   if (rc == H_P2) {
+   pr_info(Relocation on exceptions not supported\n);
+   } else if (rc != H_SUCCESS) {
pr_warn(Unable to enable relocation on exceptions: 
%ld\n, rc);
}
-- 
1.9.1

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc/pseries: Quieten relocation on exceptions warning

[Michael Neuling]

 The hypervisor returns H_P2 if relocation on exceptions are
 not supported. If we get this, just print a lower priority
 informational message.

Can you add something about why this is needed?  Something about
h_set_mode being available so we can enable LE but not supporting any of
the other calls like AIL?

Mikey

 Signed-off-by: Anton Blanchard an...@samba.org
 ---
  arch/powerpc/platforms/pseries/setup.c | 6 +-
  1 file changed, 5 insertions(+), 1 deletion(-)
 
 diff --git a/arch/powerpc/platforms/pseries/setup.c 
 b/arch/powerpc/platforms/pseries/setup.c
 index 125c589..fcc9227 100644
 --- a/arch/powerpc/platforms/pseries/setup.c
 +++ b/arch/powerpc/platforms/pseries/setup.c
 @@ -499,7 +499,11 @@ static void __init pSeries_setup_arch(void)
  
   if (firmware_has_feature(FW_FEATURE_SET_MODE)) {
   long rc;
 - if ((rc = pSeries_enable_reloc_on_exc()) != H_SUCCESS) {
 +
 + rc = pSeries_enable_reloc_on_exc();
 + if (rc == H_P2) {
 + pr_info(Relocation on exceptions not supported\n);
 + } else if (rc != H_SUCCESS) {
   pr_warn(Unable to enable relocation on exceptions: 
   %ld\n, rc);
   }

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev