Re: [PATCH] powerpc/stacktrace: Include linux/delay.h

2021-08-03 Thread Michael Ellerman 
On Thu, 29 Jul 2021 20:01:03 +0200, Michal Suchanek wrote:
> commit 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in 
> raise_backtrace_ipi()")
> introduces udelay() call without including the linux/delay.h header.
> This may happen to work on master but the header that declares the
> functionshould be included nonetheless.

Applied to powerpc/next.

[1/1] powerpc/stacktrace: Include linux/delay.h
  https://git.kernel.org/powerpc/c/135462ae7692a824e5b63299178684fca3a366e6

cheers

[PATCH] powerpc/stacktrace: Include linux/delay.h

2021-07-29 Thread Michal Suchanek 
commit 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in 
raise_backtrace_ipi()")
introduces udelay() call without including the linux/delay.h header.
This may happen to work on master but the header that declares the
functionshould be included nonetheless.

Fixes: 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in 
raise_backtrace_ipi()")
Signed-off-by: Michal Suchanek 
---
V2: Add header in alphabetical order.
---
 arch/powerpc/kernel/stacktrace.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/kernel/stacktrace.c b/arch/powerpc/kernel/stacktrace.c
index 2b0d04a1b7d2..9e4a4a7af380 100644
--- a/arch/powerpc/kernel/stacktrace.c
+++ b/arch/powerpc/kernel/stacktrace.c
@@ -8,6 +8,7 @@
  * Copyright 2018 Nick Piggin, Michael Ellerman, IBM Corp.
  */
 
+#include 
 #include 
 #include 
 #include 
-- 
2.26.2

Re: [PATCH] powerpc/stacktrace: Include linux/delay.h

2021-07-26 Thread Gabriel Paubert 
On Mon, Jul 26, 2021 at 05:42:43PM +0200, Michal Suchanek wrote:
> commit 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in 
> raise_backtrace_ipi()")
> introduces udelay() call without including the linux/delay.h header.
> This may happen to work on master but the header that declares the
> functionshould be included nonetheless.
> 
> Fixes: 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in 
> raise_backtrace_ipi()")
> Signed-off-by: Michal Suchanek 
> ---
>  arch/powerpc/kernel/stacktrace.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/powerpc/kernel/stacktrace.c 
> b/arch/powerpc/kernel/stacktrace.c
> index 2b0d04a1b7d2..a17ac10f86b1 100644
> --- a/arch/powerpc/kernel/stacktrace.c
> +++ b/arch/powerpc/kernel/stacktrace.c
> @@ -12,6 +12,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
>  #include 
>  #include 
>  #include 

Hmm, I believe we try to keep the list of includes sorted in
alphabetical order.

Gabriel

[PATCH] powerpc/stacktrace: Include linux/delay.h

2021-07-26 Thread Michal Suchanek 
commit 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in 
raise_backtrace_ipi()")
introduces udelay() call without including the linux/delay.h header.
This may happen to work on master but the header that declares the
functionshould be included nonetheless.

Fixes: 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in 
raise_backtrace_ipi()")
Signed-off-by: Michal Suchanek 
---
 arch/powerpc/kernel/stacktrace.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/kernel/stacktrace.c b/arch/powerpc/kernel/stacktrace.c
index 2b0d04a1b7d2..a17ac10f86b1 100644
--- a/arch/powerpc/kernel/stacktrace.c
+++ b/arch/powerpc/kernel/stacktrace.c
@@ -12,6 +12,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
-- 
2.26.2