Re: [PATCH] powerpc: make _ASM_NOKPROBE_SYMBOL a noop when KPROBES not defined

2016-10-13 Thread Nicholas Piggin 
On Fri, 14 Oct 2016 11:48:35 +1100
Michael Ellerman  wrote:

> Nicholas Piggin  writes:
> > Signed-off-by: Nicholas Piggin 
> > ---
> > The linker orphan sections error patch caught this  
> 
> You mean with the orphan sections patch applied this breaks the build
> when KPROBES=n right?

Yes. The linker orphan patch got picked up by one of the CI tests after I
posted it, and pointed this out (I obviously didn't test KPROBES=n case).

Thanks,
Nick

Re: [PATCH] powerpc: make _ASM_NOKPROBE_SYMBOL a noop when KPROBES not defined

2016-10-13 Thread Michael Ellerman 
Nicholas Piggin  writes:
> Signed-off-by: Nicholas Piggin 
> ---
> The linker orphan sections error patch caught this

You mean with the orphan sections patch applied this breaks the build
when KPROBES=n right?

cheers

Re: [PATCH] powerpc: make _ASM_NOKPROBE_SYMBOL a noop when KPROBES not defined

2016-10-13 Thread Balbir Singh 


On 13/10/16 13:07, Nicholas Piggin wrote:
> Signed-off-by: Nicholas Piggin 
> ---
> The linker orphan sections error patch caught this

Seems reasonable

Acked-by: Balbir Singh

[PATCH] powerpc: make _ASM_NOKPROBE_SYMBOL a noop when KPROBES not defined

2016-10-12 Thread Nicholas Piggin 
Signed-off-by: Nicholas Piggin 
---
The linker orphan sections error patch caught this

 arch/powerpc/include/asm/ppc_asm.h | 4 
 1 file changed, 4 insertions(+)

diff --git a/arch/powerpc/include/asm/ppc_asm.h 
b/arch/powerpc/include/asm/ppc_asm.h
index c73750b..ceec199 100644
--- a/arch/powerpc/include/asm/ppc_asm.h
+++ b/arch/powerpc/include/asm/ppc_asm.h
@@ -265,10 +265,14 @@ GLUE(.,name):
  * latter is for those that incdentially must be excluded from probing
  * and allows them to be linked at more optimal location within text.
  */
+#ifdef CONFIG_KPROBES
 #define _ASM_NOKPROBE_SYMBOL(entry)\
.pushsection "_kprobe_blacklist","aw";  \
PPC_LONG (entry) ;  \
.popsection
+#else
+#define _ASM_NOKPROBE_SYMBOL(entry)
+#endif
 
 #define FUNC_START(name)   _GLOBAL(name)
 #define FUNC_END(name)
-- 
2.9.3