Re: [PATCH] powerpc: maple: Fix refcount leak bug in time.c

[Michael Ellerman]

On Fri, 17 Jun 2022 20:40:45 +0800, Liang He wrote:
> In maple_get_boot_time(), of_find_compatible_node() will return
> a node pointer with refcount incremented. We should use of_node_put()
> in fail path or when it is not used anymore.
> 
> 

Applied to powerpc/next.

[1/1] powerpc: maple: Fix refcount leak bug in time.c
  https://git.kernel.org/powerpc/c/23b1481898ee8704394cead67eae2634003f7ca8

cheers

[PATCH] powerpc: maple: Fix refcount leak bug in time.c

[Liang He]

In maple_get_boot_time(), of_find_compatible_node() will return
a node pointer with refcount incremented. We should use of_node_put()
in fail path or when it is not used anymore.

Signed-off-by: Liang He 
---
 arch/powerpc/platforms/maple/time.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/platforms/maple/time.c 
b/arch/powerpc/platforms/maple/time.c
index 823e219ef8ee..91606411d2e0 100644
--- a/arch/powerpc/platforms/maple/time.c
+++ b/arch/powerpc/platforms/maple/time.c
@@ -153,6 +153,7 @@ time64_t __init maple_get_boot_time(void)
   maple_rtc_addr);
}
  bail:
+   of_node_put(rtcs);
if (maple_rtc_addr == 0) {
maple_rtc_addr = RTC_PORT(0); /* legacy address */
printk(KERN_INFO "Maple: No device node for RTC, assuming "
-- 
2.25.1