Re: [PATCH -V2 1/5] powerpc: Use HPTE constants when updating hpte bits

2013-11-19 Thread Paul Mackerras
On Mon, Nov 18, 2013 at 02:58:09PM +0530, Aneesh Kumar K.V wrote:
 From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com
 
 Even though we have same value for linux PTE bits and hash PTE pits

bits, not pits :)

 use the hash pte bits wen updating hash pte

when, not wen

 Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com

If you fix the spelling errors in the patch description:

Acked-by: Paul Mackerras pau...@samba.org
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


[PATCH -V2 1/5] powerpc: Use HPTE constants when updating hpte bits

2013-11-18 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com

Even though we have same value for linux PTE bits and hash PTE pits
use the hash pte bits wen updating hash pte

Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com
---
 arch/powerpc/platforms/cell/beat_htab.c | 4 ++--
 arch/powerpc/platforms/pseries/lpar.c   | 3 ++-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/platforms/cell/beat_htab.c 
b/arch/powerpc/platforms/cell/beat_htab.c
index c34ee4e60873..d4d245c0d787 100644
--- a/arch/powerpc/platforms/cell/beat_htab.c
+++ b/arch/powerpc/platforms/cell/beat_htab.c
@@ -111,7 +111,7 @@ static long beat_lpar_hpte_insert(unsigned long hpte_group,
DBG_LOW( hpte_v=%016lx, hpte_r=%016lx\n, hpte_v, hpte_r);
 
if (rflags  _PAGE_NO_CACHE)
-   hpte_r = ~_PAGE_COHERENT;
+   hpte_r = ~HPTE_R_M;
 
raw_spin_lock(beat_htab_lock);
lpar_rc = beat_read_mask(hpte_group);
@@ -337,7 +337,7 @@ static long beat_lpar_hpte_insert_v3(unsigned long 
hpte_group,
DBG_LOW( hpte_v=%016lx, hpte_r=%016lx\n, hpte_v, hpte_r);
 
if (rflags  _PAGE_NO_CACHE)
-   hpte_r = ~_PAGE_COHERENT;
+   hpte_r = ~HPTE_R_M;
 
/* insert into not-volted entry */
lpar_rc = beat_insert_htab_entry3(0, hpte_group, hpte_v, hpte_r,
diff --git a/arch/powerpc/platforms/pseries/lpar.c 
b/arch/powerpc/platforms/pseries/lpar.c
index 356bc75ca74f..c8fbef238d4b 100644
--- a/arch/powerpc/platforms/pseries/lpar.c
+++ b/arch/powerpc/platforms/pseries/lpar.c
@@ -153,7 +153,8 @@ static long pSeries_lpar_hpte_insert(unsigned long 
hpte_group,
 
/* Make pHyp happy */
if ((rflags  _PAGE_NO_CACHE)  !(rflags  _PAGE_WRITETHRU))
-   hpte_r = ~_PAGE_COHERENT;
+   hpte_r = ~HPTE_R_M;
+
if (firmware_has_feature(FW_FEATURE_XCMO)  !(hpte_r  HPTE_R_N))
flags |= H_COALESCE_CAND;
 
-- 
1.8.3.2

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev